[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Lucas Gass changed: What|Removed |Added Blocks||34080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 [Bug 34080] Updating suggestion status can result in 500 error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to stable|RESOLVED --- Comment #11 from Lucas Gass --- (In reply to Owen Leonard from comment #10) > The bug is a result of the new staff interface so 22.05.x shouldn't need it Thanks Owen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 --- Comment #10 from Owen Leonard --- The bug is a result of the new staff interface so 22.05.x shouldn't need it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #9 from Lucas Gass --- Doesn't apply cleanly to 22.05.x, no backport. If needed please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 --- Comment #8 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Jacob O'Mara changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.05 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 --- Comment #7 from Katrin Fischer --- Please backport, this was originally spotted in 22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #5 from Nick Clemens --- I got confused and thought we had a second selector, added a comment as a reminder - feel free to drop that RM -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 --- Comment #4 from Nick Clemens --- Created attachment 148926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148926=edit Bug 33322: (QA follow-up) Add comment to clarify selector context -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Nick Clemens changed: What|Removed |Added Attachment #148761|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 148925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148925=edit Bug 33322: Refine click handler for suggestion batch operations The handler for suggestion batch operations looks for clicks on "button[type='submit']" which is not very specific. With the new staff interface this ends up including the header search form. This patch modifies the markup of the batch operations section of the template and makes the click handler more specific so that only the right buttons are affected. To test, apply the patch and go to Suggestions. - In the header search form, perform a catalog search. You should be able to click the submit button to successfully initiate the search. - Without checking a checkbox associated with any open suggestion, test the batch operation buttons at the bottom: - Change status - Change item type - Update manager - Delete - Archive All should trigger a JS alert, "Please select at least one suggestion" - Test each batch operation with one or more suggestions selected and confirm that the operation completes successfully. Signed-off-by: Laura Escamilla Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Laura Escamilla changed: What|Removed |Added CC||Laura.escamilla@bywatersolu ||tions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 ByWater Sandboxes changed: What|Removed |Added Attachment #148657|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 148761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148761=edit Bug 33322: Refine click handler for suggestion batch operations The handler for suggestion batch operations looks for clicks on "button[type='submit']" which is not very specific. With the new staff interface this ends up including the header search form. This patch modifies the markup of the batch operations section of the template and makes the click handler more specific so that only the right buttons are affected. To test, apply the patch and go to Suggestions. - In the header search form, perform a catalog search. You should be able to click the submit button to successfully initiate the search. - Without checking a checkbox associated with any open suggestion, test the batch operation buttons at the bottom: - Change status - Change item type - Update manager - Delete - Archive All should trigger a JS alert, "Please select at least one suggestion" - Test each batch operation with one or more suggestions selected and confirm that the operation completes successfully. Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 --- Comment #1 from Owen Leonard --- Created attachment 148657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148657=edit Bug 33322: Refine click handler for suggestion batch operations The handler for suggestion batch operations looks for clicks on "button[type='submit']" which is not very specific. With the new staff interface this ends up including the header search form. This patch modifies the markup of the batch operations section of the template and makes the click handler more specific so that only the right buttons are affected. To test, apply the patch and go to Suggestions. - In the header search form, perform a catalog search. You should be able to click the submit button to successfully initiate the search. - Without checking a checkbox associated with any open suggestion, test the batch operation buttons at the bottom: - Change status - Change item type - Update manager - Delete - Archive All should trigger a JS alert, "Please select at least one suggestion" - Test each batch operation with one or more suggestions selected and confirm that the operation completes successfully. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
