[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Fridolin Somers changed: What|Removed |Added Status|Pushed to main |Needs documenting --- Comment #168 from Fridolin Somers --- Obviously no backport to 23.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #167 from Christopher Brannon --- We had an issue where we could not put all our archived newspapers on the same record, but that was back in the day when we were on Zebra. Now that we are on ES, I'll have to see if it is still an issue. It would break the search for that item or cause the item to not load fully. We'll see. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #166 from Katrin Fischer --- (In reply to Christopher Brannon from comment #165) > Will this enhancement rectify the limitations on how many items can be added > to a bib record? It depends on which limitation you mean? Are you referring to a specific bug? This will fix a performance issue mostly, it would work with many items, but this will make it work much better. The MARCXML we use doesn't really limit the number of items. There can be indexing issues with Zebra and many items, but they could be resolved in configuration (upping a size limit). Not aware of indexing issues with Elasticsearch and record size so far. There are probably other spots where it will take a while to load records with many items. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #165 from Christopher Brannon --- Will this enhancement rectify the limitations on how many items can be added to a bib record? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Martin Renvoize changed: What|Removed |Added Blocks||29275 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 [Bug 29275] Use the API to render checkout history for a biblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #164 from Fridolin Somers --- Whaou big change, great :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart changed: What|Removed |Added Text to go in the||This enhancement completely release notes||rewrites the display of the ||items table on the ||bibliographic record detail ||view. ||The filtering, ||ordering and pagination of ||this table are now done ||using the REST API endpoint ||which will fix performance ||issues for records with ||many items. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com --- Comment #163 from Lisette Scheer --- *** Bug 33930 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Katrin Fischer changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #162 from Katrin Fischer --- Follow-up was pushed to main. https://git.koha-community.org/Koha-community/Koha/commits/branch/main/search?q=33568 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Pedro Amorim changed: What|Removed |Added Blocks||36663 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 [Bug 36663] Biblio detail page - StaffDetailItemSelection hides table elements inconsistently -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Katrin Fischer changed: What|Removed |Added Blocks||16122 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 [Bug 16122] Item record needs to keep local use count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Bug 33568 depends on bug 34913, which changed state. Bug 34913 Summary: Upgrade DataTables from 1.10.18 to 1.13.6 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34913 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Bug 33568 depends on bug 29523, which changed state. Bug 29523 Summary: Add a way to prevent embedding objects that should not be allowed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #161 from Tomás Cohen Arazi --- Created attachment 164528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164528=edit Bug 33568: (follow-up) Fix duplicated key in item spec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568
Jonathan Druart changed:
What|Removed |Added
Attachment #164482|0 |1
is obsolete||
--- Comment #160 from Jonathan Druart ---
Created attachment 164485
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164485=edit
Bug 33568: Prevent api/v1/biblios.t to fail randomly
koha_1 | # Failed test 'The items are returned'
koha_1 | # at t/db_dependent/api/v1/biblios.t line 196.
koha_1 | # Structures begin differing at:
koha_1 | # $got->[0]{external_id} = 'th151O2JtgfGdVW6aiF'
koha_1 | # $expected->[0]{external_id} = 'uxrMzUXrkHQy7MHOSfjK'
koha_1 | # Looks like you failed 1 test of 11.
koha_1 |
koha_1 | # Failed test 'get_items() tests'
koha_1 | # at t/db_dependent/api/v1/biblios.t line 206.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #159 from Jonathan Druart --- Created attachment 164483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164483=edit Bug 33568: (follow-up) Add search on home and holding library's names Silly typo! Caught by a test koha_1 | # Failed test 'Home branch code matches holdingbranch' koha_1 | # at t/db_dependent/Items.t line 581. koha_1 | # got: 'QHImNSEoNi' koha_1 | # expected: 'VY5y6p' koha_1 | # Looks like you failed 1 test of 7. koha_1 | koha_1 | # Failed test 'Koha::Item(s) tests' koha_1 | # at t/db_dependent/Items.t line 588. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568
--- Comment #158 from Jonathan Druart ---
Created attachment 164482
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164482=edit
Bug 33568: Prevent api/v1/biblios.t to fail randomly
koha_1 | # Failed test 'The items are returned'
koha_1 | # at t/db_dependent/api/v1/biblios.t line 196.
koha_1 | # Structures begin differing at:
koha_1 | # $got->[0]{external_id} = 'th151O2JtgfGdVW6aiF'
koha_1 | # $expected->[0]{external_id} = 'uxrMzUXrkHQy7MHOSfjK'
koha_1 | # Looks like you failed 1 test of 11.
koha_1 |
koha_1 | # Failed test 'get_items() tests'
koha_1 | # at t/db_dependent/api/v1/biblios.t line 206.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568
--- Comment #157 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #154)
> I have given this priority as it's quite a big change and it will give us
> the chance to get a lot of eyes on it next week during the hackfest.
>
> Some notes from my own review:
>
> 1) I notice quite a lot of remaining FIXMEs. I feel like some of those
> should filed as follow-up bugs, like the question of sorting serial issues
> here:
>
> my $items_rs = $biblio->items;
> +# FIXME We need to order_by serial.publisheddate if we have
> _order_by=+me.serial_issue_number
> +# FIXME Do we always need host_items => 1 or depending on a flag?
> +# FIXME Should we prefetch => ['issue','branchtransfer']?
> +my $items_rs = $biblio->items( { host_items => 1 }
> )->search_ordered( {}, { join => 'biblioitem' } );
> $items_rs = $items_rs->filter_by_bookable if $bookable_only;
> +# FIXME We need to order_by serial.publisheddate if we have
> _order_by=+me.serial_issue_number
> my $items = $c->objects->search($items_rs);
Yes, there were a lot of FIXMEs. We were supposed to discuss them.
> 2) Untranslatables
>
> node += ' href="/cgi-bin/koha/catalogue/image.pl?itemnumber=%simagenumber=%s"
> title="Local cover image">'.format(id, id);
> node += ' src="/cgi-bin/koha/catalogue/image.pl?thumbnail=1imagenumber=%s"
> alt="Local cover image"
> data-link="/cgi-bin/koha/catalogue/imageviewer.pl?itemnumber=[%
> item.itemnumber | uri %
> return '%s
> analytics'.format(row.item_id, row.analytics_count);
> return ' href="/cgi-bin/koha/cataloguing/addbiblio.pl?hostbiblionumber=%s
> hostitemnumber=%s">Create analytics'.format(row.biblio_id, row.item_id);
> return ' href="/cgi-bin/koha/cataloguing/addbiblio.pl?hostbiblionumber=%s
> hostitemnumber=%s">Create analytics'.format(row.biblio_id, row.item_id);
> return ' href="/cgi-bin/koha/cataloguing/addbiblio.pl?hostbiblionumber=%s
> hostitemnumber=%s">Create analytics'.format(row.biblio_id, row.item_id);
> nodes += ' href="/cgi-bin/koha/tools/upload-cover-image.pl?itemnumber=%s
> filetype=image"> Upload
> image'.format(row.item_id);
> nodes += ' href="/cgi-bin/koha/cataloguing/additem.
> pl?op=edititem=%s=%s#edititem"> Edit'.format(row.biblio_id, row.item_id);
> nodes += ' class="fa fa-folder"> Manage bundle
> (%s|%s)'.format(escape_str(row.bundle_items_not_lost_count),
> escape_str(row.bundle_items_lost_count));
See last patch.
> 3) Unit tests
>
> Actually you removed some :D We should add some for balance and the new
> methods in the various .pm.
Will do on bug 36535.
> 4) Processing note
>
> The processing note now always shows for a split second when doing an action
> like sorting columns. Not sure if that is an option, but could we make it
> only show if the action itself takeslike a little longer? It's just a fast
> blink now and you can hardly even read the "processing" (definitely for a
> separate bug of course)
This is not related to this patch, if we want it that needs to be done for all
DT.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart changed: What|Removed |Added Attachment #164308|0 |1 is obsolete|| Attachment #164309|0 |1 is obsolete|| Attachment #164310|0 |1 is obsolete|| Attachment #164311|0 |1 is obsolete|| Attachment #164312|0 |1 is obsolete|| Attachment #164313|0 |1 is obsolete|| Attachment #164314|0 |1 is obsolete|| Attachment #164315|0 |1 is obsolete|| Attachment #164316|0 |1 is obsolete|| Attachment #164317|0 |1 is obsolete|| Attachment #164318|0 |1 is obsolete|| Attachment #164319|0 |1 is obsolete|| Attachment #164320|0 |1 is obsolete|| Attachment #164321|0 |1 is obsolete|| Attachment #164322|0 |1 is obsolete|| Attachment #164323|0 |1 is obsolete|| Attachment #164324|0 |1 is obsolete|| Attachment #164325|0 |1 is obsolete|| Attachment #164326|0 |1 is obsolete|| Attachment #164327|0 |1 is obsolete|| Attachment #164328|0 |1 is obsolete|| Attachment #164329|0 |1 is obsolete|| Attachment #164330|0 |1 is obsolete|| Attachment #164331|0 |1 is obsolete|| Attachment #164332|0 |1 is obsolete|| Attachment #164333|0 |1 is obsolete|| Attachment #164334|0 |1 is obsolete|| Attachment #164335|0 |1 is obsolete|| Attachment #164336|0 |1 is obsolete|| Attachment #164337|0 |1 is obsolete|| Attachment #164338|0 |1 is obsolete|| Attachment #164339|0 |1 is obsolete|| Attachment #164340|0 |1 is obsolete|| Attachment #164341|0 |1 is obsolete|| Attachment #164342|0 |1 is obsolete|| Attachment #164343|0 |1 is obsolete|| Attachment #164344|0 |1 is obsolete|| Attachment #164345|0 |1 is obsolete|| Attachment #164346|0 |1 is obsolete|| Attachment #164347|0 |1 is obsolete|| Attachment #164348|0 |1 is obsolete|| Attachment #164349|0 |1 is obsolete|| Attachment #164350|0 |1 is obsolete|| Attachment #164351|0 |1 is obsolete|| Attachment #164352|0 |1 is obsolete|| Attachment #164353|0 |1 is obsolete|| Attachment #164354|0 |1 is obsolete|| Attachment #164355|0
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Katrin Fischer changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #155 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Katrin Fischer changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568
--- Comment #154 from Katrin Fischer ---
I have given this priority as it's quite a big change and it will give us the
chance to get a lot of eyes on it next week during the hackfest.
Some notes from my own review:
1) I notice quite a lot of remaining FIXMEs. I feel like some of those should
filed as follow-up bugs, like the question of sorting serial issues here:
my $items_rs = $biblio->items;
+# FIXME We need to order_by serial.publisheddate if we have
_order_by=+me.serial_issue_number
+# FIXME Do we always need host_items => 1 or depending on a flag?
+# FIXME Should we prefetch => ['issue','branchtransfer']?
+my $items_rs = $biblio->items( { host_items => 1 } )->search_ordered(
{}, { join => 'biblioitem' } );
$items_rs = $items_rs->filter_by_bookable if $bookable_only;
+# FIXME We need to order_by serial.publisheddate if we have
_order_by=+me.serial_issue_number
my $items = $c->objects->search($items_rs);
2) Untranslatables
node += ''.format(id, id);
node += '%s
analytics'.format(row.item_id, row.analytics_count);
return 'Create
analytics'.format(row.biblio_id, row.item_id);
return 'Create
analytics'.format(row.biblio_id, row.item_id);
return 'Create
analytics'.format(row.biblio_id, row.item_id);
nodes += ' Upload image'.format(row.item_id);
nodes += ' Edit'.format(row.biblio_id, row.item_id);
nodes += ' Manage bundle
(%s|%s)'.format(escape_str(row.bundle_items_not_lost_count),
escape_str(row.bundle_items_lost_count));
3) Unit tests
Actually you removed some :D We should add some for balance and the new methods
in the various .pm.
4) Processing note
The processing note now always shows for a split second when doing an action
like sorting columns. Not sure if that is an option, but could we make it only
show if the action itself takeslike a little longer? It's just a fast blink now
and you can hardly even read the "processing" (definitely for a separate bug of
course)
IMPORTANT: When you provide follow-ups - could you please obsolete the already
pushed patches? This will make it much easier to handle. (uncommenting 60+
patches for git bz apply with -i is no fun)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart changed: What|Removed |Added Blocks||36535 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36535 [Bug 36535] 33568 introduced too many changes in modules without tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #153 from Jonathan Druart --- Created attachment 164472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164472=edit Bug 33568: Fix false positive 'missing_filter' It was ok but the QA script complains and xt/find-missing-filters.t as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Katrin Fischer changed: What|Removed |Added Keywords||roadmap_24_05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #152 from Katrin Fischer --- (In reply to Jonathan Druart from comment #151) > Thanks Tomas! > I have added Laurence and Emily as well as yours. > Laurence and Emily have done extended testing and I think they deserve their > signed-off-by lines on this one. Totally agree, thanks for thinking of it! My goal is to push this before leaving for Marseille. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #151 from Jonathan Druart --- Thanks Tomas! I have added Laurence and Emily as well as yours. Laurence and Emily have done extended testing and I think they deserve their signed-off-by lines on this one. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #150 from Jonathan Druart --- Created attachment 164374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164374=edit Bug 33568: Add hint on the table settings admin page Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #149 from Jonathan Druart --- Created attachment 164373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164373=edit Bug 33568: POD fixes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #148 from Jonathan Druart --- Created attachment 164372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164372=edit Bug 33568: serialitem => serial_item Signed-off-by: Tomas Cohen Arazi Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #147 from Jonathan Druart --- Created attachment 164371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164371=edit Bug 33568: Remove LPAD ordering This is coming from bug 3521 it seems. And we are going to deal with this later if people complains. kidclamp> the performance issue for sites with many copies is bigger than sorting issues imho kidclamp> drop the LPAD I say :-) Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #146 from Jonathan Druart --- Created attachment 164370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164370=edit Bug 33568: Fix columns shift when pref are off From comment 66: If StaffDetailItemSelection and/or LocalCoverImages is turned off, the alignment of the drop-down filters for the other columns is offset by 1 for each of the two sysprefs that is disabled Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568
--- Comment #145 from Jonathan Druart ---
Created attachment 164369
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164369=edit
Bug 33568: (follow-up) Fix ordering - WIP
This is not working. We are still getting the error
Unable to programatically derive a required group_by from the supplied order_by
criteria. To proceed either add an explicit group_by, or simplify your order_by
to only include plain columns (supplied order_by: 'lpad_copynumber').
To recreate the problem you can go to detail.pl and search for something
Without search the query is working.
The problem appears when the query has WHERE parameters added and "GROUP
BY" is added.
DBIC is adding to the GROUP BY what is added to the select, but does not
handle this situation (not a plain column).
You can play with:
1.
Remove from Koha::Items->search_ordered
475 'lpad_copynumber',
=> all good
2. Remove the following block from
/usr/share/perl5/DBIx/Class/Storage/DBIHacks.pm
584 # only consider real columns (for functions the user got to do an
explicit group_by)
585 my $chunk_ci;
586 if (
587 @{$order_by[$o_idx]} != 1
588 or
589 # only declare an unknown *plain* identifier as "leftover" if we are
called with
590 # aliastypes to examine. If there are none - we are still in
_resolve_attrs, and
591 # can just assume the user knows what they want
592 ( ! ( $chunk_ci = $colinfos->{$order_by[$o_idx][0]} ) and
$attrs->{_aliastypes} )
593 ) {
594 push @$leftovers, $order_by[$o_idx][0];
595 }
=> all good
I don't know if we are doing something wrong here, but I have no idea
how we can build the group_by explicitely.
Is there another way to do this?
Signed-off-by: Laurence Rault
Signed-off-by: Emily Lamancusa
Signed-off-by: Tomás Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #144 from Jonathan Druart --- Created attachment 164368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164368=edit Bug 33568: Fix patron_to_html display Take HidePatronName into account Display cardnumber Remove parenthesis around cardnumber if the name is hidden Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #143 from Jonathan Druart --- Created attachment 164367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164367=edit Bug 33568: Restore column filters when StaffDetailItemSelection is off Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #142 from Jonathan Druart --- Created attachment 164366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164366=edit Bug 33568: Restore link to patron Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #141 from Jonathan Druart --- Created attachment 164365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164365=edit Bug 33568: Fix popup behaviour for SpineLabelShowPrintOnBibDetails Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #140 from Jonathan Druart --- Created attachment 164364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164364=edit Bug 33568: Hide 'Host records' if EasyAnalyticalRecords is off Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #139 from Jonathan Druart --- Created attachment 164363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164363=edit Bug 33568: Do not display 'null' when no barcode Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #138 from Jonathan Druart --- Created attachment 164362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164362=edit Bug 33568: Fix ordering Use search_ordered for default ordering It also fixes a crash when StaffDetailItemSelection is turned off. Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #137 from Jonathan Druart --- Created attachment 164361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164361=edit Bug 33568: JSON-encode html output of build_table This prevents error with quotes coming from translations Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #136 from Jonathan Druart --- Created attachment 164360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164360=edit Bug 33568: Hide holdings tabs if empty (SeparateHoldings) See comment 34. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #135 from Jonathan Druart --- Created attachment 164359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164359=edit Bug 33568: Add some missing StaffDetailItemSelection conditionals Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #134 from Jonathan Druart --- Created attachment 164358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164358=edit Bug 33568: follow-up for 29523 Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #133 from Jonathan Druart --- Created attachment 164356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164356=edit Bug 33568: Do not embed item types Performance for 1000 items from 22 to 19s It replaces the input in the column header filter with a dropdown list. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #132 from Jonathan Druart --- Created attachment 164355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164355=edit Bug 33568: Do not embed library names Performance for 1000 items from 30s to 22s It replaces the input in the column header filter with a dropdown list. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #131 from Jonathan Druart --- Created attachment 164354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164354=edit Bug 33568: (bug 34226 follow-up) Add type=date to date columns Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #130 from Jonathan Druart --- Created attachment 164353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164353=edit Bug 33568: Fix 'actions' links when filters are shown/hidden It also fixes a problem when "Select all" was clicked, the checkbox selection was not kept when the table was refreshed (was comparing string and integer, parseInt needed) Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #129 from Jonathan Druart --- Created attachment 164352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164352=edit Bug 33568: Fix local cover images We need to reprocess the images when the table is refreshed, to do that we teach verify_cover_images to go through a given container instead of the whole document, and pass a call back function to build_items_table that will be called when DataTables will have redrawn the table (drawCallback). Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #128 from Jonathan Druart --- Created attachment 164351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164351=edit Bug 33568: (follow-up) Restore filters This is a bit ugly but fixes the problem raised in the previous commit, as well as others for instance comment 18 "* Click 'show filters', 'hide filters' and repeat X 2 - status column disappears?" Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #127 from Jonathan Druart --- Created attachment 164350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164350=edit Bug 33568: Prevent 500 when filtering by item type (FIXMEs) See FIXMEs added by this patch Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #126 from Jonathan Druart --- Created attachment 164349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164349=edit Bug 33568: Add search on home and holding library's names QUESTION - Do we prefer this or a dropdown list in the column filter header? Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #125 from Jonathan Druart --- Created attachment 164348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164348=edit Bug 33568: Fix select/clear all links Follow-up for "Bug 33568: Preserve item selection across pagination and filtering" FIXME We should deal with the items selection in a better way, but I would not consider it blocker, that can be done later. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #124 from Jonathan Druart --- Created attachment 164347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164347=edit Bug 33568: Fix DT dom and remove DT info if not needed Was there a real need to deal with a specific dom? The "no filter" view was not really light, only the column filters were shown/hidden. This patch is suggesting to remove all the DT info in case the table is displaying all the items of the bibliographic record: Pagination, filtering, buttons, etc. This patch is for discussion. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #123 from Jonathan Druart --- Created attachment 164346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164346=edit Bug 33568: Move code to a dedicated include file Not very nice but at least the code is isolated in a separate file and reduce the size of detail.tt We could also move the code related to the item bundle that is included inside this same table. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #122 from Jonathan Druart --- Created attachment 164345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164345=edit Bug 33568: Restore analytics FIXME We cannot have the usual _count/+count pattern for the REST API, I think it's acceptable FIXME We lost the sort on this column, not a big deal IMO Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #121 from Jonathan Druart --- Created attachment 164344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164344=edit Bug 33568: Restore host records Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #120 from Jonathan Druart --- Created attachment 164343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164343=edit Bug 33568: Restore bundle items Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #119 from Jonathan Druart --- Created attachment 164342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164342=edit Bug 33568: Display the desk name for the first hold Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #118 from Jonathan Druart --- Created attachment 164341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164341=edit Bug 33568: Bug 33568: Display library names instead of codes for recall Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #117 from Jonathan Druart --- Created attachment 164340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164340=edit Bug 33568: Bug 33568: Display library names instead of codes for first hold Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #116 from Jonathan Druart --- Created attachment 164339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164339=edit Bug 33568: Display library names instead of codes for transfers Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #115 from Jonathan Druart --- Created attachment 164338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164338=edit Bug 33568: Use as_due_date to display due dates Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #114 from Jonathan Druart --- Created attachment 164337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164337=edit Bug 33568: Preserve item selection across pagination and filtering BTW Do we really need StaffDetailItemSelection? Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #113 from Jonathan Druart --- Created attachment 164336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164336=edit Bug 33568: Fix action links display Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #112 from Jonathan Druart --- Created attachment 164335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164335=edit Bug 33568: Restore filters FIXME - If we click 'show filters' the 'columns' list does not contain all the columns. We are destroying the DT and the hidden columns are removed from the dom. I think there are 2 possible solutions here: 1. don't destroy but adjust the 'dom' parameter of DT (I didn't manage to make this work correctly, because of the th filters) 2. Move the th definition in the JS init of DT Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #111 from Jonathan Druart --- Created attachment 164334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164334=edit Bug 33568: Escape all the things Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568
--- Comment #110 from Jonathan Druart ---
Created attachment 164333
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164333=edit
Bug 33568: Course reserves
FIXME We need tests here
FIXME/TODO - Isn't it possible to replace all this mess with the
following Koha::Item method and a new DBIC rs?
sub courses {
my ($self) = @_;
return Koha::Courses->search(
{ 'ci.itemnumber' => $self->itemnumber },
{ join=> { course_reserves => 'ci' } }
);
}
Signed-off-by: Owen Leonard
Signed-off-by: Laurence Rault
Signed-off-by: Emily Lamancusa
Signed-off-by: Tomás Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #109 from Jonathan Druart --- Created attachment 164332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164332=edit Bug 33568: Separate holdings This needs to be well tested! Sysprefs SeparateHoldings and SeparateHoldingsBranch As well as the "Lost items in staff interface" that can be defined at patron's category level. This patch is simply restoring the previous behaviour but I think we could do better. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #108 from Jonathan Druart --- Created attachment 164331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164331=edit Bug 33568: Restore action buttons Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #107 from Jonathan Druart --- Created attachment 164330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164330=edit Bug 33568: Print label button Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #106 from Jonathan Druart --- Created attachment 164329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164329=edit Bug 33568: Host title See FIXMEs! Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #105 from Jonathan Druart --- Created attachment 164328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164328=edit Bug 33568: public notes Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #104 from Jonathan Druart --- Created attachment 164327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164327=edit Bug 33568: Display stringified version of copy_number FIXME - should we apply the same test for other row._strings occurrences, in case they are not linked with an AV cat? Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #103 from Jonathan Druart --- Created attachment 164326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164326=edit Bug 33568: URI Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #102 from Jonathan Druart --- Created attachment 164325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164325=edit Bug 33568: Add link to moredetail Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #101 from Jonathan Druart --- Created attachment 164324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164324=edit Bug 33568: Status FIXME We need tests here! See the FIXME in the code, we are losing the ability to search on the status, but this is really impossible to implement if we are not storing the status (DB or search engine). Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #100 from Jonathan Druart --- Created attachment 164323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164323=edit Bug 33568: enumchron/volinfo Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #99 from Jonathan Druart --- Created attachment 164322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164322=edit Bug 33568: Item groups FIXME - we need tests, but I'd like to make sure there is no an easier way to do this many to many things. Tomas? Filter on the "Item group" column needs to be tested! Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #98 from Jonathan Druart --- Created attachment 164321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164321=edit Bug 33568: Shelving location Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #97 from Jonathan Druart --- Created attachment 164320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164320=edit Bug 33568: Fix search on item type Is this good? Cannot we return incorrect results here? Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #96 from Jonathan Druart --- Created attachment 164319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164319=edit Bug 33568: Remove visibility conditions Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #95 from Jonathan Druart --- Created attachment 164318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164318=edit Bug 33568: Add columns visibility Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #94 from Jonathan Druart --- Created attachment 164317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164317=edit Bug 33568: fix DataTables bKohaColumnsUseNames Looks like this bug does not exist in Koha, but we hit it here. Could be moved to its own bug. Compare with ../includes/columns_settings.inc (code that is used prior to this change) Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #93 from Jonathan Druart --- Created attachment 164316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164316=edit Bug 33568: Temporary set searchable to false where no data Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #92 from Jonathan Druart --- Created attachment 164315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164315=edit Bug 33568: Hide empty columns Instead of relying on the existence of data in at least one item we are going to hide empty columns. That could be confusing: it does not mean items on another page do not have data for this column. The user can still display the column using the "Columns" visibility button, and filter on the column. I think this is an acceptable behaviour. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #91 from Jonathan Druart --- Created attachment 164314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164314=edit Bug 33568: Cover images Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #90 from Jonathan Druart --- Created attachment 164313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164313=edit Bug 33568: Restore class names on th's Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #89 from Jonathan Druart --- Created attachment 164312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164312=edit Bug 33568: Display item type image Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #88 from Jonathan Druart --- Created attachment 164311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164311=edit Bug 33568: can_be_edited Not sure if this is ideal but at least the algorithm complexity is way better than before! Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #87 from Jonathan Druart --- Created attachment 164310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164310=edit Bug 33568: Display string version of coded values + format dates Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #86 from Jonathan Druart --- Created attachment 164309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164309=edit Bug 33568: Starting up Copying the same thead and making a new table using the REST API endpoint Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #85 from Jonathan Druart --- Created attachment 164308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164308=edit Bug 33568: Remove debug_display This is useless, we could move it to its own bug report if needed. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Emily Lamancusa Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #84 from Katrin Fischer --- Cool. Tomas, ready to pass QA or do we miss something else? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #83 from Jonathan Druart --- (In reply to Katrin Fischer from comment #82) > (In reply to Jonathan Druart from comment #81) > > There are really too many columns to display them all. I think the solution > > proposed by this patch is a good compromise and we need to hear from end > > users to adjust the behaviour if needed. > > I am OK with that. IIRC it would mean that not much changes for libraries > with few items, which is good for now. What do you think about adding a > little tool tip to the relevant section on the columns configuration page? > Maybe something like: > > "Please note that if a field is not used on the first page of items int he > holdings table, it will be automatically hidden from display and can be made > visible on demand. You can still use the column configuration to permanently > hide columns from the holdings table." > > Trying to minimize the surprise and manage expectations :) Added, see commit "Add hint on the table settings admin page". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
