[Koha-bugs] [Bug 33649] Fix use of cronlogaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED CC||lu...@bywatersolutions.com Status|Pushed to stable|RESOLVED --- Comment #9 from Lucas Gass --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33649] Fix use of cronlogaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 --- Comment #8 from Martin Renvoize --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33649] Fix use of cronlogaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Martin Renvoize changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.06 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33649] Fix use of cronlogaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Bug 33649 depends on bug 31203, which changed state. Bug 31203 Summary: Cronjobs should log completion as well as logging begin https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33649] Fix use of cronlogaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33649] Fix use of cronlogaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33649] Fix use of cronlogaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Jonathan Druart changed: What|Removed |Added Severity|enhancement |normal --- Comment #6 from Jonathan Druart --- Can be tested easily adding a sleep right after the lock. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33649] Fix use of cronlogaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649
Jonathan Druart changed:
What|Removed |Added
Attachment #150573|0 |1
is obsolete||
--- Comment #5 from Jonathan Druart ---
Created attachment 150577
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150577&action=edit
Bug 33649: Fix use of cronlogaction
C4::Log::cronlogaction() takes a hashref as argument, with "info"
and possibly "action" as keys. But there are a couple of places
where it is called with just a string as argument, and that does
not work. Both places need lock_exec to fail to trigger the error.
I have seen this on a production server, but not been able to
reproduce in ktd.
To test:
- Run this on the Koha repo: grep -r "cronlogaction(" *
- Verify that fines.pl and process_message_queue.pl are the only
scripts that call cronlogaction without a hashref as argument,
but do it like this: cronlogaction( $message );
- Apply this patch
- Run the grep again and verify that all calls to cronlogaction
now take a hashref as argument
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33649] Fix use of cronlogaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33649] Fix use of cronlogaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649
Nick Clemens changed:
What|Removed |Added
Attachment #150563|0 |1
is obsolete||
--- Comment #4 from Nick Clemens ---
Created attachment 150573
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150573&action=edit
Bug 33649: Fix use of cronlogaction
C4::Log::cronlogaction() takes a hashref as argument, with "info"
and possibly "action" as keys. But there are a couple of places
where it is called with just a string as argument, and that does
not work. Both places need lock_exec to fail to trigger the error.
I have seen this on a production server, but not been able to
reproduce in ktd.
To test:
- Run this on the Koha repo: grep -r "cronlogaction(" *
- Verify that fines.pl and process_message_queue.pl are the only
scripts that call cronlogaction without a hashref as argument,
but do it like this: cronlogaction( $message );
- Apply this patch
- Run the grep again and verify that all calls to cronlogaction
now take a hashref as argument
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33649] Fix use of cronlogaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33649] Fix use of cronlogaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649
--- Comment #3 from Magnus Enger ---
Created attachment 150563
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150563&action=edit
Bug 33649: Fix use of cronlogaction
C4::Log::cronlogaction() takes a hashref as argument, with "info"
and possibly "action" as keys. But there are a couple of places
where it is called with just a string as argument, and that does
not work. Both places need lock_exec to fail to trigger the error.
I have seen this on a production server, but not been able to
reproduce in ktd.
To test:
- Run this on the Koha repo: grep -r "cronlogaction(" *
- Verify that fines.pl and process_message_queue.pl are the only
scripts that call cronlogaction without a hashref as argument,
but do it like this: cronlogaction( $message );
- Apply this patch
- Run the grep again and verify that all calls to cronlogaction
now take a hashref as argument
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33649] Fix use of cronlogaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Magnus Enger changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33649] Fix use of cronlogaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 --- Comment #2 from Magnus Enger --- (In reply to Jonathan Druart from comment #1) > There is an other one in misc/cronjobs/fines.pl. Yeah, just spotted it. :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33649] Fix use of cronlogaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Magnus Enger changed: What|Removed |Added Summary|Fix use of cronlogaction in |Fix use of cronlogaction |process_message_queue.pl| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33649] Fix use of cronlogaction in process_message_queue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Jonathan Druart changed: What|Removed |Added Depends on||31203 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 [Bug 31203] Cronjobs should log completion as well as logging begin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33649] Fix use of cronlogaction in process_message_queue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #1 from Jonathan Druart --- There is an other one in misc/cronjobs/fines.pl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33649] Fix use of cronlogaction in process_message_queue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Magnus Enger changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mag...@libriotech.no |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
