[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 --- Comment #15 from Matt Blenkinsop --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 Matt Blenkinsop changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.11.00|23.11.00,23.05.04 released in|| CC||fridolin.som...@biblibre.co ||m --- Comment #14 from Fridolin Somers --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 --- Comment #12 from Marcel de Rooy --- (In reply to David Nind from comment #8) > This patch removes a deprecated internal data structure no longer supported > in jQuery. This means that AddEventHandlers now correctly passes events to > cloned fields in the MARC record Took the liberty to further clarify this statement in the commit message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 Marcel de Rooy changed: What|Removed |Added Attachment #154796|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 155081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155081=edit Bug 33744: Fix cloning (sub)fields with framework plugins This patch is meant as a temporary measure for fixing the problem. Bug 30975 may resolve it further, but this is good for now. Note: The original commit message referred to removing a deprecated internal structure. But this patch actually still uses the structure which has been moved to _data in jQuery now. Test plan: 1) Apply patch 2) Repeat steps in the original bug description 3) This time clicking on the Upload button for a cloned field should launch the uploads pop up. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #10 from Marcel de Rooy --- Looking here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 --- Comment #9 from David Nind --- I've added some comments to bug 30975 (comment 45) on whether to go ahead with 30975 as is, or go ahead with this one as a temporary measure. From the user perspective, maybe getting cloning of subfields with plugins/value builders should be the priority? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744
David Nind changed:
What|Removed |Added
Attachment #153538|0 |1
is obsolete||
--- Comment #8 from David Nind ---
Created attachment 154796
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154796=edit
Bug 33744: Fix deprecated use of .data('events')
This patch removes a deprecated internal data structure no longer supported in
jQuery. This means that AddEventHandlers now correctly passes events to cloned
fields in the MARC record
Test plan:
1) Apply patch
2) Repeat steps in the original bug description
3) This time clicking on the Upload button for a cloned field should launch the
uploads pop up.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 David Nind changed: What|Removed |Added CC||da...@davidnind.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30975 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744
Matt Blenkinsop changed:
What|Removed |Added
Attachment #151270|0 |1
is obsolete||
--- Comment #7 from Matt Blenkinsop ---
Created attachment 153538
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153538=edit
Bug 33744: Fix deprecated use of .data('events')
This patch removes a deprecated internal data structure no longer supported in
jQuery. This means that AddEventHandlers now correctly passes events to cloned
fields in the MARC record
Test plan:
1) Apply patch
2) Repeat steps in the original bug description
3) This time clicking on the Upload button for a cloned field should launch the
uploads pop up.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 Matt Blenkinsop changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 --- Comment #6 from Matt Blenkinsop --- 30975 is still blocked so maybe Marcel is right and we should use this patch as a temporary fix - I'll rebase and re-submit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 --- Comment #5 from Marcel de Rooy --- Perhaps we can use it as a temporary workaround until 30975 gets in ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744
--- Comment #4 from Marcel de Rooy ---
> This patch removes a deprecated internal data structure no longer supported
> in jQuery.
// Note: This code depends on the jQuery data for events; this structure
// is moved to _data as of jQuery 1.8.
-var ev= $(oldcontrol).data('events');
+var ev = $._data(oldcontrol, "events");
You are using an internal structure here. Where we really dont know how long it
will be supported.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 Marcel de Rooy changed: What|Removed |Added Resolution|DUPLICATE |--- Status|RESOLVED|REOPENED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744
--- Comment #3 from Matt Blenkinsop ---
Created attachment 151270
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151270=edit
Bug 33744: Fix deprecated use of .data('events')
This patch removes a deprecated internal data structure no longer supported in
jQuery. This means that AddEventHandlers now correctly passes events to cloned
fields in the MARC record
Test plan:
1) Apply patch
2) Repeat steps in the original bug description
3) This time clicking on the Upload button for a cloned field should launch the
uploads pop up.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 Marcel de Rooy changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Marcel de Rooy --- *** This bug has been marked as a duplicate of bug 30975 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 --- Comment #1 from Marcel de Rooy --- Looks like this is addressed under bug 30975. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 Matt Blenkinsop changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
