[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-06-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Matt Blenkinsop  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||matt.blenkinsop@ptfs-europe
   ||.com
 Status|Pushed to master|RESOLVED

--- Comment #16 from Matt Blenkinsop  ---
Dependencies missing - not backporting to 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Jonathan Druart  changed:

   What|Removed |Added

   Severity|blocker |normal
 Version(s)||23.05.00
released in||
 Status|Signed Off  |Passed QA
   Keywords|regression, |
   |rel_23_05_candidate |

--- Comment #15 from Jonathan Druart  ---
Pushed to master for 23.05.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 151817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151817=edit
Bug 33783: Only use ecost if unitprice has not been set on ordering

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

--- Comment #13 from Jonathan Druart  ---
You need to get ecost only if unitprice has not been passed when ordering.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

--- Comment #12 from Jonathan Druart  ---
416 [% IF (invoiceincgst) %]
417 [% SET unitprice = order.unitprice_tax_included > 0 ?
order.unitprice_tax_included : order.ecost_tax_included %]
418  (tax inclusive)
419 [% ELSE %]
420 [% SET unitprice = order.unitprice_tax_included > 0 ?
order.unitprice_tax_excluded : order.ecost_tax_excluded %]
421  (tax exclusive)
422 [% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com
 Status|Passed QA   |Failed QA

--- Comment #11 from Jonathan Druart  ---
wait

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

--- Comment #10 from Jonathan Druart  ---
Created attachment 151795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151795=edit
Bug 33783: Make sure the value is populated on load time

The original patch makes the form set the right values in the order row
(before storing it) but misses to load the right value on page load,
which is still a regression. This patch solves that.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #151761|0   |1
is obsolete||
 Attachment #151789|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart  ---
Created attachment 151794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151794=edit
Bug 33783: (bug 8179 follow-up) Populate actual cost with ecost during
receiving if not set

This restores behavior prior to 8179 to use the estimated cost when receiving
if the
actual cost is not set.

We set the unitprice in the table row so that it will be used when editing and
will be saved even if not adjusted

To test:
1 - Add some orders to a basket, do not set actual cost field
2 - Close basket, receive orders
3 - Note actual cost field is blank
4 - Cancel receipt
5 - Apply patch
6 - Receive again
7 - Note actual cost is populated
8 - Complete receipt and confirm actual cost correctly saved

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 151789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151789=edit
Bug 33783: Make sure the value is populated on load time

The original patch makes the form set the right values in the order row
(before storing it) but misses to load the right value on page load,
which is still a regression. This patch solves that.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

--- Comment #7 from Katrin Fischer  ---
Just noting: I tested the process in 20.11 and the actual cost is pre-populated
there. So I can confirm this bug is a regression.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #6 from Katrin Fischer  ---
Applied patch, restart_all, but the actual cost remains 0 on receive, for both
multi and single receive :(

Any hints?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #151758|0   |1
is obsolete||

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 151761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151761=edit
Bug 33783: (bug 8179 follow-up) Populate actual cost with ecost during
receiving if not set

This restores behavior prior to 8179 to use the estimated cost when receiving
if the
actual cost is not set.

We set the unitprice in the table row so that it will be used when editing and
will be saved even if not adjusted

To test:
1 - Add some orders to a basket, do not set actual cost field
2 - Close basket, receive orders
3 - Note actual cost field is blank
4 - Cancel receipt
5 - Apply patch
6 - Receive again
7 - Note actual cost is populated
8 - Complete receipt and confirm actual cost correctly saved

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Nick Clemens  changed:

   What|Removed |Added

 Attachment #151469|0   |1
is obsolete||

--- Comment #4 from Nick Clemens  ---
Created attachment 151758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151758=edit
Bug 33783: (bug 8179 follow-up) Populate actual cost with ecost during
receiving if not set

This restores behavior prior to 8179 to use the estimated cost when receiving
if the
actual cost is not set.

We set the unitprice in the table row so that it will be used when editing and
will be saved even if not adjusted

To test:
1 - Add some orders to a basket, do not set actual cost field
2 - Close basket, receive orders
3 - Note actual cost field is blank
4 - Cancel receipt
5 - Apply patch
6 - Receive again
7 - Note actual cost is populated
8 - Complete receipt and confirm actual cost correctly saved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

--- Comment #3 from Nick Clemens  ---
The problem is that the form expects you to enter a value - if you don't we
don't fire an event to update the table rows, which are considered the source
of truth.

We need some way to check the form values when  'Save changes' is clicked

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Sam Lau  changed:

   What|Removed |Added

 CC||sama...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #2 from Sam Lau  ---
Created a new basket and added various items to basket, giving each one a
vendor price, however leaving actual cost blank. After adding to basket, I
closed basket and received the orders. Actual cost field was blank on the
receipt. Canceled the receipt and applied patch. Received orders again. This
time when I was receiving I noticed that the actual cost was showing up while
receiving, however after finishing and viewing the receipt, the actual cost was
still left blank.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||8179


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179
[Bug 8179] Receiving multiple order lines at once
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|8179|


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179
[Bug 8179] Receiving multiple order lines at once
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Severity|enhancement |blocker

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords||rel_23_05_candidate
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

--- Comment #1 from Nick Clemens  ---
Created attachment 151469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151469=edit
Bug 33783: (bug 8179 follow-up) Populate actual cost with ecost during
receiving if not set

This restores behavior prior to 8179 to use the estimated cost when receiving
if the
actual cost is not set

To test:
1 - Add some orders to a basket, do not set actual cost field
2 - Close basket, receive orders
3 - Note actual cost field is blank
4 - Cancel receipt
5 - Apply patch
6 - Receive again
7 - Note actual cost is populated
8 - Complete receipt and confirm actual cost correctly saved

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)

2023-05-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 Depends on||8179


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179
[Bug 8179] Receiving multiple order lines at once
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/