[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #13 from Katrin Fischer --- Works well, fixed the commit message :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Katrin Fischer changed: What|Removed |Added Attachment #151776|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 151777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151777=edit Bug 33786: ILL requests table id Make sure requests table is unique when visiting patron ILL history so the table state is not shared unintentionally Reproduce: 1) Have a borrower with >20 ILL requests in their history 2) Visit cgi-bin/koha/members/ill-requests.pl?borrowernumber= 3) On the table, click page 2 4) Visit a different borrower with <20 ILL requests 5) Verify that no requests are shown, this is because the table is using page 2 from step 3) 6) Go back to original borrower, click table page 1 7) Now go back to 2nd borrower, verify is now showing page 1 correctly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Katrin Fischer changed: What|Removed |Added Attachment #151773|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 151776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151776=edit Bug 33786: ILL requests table id Reproduce: 1) Have a borrower with >20 ILL requests in their history 2) Visit cgi-bin/koha/members/ill-requests.pl?borrowernumber= 3) On the table, click page 2 4) Visit a different borrower with <20 ILL requests 5) Verify that no requests are shown, this is because the table is using page 2 from step 3) 6) Go back to original borrower, click table page 1 7) Now go back to 2nd borrower, verify is now showing page 1 correctly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 --- Comment #10 from Katrin Fischer --- Please don't forget to write good commit messages. Problem description and test plan should be included. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 --- Comment #9 from Pedro Amorim --- I've rewritten the patch and tested that all works as intended. Please review again. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 --- Comment #8 from Pedro Amorim --- Created attachment 151773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151773=edit Bug 33786: ILL requests table id -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Pedro Amorim changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Pedro Amorim changed: What|Removed |Added Attachment #151670|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 --- Comment #7 from Tomás Cohen Arazi --- Can we make this happen before wednesday? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #6 from Jonathan Druart --- We should instantiate borrower_prefilter_value, the code is confusing as it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Martin Renvoize changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Martin Renvoize changed: What|Removed |Added Attachment #151511|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 151670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151670=edit Bug 33786: ILL requests table id Make sure requests table is unique when visiting patron ILL history so the table state is not shared unintentionally Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Pedro Amorim changed: What|Removed |Added Blocks||30719 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 [Bug 30719] ILL should provide the ability to create batch requests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Pedro Amorim changed: What|Removed |Added Attachment #151506|0 |1 is obsolete|| --- Comment #4 from Pedro Amorim --- Created attachment 151511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151511=edit Bug 33786: ILL requests table id Make sure requests table is unique when visiting patron ILL history so the table state is not shared unintentionally -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 --- Comment #3 from Pedro Amorim --- I'm happy with this patch, extra eyes on it are welcome. Thank you Tomas for your suggestion re making the requests table id unique, it does fix the issue and we can keep the stateSave: true this way. Test plan is the same as the steps to reproduce the issue, except the issue should not occur anymore after patch is applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Pedro Amorim changed: What|Removed |Added Attachment #151487|0 |1 is obsolete|| --- Comment #2 from Pedro Amorim --- Created attachment 151506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151506=edit Bug 33786: ILL requests table id Make sure requests table is unique when visiting patron ILL history so the table state is not shared unintentionally -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 --- Comment #1 from Pedro Amorim --- Created attachment 151487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151487=edit Bug 33786: set stateSave to false This fixes the issue, but I wonder if this is the fix for this, or a better alternative exists -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
