[Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 --- Comment #11 from Pedro Amorim --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Pedro Amorim changed: What|Removed |Added Version(s)|23.11.00,23.05.01 |23.11.00,23.05.01,22.11.08 released in|| Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.11.00|23.11.00,23.05.01 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Nick Clemens changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 --- Comment #8 from Nick Clemens --- Created attachment 152111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152111=edit Bug 33844: Fix is_denied_renewal Going via result_set->has_column does cost actually nothing if the object is already there. Test plan: Run again t/db_dependent/Koha/Item.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Nick Clemens changed: What|Removed |Added Attachment #151785|0 |1 is obsolete|| Attachment #151786|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 152110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152110=edit Bug 33844: Modify test to show problem Add delete key. Without the follow-up, this triggers a delete. Test fails. DBIx::Class::Row::delete(): Not in database at /usr/share/koha/Koha/Object.pm line 234 Test plan: Run t/db_dependent/Koha/Item.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 --- Comment #6 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #5) > We usually use Koha::Objects->columns to retrieve the exist columns. Not > sure what's the fastest here however. This is the fastest. Timed a few things here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #5 from Jonathan Druart --- We usually use Koha::Objects->columns to retrieve the exist columns. Not sure what's the fastest here however. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Katrin Fischer changed: What|Removed |Added Attachment #151760|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 151786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151786=edit Bug 33844: Fix is_denied_renewal Going via result_set->has_column does cost actually nothing if the object is already there. Test plan: Run again t/db_dependent/Koha/Item.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Katrin Fischer changed: What|Removed |Added Attachment #151759|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 151785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151785=edit Bug 33844: Modify test to show problem Add delete key. Without the follow-up, this triggers a delete. Test fails. DBIx::Class::Row::delete(): Not in database at /usr/share/koha/Koha/Object.pm line 234 Test plan: Run t/db_dependent/Koha/Item.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Marcel de Rooy changed: What|Removed |Added Summary|item->is_denied_renewal |item->is_denied_renewal |should validate fields from |should check column from |associated pref |associated pref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
