[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #15 from Fridolin Somers --- Not backported to 23.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Marcel de Rooy changed: What|Removed |Added Blocks||34336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 [Bug 34336] Test::DBIx::Class should be removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 --- Comment #13 from Jonathan Druart --- Created attachment 155096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155096=edit Bug 33870: Fix indentation in subtest Test plan: git diff -w HEAD~1.. t/db_dependent/Sitemapper.t Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim JD amended patch: tidy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 --- Comment #12 from Jonathan Druart --- Created attachment 155095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155095=edit Bug 33870: Polishing Sitemapper.t Create subtest. Remove (useless) mock on DateTime. Remove T::D::C module, add TestBuilder. Replace local slurp function by use File::Slurp. Test plan: Run t/db_dependent/Sitemapper.t Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Jonathan Druart changed: What|Removed |Added Attachment #153453|0 |1 is obsolete|| Attachment #153454|0 |1 is obsolete|| Attachment #153455|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 155094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155094=edit Bug 33870: Make $MAX in Sitemapper::Writer global This should preferably not be a lexical variable (in case we ever should call this under Plack). A global variable will also simplify testing (see next patch). Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 --- Comment #10 from Pedro Amorim --- (In reply to Jonathan Druart from comment #9) > # FIXME Would be nice to remove both deletes again > Koha::Checkouts->delete; > Koha::Biblios->delete; > > > We should not do that, even with a FIXME. They get removed in bug 33871 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.druart+koha@gmail. ||com --- Comment #9 from Jonathan Druart --- # FIXME Would be nice to remove both deletes again Koha::Checkouts->delete; Koha::Biblios->delete; We should not do that, even with a FIXME. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Pedro Amorim changed: What|Removed |Added Attachment #151877|0 |1 is obsolete|| --- Comment #8 from Pedro Amorim --- Created attachment 153455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153455=edit Bug 33870: Fix indentation in subtest Test plan: git diff -w HEAD~1.. t/db_dependent/Sitemapper.t Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Pedro Amorim changed: What|Removed |Added Attachment #151876|0 |1 is obsolete|| --- Comment #7 from Pedro Amorim --- Created attachment 153454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153454=edit Bug 33870: Polishing Sitemapper.t Create subtest. Remove (useless) mock on DateTime. Remove T::D::C module, add TestBuilder. Replace local slurp function by use File::Slurp. Test plan: Run t/db_dependent/Sitemapper.t Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Pedro Amorim changed: What|Removed |Added Attachment #151875|0 |1 is obsolete|| --- Comment #6 from Pedro Amorim --- Created attachment 153453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153453=edit Bug 33870: Make $MAX in Sitemapper::Writer global This should preferably not be a lexical variable (in case we ever should call this under Plack). A global variable will also simplify testing (see next patch). Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 --- Comment #5 from Marcel de Rooy --- (In reply to Pedro Amorim from comment #4) > Hi Marcel, I'm looking at this to attempt an SO but I'm not 100% familiar > with tests or Sitemapper.t. > > My understanding of this patch is that we're cleaning up Sitemapper.t and > bringing it up to par a bit more with the most recent way of writing tests, > e.g. Slurp. > > $schema->storage->txn_rollback; at the end also seems like something that > was missing and I believe it should've always been there? Yes > I don't understand or see the need for the "FIXME" comment, if for the tests > we need to make sure the only biblios that exist are the 2 biblios we're > creating in the tests, isn't "Koha::Biblios->delete;" a perfectly fine way > of doing it? Yes, it works. And we do it more often in tests. But it is not the most elegant way. So maybe TODO could have been more appropriate? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m --- Comment #4 from Pedro Amorim --- Hi Marcel, I'm looking at this to attempt an SO but I'm not 100% familiar with tests or Sitemapper.t. My understanding of this patch is that we're cleaning up Sitemapper.t and bringing it up to par a bit more with the most recent way of writing tests, e.g. Slurp. $schema->storage->txn_rollback; at the end also seems like something that was missing and I believe it should've always been there? I don't understand or see the need for the "FIXME" comment, if for the tests we need to make sure the only biblios that exist are the 2 biblios we're creating in the tests, isn't "Koha::Biblios->delete;" a perfectly fine way of doing it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Marcel de Rooy changed: What|Removed |Added Blocks||33871 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33871 [Bug 33871] Add where parameter to sitemap.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 --- Comment #3 from Marcel de Rooy --- Created attachment 151877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151877=edit Bug 33870: Fix indentation in subtest Test plan: git diff -w HEAD~1.. t/db_dependent/Sitemapper.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 --- Comment #2 from Marcel de Rooy --- Created attachment 151876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151876=edit Bug 33870: Polishing Sitemapper.t Create subtest. Remove (useless) mock on DateTime. Remove T::D::C module, add TestBuilder. Replace local slurp function by use File::Slurp. Test plan: Run t/db_dependent/Sitemapper.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 --- Comment #1 from Marcel de Rooy --- Created attachment 151875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151875=edit Bug 33870: Make $MAX in Sitemapper::Writer global This should preferably not be a lexical variable (in case we ever should call this under Plack). A global variable will also simplify testing (see next patch). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Marcel de Rooy changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
