[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Bug 34119 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What|Removed |Added Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #23 from Matt Blenkinsop --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.12 released in|| Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|23.11.00|23.11.00,23.05.05 released in|| Status|Pushed to master|Pushed to stable --- Comment #22 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #21 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #20 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #19) > (In reply to Katrin Fischer from comment #18) > > I think removing them would be nice, but is probably a page specific change > > whie this takes care of the general elements. I think maybe we could take a > > closer look at other pages separately. Also: patron search results has a > > export > print option on the table that gives nice results :) > > Alright, let's go with the current proposal then! :) > > > > minor findings: > > > - on record detail page, should the content of the descriptions tab be > > > after > > > the list of items? And same for acquisition details. No reliable idea on > > > what is more relevant when printing, mentioning this just in case. > > > > They both appear after the item list for me. And it doesn't matter which tab > > is active before switching to print layout. > > My phrasing was weird. I meant that they are indeed after the item list, but > should they? > (It sounded that like I was suggesting that they should be after. But it's > already the case) That's the sequence in the source code, I think it's correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #19 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #18) > I think removing them would be nice, but is probably a page specific change > whie this takes care of the general elements. I think maybe we could take a > closer look at other pages separately. Also: patron search results has a > export > print option on the table that gives nice results :) Alright, let's go with the current proposal then! :) > > minor findings: > > - on record detail page, should the content of the descriptions tab be after > > the list of items? And same for acquisition details. No reliable idea on > > what is more relevant when printing, mentioning this just in case. > > They both appear after the item list for me. And it doesn't matter which tab > is active before switching to print layout. My phrasing was weird. I meant that they are indeed after the item list, but should they? (It sounded that like I was suggesting that they should be after. But it's already the case) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Katrin Fischer changed: What|Removed |Added Attachment #156814|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 157161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157161=edit Bug 34119: Improve staff interface print stylesheet following redesign This patch makes some updates to the staff interface print stylesheet in order to make it work better following the staff interface redesign. To test, apply the patch and clear your browser cache if necessary. In the staff client, go to various pages and view the print preview. The print view should exclude the header navigation, header search, page toolbars and page sidebars. - Pages with tabbed displays should show content from all tabs: e.g. bibliographic details, MARC editor. - In Reports, check that report results print well. - Pages with DataTables should print with table information visible but table controls hidden. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119
Katrin Fischer changed:
What|Removed |Added
Attachment #156813|0 |1
is obsolete||
--- Comment #16 from Katrin Fischer ---
Created attachment 157160
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157160=edit
Bug 34119: (Preliminary) Run stylelint fixes on print.css
This patch corrects errors raised by the new stylelint configuration in
print.css. Most of the fixes were made automatically by using the
"--fix" option:
npx stylelint koha-tmpl/intranet-tmpl/prog/css/print.css --fix
Some examples of errors fixed automatically:
- Expected indentation of 4 spaces
- Unexpected whitespace before ":"
- Unexpected unit
- Expected single space before "{"
- Expected newline after ";" in a multi-line declaration block
Errors from use of "!important" have been ignored.
Signed-off-by: Marcel de Rooy
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Marcel de Rooy changed: What|Removed |Added Attachment #156799|0 |1 is obsolete|| --- Comment #14 from Marcel de Rooy --- Created attachment 156814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156814=edit Bug 34119: Improve staff interface print stylesheet following redesign This patch makes some updates to the staff interface print stylesheet in order to make it work better following the staff interface redesign. To test, apply the patch and clear your browser cache if necessary. In the staff client, go to various pages and view the print preview. The print view should exclude the header navigation, header search, page toolbars and page sidebars. - Pages with tabbed displays should show content from all tabs: e.g. bibliographic details, MARC editor. - In Reports, check that report results print well. - Pages with DataTables should print with table information visible but table controls hidden. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119
Marcel de Rooy changed:
What|Removed |Added
Attachment #156798|0 |1
is obsolete||
--- Comment #13 from Marcel de Rooy ---
Created attachment 156813
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156813=edit
Bug 34119: (Preliminary) Run stylelint fixes on print.css
This patch corrects errors raised by the new stylelint configuration in
print.css. Most of the fixes were made automatically by using the
"--fix" option:
npx stylelint koha-tmpl/intranet-tmpl/prog/css/print.css --fix
Some examples of errors fixed automatically:
- Expected indentation of 4 spaces
- Unexpected whitespace before ":"
- Unexpected unit
- Expected single space before "{"
- Expected newline after ";" in a multi-line declaration block
Errors from use of "!important" have been ignored.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #12 from Owen Leonard --- Created attachment 156799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156799=edit Bug 34119: Improve staff interface print stylesheet following redesign This patch makes some updates to the staff interface print stylesheet in order to make it work better following the staff interface redesign. To test, apply the patch and clear your browser cache if necessary. In the staff client, go to various pages and view the print preview. The print view should exclude the header navigation, header search, page toolbars and page sidebars. - Pages with tabbed displays should show content from all tabs: e.g. bibliographic details, MARC editor. - In Reports, check that report results print well. - Pages with DataTables should print with table information visible but table controls hidden. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119
--- Comment #11 from Owen Leonard ---
Created attachment 156798
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156798=edit
Bug 34119: (Preliminary) Run stylelint fixes on print.css
This patch corrects errors raised by the new stylelint configuration in
print.css. Most of the fixes were made automatically by using the
"--fix" option:
npx stylelint koha-tmpl/intranet-tmpl/prog/css/print.css --fix
Some examples of errors fixed automatically:
- Expected indentation of 4 spaces
- Unexpected whitespace before ":"
- Unexpected unit
- Expected single space before "{"
- Expected newline after ";" in a multi-line declaration block
Errors from use of "!important" have been ignored.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Owen Leonard changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #10 from Owen Leonard --- *** Bug 35016 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Owen Leonard changed: What|Removed |Added Depends on||30952 Status|NEW |ASSIGNED Summary|After redesign, print.css |Improve staff interface |no longer hides things at |print stylesheet following |the top of report results |redesign Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
