[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 --- Comment #11 from Lucas Gass --- Thank you, Martin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 --- Comment #10 from Martin Renvoize --- Tiny rebase.. deciding to upgrade my SO to a PQA as the patch is trivial, clear and QA scripts are happy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Martin Renvoize changed: What|Removed |Added Attachment #155380|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 157235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157235=edit Bug 34377: (follow-up) Use patron-title include This switched the existing manual handling of patron title construction to use the accepted include method. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Martin Renvoize changed: What|Removed |Added Attachment #155379|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 157234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157234=edit Bug 34377: Add managing librarain 1. From the patron Accounting tab > "Create manual credit". 2. From the patron Accounting tab > "Create manua 3. Go to the Transaction tab (members/boraccount.pl) and click the 'Details' button. 4. Do this for both a debit and a credit. 5. No info. about which librarain administered the credit/debit. 6. Apply patch 7. Try 3 -6 again, notice the table now shows which librarian administed the credit/debit. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 --- Comment #7 from Lucas Gass --- (In reply to Martin Renvoize from comment #6) > I signed off and added a follow-up to convert to using the aforementioned > include. > > I'm confused by that include.. it requires `hide_patron_infos_if_needed => > 1` is passed to allow a link to be created. In this case, we're looking at a > librarian, I sort of feel like we should be able to override the hide but > that would nuke the link which would be a regression I believe. > > Anywho.. it's looking good to me now. Thank you, Martin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 --- Comment #6 from Martin Renvoize --- I signed off and added a follow-up to convert to using the aforementioned include. I'm confused by that include.. it requires `hide_patron_infos_if_needed => 1` is passed to allow a link to be created. In this case, we're looking at a librarian, I sort of feel like we should be able to override the hide but that would nuke the link which would be a regression I believe. Anywho.. it's looking good to me now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 --- Comment #5 from Martin Renvoize --- Created attachment 155380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155380=edit Bug 34377: (follow-up) Use patron-title include This switched the existing manual handling of patron title construction to use the accepted include method. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Martin Renvoize changed: What|Removed |Added Attachment #155345|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 155379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155379=edit Bug 34377: Add managing librarain 1. From the patron Accounting tab > "Create manual credit". 2. From the patron Accounting tab > "Create manua 3. Go to the Transaction tab (members/boraccount.pl) and click the 'Details' button. 4. Do this for both a debit and a credit. 5. No info. about which librarain administered the credit/debit. 6. Apply patch 7. Try 3 -6 again, notice the table now shows which librarian administed the credit/debit. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 --- Comment #3 from Martin Renvoize --- You construct the name display here manually.. don't we have an include for that to ensure consistency? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Lucas Gass changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Lucas Gass changed: What|Removed |Added Version|unspecified |master Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 --- Comment #2 from Lucas Gass --- Created attachment 155345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155345=edit Bug 34377: Add managing librarain 1. From the patron Accounting tab > "Create manual credit". 2. From the patron Accounting tab > "Create manua 3. Go to the Transaction tab (members/boraccount.pl) and click the 'Details' button. 4. Do this for both a debit and a credit. 5. No info. about which librarain administered the credit/debit. 6. Apply patch 7. Try 3 -6 again, notice the table now shows which librarian administed the credit/debit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34377] accountline-details.pl does not show managing librarian info for credits/debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377 Lucas Gass changed: What|Removed |Added Summary|accountline-details.pl does |accountline-details.pl does |not show related|not show managing librarian |transaction information for |info for credits/debits |credits | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
