[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 --- Comment #14 from Victor Grousset/tuxayo --- Ain't no way... SCI and SCO are broken due to not complying with CSRF. Reviewing this patch is endless Great, it's a known bug and it's active: Bug 36349 (OMG it's a mess ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643
--- Comment #13 from Kyle M Hall ---
(In reply to Victor Grousset/tuxayo from comment #11)
> Thanks for the follow-up.
>
> > ("CircConfirmItemPartsSCI", ?, NULL, "Deny checkout of multipart items for
> > self-checkin", "Yes/No"),
>
> Hmm, that question mark pretty sus.
> Somehow it doesn't exploded when populating the DB and can go unnoticed :o
Very sus ;) Also fixed now!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 --- Comment #12 from Kyle M Hall --- Created attachment 163675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163675=edit Bug 34643: (QA follow-up) Fix default syspref values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #11 from Victor Grousset/tuxayo ---
Thanks for the follow-up.
> ("CircConfirmItemPartsSCI", ?, NULL, "Deny checkout of multipart items for
> self-checkin", "Yes/No"),
Hmm, that question mark pretty sus.
Somehow it doesn't exploded when populating the DB and can go unnoticed :o
So, it should be 0, right? Because we copy CircConfirmItemParts in the dbrev
and here it defaults to 0.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 --- Comment #10 from Victor Grousset/tuxayo --- Created attachment 163657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163657=edit Bug 34643: (QA follow-up): fix order of new sysprefs and quotation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 Victor Grousset/tuxayo changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 --- Comment #9 from Kyle M Hall --- Created attachment 163318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163318=edit Bug 34643: (QA follow-up) Add new sysprefs to sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Signed Off |Failed QA --- Comment #8 from Victor Grousset/tuxayo --- (In reply to Victor Grousset/tuxayo from comment #7) > Is that something we usually do to not have some sysprefs in > installer/data/mysql/mandatory/sysprefs.sql ? > When their default value is 0. Confirmed that is an issue: Bug 34979 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 --- Comment #7 from Victor Grousset/tuxayo --- Is that something we usually do to not have some sysprefs in installer/data/mysql/mandatory/sysprefs.sql ? When their default value is 0. It's not mentioned here: https://wiki.koha-community.org/wiki/System_Preferences#Adding_a_new_system_preference --- Amended the patch for minor tidying. --- Otherwise, code looks good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #159113|0 |1 is obsolete|| --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 163145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163145=edit Bug 34643: Split CircConfirmItemParts for self-checkout and self-checkin Many libraries wish to be able to allow self-check for multi-part items while requesting librarians to verify the parts when checking out/in at the desk. It makes sense to split CircConfirmItemParts into three prefs such that the feature can be enabled/disabled for SCO and SCI independently. Test Plan: 1) Apply this patch 2) Enable SCO and SCI 3) Set CircConfirmItemPartsSCO to "Don't allow" 4) Attempt to checkout out an item with materials via SCO, it should fail 5) Set CircConfirmItemPartsSCO to "Allow" 6) Repeat step 4, it should succeed 7) Set CircConfirmItemPartsSCI to "Don't allow" 8) Attempt to check in the item via SCI, it should fail 9) Attempt to check in the item via SCO, it should fail 9) Set CircConfirmItemPartsSCI to "Allow" 10) Attempt to check in the item via SCO and SCI, it should succeed! Signed-off-by: AFHDubCoLib -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 --- Comment #5 from Andrew Fuerste-Henry --- I made those wording changes as part of signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #154910|0 |1 is obsolete|| --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 159113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159113=edit Bug 34643: Split CircConfirmItemParts for self-checkout and self-checkin Many libraries wish to be able to allow self-check for multi-part items while requesting librarians to verify the parts when checking out/in at the desk. It makes sense to split CircConfirmItemParts into three prefs such that the feature can be enabled/disabled for SCO and SCI independently. Test Plan: 1) Apply this patch 2) Enable SCO and SCI 3) Set CircConfirmItemPartsSCO to "Don't allow" 4) Attempt to checkout out an item with materials via SCO, it should fail 5) Set CircConfirmItemPartsSCO to "Allow" 6) Repeat step 4, it should succeed 7) Set CircConfirmItemPartsSCI to "Don't allow" 8) Attempt to check in the item via SCI, it should fail 9) Attempt to check in the item via SCO, it should fail 9) Set CircConfirmItemPartsSCI to "Allow" 10) Attempt to check in the item via SCO and SCI, it should succeed! Signed-off-by: AFHDubCoLib -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org --- Comment #3 from Andrew Fuerste-Henry --- This works, but could be presented more clearly. Your syspref names strongly imply that one preference controls the behavior of the web-based self checkout while the other controls the behavior of the web-based self check-in. However that is not quite the case. I suggest rewording the sysprefs thus: CircConfirmItemPartsSCI: (Allow / Don't allow) multi-part items to be checked in via the web-based self check-in and self checkout modules. CircConfirmItemPartsSCO: (Allow / Don't allow) multi-part items to be checked out via the web-based self checkout module. This clarifies the difference between the two sysprefs, clarifies that they're not about SIP or any other interface, and makes the wording consistent with SelfCheckInModule and WebBasedSelfCheck. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 Kyle M Hall changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com --- Comment #2 from Kyle M Hall --- *** Bug 33700 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 --- Comment #1 from Kyle M Hall --- Created attachment 154910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154910=edit Bug 34643: Split CircConfirmItemParts for self-checkout and self-checkin Many libraries wish to be able to allow self-check for multi-part items while requesting librarians to verify the parts when checking out/in at the desk. It makes sense to split CircConfirmItemParts into three prefs such that the feature can be enabled/disabled for SCO and SCI independently. Test Plan: 1) Apply this patch 2) Enable SCO and SCI 3) Set CircConfirmItemPartsSCO to "Don't allow" 4) Attempt to checkout out an item with materials via SCO, it should fail 5) Set CircConfirmItemPartsSCO to "Allow" 6) Repeat step 4, it should succeed 7) Set CircConfirmItemPartsSCI to "Don't allow" 8) Attempt to check in the item via SCI, it should fail 9) Attempt to check in the item via SCO, it should fail 9) Set CircConfirmItemPartsSCI to "Allow" 10) Attempt to check in the item via SCO and SCI, it should succeed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
