[Koha-bugs] [Bug 34691] Active link in the menu is not always correctly styled - again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34691 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #9 from Fridolin Somers --- Depends on Bug 33169 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34691] Active link in the menu is not always correctly styled - again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34691 --- Comment #8 from Pedro Amorim --- The new command is/was supposed to be in support/commands.js instead of support/index.js but this gets fixed by bug 34319 anyway so no follow-up required here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34691] Active link in the menu is not always correctly styled - again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34691 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34691] Active link in the menu is not always correctly styled - again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34691 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34691] Active link in the menu is not always correctly styled - again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34691 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34691] Active link in the menu is not always correctly styled - again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34691 Jonathan Druart changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33169 | Depends on||33169 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 [Bug 33169] Improve vue breadcrumbs and left-hand menu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34691] Active link in the menu is not always correctly styled - again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34691 --- Comment #6 from Jonathan Druart --- Created attachment 155121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155121=edit Bug 34691: Fix linkActiveClass in createRouter Test plan: 1) Visit /cgi-bin/koha/erm/agreements/add 2) Notice the "Agreements" menu item is not active 3) Apply the tests patch only 4) Run tests, watch them fail 5) Apply this patch, restart yarn js:watch and hard refresh browser 6) Repeat steps 1) and 2) Verify it's now active 7) Run tests, watch them pass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34691] Active link in the menu is not always correctly styled - again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34691 Jonathan Druart changed: What|Removed |Added Attachment #155117|0 |1 is obsolete|| Attachment #155118|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 155120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155120=edit Bug 34691: Add cypress tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34691] Active link in the menu is not always correctly styled - again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34691 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34691] Active link in the menu is not always correctly styled - again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34691 Pedro Amorim changed: What|Removed |Added Attachment #155114|0 |1 is obsolete|| --- Comment #4 from Pedro Amorim --- Created attachment 155118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155118=edit Bug 34691: Fix linkActiveClass in createRouter Test plan: 1) Visit /cgi-bin/koha/erm/agreements/add 2) Notice the "Agreements" menu item is not active 3) Apply the tests patch only 4) Run tests, watch them fail 5) Apply this patch, restart yarn js:watch and hard refresh browser 6) Repeat steps 1) and 2) Verify it's now active 7) Run tests, watch them pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34691] Active link in the menu is not always correctly styled - again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34691 --- Comment #3 from Pedro Amorim --- Created attachment 155117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155117=edit Bug 34691: Add cypress tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34691] Active link in the menu is not always correctly styled - again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34691 Pedro Amorim changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34691] Active link in the menu is not always correctly styled - again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34691 Pedro Amorim changed: What|Removed |Added Assignee|jonathan.druart+koha@gmail. |pedro.amo...@ptfs-europe.co |com |m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34691] Active link in the menu is not always correctly styled - again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34691 Pedro Amorim changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Pedro Amorim --- This is not done yet, we need to add Cypress tests for this to make sure we don't break it again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34691] Active link in the menu is not always correctly styled - again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34691 --- Comment #1 from Pedro Amorim --- Created attachment 155114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155114=edit Bug 34691: Fix linkActiveClass in createRouter Test plan: 1) Visit /cgi-bin/koha/erm/agreements/add 2) Notice the "Agreements" menu item is not active 3) Apply patch, restart yarn js:watch. Repeat -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
