[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #50 from Pedro Amorim --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Pedro Amorim changed: What|Removed |Added Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in|| Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.11.00|23.11.00,23.05.06 released in|| CC||fridolin.som...@biblibre.co ||m --- Comment #49 from Fridolin Somers --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #48 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added Blocks||35285 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35285 [Bug 35285] Centralise notice content wrapping for html output -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added Blocks|30287 | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 [Bug 30287] Notices using HTML renders differently in notices.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added Text to go in the||The patch removes the release notes||automated additional of ||html linebreak markup to ||print notices when using ||--html. || ||If you are using ||this flag with ||gather_print_notices.pl you ||may need to revisit your ||notice templates to ensure ||they are properly marked up ||as expected for html ||notices. If you are using ||non-html notices then they ||should remain as before. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added Attachment #158637|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #47 from Martin Renvoize --- Created attachment 158643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158643=edit Bug 34704: Remove regex for adding additional line breaks to print templates This makes sure that we don't change the line breaking for either HTML nor plain text print notices. For plain text, the is used to keep the line breaks as defined in the notices template. For HTML we require on the line breaks added by block elements in the HTML notice, not adding any additional ones like before. This gives the full control of the formatting to the notice editor. To test: * Make sure your patron doesn't have an email address * Make sure to check the hold filled notice in messaging preferences * Place a old on any item * Checkin the item * Confirm hold * Verify notices tab shows the Hold (print) notice * ./misc/cronjobs/gather_print_notices.pl ./ --html * Verify the generated file has the HTML output wrapped in pre. * Reformat the HOLD print notice to be HTML by setting the checkbox. Mmake sure to add some empty lines for (they should not print later) and some , , - They should be reflected in the notice later. * Repeat test. * All should be well :) Signed-off-by: Matt Blenkinsop Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added Attachment #158602|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added Attachment #158603|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added Attachment #158604|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #46 from Martin Renvoize --- (In reply to Katrin Fischer from comment #43) > It comes from here: > > my $template = > C4::Templates::gettemplate( 'batch/print-notices.tt', 'intranet', > CGI->new ); > > > And then the template takes care of it: > > > [% IF ( message.is_html ) %] > [% message.content | $raw %] > [% ELSE %] > [% message.content | $raw %] > [% END %] > Which we added in bug 34728, the counterpart of this but months ago. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #45 from Katrin Fischer --- I thought instead of the 3 that are going to be a little confusing, I'll throw in an alternate - let me know what you think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #44 from Katrin Fischer --- Created attachment 158637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158637=edit Bug 34704: [Alternate] Remove regex for adding additional line breaks to print templates This makes sure that we don't change the line breaking for either HTML nor plain text print notices. For plain text, the is used to keep the line breaks as defined in the notices template. For HTML we require on the line breaks added by block elements in the HTML notice, not adding any additional ones like before. This gives the full control of the formatting to the notice editor. To test: * Make sure your patron doesn't have an email address * Make sure to check the hold filled notice in messaging preferences * Place a old on any item * Checkin the item * Confirm hold * Verify notices tab shows the Hold (print) notice * ./misc/cronjobs/gather_print_notices.pl ./ --html * Verify the generated file has the HTML output wrapped in pre. * Reformat the HOLD print notice to be HTML by setting the checkbox. Mmake sure to add some empty lines for (they should not print later) and some , , - They should be reflected in the notice later. * Repeat test. * All should be well :) Current patch-complexity: Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #43 from Katrin Fischer --- It comes from here: my $template = C4::Templates::gettemplate( 'batch/print-notices.tt', 'intranet', CGI->new ); And then the template takes care of it: [% IF ( message.is_html ) %] [% message.content | $raw %] [% ELSE %] [% message.content | $raw %] [% END %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #42 from Katrin Fischer --- We already add the somewhere else, because now we have a double up: Centerville^M ... Copy: I tested this way: * Make sure your patron doesn't have an email address * Make sure to check the hold filled notice in messaging preferences * Place a old on any item * Checkin the item * Confirm hold * Verify notices tab shows the Hold (print) notice * ./misc/cronjobs/gather_print_notices.pl ./ --html * Verified the generated file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #41 from Katrin Fischer --- Since we changed course here - should we squash and adapt the test plan in first commit message? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #40 from Katrin Fischer --- WARN misc/cronjobs/gather_print_notices.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 92, now: 93) Fixed in amended last patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #39 from Martin Renvoize --- Back to you Katrin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #38 from Martin Renvoize --- Follow-up added that drops the regex entirely.. as requested.. and instead checks for content type of the notice generated itself and treats it appropriately by either leaving it as is (for html formatted notices) or wraps the content in a block for pre-formatted plaintext. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #37 from Martin Renvoize --- Created attachment 158604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158604=edit Bug 34704: Replace regex with wrap for non-html based notices If a notice is marked as HTML in the template editor we don't want to add any additional HTML markup. If a notice is not marked as HTML in the template editor, then it is assumed the notice is plaintext and thus includes formatting and so for an html output the content should be wrapped in . -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added Attachment #157303|0 |1 is obsolete|| --- Comment #36 from Martin Renvoize --- Created attachment 158603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158603=edit Bug 34704: (QA follow-up): Add multi-line modifier This patch adds a multi line modifier to the regex to catch all lines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added Attachment #156230|0 |1 is obsolete|| --- Comment #35 from Martin Renvoize --- Created attachment 158602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158602=edit Bug 34704: Stop tags being entered on every line in html letter templates This patch amends a regex check to stop tags from being added to every line of html template Test plan: 1) This is easy to see using a regex checking tool. In your browser go to regex101.com 2) In the "Test string", copy and paste the text from the comment in the bug 3) In the regular expression field, enter 's/\n//g' 4) Observe that the output has a tag inserted after every html element and it is now one line of text 5) Replace the regular expression with '^\s*\n' 6) The output should now be formatted correctly with no tags Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #34 from Martin Renvoize --- I just wrote bug 35279 to make this simpler to test ;). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35279 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #33 from Martin Renvoize --- My point wasn't to add a database update here.. more that we perhaps need to really clearly state that the processing for print notices has changed and that any html notices used for print will need adapting by the end user. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #32 from Katrin Fischer --- (In reply to Martin Renvoize from comment #31) > I also vaguely wonder about br Vs p in the template update context.. but > that's just a random thought after the fact I don't think there is a good way to automatically update the notices. We cannot tell if something was intentionally left outside an HTML tag or not. There are also: li, ul, ol, p, br, table, th, tr, td... People using this script now, might have left off extras, others might have added them... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #31 from Martin Renvoize --- I also vaguely wonder about br Vs p in the template update context.. but that's just a random thought after the fact -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #30 from Martin Renvoize --- I've asked Matt to take a look and comment as he was a little closer to the original request. I have a feeling we may need to further update the notices that were causing our customers problems to make them work without the regex. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #29 from Katrin Fischer --- Thx for the help on the bugs - what is our conclusion here? Do we remove the regex? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added Blocks||35268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35268 [Bug 35268] Add CodeMirror editor as an option for html notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35268 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24793 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35267 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added Blocks||30287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 [Bug 30287] Notices using HTML renders differently in notices.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #28 from Katrin Fischer --- I spent quite a bit of time on this one and on fixing our sample notices. It would be nice to keep the conversation going. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #27 from Katrin Fischer --- I wanted to check the 'size' of this problem a bit more and did some testing. And it's not as bad as one would think: I tested the HTML notices especially and the results are interesting: 1) Slips: use explicit line breaks When a slip template is printed in the browser, only br and other block elements will cause a line break. I fixed some of our sample notices on bug 35187. 2) E-mail notices: use explicit line breaks When an email is sent in HTML format, only br and other block elements will cause a line break. I fixed the WELCOME notice also on bug 35187. 3) Print notices with gather_print_notices and --html: implicit line breaks Note that we have a known display bug on the notices tab: bug 30287. It shows implicit line breaks, not reflecting how the actual email will look later. --- (In reply to Martin Renvoize from comment #24) > OK, I see you're points now. > > This was meant to be "least invasive", but I do agree it would be nice to > drop it entirely and require proper HTML throughout for these notices. > > The challenge will be to write a DB update that looks at all the existing > notices and fixes them for all current html notices to include the breaks. We have never used the --html option on this job so I can't tell about how widely it would be used. I am not sure it's worth messing with the existing notices. * If you have a working email template that is used as a fallback for print, it will definitely add unnecessary/additional line breaks. * So only explicit print layouts that use HTML could be affected negatively. I'd like to avoid a system preference for this inconsistent behavior... but could a command line switch for 'implicit_line_breaks' help some? > Also, we'd need to update all the existing default notices for install. It's not as big an issue as one would think. I already did it: I fixed all HTML notices in the 3 bugs dependent on this one: 35185, 35186, 35187 With these 3 bugs I believe we can consider the sample notices fixed and improved. It helps that most our notices are still plain text (is_html: 0) > This is all a much larger job that we were expecting to undertake here.. > worthwhile I suppose, but I'm not sure where I'm going to find funding for > that extra time. We can have this go in as is, but I believe removing would be better instead of changing the output somewhat arbitrarily. Maybe we should just "bite the bullet" here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Katrin Fischer changed: What|Removed |Added Depends on||35187 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 [Bug 35187] Fix line breaks in some HTML notices, including WELCOME -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Katrin Fischer changed: What|Removed |Added Depends on||35186 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 [Bug 35186] Remove html tags from sample notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Katrin Fischer changed: What|Removed |Added Depends on||35185 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 [Bug 35185] Remove is_html flag from sample notices for text notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #26 from Martin Renvoize --- In my perfect world you'd have WYSIWYG and Codemirror options. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #25 from Martin Renvoize --- I think if we're going whole hog here, we likely would want to switch the editor to allow the WYSIWYG option for html input to keep the simplicity option at user disposal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #24 from Martin Renvoize --- OK, I see you're points now. This was meant to be "least invasive", but I do agree it would be nice to drop it entirely and require proper HTML throughout for these notices. The challenge will be to write a DB update that looks at all the existing notices and fixes them for all current html notices to include the breaks. Also, we'd need to update all the existing default notices for install. This is all a much larger job that we were expecting to undertake here.. worthwhile I suppose, but I'm not sure where I'm going to find funding for that extra time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #23 from Lucas Gass --- > For consistency: How do these templates behave when looked at in the notices > tab or when sent per email? Im my tests/examples I used overdue notices ( ODUE ), so what I see in notice tab/email remains consistent with the patch, without the patch, and when I remove the regex line. TEST1 Our Address Our City Our State Thank you, Library But this is because that content is generated by overdue_notices.pl and is not going through gather_print_notices.pl Question: Could the regex line we are changing in gather_print_notices.pl be something that we make configurable? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #22 from Katrin Fischer --- (In reply to Lucas Gass from comment #20) > I have a question. When we tick the box to make a notice an HTML message ( > is_html=1 ) do we expect in the entire template to marked up? In Matt's > example that is the case. Hm, I think we are getting to the bottom of this now. Yes, I think we do for email notices and we should also do that for print notices? If we use HTML and especially with TT mark-up we want the line breaks to be explicit, not implicit. You will want to format a CASE statement or similar on multiple lines to be readable. And it should collapse them as expected from HTML. Doing implicit line breaks might help people who didn't stick with HTML, but it removes control for everyone else and force us to do weird things. Our templates are getting more advanced and complicated all the time with TT, I could also see an IF-statement, that leaves blank lines if the condition is not met. I believe that this behaviour will bite us. > I ask because we have a lot of templates where this is not the case. For > instance someone might add a logo at the top of the notice, src="somesorc" width="500" alt="somealt" /> > > > But after that they rest of the notice is NOT marked up. So here is my > example template: > > > TEST1 > > > Our Address > Our City > Our State > > > Thank you, > > > Library > > > > With no patch applied I continue to have line breaks honored for the content > NOT wrapped in HTML elements. > > With the patch my non-marked up content looks like this: > > > Our Address Our City Our State > Thank you, > Library > > > > With no regex, like Cait suggests I get this for my non-marked up content: > > > Our Address Our City Our State Thank you, Library > I can see where this whole thing is a problem now when this has worked before :( For consistency: How do these templates behave when looked at in the notices tab or when sent per email? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #21 from Lucas Gass --- So I guess the question is whether or not we should allow for this mix of html/non-html content. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #20 from Lucas Gass --- I have a question. When we tick the box to make a notice an HTML message ( is_html=1 ) do we expect in the entire template to marked up? In Matt's example that is the case. I ask because we have a lot of templates where this is not the case. For instance someone might add a logo at the top of the notice, But after that they rest of the notice is NOT marked up. So here is my example template: TEST1 Our Address Our City Our State Thank you, Library With no patch applied I continue to have line breaks honored for the content NOT wrapped in HTML elements. With the patch my non-marked up content looks like this: Our Address Our City Our State Thank you, Library With no regex, like Cait suggests I get this for my non-marked up content: Our Address Our City Our State Thank you, Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #19 from Katrin Fischer --- I thought I was clear: Can you explain why we are adding at all? It feels like this is an unneded change. We either have an HTML template, then we are good. Or we have a plain text template and we are using pre - we are also good. I think it helps your sites, because it reduces unwanted additional breaks, but why add any at all? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #18 from Martin Renvoize --- We spent quite a bit of time working through this, and it's in production at all our sites now. I think you need to be clearer about what changes you're expecting, Katrin.. It's not at all clear how we move this on from here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added Depends on||34728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34728 [Bug 34728] HTML notices should not be pre-formatted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #17 from Katrin Fischer --- I am still a bit confused by this patch/script. It looks like we always turn an empty line into a . It seems an improvement from previous behavior, but I wonder if it's correct. What I would expect when the html flag is passed: * If the notice template is already HTML, do not make any changes. * If the notice is plain text, wrap in , do not add any additional line breaks. Why is the regex required at all? It seems to add additional breaks where they might not be needed/intended. Especially with TT sometimes it's nice to add some line breaks separating blocks etc. I thik we can now use the letter_id in message_queue to figure out if the template is HTML if that helps things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch Severity|trivial |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #16 from Matt Blenkinsop --- Completely missed this - I've added the modifier, good spot -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #15 from Matt Blenkinsop --- Created attachment 157303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157303=edit Bug 34704: (QA follow-up): Add multi-line modifier This patch adds a multi line modifier to the regex to catch all lines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Matt Blenkinsop changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl --- Comment #14 from Marcel de Rooy --- +s/^\s*\n//g; Adding the ^ without multiline modifier makes it work on the first line only. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Matt Blenkinsop changed: What|Removed |Added Attachment #156229|0 |1 is obsolete|| --- Comment #13 from Matt Blenkinsop --- Created attachment 156230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156230=edit Bug 34704: Stop tags being entered on every line in html letter templates This patch amends a regex check to stop tags from being added to every line of html template Test plan: 1) This is easy to see using a regex checking tool. In your browser go to regex101.com 2) In the "Test string", copy and paste the text from the comment in the bug 3) In the regular expression field, enter 's/\n//g' 4) Observe that the output has a tag inserted after every html element and it is now one line of text 5) Replace the regular expression with '^\s*\n' 6) The output should now be formatted correctly with no tags Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Matt Blenkinsop changed: What|Removed |Added Attachment #155503|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #12 from Matt Blenkinsop --- Created attachment 156229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156229=edit Bug 34704: Stop tags being entered on every line in html letter templates This patch amends a regex check to stop tags from being added to every line of html template Test plan: 1) This is easy to see using a regex checking tool. In your browser go to regex101.com 2) In the "Test string", copy and paste the text from the comment in the bug 3) In the regular expression field, enter 's/\n//g' 4) Observe that the output has a tag inserted after every html element and it is now one line of text 5) Replace the regular expression with '^\s*\n' 6) The output should now be formatted correctly with no tags -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Matt Blenkinsop changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Matt Blenkinsop changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34728 --- Comment #11 from Matt Blenkinsop --- You're correct with your example but I've added bug 34728 to the "See also" section - in that bug we wrap any notice template where is_html=0 in a tag to preserve the formatting. That should fix the scenario you mention (I think) - the tag will only be inserted where there are empty lines rather than on every line, the \n will be preserved by the tag when the content is rendered. Let me know your thoughts, I'll update the commit title in the meantime -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #10 from Jonathan Druart ---
(In reply to Lucas Gass from comment #9)
> (In reply to Jonathan Druart from comment #6)
> > I don't think this is correct. You will still need to add br tags for non
> > HTML notice templates, or it will be on a single line :)
>
> Isn't this only when the html flag is passed?
>
> if ( $html ) {
I have not tested the patch (what I should), but reading the diff it seems that
the following use case will be problematic:
Define a notice template that is not using HTML tags (so is_html=0)
Run the print_notices script with the --html flag
=> All will be one line
I guess that's why we had this replacement.
If you think I am wrong, please switch back to SO and I will have a look at it
again next week.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704
--- Comment #9 from Lucas Gass ---
(In reply to Jonathan Druart from comment #6)
> I don't think this is correct. You will still need to add br tags for non
> HTML notice templates, or it will be on a single line :)
Isn't this only when the html flag is passed?
if ( $html ) {
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #8 from Jonathan Druart --- And please write a meaningful commit *title*. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #7 from Jonathan Druart --- And please write a meaningful commit message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart --- I don't think this is correct. You will still need to add br tags for non HTML notice templates, or it will be on a single line :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Matt Blenkinsop changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #5 from Martin Renvoize --- Thanks Lucas.. I wasn't aware if the Collapse filter, but I think this is a great fix to have and it makes me happy to know it wasn't just us running into it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #4 from Lucas Gass --- Simple, but very nice quality of life improvement. I have been wrapping all of my HTML notices in [% filter COLLAPSE %] to avoid this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Lucas Gass changed: What|Removed |Added Attachment #155196|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 155503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155503=edit Bug 34704: Fix regex This patch amends a regex check to stop tags from being added to every line of html template Test plan: 1) This is easy to see using a regex checking tool. In your browser go to regex101.com 2) In the "Test string", copy and paste the text from the comment in the bug 3) In the regular expression field, enter 's/\n//g' 4) Observe that the output has a tag inserted after every html element and it is now one line of text 5) Replace the regular expression with '^\s*\n' 6) The output should now be formatted correctly with no tags Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33478 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||lu...@bywatersolutions.com, ||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Assignee|koha-b...@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Matt Blenkinsop changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #2 from Matt Blenkinsop --- Text to test with: <> <> <> <> <> <> <> <> Library: <> Telephone: <> Email: <> Dear <> <> Membership number: <> HOLD AVAILABLE FOR PICKUP Your requested item is now available for collection from the following library: <> <> <> <> <> AUTHOR: <> TITLE: <> BARCODE: <> Please collect within 10 days from the date of this letter and don't forget to bring your library card with you. Be aware that opening hours vary at different library branches so if in doubt double check the times before you visit. Should you no longer require this item please contact us so we can make it available for another customer. Thank you -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #1 from Matt Blenkinsop --- Created attachment 155196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155196=edit Bug 34704: Fix regex This patch amends a regex check to stop tags from being added to every line of html template Test plan: 1) This is easy to see using a regex checking tool. In your browser go to regex101.com 2) In the "Test string", copy and paste the text from the comment in the bug 3) In the regular expression field, enter 's/\n//g' 4) Observe that the output has a tag inserted after every html element and it is now one line of text 5) Replace the regular expression with '^\s*\n' 6) The output should now be formatted correctly with no tags -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
