[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 --- Comment #17 from Matt Blenkinsop --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 Matt Blenkinsop changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.11 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|23.11.00|23.11.00,23.05.04 released in|| Status|Pushed to master|Pushed to stable --- Comment #16 from Fridolin Somers --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 --- Comment #14 from Victor Grousset/tuxayo --- (double checked scanning with a phone before and after the patch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #13 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 --- Comment #12 from Victor Grousset/tuxayo --- Created attachment 155709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155709=edit Bug 34732: (QA follow-up): tidy up code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #155391|0 |1 is obsolete|| --- Comment #11 from Victor Grousset/tuxayo --- Created attachment 155708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155708=edit Bug 34732: For Code39, append or prepend asterisk if missing from barcode This patch appends or prepends an asterisk on Code39 barcodes if they are missing from the input. This is so that they form correct Code39 barcode images. Test plan: 0. Apply the patch 1. koha-plack --reload kohadev 2. Go to http://localhost:8081/cgi-bin/koha/labels/barcode-print.pl 3. Type 301310 into "Barcode" and click "Show barcode" 4. Note that the barcode text on the right includes asterisks around it 5. Type *301310 into "Barcode" and click "Show barcode" 6. Note the same as above 7. Type 301310* into "Barcode" and click "Show barcode" 8. Note the same as above 9. Type *301310* into "Barcode" and click "Show barcode" 10. Note the same as above Signed-off-by: Matt Blenkinsop Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 Victor Grousset/tuxayo changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net |y.org | --- Comment #10 from Victor Grousset/tuxayo --- 19 years since last update but there is a more recent fork. I contacted both maintainers to know if they are still active in the maintenance of this package. To then know if there is a reason to not have the surrounding "*" added. At least having the choice with a different method or params. Maybe the root of the problem is this: > This code is traditionally mapped to the * character in barcode fonts and > will often appear with the human-readable representation alongside the barcode https://en.wikipedia.org/wiki/Code_39 Anyway given all that context, the proposed fix here makes sense. Testing in progress. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #9 from Victor Grousset/tuxayo --- For some reason GD::Barcode commented the addition of the surrounding "*" :o https://metacpan.org/release/KWITKNR/GD-Barcode-1.15/source/Barcode/Code39.pm#L85 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 Matt Blenkinsop changed: What|Removed |Added Attachment #155350|0 |1 is obsolete|| --- Comment #8 from Matt Blenkinsop --- Created attachment 155391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155391=edit Bug 34732: For Code39, append or prepend asterisk if missing from barcode This patch appends or prepends an asterisk on Code39 barcodes if they are missing from the input. This is so that they form correct Code39 barcode images. Test plan: 0. Apply the patch 1. koha-plack --reload kohadev 2. Go to http://localhost:8081/cgi-bin/koha/labels/barcode-print.pl 3. Type 301310 into "Barcode" and click "Show barcode" 4. Note that the barcode text on the right includes asterisks around it 5. Type *301310 into "Barcode" and click "Show barcode" 6. Note the same as above 7. Type 301310* into "Barcode" and click "Show barcode" 8. Note the same as above 9. Type *301310* into "Barcode" and click "Show barcode" 10. Note the same as above Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 Matt Blenkinsop changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 David Cook changed: What|Removed |Added Severity|enhancement |normal Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 --- Comment #7 from David Cook --- Created attachment 155350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155350=edit Bug 34732: For Code39, append or prepend asterisk if missing from barcode This patch appends or prepends an asterisk on Code39 barcodes if they are missing from the input. This is so that they form correct Code39 barcode images. Test plan: 0. Apply the patch 1. koha-plack --reload kohadev 2. Go to http://localhost:8081/cgi-bin/koha/labels/barcode-print.pl 3. Type 301310 into "Barcode" and click "Show barcode" 4. Note that the barcode text on the right includes asterisks around it 5. Type *301310 into "Barcode" and click "Show barcode" 6. Note the same as above 7. Type 301310* into "Barcode" and click "Show barcode" 8. Note the same as above 9. Type *301310* into "Barcode" and click "Show barcode" 10. Note the same as above -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 David Cook changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 --- Comment #6 from David Cook --- (In reply to Katrin Fischer from comment #5) > We've run into the same issue. When using in notices we add the * before and > after what we want to print and that fixes the issue. > > I think it would be great to test for these and add them if not present. > It's not obvious for users and it took us quite some research to figure it > out :) Sounds like a plan. It should be easy enough to do. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732 Katrin Fischer changed: What|Removed |Added Summary|Barcode image generator |Barcode image generator |doesn't generate correct|doesn't generate correct |Barcode |Code39 barcode -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
