[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Matt Blenkinsop changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to stable|RESOLVED CC||matt.blenkinsop@ptfs-europe ||.com --- Comment #10 from Matt Blenkinsop --- Dependency missing for 22.11.x - not backporting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Slava Shishkin changed: What|Removed |Added Blocks||35004 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35004 [Bug 35004] Error about no quantity set on acquisitions order receive confirmation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 --- Comment #9 from Victor Grousset/tuxayo --- oh no, very weird it did that. Thanks for finding it out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Katrin Fischer changed: What|Removed |Added Blocks||34880 --- Comment #8 from Katrin Fischer --- I am afraid we have an unwanted side-effect here if my git-bisect is correct :( Bug 34880 - Receive impossible if items created 'in cataloguing' Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 [Bug 34880] Receive impossible if items created 'in cataloguing' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|23.11.00|23.11.00,23.05.04 released in|| Status|Pushed to master|Pushed to stable --- Comment #7 from Fridolin Somers --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Signed Off |Passed QA --- Comment #5 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) It was a nasty one, well done all ^^ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #155384|0 |1 is obsolete|| --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 155579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155579=edit Bug 34736: Don't trigger quantity change on loading order We have a change event to automatically check or uncheck the first items on a list when the value is changed directly. The code is calling this when setting the quantity when loading an order, but this is causing a problem in that we are setting the quantity to load.switch orders and triggering the checkboxes wrongly To test: 1 - Create a new basket, create items on placing the order 2 - Create an order line with 4 items 3 - Create another order line with 2 items 4 - Close the basket 5 - Receive shipment and create an invoice 6 - Select both orders via the checkboxes got multi-receive 7 - Click "receive selected" 8 - Edit first order line, quantity received = 1 (1 out of 4) 9 - Verify that one item is also selected in the table 10 - Switch to "next order" 11 - Quantity received is 0, no items checked in the second order 12 - Switch to "Previous order" 13 - ERROR: Item checkbox was lost, quantity received still correct 14 - Switch to next order 15 - ERROR: item is now checked, quantity received 0 16 - Note: We see a mix up of the information entered, one has the checkbox now, the other the quantity. 17 - Save changes 18 - Click confirm 19 - Continue (complaint about the second order left unchanged) 20 - You are back on the summary: * pending order: quantity changed from 4 to 3 - correct * received order: quantity shows 1 - correct 21 - Click on receive for your updated order line (with 3 items) * 4 items show to be received (should be 3) 22 - Apply patch 23 - Cancel receipt of items 24 - Repeat 1-12 25 - Items are loaded correctly 26 - Try with various checkboxes and switch back and forth 27 - Confirm that manually adjusting quantity received checks the first n boxes 28 - Confirm setting quantity to 0 unchecks the boxes Signed-off-by: Katrin Fischer Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 --- Comment #3 from Katrin Fischer --- Bad bug, small fix - just how I like it. Thanks a lot Nick! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Katrin Fischer changed: What|Removed |Added Attachment #155342|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 155384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155384=edit Bug 34736: Don't trigger quantity change on loading order We have a change event to automatically check or uncheck the first items on a list when the value is changed directly. The code is calling this when setting the quantity when loading an order, but this is causing a problem in that we are setting the quantity to load.switch orders and triggering the checkboxes wrongly To test: 1 - Create a new basket, create items on placing the order 2 - Create an order line with 4 items 3 - Create another order line with 2 items 4 - Close the basket 5 - Receive shipment and create an invoice 6 - Select both orders via the checkboxes got multi-receive 7 - Click "receive selected" 8 - Edit first order line, quantity received = 1 (1 out of 4) 9 - Verify that one item is also selected in the table 10 - Switch to "next order" 11 - Quantity received is 0, no items checked in the second order 12 - Switch to "Previous order" 13 - ERROR: Item checkbox was lost, quantity received still correct 14 - Switch to next order 15 - ERROR: item is now checked, quantity received 0 16 - Note: We see a mix up of the information entered, one has the checkbox now, the other the quantity. 17 - Save changes 18 - Click confirm 19 - Continue (complaint about the second order left unchanged) 20 - You are back on the summary: * pending order: quantity changed from 4 to 3 - correct * received order: quantity shows 1 - correct 21 - Click on receive for your updated order line (with 3 items) * 4 items show to be received (should be 3) 22 - Apply patch 23 - Cancel receipt of items 24 - Repeat 1-12 25 - Items are loaded correctly 26 - Try with various checkboxes and switch back and forth 27 - Confirm that manually adjusting quantity received checks the first n boxes 28 - Confirm setting quantity to 0 unchecks the boxes Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 --- Comment #1 from Nick Clemens --- Created attachment 155342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155342=edit Bug 34736: Don't trigger quantity change on loading order We have a change event to automatically check or uncheck the first items on a list when the value is changed directly. The code is calling this when setting the quantity when loading an order, but this is causing a problem in that we are setting the quantity to load.switch orders and triggering the checkboxes wrongly To test: 1 - Create a new basket, create items on placing the order 2 - Create an order line with 4 items 3 - Create another order line with 2 items 4 - Close the basket 5 - Receive shipment and create an invoice 6 - Select both orders via the checkboxes got multi-receive 7 - Click "receive selected" 8 - Edit first order line, quantity received = 1 (1 out of 4) 9 - Verify that one item is also selected in the table 10 - Switch to "next order" 11 - Quantity received is 0, no items checked in the second order 12 - Switch to "Previous order" 13 - ERROR: Item checkbox was lost, quantity received still correct 14 - Switch to next order 15 - ERROR: item is now checked, quantity received 0 16 - Note: We see a mix up of the information entered, one has the checkbox now, the other the quantity. 17 - Save changes 18 - Click confirm 19 - Continue (complaint about the second order left unchanged) 20 - You are back on the summary: * pending order: quantity changed from 4 to 3 - correct * received order: quantity shows 1 - correct 21 - Click on receive for your updated order line (with 3 items) * 4 items show to be received (should be 3) 22 - Apply patch 23 - Cancel receipt of items 24 - Repeat 1-12 25 - Items are loaded correctly 26 - Try with various checkboxes and switch back and forth 27 - Confirm that manually adjusting quantity received checks the first n boxes 28 - Confirm setting quantity to 0 unchecks the boxes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Katrin Fischer changed: What|Removed |Added Summary|Item checkboxes are lost in |Item checkboxes move to |multi-receive, breaking |wrong order line in |partial receive |multi-receive, breaking ||partial receive -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/