[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 --- Comment #29 from Katrin Fischer --- Thanks, Tomas. Kyle, can you take a look and let us know what you think? I certainly agree about the cool feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 --- Comment #28 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #27) > The endpoints introduced here feel very specific and RPC rather than REST.. > I'm going to review with Tomas and see if we can come up with something a > little more in keeping with the rest of the REST api's I agree and have said something similar on private conversations with Kyle. What I proposed Kyle in that conversation, was that we already have something similar, and flexible enough so we can use the same pattern everywhere... POST /jobs. If we made this particular case process immediately, e.g. POST /jobs/bach_call_number_update could return a regular job object, with Location => /jobs/:job_id, and the usual payload found in the job object would just carry the needed information to avoid a second API call... He didn't like it that it is not really a background job. I mention this conversation in case it triggers some better idea to someone. I have thought about this a bit more, and I feel like we could do something like: POST /biblios/:biblio_id/batch_call_number_update which will return an object, representing the batch operation results (e.g. the items that got modified, those that failed if partial success is accepted, etc). It resembles too much what a 'job' is, hence my hesitation. We should really find some middle ground and move ahead with this cool feature. I don't entirely like the pattern, but it would be more RESTful. My two cents. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 --- Comment #27 from Martin Renvoize --- The endpoints introduced here feel very specific and RPC rather than REST.. I'm going to review with Tomas and see if we can come up with something a little more in keeping with the rest of the REST api's -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 --- Comment #26 from Katrin Fischer --- NOTE: Number of tests in t/db_dependent/api/v1/biblios.t also needs to be increased to 15 (had this fixed locally) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 Katrin Fischer changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 --- Comment #25 from Katrin Fischer --- Hi Kyle, I am sorry, I believe there are still issues here highlighted by the xt/api.t test. Referring to Tomas and Martin to have a look at the API part. As I also was the one to QA this, I think another set of eyes would be no mistake. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 --- Comment #24 from Martin Renvoize --- Created attachment 160349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160349=edit Bug 34784: (QA follow-up) Add additionalProperties to pass xt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 Katrin Fischer changed: What|Removed |Added Attachment #158593|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 158631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158631=edit Bug 34784: (QA follow-up) Fix broken links, re-add newlines Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 Katrin Fischer changed: What|Removed |Added Attachment #158572|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 158630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158630=edit Bug 34784: (QA follow-up) Terminology: callnumber, biblio, syspref Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 Katrin Fischer changed: What|Removed |Added Attachment #158571|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 158629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158629=edit Bug 34784: (QA follow-up) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 Katrin Fischer changed: What|Removed |Added Attachment #158570|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 158628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158628=edit Bug 34784: Implement feature in staff interface Some libraries would like to auto-populate item callnumbers for items on a record based on the system preference "itemcallnumber". Only items with empty callnumbers would affected. This would add a button "Populate empty item callnumbers" on catalogue/detail.pl, as well as a "Populate callnumber" button for each line in the holdings table to set the callnumber for that specific item. Test Plan: 1) Set the systempreference to something ( "245a" will make the callnumber the record title for testing purposes ) 2) Apply this patch set 3) Restart all the things! 4) Browse to a record details page, note no new buttons 5) Enable the new syspref EnablePopulateCallnumbers 5) Reload the record details, note the new "Populate callnumbers" button in the cataloging toolbar 7) Add one or more items with no callnumber to the record 8) Test the "Populate callnumbers" button 9) Add another item with no callnumber to the record 10) Test the "Populate callnumber" button for that single item Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 Katrin Fischer changed: What|Removed |Added Attachment #158569|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 158627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158627=edit Bug 34784: Add REST API endpoints for updating single item or all applicable items on a bib Test Plan: 1) Apply this patch 2) prove t/db_dependent/api/v1/biblios.t Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784
--- Comment #18 from Kyle M Hall ---
> Yes, but introducing more wrong terminology (see 2).
> Not quite, see my follow-up.
Thanks for the follow up!
> Sorry, but I believe it's worth it! And it works nicely too.
Excellent :)
> You could just have done this to keep your line break:
>
> +msg += "\n" + __('Reload the page?');
Thanks for the example, now I know exactly what you mean!
> Yes, but it no longer works :(
> POST
> http://localhost:8081/api/v1/biblios/undefined/items/undefined/
> populate_empty_callnumbers
>
> The undefined don't look good.
> Yes, but it no longer works :(
> POST
> http://localhost:8081/api/v1/biblios/undefined/items/
> populate_empty_callnumbers
Fixed!
> I don't need one, I was just wondering if there was more planned around this.
This is an atomic enhancement, at least for the time being!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 --- Comment #17 from Kyle M Hall --- Created attachment 158593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158593=edit Bug 34784: (QA follow-up) Fix broken links, re-add newlines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 Katrin Fischer changed: What|Removed |Added Summary|Add ability to populate |Add ability to populate |empty item callnumbers for |empty item call numbers for |a record based on the |a record based on the |itemcallnumber system |itemcallnumber system |preferences |preference |sss | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
