[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2024-05-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|QUICK NOTE: only for new|This only applies to new
  release notes|installs that select|installations that select
   |"sample news items" in the  |"sample news items" in the
   |installer   |web installer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2024-05-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to main  |Needs documenting

--- Comment #31 from Fridolin Somers  ---
Not backported to 23.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793
Bug 34793 depends on bug 27378, which changed state.

Bug 27378 Summary: Enable compliance with EU Cookie Legislation via cookie 
consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #30 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #29 from Katrin Fischer  ---
Just stumbled on this one a little bit: Cookies policy. It looks like Cookie
policy might be a little more common, but relying on the native speakers there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2024-02-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Text to go in the||QUICK NOTE: only for new
  release notes||installs that select
   ||"sample news items" in the
   ||installer
 Status|Signed Off  |Passed QA

--- Comment #28 from Victor Grousset/tuxayo  ---
Works, makes sense, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2024-02-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #162014|0   |1
is obsolete||

--- Comment #27 from Victor Grousset/tuxayo  ---
Created attachment 162042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162042=edit
Bug 34793: (QA follow-up): forgotten 'Cookie consents'=>'Cookies policy'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2024-02-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #159135|0   |1
is obsolete||

--- Comment #26 from Victor Grousset/tuxayo  ---
Created attachment 162041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162041=edit
Bug 34793: (follow-up) Add table classes to popup

This patch adds the appropriate table classes to the Popup html
customisation block. This ensure we have proper table display formatting
in the modal on the OPAC.

Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2024-02-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #159134|0   |1
is obsolete||

--- Comment #25 from Victor Grousset/tuxayo  ---
Created attachment 162040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162040=edit
Bug 34793: (follow-up) Rename 'Cookie consents' to 'Cookies policy'

The modal is not always about consent, but rather about displaying the
libraries cookie policy. It makes sense to update the heading to reflect
that.

Signed-off-by: Martin Renvoize 
Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2024-02-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #159133|0   |1
is obsolete||

--- Comment #24 from Victor Grousset/tuxayo  ---
Created attachment 162039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162039=edit
Bug 34793: Add default HTML Customisations for cookie information

This patch adds some default html customisation content for the cookie
consent feature.

Test plan
1) Run through the installer and pick to import the sample news items
2) Confirm that after enabling the CookieConsent preference that the
   default content appears in the cookie bar at the bottom of the page
   and in the modal that appears after clicking 'More information'

Mentored-by: Martin Renvoize 
Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2024-02-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #23 from Victor Grousset/tuxayo  ---
> I don't think we need to change the text

ok, it was in case a native speaker and closer to the domain than me had an
idea.
Thanks Aude for the confirmation.
No problem here.


> yes the whole feature should be at interface level but it's not. And that's a 
> big job compared to polishing the polishing this bug achieves.

Totally.


> This sort of content change at upgrade isn't generally something we do. It 
> risks breaking existing setups for little win.. 

So like existing setups for which having the currently empty CookieConsentBar
or CookieConsentPopup being filled would be a problem? : then add the two html
customisation only if CookieConsent is disabled.

The current proposal is only usable for new installs that would guess that
"sample news items" in the installer might have interesting stuff for
production. And those who use CookieConsent will have the pleasant surprise to
get that nice prewritten cookies policy.
Or have the very specific knowledge that there is the sample cookie policy
there.

The current win is little. If there is no simple immediately consensual way to
make the current text available outside of the current narrow cases, then let's
see the current proposal as an incremental step. This still has value as demo
data and for people who know how to find it for new installs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2024-02-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #22 from Aude Charillon  ---
Thank you for looking into our cookie recipes Victor! ;-)

Yes, we are fully aware the default text for CookieConsentBar specifically
references the catalog... even though it will also be seen on the staff
interface. Ideally, there should be separate HTML customizations for the Opac
cookies and the Intranet cookies. As you pointed out, the cookies used on the
two sites could be different. We discussed this with Martin back in September
and we agreed the separate HTML customizations would be logged as follow-up
bugs. Right now, we want to focus on making the Opac cookies work in a more
logical way and on helping the library team get a head start when using the
feature. We assume the public-facing side is more of a priority for library
teams.

I don't think the wording "the online catalog" needs to be changed. Here's why:
1. When creating a new HTML customization and selecting a display location,
CookieConsentBar and CookieConsentPopup are under the Opac section. This makes
it clear to library staff the default text is aimed at the Opac.
2. It's default text: by definition, it's meant to be built on. I expect
library teams to amend the wording to their liking.
3. The essential cookies described in CookieConsentPopup are only those used on
the Opac. According to the wiki
(https://wiki.koha-community.org/wiki/Use_of_Cookies) there are more in the
intranet. Having both sets in the HTML customizations would make it messy and
confusing, which completely undermines the concept of proposing a clear and
simple default cookie text - that we're trying to achieve here.

Sorry it turned into a long reply! I think Martin covered the more technical
questions :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2024-02-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #21 from Martin Renvoize  ---
And this is why bug sets need to go in as sets!

I don't think we need to change the text, yes the whole feature should be at
interface level but it's not. And that's a big job compared to polishing the
polishing this bug achieves.

This sort of content change at upgrade isn't generally something we do. It
risks breaking existing setups for little win.. and the sooner this goes in the
less such an upgrade is needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2024-02-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net
   |y.org   |
 CC||vic...@tuxayo.net

--- Comment #20 from Victor Grousset/tuxayo  ---
> The online catalog uses functional cookies: these are essential to make the 
> site work.

It says the same on the staff interface >_<

Nothing that would work for both comes to my mind, any ideas?

Or do we still call it online catalog in the staff interface and whatever.
And like if for some libraries there is really a difference in cookies in the
staff and OPAC because of some staff plugin or additional tracking of
librarians (b!). Then they would submit/order a patch to have two different
additional content entries for staff and OPAC and that will also solve this.

Anyway, most important is if there would be a nice phrasing instead of "online
catalog" that would also work for the staff. Maybe not something as generic as
"this web application".
Before that stuff is half set in stone when it's shipped and in the DB of
instances.

---

There doesn't seem to be other relevant occurrences after searching "Cookie
consent" and "consent" (case unsensitively). Some stuff is still user facing
but it's for the librarians managing html_customizations and that would require
changing existing data so not worth it.

---

Maybe a follow-up ticket is needed: to have these ticked by default in the
installer. Because "sample news items" looks like demo stuff and not something
that every library in EU and Australia (at least) needs to have. So they would
miss it. If it's by default, when enabling the syspref, the English default
text would immediately pop so they can directly use it or translate it without
having to search for the list of cookies Koha use for example.

Oh wait, shouldn't it even be in a database upgrade instead of installer's
optional sample data? (then it's a matter for this ticket) For existing
instances that enabled the consent but don't have the additional content
entries related to cookies policy. Like due to not immediately knowing what to
put there (cookie list and explanation what are cookies).
It's also a way to address the above paragraph.

---

I though I was close to having finished reviewing without having found issues
>_<

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2024-02-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #19 from Victor Grousset/tuxayo  ---
Created attachment 162014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162014=edit
Bug 34793: (QA follow-up): forgotten 'Cookie consents'=>'Cookies policy'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2024-02-07 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #18 from Martin Renvoize  ---
Considering this series is a set that really aught to have been included in
23.11.00.. I'm a little disappointed they're still stuck waiting for QA :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Owen Leonard  changed:

   What|Removed |Added

 Blocks|34792   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34792
[Bug 34792] CookieConsentBar content feels mis-aligned
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #17 from David Nind  ---
(In reply to Martin Renvoize from comment #13)
> PS, I set up a sandboxes with the full set of bugs applied if, it includes
> the follow-up I just added here too.
> 
> http://opac-cookies.sandboxes.ptfs-europe.co.uk

Thanks Martin! I had missed the other bugs. I can see the bigger picture now...

Thanks also for fixing the CSS for the OPAC display.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

David Nind  changed:

   What|Removed |Added

 Attachment #159132|0   |1
is obsolete||

--- Comment #16 from David Nind  ---
Created attachment 159135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159135=edit
Bug 34793: (follow-up) Add table classes to popup

This patch adds the appropriate table classes to the Popup html
customisation block. This ensure we have proper table display formatting
in the modal on the OPAC.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

David Nind  changed:

   What|Removed |Added

 Attachment #159095|0   |1
is obsolete||

--- Comment #15 from David Nind  ---
Created attachment 159134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159134=edit
Bug 34793: (follow-up) Rename 'Cookie consents' to 'Cookies policy'

The modal is not always about consent, but rather about displaying the
libraries cookie policy. It makes sense to update the heading to reflect
that.

Signed-off-by: Martin Renvoize 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

David Nind  changed:

   What|Removed |Added

 Attachment #159094|0   |1
is obsolete||

--- Comment #14 from David Nind  ---
Created attachment 159133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159133=edit
Bug 34793: Add default HTML Customisations for cookie information

This patch adds some default html customisation content for the cookie
consent feature.

Test plan
1) Run through the installer and pick to import the sample news items
2) Confirm that after enabling the CookieConsent preference that the
   default content appears in the cookie bar at the bottom of the page
   and in the modal that appears after clicking 'More information'

Mentored-by: Martin Renvoize 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #13 from Martin Renvoize  ---
PS, I set up a sandboxes with the full set of bugs applied if, it includes the
follow-up I just added here too.

http://opac-cookies.sandboxes.ptfs-europe.co.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #12 from Martin Renvoize  ---
Created attachment 159132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159132=edit
Bug 34793: (follow-up) Add table classes to popup

This patch adds the appropriate table classes to the Popup html
customisation block. This ensure we have proper table display formatting
in the modal on the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #11 from Martin Renvoize  ---
(In reply to David Nind from comment #10)
> I've tested and am happy to sign off.
> 
> Comments/suggestions:
> 
> 1. Should the cookie bar link to the cookie policy? I only see this in the
> OPAC by going to Your account > Consents > under Cookies policy is "View
> your cookie consents" button > pop up window has "Accept all cookies"
> irrespective of whether you have clicked on the "Accept all cookies" in the
> cookie bar.

Right now it depends.. but follow the tree here and you'll find we fixed that
too in one of the next bugs ;P

> 2. The table in the Consent policy page in the OPAC. It looks fine when you
> preview in Tools. However, in the OPAC it has hard to read as the rows are
> aligned to the center, with no alternate row colours or border between rows.
> Can the table rows be aligned to the top, and formatted similar to the staff
> interface tools preview?

Looks like we missed the classes (annoyingly, the preview in staff always uses
the staff css.. we should fix that somehow really)

> 3. I'm not sure that I understand the normal workflow for this from a patron
> perspective, even after reading through bug 27378, and how it works with the
> privacy policy.

It's in the documentation list.. hopefully aude and I can work through it asap.

> Testing notes:
> 
> 1. Starting the web installer in KTD:
> https://gitlab.com/-/snippets/1893788#user-content-starting-the-web-installer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #10 from David Nind  ---
I've tested and am happy to sign off.

Comments/suggestions:

1. Should the cookie bar link to the cookie policy? I only see this in the OPAC
by going to Your account > Consents > under Cookies policy is "View your cookie
consents" button > pop up window has "Accept all cookies" irrespective of
whether you have clicked on the "Accept all cookies" in the cookie bar.

2. The table in the Consent policy page in the OPAC. It looks fine when you
preview in Tools. However, in the OPAC it has hard to read as the rows are
aligned to the center, with no alternate row colours or border between rows.
Can the table rows be aligned to the top, and formatted similar to the staff
interface tools preview?

3. I'm not sure that I understand the normal workflow for this from a patron
perspective, even after reading through bug 27378, and how it works with the
privacy policy.


Testing notes:

1. Starting the web installer in KTD:
https://gitlab.com/-/snippets/1893788#user-content-starting-the-web-installer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Martin Renvoize  changed:

   What|Removed |Added

 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #9 from Martin Renvoize  ---
Quick typo fix applied ;P

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #159090|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 159095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159095=edit
Bug 34793: (follow-up) Rename 'Cookie consents' to 'Cookies policy'

The modal is not always about consent, but rather about displaying the
libraries cookie policy. It makes sense to update the heading to reflect
that.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #159089|0   |1
is obsolete||

--- Comment #7 from Martin Renvoize  ---
Created attachment 159094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159094=edit
Bug 34793: Add default HTML Customisations for cookie information

This patch adds some default html customisation content for the cookie
consent feature.

Test plan
1) Run through the installer and pick to import the sample news items
2) Confirm that after enabling the CookieConsent preference that the
   default content appears in the cookie bar at the bottom of the page
   and in the modal that appears after clicking 'More information'

Mentored-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #6 from Martin Renvoize  ---
Aude did all the hard work here putting together the text, I just helped to
construct the patch and upload it.

Great work Aude, I think it looks much better now as a feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #5 from Martin Renvoize  ---
Created attachment 159090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159090=edit
Bug 34793: (follow-up) Rename 'Cookie consents' to 'Cookies policy'

The modal is not always about consent, but rather about displaying the
libraries cookie policy. It makes sense to update the heading to reflect
that.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #4 from Martin Renvoize  ---
Created attachment 159089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159089=edit
Bug 34793: Add default HTML Customisations for cookie information

This patch adds some default html customisation content for the cookie
consent feature.

Test plan
1) Run through the installer and pick to import the sample news items
2) Confirm that after enabling the CookieConsent preference that the
   default content appears in the cookie bar at the bottom of the page
   and in the modal that appears after clicking 'More information'

Mentored-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||34792


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34792
[Bug 34792] CookieConsentBar content feels mis-aligned
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|35348   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348
[Bug 35348] Cookie information should be available regardless of whether you
are logged in or not
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|35346   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346
[Bug 35346] 'Accept essential cookies' should always appear if CookieConsent is
enabled
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||35348


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348
[Bug 35348] Cookie information should be available regardless of whether you
are logged in or not
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||35347


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35347
[Bug 35347] 'More information' should always display in cookie consent bar
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||35346


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346
[Bug 35346] 'Accept essential cookies' should always appear if CookieConsent is
enabled
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |aude.charillon@ptfs-europe.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-09-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #3 from Aude Charillon  ---
I'm all for informing users! Even if all the cookies are required and there is
no choice for the user, we have to tell them what's happening.

Can we slightly shift the cookie consent feature so that it's not just about
the consent but mostly about the cookies?
Or do we need a default Opac page about required cookies, with a link from the
Opac footer?
(Just throwing ideas wildly here.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #2 from Martin Renvoize  ---
Just because they're required for operation doesn't mean we should hide them. 
We should have encouraged best practice which is to inform the user what the
required cookies are used for.. That way then can then choose to opt out of
using your service if they believe the required cookies are over the top.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-09-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #1 from Katrin Fischer  ---
The issue I see here is that our required cookies don't require consent - they
cannot be avoided if you want to use the OPAC.
I am not sure how that would fit the modal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

Martin Renvoize  changed:

   What|Removed |Added

 CC||aude.charillon@ptfs-europe.
   ||com,
   ||katrin.fisc...@bsz-bw.de,
   ||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/