[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 Lucas Gass changed: What|Removed |Added Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in|| CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable --- Comment #14 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 Fridolin Somers changed: What|Removed |Added Version(s)|24.05.00|24.05.00,23.11.06 released in|| CC||fridolin.som...@biblibre.co ||m Status|Pushed to main |Pushed to stable --- Comment #13 from Fridolin Somers --- Pushed to 23.11.x for 23.11.06 Patch adapted : 'cud-save' => 'save' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 --- Comment #12 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 Nick Clemens changed: What|Removed |Added Attachment #165020|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 165200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165200=edit Bug 34963: Restore the ability to blank fields when editing a suggestion Regression introduced by bug 23991. We don't want to remove the fields from the edition if they are empty. Ideally we should have separate parameters for edition and search, but this is the low-effort fix, and hopefully won't introduce side-effects. Test plan: Try to edit a suggestion and blank some fields Try to search for suggestions using the search form on the left of the screen Signed-off-by: Ray Delahunty Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 --- Comment #10 from Katrin Fischer --- It never hurts to restart the services :) Thanks for the fix and sign-off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 Ray Delahunty changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #9 from Ray Delahunty --- Added 2 suggestions, one via Intranet, one via OPAC. Added content to publisher, public and private notes fields. Prior to patch application could not delete any of the three. After the patch applied could delete all three fields in both OPAC and Intranet sourced suggestions. (I did restart services- not sure if that was necessary- am new to signoffs). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #164986|0 |1 is obsolete|| --- Comment #8 from PTFS Europe Sandboxes --- Created attachment 165020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165020=edit Bug 34963: Restore the ability to blank fields when editing a suggestion Regression introduced by bug 23991. We don't want to remove the fields from the edition if they are empty. Ideally we should have separate parameters for edition and search, but this is the low-effort fix, and hopefully won't introduce side-effects. Test plan: Try to edit a suggestion and blank some fields Try to search for suggestions using the search form on the left of the screen Signed-off-by: Ray Delahunty -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@gmail.com |ity.org | --- Comment #7 from Jonathan Druart --- Sorry, I was not aware of this bug (or I forgot!) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 --- Comment #6 from Jonathan Druart --- Created attachment 164986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164986=edit Bug 34963: Restore the ability to blank fields when editing a suggestion Regression introduced by bug 23991. We don't want to remove the fields from the edition if they are empty. Ideally we should have separate parameters for edition and search, but this is the low-effort fix, and hopefully won't introduce side-effects. Test plan: Try to edit a suggestion and blank some fields Try to search for suggestions using the search form on the left of the screen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 Jonathan Druart changed: What|Removed |Added Depends on||23991 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 [Bug 23991] Move SearchSuggestion to Koha::Suggestions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 Michaela Sieber changed: What|Removed |Added CC||jonathan.dru...@gmail.com, ||michaela.sie...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 --- Comment #5 from Katrin Fischer --- It's all the text fields :( But I haven't been able to get developer's attention on this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #4 from Caroline Cyr La Rose --- I just noticed this is also true for the new non-public note... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35176 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34963] Unable to delete fields in suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 Katrin Fischer changed: What|Removed |Added Summary|Unable to delete notes in |Unable to delete fields in |suggestions |suggestions Severity|enhancement |normal --- Comment #3 from Katrin Fischer --- Actually it's all the non-mandatory fields - you can't empty them, only edit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
