[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #67 from Matt Blenkinsop --- Created attachment 165681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165681=edit Bug 35026: (QA follow-up): Restore order grouping This patch restores the grouping of orderlines by fund rather than one line per item. It also re-enables the reading of the barcoe, enumchron and coded_location_qualifier fields as well as passing the sort1 and sort2 values to the orderline. It also reintroduces some missed functionality for when MarcItemFieldsToOrder is not passed through and can now create order lines and records for an imported file when this is the case -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #66 from Nick Clemens --- I tested with the newly attached file and sysprefs set as below. I had to set the barcodes individually while importing (to make them unique, quantity and barcode are not compatible) Before: I had 3 orderlines, grouped by fund Item barcodes were filled Replacement price was correct for items, but order used the last one from multiple items sort 1 and 2 were correctly populated After: There was 1 orderline per item, 8 total, no grouping Item barcodes did not come through Replacement price for order and item were correct Sort 1 and 2 were not populated I believe all other fields were the same before and after, can you test and confirm and fix the sort fields and barcode? I am not sure what is correct for the grouping of orders. MarcItemFieldsToOrder homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g|949$j replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l barcode: 949$p coded_location_qualifier: 949$f enumchron: 949$h MarcFieldsToOrder price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q Testing with the same file, but empyting MarcItemFieldsToOrder and only using MarcFieldsToOrder I get two order records and 4 items before these patches (the second 949 seems to be ignored) but after applying these patches the records import but I had no orders or items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #65 from Nick Clemens --- Created attachment 165378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165378=edit Two record order fikle This is a test file to use all the fields listed on MarcItemFieldsToOrder - two records - multiple orders -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #164695|0 |1 is obsolete|| --- Comment #64 from Matt Blenkinsop --- Created attachment 164937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164937=edit Bug 35026: Refactor syspref mapping This patch refactors the way we read MarcFieldsToOrder and MarcItemFieldsToOrder to only use one method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Nick Clemens changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #63 from Matt Blenkinsop --- Created attachment 164695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164695=edit Bug 35026: Refactor syspref mapping This patch refactors the way we read MarcFieldsToOrder and MarcItemFieldsToOrder to only use one method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #62 from Matt Blenkinsop --- Thanks for signing off Barbara, the unit tests can be checked in QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #61 from Barbara Johnson --- I signed off on all patches. I realize now that one of them was to 'prove t/db_dependent/Koha/MarcOrder.t' which I don't think I can do in a sandbox? And, if I can, I don't know how. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #163794|0 |1 is obsolete|| --- Comment #60 from PTFS Europe Sandboxes --- Created attachment 163845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163845=edit Bug 35026: Fix unit tests This patch fixes the unit tests that were failing and also removes some tests that should not be introduced until bug 34355 Test plan: prove t/db_dependent/Koha/MarcOrder.t Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #163793|0 |1 is obsolete|| --- Comment #59 from PTFS Europe Sandboxes --- Created attachment 163844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163844=edit Bug 35026: Adjust price field to match UI Following bug 36036 the price field has been renamed in the UI- this patch removes the logic that was renaming that field in the backend to match this Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #163792|0 |1 is obsolete|| --- Comment #58 from PTFS Europe Sandboxes --- Created attachment 163843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163843=edit Bug 35026: Allow multiple records from one marc file This patch addresses a bug where only one record would be read from a marc file and other records would be lost. All records are now read from the file and displayed in the UI. Test plan as above Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #163791|0 |1 is obsolete|| --- Comment #57 from PTFS Europe Sandboxes --- Created attachment 163842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163842=edit Bug 35026: Add unit tests This commit adds a set of unit tests for the new methods in Koha::MarcOrder The two controller functions at the start of the file have not been included as they simply call the functions in these tests The _stage_file method is also not included as this is a copy of the existing file staging code with the background job functionality removed Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #163790|0 |1 is obsolete|| --- Comment #56 from PTFS Europe Sandboxes --- Created attachment 163841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163841=edit Bug 35026: Make add_items_from_import_record DRY This patch improves the code in add_items_from_import_record to make sure that the code is not repeating itself It also fixes a minor error in the template file and rebases in changes from bugs 35254 and 33170 Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #163789|0 |1 is obsolete|| --- Comment #55 from PTFS Europe Sandboxes --- Created attachment 163840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163840=edit Bug 35026: Tidy file Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #163788|0 |1 is obsolete|| --- Comment #54 from PTFS Europe Sandboxes --- Created attachment 163839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163839=edit Bug 35026: Refactor addorderiso2709.pl to use the MarcOrder class This script uses the newly created MarcOrder class to refactor the script into a cleaner controller function. This MarcOrder class will also be used in bug 34355 to automate the creation of order lines from marc records. Test plan: 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Paste the following into MarcFieldsToOrder price: 975$p quantity: 975$q budget_code: 975$h 3) Paste the following into MarcItemFieldsToOrder homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Now save the sysprefs 4) Navigate to acquisitions and go into a basket 5) Click Add to basket and select “From a new file” 6) Download the file attached to this bug 7) Import the file and when the job is complete click “Add staged files to basket” 8) Click the checkbox next to the record to display the items and confirm that the data matches the mappings from the file that you imported - there should be 8 items, grouped in 4 pairs of identical items 9) Fill in the required fields and click “Save” 10) That basket should be correctly populated with an order matching the file that you imported Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #163787|0 |1 is obsolete|| --- Comment #53 from PTFS Europe Sandboxes --- Created attachment 163838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163838=edit Bug 35026: Add a MarcOrder object class This patch adds a MarcOrder object class. This will primarily be used for the functionality in bug 34355 to automate order creation from a Marc file. The automation functionality is similar in principle to the functionality in the addorderis02709.pl script so it makes sense to refactor this script to use the same code. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #52 from Barbara Johnson --- Created attachment 163836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163836=edit Correct replacement price imported on basket.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #51 from Barbara Johnson --- Created attachment 163835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163835=edit Correct replacement price imported on addorderiso2709.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Barbara Johnson changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #50 from Barbara Johnson --- Success! Attached two more screenshots just to show that the different replacement prices I put in came over as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #49 from Matt Blenkinsop --- Looking at the file I attached to this bug there are no replacement price fields in the marc file (949$v). If you add a 949$v field to the file then you should see whatever price you added being imported correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #48 from Barbara Johnson --- Created attachment 163820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163820=edit Replacement price missing on basket.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #47 from Barbara Johnson --- Created attachment 163819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163819=edit Replacement price missing on addorderiso2709.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Barbara Johnson changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #46 from Barbara Johnson --- I retested in a sandbox. The replacement price is still coming over as 0.00 for me on the right hand side on addorderiso2709.pl. It's also 0.00 on basket.pl. I attached screenshots so you can see what I am seeing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #45 from Matt Blenkinsop --- Thanks again for testing Barbara, just addressing your comments below: (In reply to Barbara Johnson from comment #36) > * No data was imported into the price (949$g) field - everything is 0.00. Are you looking at the price inputs on the left or on the right under "Item record 1" etc? The boxes on the left should display 0.00 as there is no 975 field on the record. The boxes on the right are correctly displaying the prices for me. > * No data was imported into replacement price (949$v) because there was no > data in the sample file. Same as above > * The barcode# from the sample file was not imported into the 949$p. It was > not specified to be included in MarcItemFieldsToOrder in the test plan. If you add "barcode: 949$p" into the MarcItemFieldsToOrder it should import correctly > * The sample file contains three fields with the date of 2014-09-04. These > are in subfields d - Date acquired and w - Price effective from and subfield > r. Subfields d and w were populated with the current date instead of the > date in the xml file. I'm not sure what subfield r stands for. None of these fields are included in the import scope of MarcItemFieldsToOrder so the values should not transfer from the marc file > On a side note, I tried to not match on the biblio because of the error I > received in previous testing telling me there was a match and I would have > to handle the records individually. However, even when not matching I got > that error message. I had to delete the existing bib and attached items > before I could bring in the order. This is expected behaviour due to the matching record. There is a dropdown menu at the top of the page underneath the "Item information" tab. If you change this to "Do not look for matching records" you can bypass this behaviour and you will see the basket populated :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #162654|0 |1 is obsolete|| --- Comment #44 from Matt Blenkinsop --- Created attachment 163794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163794=edit Bug 35026: Fix unit tests This patch fixes the unit tests that were failing and also removes some tests that should not be introduced until bug 34355 Test plan: prove t/db_dependent/Koha/MarcOrder.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #162653|0 |1 is obsolete|| --- Comment #43 from Matt Blenkinsop --- Created attachment 163793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163793=edit Bug 35026: Adjust price field to match UI Following bug 36036 the price field has been renamed in the UI- this patch removes the logic that was renaming that field in the backend to match this -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #162652|0 |1 is obsolete|| --- Comment #42 from Matt Blenkinsop --- Created attachment 163792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163792=edit Bug 35026: Allow multiple records from one marc file This patch addresses a bug where only one record would be read from a marc file and other records would be lost. All records are now read from the file and displayed in the UI. Test plan as above -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #162651|0 |1 is obsolete|| --- Comment #41 from Matt Blenkinsop --- Created attachment 163791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163791=edit Bug 35026: Add unit tests This commit adds a set of unit tests for the new methods in Koha::MarcOrder The two controller functions at the start of the file have not been included as they simply call the functions in these tests The _stage_file method is also not included as this is a copy of the existing file staging code with the background job functionality removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #162650|0 |1 is obsolete|| --- Comment #40 from Matt Blenkinsop --- Created attachment 163790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163790=edit Bug 35026: Make add_items_from_import_record DRY This patch improves the code in add_items_from_import_record to make sure that the code is not repeating itself It also fixes a minor error in the template file and rebases in changes from bugs 35254 and 33170 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #162649|0 |1 is obsolete|| --- Comment #39 from Matt Blenkinsop --- Created attachment 163789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163789=edit Bug 35026: Tidy file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #162648|0 |1 is obsolete|| --- Comment #38 from Matt Blenkinsop --- Created attachment 163788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163788=edit Bug 35026: Refactor addorderiso2709.pl to use the MarcOrder class This script uses the newly created MarcOrder class to refactor the script into a cleaner controller function. This MarcOrder class will also be used in bug 34355 to automate the creation of order lines from marc records. Test plan: 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Paste the following into MarcFieldsToOrder price: 975$p quantity: 975$q budget_code: 975$h 3) Paste the following into MarcItemFieldsToOrder homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Now save the sysprefs 4) Navigate to acquisitions and go into a basket 5) Click Add to basket and select “From a new file” 6) Download the file attached to this bug 7) Import the file and when the job is complete click “Add staged files to basket” 8) Click the checkbox next to the record to display the items and confirm that the data matches the mappings from the file that you imported - there should be 8 items, grouped in 4 pairs of identical items 9) Fill in the required fields and click “Save” 10) That basket should be correctly populated with an order matching the file that you imported -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #162647|0 |1 is obsolete|| --- Comment #37 from Matt Blenkinsop --- Created attachment 163787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163787=edit Bug 35026: Add a MarcOrder object class This patch adds a MarcOrder object class. This will primarily be used for the functionality in bug 34355 to automate order creation from a Marc file. The automation functionality is similar in principle to the functionality in the addorderis02709.pl script so it makes sense to refactor this script to use the same code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #36 from Barbara Johnson --- Using Nick's suggestion from comment #35 solved the problem I reported in comment #34. * The location code of 'AV' successfully imported into the 949$c tag. * No data was imported into the price (949$g) field - everything is 0.00. * No data was imported into replacement price (949$v) because there was no data in the sample file. * The barcode# from the sample file was not imported into the 949$p. It was not specified to be included in MarcItemFieldsToOrder in the test plan. * The sample file contains three fields with the date of 2014-09-04. These are in subfields d - Date acquired and w - Price effective from and subfield r. Subfields d and w were populated with the current date instead of the date in the xml file. I'm not sure what subfield r stands for. On a side note, I tried to not match on the biblio because of the error I received in previous testing telling me there was a match and I would have to handle the records individually. However, even when not matching I got that error message. I had to delete the existing bib and attached items before I could bring in the order. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #35 from Nick Clemens --- (In reply to Barbara Johnson from comment #34) > I tested this in a ByWater sandbox but am getting an error. I used the test > plan from comment 27. In step 9 I am getting an error when saving on > addorderiso2709.pl that says 'Some required item subfields are not set.' The > only field that displays required next to it is budget_code which is already > filled in from the xml file. I tried changing the budget_code to a different > value but still got the error. I tried globally changing the budget_code via > the 'Default accounting details' setting but am still getting the error > message. > > I also noticed that the price (949$g) and replacementprice (949$v) were not > populated on addorderiso2709.pl. I tried entering prices for those fields > but that also did not clear the error. > > In case it matters, I also saw that the data in the xml file contained > barcodes in the 949$p but those did not populate on addorderiso2709.pl. Hi Barbara, I think you might be seeing bug 32209 - can you try setting the itemtype field in the item information tab? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Barbara Johnson changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #34 from Barbara Johnson --- I tested this in a ByWater sandbox but am getting an error. I used the test plan from comment 27. In step 9 I am getting an error when saving on addorderiso2709.pl that says 'Some required item subfields are not set.' The only field that displays required next to it is budget_code which is already filled in from the xml file. I tried changing the budget_code to a different value but still got the error. I tried globally changing the budget_code via the 'Default accounting details' setting but am still getting the error message. I also noticed that the price (949$g) and replacementprice (949$v) were not populated on addorderiso2709.pl. I tried entering prices for those fields but that also did not clear the error. In case it matters, I also saw that the data in the xml file contained barcodes in the 949$p but those did not populate on addorderiso2709.pl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #33 from Matt Blenkinsop --- Created attachment 162654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162654=edit Bug 35026: Fix unit tests This patch fixes the unit tests that were failing and also removes some tests that should not be introduced until bug 34355 Test plan: prove t/db_dependent/Koha/MarcOrder.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #32 from Matt Blenkinsop --- Created attachment 162653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162653=edit Bug 35026: Adjust price field to match UI Following bug 36036 the price field has been renamed in the UI- this patch removes the logic that was renaming that field in the backend to match this -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #160837|0 |1 is obsolete|| --- Comment #31 from Matt Blenkinsop --- Created attachment 162652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162652=edit Bug 35026: Allow multiple records from one marc file This patch addresses a bug where only one record would be read from a marc file and other records would be lost. All records are now read from the file and displayed in the UI. Test plan as above -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #160836|0 |1 is obsolete|| --- Comment #30 from Matt Blenkinsop --- Created attachment 162651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162651=edit Bug 35026: Add unit tests This commit adds a set of unit tests for the new methods in Koha::MarcOrder The two controller functions at the start of the file have not been included as they simply call the functions in these tests The _stage_file method is also not included as this is a copy of the existing file staging code with the background job functionality removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #160835|0 |1 is obsolete|| --- Comment #29 from Matt Blenkinsop --- Created attachment 162650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162650=edit Bug 35026: Make add_items_from_import_record DRY This patch improves the code in add_items_from_import_record to make sure that the code is not repeating itself It also fixes a minor error in the template file and rebases in changes from bugs 35254 and 33170 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #160834|0 |1 is obsolete|| --- Comment #28 from Matt Blenkinsop --- Created attachment 162649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162649=edit Bug 35026: Tidy file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #160833|0 |1 is obsolete|| --- Comment #27 from Matt Blenkinsop --- Created attachment 162648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162648=edit Bug 35026: Refactor addorderiso2709.pl to use the MarcOrder class This script uses the newly created MarcOrder class to refactor the script into a cleaner controller function. This MarcOrder class will also be used in bug 34355 to automate the creation of order lines from marc records. Test plan: 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Paste the following into MarcFieldsToOrder price: 975$p quantity: 975$q budget_code: 975$h 3) Paste the following into MarcItemFieldsToOrder homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Now save the sysprefs 4) Navigate to acquisitions and go into a basket 5) Click Add to basket and select “From a new file” 6) Download the file attached to this bug 7) Import the file and when the job is complete click “Add staged files to basket” 8) Click the checkbox next to the record to display the items and confirm that the data matches the mappings from the file that you imported - there should be 8 items, grouped in 4 pairs of identical items 9) Fill in the required fields and click “Save” 10) That basket should be correctly populated with an order matching the file that you imported -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #159969|0 |1 is obsolete|| --- Comment #26 from Matt Blenkinsop --- Created attachment 162647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162647=edit Bug 35026: Add a MarcOrder object class This patch adds a MarcOrder object class. This will primarily be used for the functionality in bug 34355 to automate order creation from a Marc file. The automation functionality is similar in principle to the functionality in the addorderis02709.pl script so it makes sense to refactor this script to use the same code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com ||, ||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Depends on||36036 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36036 [Bug 36036] Fix location field in addorderiso2709.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #25 from Matt Blenkinsop --- Thanks for testing Barbara, I've worked through your feedback. It looks like the new release of master has introduced some bugs into the page and all of the text inputs appear blank even though the values are being passed through. I'll need to resolve that before uploading my patches for testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Depends on||36035 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36035 [Bug 36035] Wrong text colour in addorderiso2709.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Barbara Johnson changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #24 from Barbara Johnson --- Forgot to set the status to Failed QA after testing the bug yesterday. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov --- Comment #23 from Barbara Johnson --- Here is what I found in testing this bug: * The location code of 'AV' was not imported into the 949$c tag even though it looks correct in the sample file and the location code exists. * No data was imported into replacement price (949$v) because there was no data in the sample file. It would be good to test this field because I hear many complaints from librarians when the replacement price doesn't come through. * The itemcallnumber from the sample file was not imported into the 949$o. It was not specified to be included in MarcItemFieldsToOrder in the test plan. * The barcode# from the sample file was not imported into the 949$p. It was not specified to be included in MarcItemFieldsToOrder in the test plan. * The sample file contains three fields with the date of 2014-09-04. These are in subfields d - Date acquired and w - Price effective from. Those fields were not specified to be included in MarcItemFieldsToOrder in the test plan which is probably why they populated with today's date. That date was also in subfield r in the sample file. * There are other fields that were not contained in the sample data that I think it would be good to test. They are the 949$7 (Not for loan), 949$u (Uniform resource identifier) and 949$x (Nonpublic note) * When I saved the file and viewed it in steps 9 and 10 I got the message: No records imported No records have been imported because they all match existing records in your catalog. You'll have to treat them individually. Since that's not something I do very often I opted to not match existing records which were successfully imported. The item data looked correct to me in the other fields, the prices appeared correct and the ordered were split up amongst the three funds. Once you are ready I'll be glad to retest this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #22 from Matt Blenkinsop --- Thanks for the feedback Nick, I've used the data from bug 34654 and am now seeing the items correctly populated and added to the basket. I will need to do some re-work to the cronjob side of the code but I'll do that in the background and push that to bug 34355 with the rest of that code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #21 from Matt Blenkinsop --- Created attachment 160838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160838=edit Sample data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #20 from Matt Blenkinsop --- Created attachment 160837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160837=edit Bug 35026: Allow multiple records from one marc file This patch addresses a bug where only one record would be read from a marc file and other records would be lost. All records are now read from the file and displayed in the UI. Test plan as above -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #159973|0 |1 is obsolete|| --- Comment #19 from Matt Blenkinsop --- Created attachment 160836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160836=edit Bug 35026: Add unit tests This commit adds a set of unit tests for the new methods in Koha::MarcOrder The two controller functions at the start of the file have not been included as they simply call the functions in these tests The _stage_file method is also not included as this is a copy of the existing file staging code with the background job functionality removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #159972|0 |1 is obsolete|| --- Comment #18 from Matt Blenkinsop --- Created attachment 160835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160835=edit Bug 35026: Make add_items_from_import_record DRY This patch improves the code in add_items_from_import_record to make sure that the code is not repeating itself It also fixes a minor error in the template file and rebases in changes from bugs 35254 and 33170 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #159971|0 |1 is obsolete|| --- Comment #17 from Matt Blenkinsop --- Created attachment 160834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160834=edit Bug 35026: Tidy file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #159970|0 |1 is obsolete|| --- Comment #16 from Matt Blenkinsop --- Created attachment 160833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160833=edit Bug 35026: Refactor addorderiso2709.pl to use the MarcOrder class This script uses the newly created MarcOrder class to refactor the script into a cleaner controller function. This MarcOrder class will also be used in bug 34355 to automate the creation of order lines from marc records. Test plan: 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Paste the following into MarcFieldsToOrder price: 975$p quantity: 975$q budget_code: 975$h 3) Paste the following into MarcItemFieldsToOrder homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Now save the sysprefs 4) Navigate to acquisitions and go into a basket 5) Click Add to basket and select “From a new file” 6) Download the file attached to this bug 7) Import the file and when the job is complete click “Add staged files to basket” 8) Click the checkbox next to the record to display the items and confirm that the data matches the mappings from the file that you imported - there should be 8 items, grouped in 4 pairs of identical items 9) Fill in the required fields and click “Save” 10) That basket should be correctly populated with an order matching the file that you imported -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #15 from Nick Clemens --- Using the settings and test file from bug 34645 I expect to get 8 items - I only get 2. I suspect there is a problem in _get_MarcItemFieldsToOrder_syspref_data as it builds an array, but only returns a single: return $result[0]; Two routines that are used have not been imported: +GetImportBatchRangeDesc +GetNumberOfNonZ3950ImportBatches Why not use C4::Context->yaml_preference in the _get_MarcItem... subroutines? Can you provide a test plan with sample data (feel free to steal from 34645) we should test with a file with multiple records and multiple orders per record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #159306|0 |1 is obsolete|| --- Comment #14 from Matt Blenkinsop --- Created attachment 159973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159973=edit Bug 35026: Add unit tests This commit adds a set of unit tests for the new methods in Koha::MarcOrder The two controller functions at the start of the file have not been included as they simply call the functions in these tests The _stage_file method is also not included as this is a copy of the existing file staging code with the background job functionality removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #159305|0 |1 is obsolete|| --- Comment #13 from Matt Blenkinsop --- Created attachment 159972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159972=edit Bug 35026: Make add_items_from_import_record DRY This patch improves the code in add_items_from_import_record to make sure that the code is not repeating itself It also fixes a minor error in the template file and rebases in changes from bugs 35254 and 33170 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #157058|0 |1 is obsolete|| --- Comment #12 from Matt Blenkinsop --- Created attachment 159971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159971=edit Bug 35026: Tidy file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #157057|0 |1 is obsolete|| --- Comment #11 from Matt Blenkinsop --- Created attachment 159970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159970=edit Bug 35026: Refactor addorderiso2709.pl to use the MarcOrder class This script uses the newly created MarcOrder class to refactor the script into a cleaner controller function. This MarcOrder class will also be used in bug 34355 to automate the creation of order lines from marc records. Test plan: 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Paste the following into MarcFieldsToOrder price: 975$p quantity: 975$q budget_code: 975$h 3) Paste the following into MarcItemFieldsToOrder homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 975$8 notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 975$q budget_code: 975$h price: 975$p replacementprice: 975$v Now save the sysprefs 4) Navigate to acquisitions and go into a basket 5) Click Add to basket and select “From a new file” 6) Ensure that you have a marc file that contains mappings matching some of the fields that you entered into the two sysprefs and select this file to upload 7) Import the file and when the job is complete click “Add staged files to basket” 8) Click the checkbox next to an item and confirm that the data matches the mappings from the file that you imported 9) Fill in the required fields and click “Save” 10) That basket should be correctly populated with an order matching the file that you imported -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #157056|0 |1 is obsolete|| --- Comment #10 from Matt Blenkinsop --- Created attachment 159969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159969=edit Bug 35026: Add a MarcOrder object class This patch adds a MarcOrder object class. This will primarily be used for the functionality in bug 34355 to automate order creation from a Marc file. The automation functionality is similar in principle to the functionality in the addorderis02709.pl script so it makes sense to refactor this script to use the same code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Martin Renvoize changed: What|Removed |Added Depends on||33171 CC||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 [Bug 33171] Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #9 from Matt Blenkinsop --- Created attachment 159306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159306=edit Bug 35026: Add unit tests This commit adds a set of unit tests for the new methods in Koha::MarcOrder The two controller functions at the start of the file have not been included as they simply call the functions in these tests The _stage_file method is also not included as this is a copy of the existing file staging code with the background job functionality removed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #8 from Matt Blenkinsop --- Created attachment 159305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159305=edit Bug 35026: Make add_items_from_import_record DRY This patch improves the code in add_items_from_import_record to make sure that the code is not repeating itself It also fixes a minor error in the template file and rebases in changes from bugs 35254 and 33170 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #7 from Nick Clemens --- Let me start by saying thank you for taking on some work that has been needed for a ling time. I like the way this is going very much, but I do have a few concerns: I think we need some test coverage for the new module if we want to move it forward. The templates should not be passed to the object, the matcher/batch info would be better served as template plugins I think. I wonder if add_items_from_import_record could combine a little more of the code for the two agents - perhaps there could be a top level routine that calls a lower level - after getting the parameters needed for the two different agents? add_biblios_from_import_record - I don't think the plural is correct here, orders->biblios is 1:1? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Blocks||34355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 [Bug 34355] Automated MARC record ordering process -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Blocks|34355 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 [Bug 34355] Automated MARC record ordering process -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Blocks||34355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 [Bug 34355] Automated MARC record ordering process -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #157052|0 |1 is obsolete|| --- Comment #6 from Matt Blenkinsop --- Created attachment 157058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157058=edit Bug 35026: Tidy file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #157051|0 |1 is obsolete|| --- Comment #5 from Matt Blenkinsop --- Created attachment 157057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157057=edit Bug 35026: Refactor addorderiso2709.pl to use the MarcOrder class This script uses the newly created MarcOrder class to refactor the script into a cleaner controller function. This MarcOrder class will also be used in bug 34355 to automate the creation of order lines from marc records. Test plan: 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Paste the following into MarcFieldsToOrder price: 975$p quantity: 975$q budget_code: 975$h 3) Paste the following into MarcItemFieldsToOrder homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 975$8 notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 975$q budget_code: 975$h price: 975$p replacementprice: 975$v Now save the sysprefs 4) Navigate to acquisitions and go into a basket 5) Click Add to basket and select “From a new file” 6) Ensure that you have a marc file that contains mappings matching some of the fields that you entered into the two sysprefs and select this file to upload 7) Import the file and when the job is complete click “Add staged files to basket” 8) Click the checkbox next to an item and confirm that the data matches the mappings from the file that you imported 9) Fill in the required fields and click “Save” 10) That basket should be correctly populated with an order matching the file that you imported -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Matt Blenkinsop changed: What|Removed |Added Attachment #157050|0 |1 is obsolete|| --- Comment #4 from Matt Blenkinsop --- Created attachment 157056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157056=edit Bug 35026: Add a MarcOrder object class This patch adds a MarcOrder object class. This will primarily be used for the functionality in bug 34355 to automate order creation from a Marc file. The automation functionality is similar in principle to the functionality in the addorderis02709.pl script so it makes sense to refactor this script to use the same code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #3 from Matt Blenkinsop --- Created attachment 157052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157052=edit Bug 35026: Tidy file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #2 from Matt Blenkinsop --- Created attachment 157051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157051=edit Bug 35026: Refactor addorderiso2709.pl to use the MarcOrder class This script uses the newly created MarcOrder class to refactor the script into a cleaner controller function. This MarcOrder class will also be used in bug 34355 to automate the creation of order lines from marc records. Test plan: 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Paste the following into MarcFieldsToOrder price: 975$p quantity: 975$q budget_code: 975$h 3) Paste the following into MarcItemFieldsToOrder homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 975$8 notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 975$q budget_code: 975$h price: 975$p replacementprice: 975$v Now save the sysprefs 4) Navigate to acquisitions and go into a basket 5) Click Add to basket and select “From a new file” 6) Ensure that you have a marc file that contains mappings matching some of the fields that you entered into the two sysprefs and select this file to upload 7) Import the file and when the job is complete click “Add staged files to basket” 8) Click the checkbox next to an item and confirm that the data matches the mappings from the file that you imported 9) Fill in the required fields and click “Save” 10) That basket should be correctly populated with an order matching the file that you imported -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 --- Comment #1 from Matt Blenkinsop --- Created attachment 157050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157050=edit Bug 35026: Add a MarcOrder object class This patch adds a MarcOrder object class. This will primarily be used for the functionality in bug 34355 to automate order creation from a Marc file. The automation functionality is similar in principle to the functionality in the addorderis02709.pl script so it makes sense to refactor this script to use the same code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
