[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 --- Comment #12 from Matt Blenkinsop --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.12 released in|| Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to master|Pushed to stable Version(s)|23.11.00|23.11.00,23.05.05 released in|| --- Comment #11 from Fridolin Somers --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Marcel de Rooy changed: What|Removed |Added QA Contact||m.de.r...@rijksmuseum.nl --- Comment #9 from Marcel de Rooy --- Shouldnt we at some point change the itemtypes table? `notforloan` smallint(6) DEFAULT NULL COMMENT '1 if the item is not for loan, 0 if the item is available for loan', Just inconsistent? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Marcel de Rooy changed: What|Removed |Added Attachment #157955|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 157969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157969=edit Bug 35167: Make 'effective_not_for_loan_status' fallback to 0 if itype has it undef This patch makes the effective not for loan status be set the item value if not defined at itype level. To test: 1. Apply the regressions tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/items.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Marcel de Rooy changed: What|Removed |Added Attachment #157954|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 157968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157968=edit Bug 35167: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #6 from Marcel de Rooy --- Looking here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Lucas Gass changed: What|Removed |Added Attachment #157949|0 |1 is obsolete|| --- Comment #5 from Lucas Gass --- Created attachment 157955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157955=edit Bug 35167: Make 'effective_not_for_loan_status' fallback to 0 if itype has it undef This patch makes the effective not for loan status be set the item value if not defined at itype level. To test: 1. Apply the regressions tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/items.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Lucas Gass changed: What|Removed |Added Attachment #157948|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 157954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157954=edit Bug 35167: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Tomás Cohen Arazi changed: What|Removed |Added CC||dc...@prosentient.com.au, ||lu...@bywatersolutions.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_22_11_candidate, ||rel_23_05_candidate, ||rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Tomás Cohen Arazi changed: What|Removed |Added Summary|GET /items* broken if |GET /items* broken if |notforloan == 0 |notforloan == 0 and ||itemtype.notforloan == NULL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/