[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #35 from Fridolin Somers --- Does not apply easy on 23.11.x, I prefer not backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #34 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #33 from Katrin Fischer --- Had to fix a small conflict in the first patch and the unit test due to CSRF changes. This means that if this was to be backported, we'd probably need some small changes. Fixed commit message: Bug 35331: (QA follow-up): This one is confusing. It's a one line change - I tidied it, the QA issue remained: Small QA script failures: FAIL ill/ill-requests.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 181, now: 182) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #32 from Pedro Amorim --- Rebased on bug 34478 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Attachment #160637|0 |1 is obsolete|| --- Comment #31 from Pedro Amorim --- Created attachment 162816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162816=edit Bug 35331: (QA follow-up): Patron ILL history With the previous patches applied and successfull test plans, access the users ILL history page, visit: /cgi-bin/koha/members/ill-requests.pl?borrowernumber=51 Notice you get an error. Apply this patch, and try again, notice the error is gone and the custom plugin action is also in the patron's ILL history table Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Attachment #160636|0 |1 is obsolete|| --- Comment #30 from Pedro Amorim --- Created attachment 162815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162815=edit Bug 35331: (QA follow-up): Avoid code pattern iterating on plugin responses (see bug 28010) Use plugin call pattern established in bug 28211. Please utilize version 1.0.1 of the plugin to test this follow-up: https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.1 Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Attachment #160635|0 |1 is obsolete|| --- Comment #29 from Pedro Amorim --- Created attachment 162814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162814=edit Bug 35331: Add plugin hook tests prove t/db_dependent/Koha/Plugins/Ill_hooks.t Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #28 from Pedro Amorim --- Created attachment 162813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162813=edit Bug 35331: CSRF follow-up Update method to op -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Attachment #160634|0 |1 is obsolete|| --- Comment #27 from Pedro Amorim --- Created attachment 162812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162812=edit Bug 35331: Add table actions hook to ILL table Test plan, k-t-d, apply patches: 1) Install FreeForm backend, enable ILLModule sys pref, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Navigate to ILL requests, visit: /cgi-bin/koha/ill/ill-requests.pl 3) Click '+New ILL request', select a type, enter an existing cardnumber (e.g. '42') and pick a library. Click 'Create'. 4) Visit ILL requests again, repeat 2) 5) Notice the row for the created request has the already existing action button 'Manage request' 6) Install the ILL actions plugin, located at: https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.0 7) Restart plack, run: koha-plack --restart kohadev 8) Repeat 4) and 5). Notice the row for the created request now has a new custom action in addition to the already existing core one. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #26 from Pedro Amorim --- It no longer applied after bug 35070. Rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Attachment #159109|0 |1 is obsolete|| --- Comment #25 from Pedro Amorim --- Created attachment 160637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160637=edit Bug 35331: (QA follow-up): Patron ILL history With the previous patches applied and successfull test plans, access the users ILL history page, visit: /cgi-bin/koha/members/ill-requests.pl?borrowernumber=51 Notice you get an error. Apply this patch, and try again, notice the error is gone and the custom plugin action is also in the patron's ILL history table Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Attachment #159108|0 |1 is obsolete|| --- Comment #24 from Pedro Amorim --- Created attachment 160636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160636=edit Bug 35331: (QA follow-up): Avoid code pattern iterating on plugin responses (see bug 28010) Use plugin call pattern established in bug 28211. Please utilize version 1.0.1 of the plugin to test this follow-up: https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.1 Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Attachment #159107|0 |1 is obsolete|| --- Comment #23 from Pedro Amorim --- Created attachment 160635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160635=edit Bug 35331: Add plugin hook tests prove t/db_dependent/Koha/Plugins/Ill_hooks.t Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Attachment #159106|0 |1 is obsolete|| --- Comment #22 from Pedro Amorim --- Created attachment 160634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160634=edit Bug 35331: Add table actions hook to ILL table Test plan, k-t-d, apply patches: 1) Install FreeForm backend, enable ILLModule sys pref, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Navigate to ILL requests, visit: /cgi-bin/koha/ill/ill-requests.pl 3) Click '+New ILL request', select a type, enter an existing cardnumber (e.g. '42') and pick a library. Click 'Create'. 4) Visit ILL requests again, repeat 2) 5) Notice the row for the created request has the already existing action button 'Manage request' 6) Install the ILL actions plugin, located at: https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.0 7) Restart plack, run: koha-plack --restart kohadev 8) Repeat 4) and 5). Notice the row for the created request now has a new custom action in addition to the already existing core one. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Blocks||35581 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 [Bug 35581] ILL Koha classes are not consistent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #21 from Kyle M Hall --- Created attachment 159109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159109=edit Bug 35331: (QA follow-up): Patron ILL history With the previous patches applied and successfull test plans, access the users ILL history page, visit: /cgi-bin/koha/members/ill-requests.pl?borrowernumber=51 Notice you get an error. Apply this patch, and try again, notice the error is gone and the custom plugin action is also in the patron's ILL history table Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #20 from Kyle M Hall --- Created attachment 159108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159108=edit Bug 35331: (QA follow-up): Avoid code pattern iterating on plugin responses (see bug 28010) Use plugin call pattern established in bug 28211. Please utilize version 1.0.1 of the plugin to test this follow-up: https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.1 Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #19 from Kyle M Hall --- Created attachment 159107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159107=edit Bug 35331: Add plugin hook tests prove t/db_dependent/Koha/Plugins/Ill_hooks.t Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Kyle M Hall changed: What|Removed |Added Attachment #159105|0 |1 is obsolete|| --- Comment #18 from Kyle M Hall --- Created attachment 159106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159106=edit Bug 35331: Add table actions hook to ILL table Test plan, k-t-d, apply patches: 1) Install FreeForm backend, enable ILLModule sys pref, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Navigate to ILL requests, visit: /cgi-bin/koha/ill/ill-requests.pl 3) Click '+New ILL request', select a type, enter an existing cardnumber (e.g. '42') and pick a library. Click 'Create'. 4) Visit ILL requests again, repeat 2) 5) Notice the row for the created request has the already existing action button 'Manage request' 6) Install the ILL actions plugin, located at: https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.0 7) Restart plack, run: koha-plack --restart kohadev 8) Repeat 4) and 5). Notice the row for the created request now has a new custom action in addition to the already existing core one. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Kyle M Hall changed: What|Removed |Added Attachment #159046|0 |1 is obsolete|| Attachment #159047|0 |1 is obsolete|| Attachment #159048|0 |1 is obsolete|| Attachment #159049|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall --- Created attachment 159105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159105=edit Bug 35331: Add table actions hook to ILL table Test plan, k-t-d, apply patches: 1) Install FreeForm backend, enable ILLModule sys pref, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Navigate to ILL requests, visit: /cgi-bin/koha/ill/ill-requests.pl 3) Click '+New ILL request', select a type, enter an existing cardnumber (e.g. '42') and pick a library. Click 'Create'. 4) Visit ILL requests again, repeat 2) 5) Notice the row for the created request has the already existing action button 'Manage request' 6) Install the ILL actions plugin, located at: https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.0 7) Restart plack, run: koha-plack --restart kohadev 8) Repeat 4) and 5). Notice the row for the created request now has a new custom action in addition to the already existing core one. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #16 from Pedro Amorim --- Brilliant, David. Thank you, you're awesome! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #15 from David Nind --- Testing notes (using KTD): 1. Without the 4th patch applied, go to Patrons > [Patron account] > Ill requests history. The screen displays the ILL requests history table headers and shows "Processing". See [1] for the Web Developer Tools console error. 2. The tests pass if the ILL Actions plugin is disabled or uninstalled. [1] Web Developer Tools console error: Uncaught ReferenceError: ill_table_actions is not defined render_table_actions http://127.0.0.1:8081/intranet-tmpl/prog/js/ill-list-table_23.0600079.js:421 render http://127.0.0.1:8081/intranet-tmpl/prog/js/ill-list-table_23.0600079.js:411 S http://127.0.0.1:8081/intranet-tmpl/lib/datatables/datatables.min_23.0600079.js:56 fnGetData http://127.0.0.1:8081/intranet-tmpl/lib/datatables/datatables.min_23.0600079.js:50 B http://127.0.0.1:8081/intranet-tmpl/lib/datatables/datatables.min_23.0600079.js:55 Ha http://127.0.0.1:8081/intranet-tmpl/lib/datatables/datatables.min_23.0600079.js:63 P http://127.0.0.1:8081/intranet-tmpl/lib/datatables/datatables.min_23.0600079.js:67 vb http://127.0.0.1:8081/intranet-tmpl/lib/datatables/datatables.min_23.0600079.js:78 lb http://127.0.0.1:8081/intranet-tmpl/lib/datatables/datatables.min_23.0600079.js:75 i http://127.0.0.1:8081/intranet-tmpl/lib/datatables/datatables.min_23.0600079.js:73 success http://127.0.0.1:8081/intranet-tmpl/lib/datatables/datatables.min_23.0600079.js:74 jQuery 4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 David Nind changed: What|Removed |Added Attachment #159037|0 |1 is obsolete|| --- Comment #14 from David Nind --- Created attachment 159049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159049=edit Bug 35331: (QA follow-up): Patron ILL history With the previous patches applied and successfull test plans, access the users ILL history page, visit: /cgi-bin/koha/members/ill-requests.pl?borrowernumber=51 Notice you get an error. Apply this patch, and try again, notice the error is gone and the custom plugin action is also in the patron's ILL history table Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 David Nind changed: What|Removed |Added Attachment #158993|0 |1 is obsolete|| --- Comment #13 from David Nind --- Created attachment 159048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159048=edit Bug 35331: (QA follow-up): Avoid code pattern iterating on plugin responses (see bug 28010) Use plugin call pattern established in bug 28211. Please utilize version 1.0.1 of the plugin to test this follow-up: https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.1 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 David Nind changed: What|Removed |Added Attachment #158917|0 |1 is obsolete|| --- Comment #12 from David Nind --- Created attachment 159047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159047=edit Bug 35331: Add plugin hook tests prove t/db_dependent/Koha/Plugins/Ill_hooks.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 David Nind changed: What|Removed |Added Attachment #158916|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 159046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159046=edit Bug 35331: Add table actions hook to ILL table Test plan, k-t-d, apply patches: 1) Install FreeForm backend, enable ILLModule sys pref, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Navigate to ILL requests, visit: /cgi-bin/koha/ill/ill-requests.pl 3) Click '+New ILL request', select a type, enter an existing cardnumber (e.g. '42') and pick a library. Click 'Create'. 4) Visit ILL requests again, repeat 2) 5) Notice the row for the created request has the already existing action button 'Manage request' 6) Install the ILL actions plugin, located at: https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.0 7) Restart plack, run: koha-plack --restart kohadev 8) Repeat 4) and 5). Notice the row for the created request now has a new custom action in addition to the already existing core one. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #10 from Pedro Amorim --- (In reply to David Nind from comment #7) > I'm not a developer, so I don't know whether tests should pass with and > without the koha-plugin-ill-actions plugin enabled. If we run the following command (no plugins installed): prove t/db_dependent/Koha/Plugins All tests pass. But, if we then install the kitchensink plugin located at: https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/releases/tag/v2.3.1 And run the plugin tests again: prove t/db_dependent/Koha/Plugins A bunch of them are now failing, because the installed plugin is changing the expected static result of the tests. In conclusion, I think it's safe to assume that no plugins should be installed when running unit tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #9 from Pedro Amorim --- Created attachment 159037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159037=edit Bug 35331: (QA follow-up): Patron ILL history With the previous patches applied and successfull test plans, access the users ILL history page, visit: /cgi-bin/koha/members/ill-requests.pl?borrowernumber=51 Notice you get an error. Apply this patch, and try again, notice the error is gone and the custom plugin action is also in the patron's ILL history table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #8 from Pedro Amorim --- (In reply to David Nind from comment #7) > Tests pass if the koha-plugin-ill-actions plugin is disabled. > > Note: with version 1.0.1 of the plugin, the new action no longer works[1] > (it did previously with v1.0.0), but I don't know if that is relevant for > signing off. > > I'm not a developer, so I don't know whether tests should pass with and > without the koha-plugin-ill-actions plugin enabled. > > [1] Page not found error when clicking on new action - "New request for this > user": > > Page URL: > http://127.0.0.1:8081/api/v1/contrib/ill_actions/new_request_for_patron/1 > > Start of the page content ()no CSS style sheet): > > Page Not Found > This application is in development mode and will show internal information > to help you with debugging. > > None of these routes could generate a response for your GET request for > /api/v1/contrib/ill_actions/new_request_for_patron/1, maybe you need to add > a new one? Once again, thank you David. I was able to reproduce the problem described, but running: koha-plack --restart kohadev after having installed the plugin did the trick for me. Would you please give that a go? Thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #7 from David Nind --- Tests pass if the koha-plugin-ill-actions plugin is disabled. Note: with version 1.0.1 of the plugin, the new action no longer works[1] (it did previously with v1.0.0), but I don't know if that is relevant for signing off. I'm not a developer, so I don't know whether tests should pass with and without the koha-plugin-ill-actions plugin enabled. [1] Page not found error when clicking on new action - "New request for this user": Page URL: http://127.0.0.1:8081/api/v1/contrib/ill_actions/new_request_for_patron/1 Start of the page content ()no CSS style sheet): Page Not Found This application is in development mode and will show internal information to help you with debugging. None of these routes could generate a response for your GET request for /api/v1/contrib/ill_actions/new_request_for_patron/1, maybe you need to add a new one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #6 from Pedro Amorim --- Created attachment 158993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158993=edit Bug 35331: (QA follow-up): Avoid code pattern iterating on plugin responses (see bug 28010) Use plugin call pattern established in bug 28211. Please utilize version 1.0.1 of the plugin to test this follow-up: https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331
--- Comment #5 from Pedro Amorim ---
(In reply to David Nind from comment #3)
> Everything works for me, except running the tests - which fail 8-(...
>
> kohadev-koha@kohadevbox:koha(bz35331)$ prove
> t/db_dependent/Koha/Plugins/Ill_hooks.t
> t/db_dependent/Koha/Plugins/Ill_hooks.t .. 1/4
> # Failed test 'get_staff_table_actions() should return core action
> plus a custom plugin actions'
> # at t/db_dependent/Koha/Plugins/Ill_hooks.t line 52.
> # Structures begin differing at:
> # $got->[1]{button_class} = 'btn btn-default btn-sm'
> # $expected->[1]{button_class} = 'test class'
> # Looks like you failed 1 test of 1.
> t/db_dependent/Koha/Plugins/Ill_hooks.t .. 4/4
> # Failed test 'ill_table_actions hook'
> # at t/db_dependent/Koha/Plugins/Ill_hooks.t line 73.
> # Looks like you failed 1 test of 4.
> t/db_dependent/Koha/Plugins/Ill_hooks.t .. Dubious, test returned 1 (wstat
> 256, 0x100)
> Failed 1/4 subtests
>
> Test Summary Report
> ---
> t/db_dependent/Koha/Plugins/Ill_hooks.t (Wstat: 256 Tests: 4 Failed: 1)
> Failed test: 4
> Non-zero exit status: 1
> Files=1, Tests=4, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.93 cusr 0.14
> csys = 1.09 CPU)
> Result: FAIL
Thank you so much for testing, David!
I believe the tests may be failing for you because you have the plugin
installed.
They pass for me without having the plugin installed, as I believe that will be
the case for CI/CD.
Having said that, I'm not certain this is what's expected, i.e. a particular
hook test fails if a plugin implementing it is installed. As this is my first
time writing a hook test, there is a chance the tests need to/could be
improved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 David Nind changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co |ity.org |m --- Comment #4 from David Nind --- Updated assignee -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC||da...@davidnind.com
--- Comment #3 from David Nind ---
Everything works for me, except running the tests - which fail 8-(...
kohadev-koha@kohadevbox:koha(bz35331)$ prove
t/db_dependent/Koha/Plugins/Ill_hooks.t
t/db_dependent/Koha/Plugins/Ill_hooks.t .. 1/4
# Failed test 'get_staff_table_actions() should return core action plus a
custom plugin actions'
# at t/db_dependent/Koha/Plugins/Ill_hooks.t line 52.
# Structures begin differing at:
# $got->[1]{button_class} = 'btn btn-default btn-sm'
# $expected->[1]{button_class} = 'test class'
# Looks like you failed 1 test of 1.
t/db_dependent/Koha/Plugins/Ill_hooks.t .. 4/4
# Failed test 'ill_table_actions hook'
# at t/db_dependent/Koha/Plugins/Ill_hooks.t line 73.
# Looks like you failed 1 test of 4.
t/db_dependent/Koha/Plugins/Ill_hooks.t .. Dubious, test returned 1 (wstat 256,
0x100)
Failed 1/4 subtests
Test Summary Report
---
t/db_dependent/Koha/Plugins/Ill_hooks.t (Wstat: 256 Tests: 4 Failed: 1)
Failed test: 4
Non-zero exit status: 1
Files=1, Tests=4, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.93 cusr 0.14
csys = 1.09 CPU)
Result: FAIL
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #2 from Pedro Amorim --- Created attachment 158917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158917=edit Bug 35331: Add plugin hook tests prove t/db_dependent/Koha/Plugins/Ill_hooks.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #1 from Pedro Amorim --- Created attachment 158916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158916=edit Bug 35331: Add table actions hook to ILL table Test plan, k-t-d, apply patches: 1) Install FreeForm backend, enable ILLModule sys pref, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Navigate to ILL requests, visit: /cgi-bin/koha/ill/ill-requests.pl 3) Click '+New ILL request', select a type, enter an existing cardnumber (e.g. '42') and pick a library. Click 'Create'. 4) Visit ILL requests again, repeat 2) 5) Notice the row for the created request has the already existing action button 'Manage request' 6) Install the ILL actions plugin, located at: https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.0 7) Restart plack, run: koha-plack --restart kohadev 8) Repeat 4) and 5). Notice the row for the created request now has a new custom action in addition to the already existing core one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
