subject:"\[Koha\-bugs\] \[Bug 3534\] Patron quick add form"

[Koha-bugs] [Bug 3534] Patron quick add form

2019-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #84851|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2019-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #66 from Kyle M Hall  ---
Created attachment 84851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84851=edit
Bug 3534: (QA Follow-up) Fix the return value for the new format, it should be
a hashref, not a string

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2017-09-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||19249


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249
[Bug 19249] date picker broken in quick add brief form
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2017-05-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #65 from Mason James  ---
New feature, skipping for 16.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2017-05-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

 Blocks||18598


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598
[Bug 18598] Quick add form doesn't clear values when switching
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2017-05-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

 Blocks||18597


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597
[Bug 18597] Quick add form does not transfer patron attributes values when
switching forms/saving
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2017-05-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

 Blocks||18596


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596
[Bug 18596] Quick add form duplicating password confirm
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2017-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18569


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18569
[Bug 18569] Quick add patron will not copy over details from cities and towns
pull down into patron details
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-12-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-11-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Zeno Tajoli  changed:

   What|Removed |Added

  Text to go in the||This patch adds a new
  release notes||system preference:
   ||PatronQuickAddFields
   ||When
   ||either this pref or
   ||BorrowerMandatoryField is
   ||populated this will add a
   ||new dropdown to the bew
   ||patron toolbar. When a
   ||category is chosen from
   ||this dropdown the fields in
   ||PatronQuickAddFields and
   ||BorrowerMandatoryField will
   ||be displayed. There will be
   ||a button allowing a user to
   ||switch from the quickadd to
   ||the full form and fields
   ||will be copied between the
   ||forms when toggling.
   ||The
   ||Quick add will only be
   ||displayed on add of a new
   ||patron, future edits should
   ||display the full form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-11-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17344


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344
[Bug 17344] Can't set guarantor in quick add brief form
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-11-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-08-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Indranil Das Gupta  changed:

   What|Removed |Added

 CC||indr...@l2c2.co.in

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-07-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nicole C. Engard  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #64 from Kyle M Hall  ---
Pushed to master for Koha 16.11, thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #63 from Jonathan Druart  
---
I have squashed 2 patches for the readability.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #59 from Jonathan Druart  
---
Created attachment 53172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53172=edit
Bug 3534 - QA Followup - use floating save

I am not sure if this is desired, it makes sense for consistency but
floats in a wierd place for a short form.

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #60 from Jonathan Druart  
---
Created attachment 53173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53173=edit
Bug 3534 (QA Followup) Fix indentation, show guarantor form, ignore bad data in
pref

Switch incorrect == to != when checking skipped fields

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #61 from Jonathan Druart  
---
Created attachment 53174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53174=edit
Bug 3534 (QA Followup) Rebase and change floating save

Bug 3534 - (QA Followup) Use single toolbar for regular/quickadd forms

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #62 from Jonathan Druart  
---
Created attachment 53175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53175=edit
Bug 3534: Force margin-left: 0 for second button

When quick adding a new patron, both button are in the DOM and the
second button has a margin-left (from .btn-toolbar > .btn + .btn).
This patch force the margin-left to 0 to avoid the button to move when
toggling them.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52934|0   |1
is obsolete||
  Attachment #52935|0   |1
is obsolete||
  Attachment #52936|0   |1
is obsolete||
  Attachment #52937|0   |1
is obsolete||
  Attachment #53152|0   |1
is obsolete||

--- Comment #58 from Jonathan Druart  
---
Created attachment 53171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53171=edit
Bug 3534 - Patron quick add form

This patch adds a new system preference:
PatronQuickAddFields

When either this pref or BorrowerMandatoryField is populated this will add a
new dropdown to the bew patron toolbar.
When a category is chosen from this dropdown the fields in PatronQuickAddFields
and BorrowerMandatoryField will be displayed.
There will be a button allowing a user to switch from the quickadd to the full
form and fields will be copied between the forms when toggling.

The Quick add will only be displayed on add of a new patron, future edits
should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields
 and note the new button for adding a patron
 5 - Click the Quick add and choose a type
 6 - Only required or quick add fields should be displayed
 7 - Verify toggling forms copies information
 8 - Ensure you cannot save patron without filling required fields
 (quick add fields should be optional)
 9 - Ensure you can save patron with fields filled out
10 - Ensure that a duplicate patron brings up the duplicate/add new
buttons with full form displayed
11 - Verify that subsequent edits use only full form
12 - Verify that data on form submitted is the data saved to patron
13 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries)

Followed test plan, works as expected.
Re-tested together with followup, works as expected (2016-06-02)
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-07-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #57 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #55)
> I think you should trick the code to have only 1 toolbar for the 2 forms.
> You will need to add a flag to check, to know which form we want to save.

Indeed, combined to one toolbar, removed 'onclick' action from regular save and
redirected to a js function

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-07-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-07-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

  Attachment #53109|0   |1
is obsolete||

--- Comment #56 from Nick Clemens  ---
Created attachment 53152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53152=edit
Bug 3534 - (QA Followup) Use single toolbar for regular/quickadd forms

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-07-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #55 from Jonathan Druart  
---
Nick, with your last patches, there is a problem:
If you are on the quick add form, then switch to the full form, the toolbar is
not floating.
If I remove the last patch, there is floating toolbar on the quick add form is
not displayed correctly (there is a margin top).
I think you should trick the code to have only 1 toolbar for the 2 forms. You
will need to add a flag to check, to know which form we want to save.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-07-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #54 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #52)
> Why do you use another id for the toolbar? You won't need to add this
> specific JS code if you just use "toolbar" as the id.

It was just to keep the toolbar in the quick add form, it seemed cleaner.

Moving it to the top of the page works as well and doesn't require the js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-07-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-07-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #53 from Nick Clemens  ---
Created attachment 53109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53109=edit
Bug 3534 (QA Followup)

Move QA save toolbar and use same class as full form

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-07-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #52 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #51)
> Created attachment 52937 [details] [review]
> Bug 3534 (QA Followup) Rebase and change floating save

Why do you use another id for the toolbar? You won't need to add this specific
JS code if you just use "toolbar" as the id.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #51 from Nick Clemens  ---
Created attachment 52937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52937=edit
Bug 3534 (QA Followup) Rebase and change floating save

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52586|0   |1
is obsolete||

--- Comment #50 from Nick Clemens  ---
Created attachment 52936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52936=edit
Bug 3534 (QA Followup) Fix indentation, show guarantor form, ignore bad data in
pref

Switch incorrect == to != when checking skipped fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52585|0   |1
is obsolete||

--- Comment #49 from Nick Clemens  ---
Created attachment 52935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52935=edit
Bug 3534 - QA Followup - use floating save

I am not sure if this is desired, it makes sense for consistency but
floats in a wierd place for a short form.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52584|0   |1
is obsolete||

--- Comment #48 from Nick Clemens  ---
Created attachment 52934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52934=edit
Bug 3534 - Patron quick add form

This patch adds a new system preference:
PatronQuickAddFields

When either this pref or BorrowerMandatoryField is populated this will add a
new dropdown to the bew patron toolbar.
When a category is chosen from this dropdown the fields in PatronQuickAddFields
and BorrowerMandatoryField will be displayed.
There will be a button allowing a user to switch from the quickadd to the full
form and fields will be copied between the forms when toggling.

The Quick add will only be displayed on add of a new patron, future edits
should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields
 and note the new button for adding a patron
 5 - Click the Quick add and choose a type
 6 - Only required or quick add fields should be displayed
 7 - Verify toggling forms copies information
 8 - Ensure you cannot save patron without filling required fields
 (quick add fields should be optional)
 9 - Ensure you can save patron with fields filled out
10 - Ensure that a duplicate patron brings up the duplicate/add new
buttons with full form displayed
11 - Verify that subsequent edits use only full form
12 - Verify that data on form submitted is the data saved to patron
13 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries)

Followed test plan, works as expected.
Re-tested together with followup, works as expected (2016-06-02)
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #47 from Jonathan Druart  
---
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #46 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #42)
> The mandatory fields show up nicely, but I have problems using the new
> PatronQuickAddFields for adding additional fields. The fields are not
> showing up.

I got my equalities mixed up, fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

  Attachment #51961|0   |1
is obsolete||

--- Comment #44 from Nick Clemens  ---
Created attachment 52585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52585=edit
Bug 3534 - QA Followup - use floating save

I am not sure if this is desired, it makes sense for consistency but
floats in a wierd place for a short form.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52192|0   |1
is obsolete||

--- Comment #45 from Nick Clemens  ---
Created attachment 52586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52586=edit
Bug 3534 (QA Followup) Fix indentation, show guarantor form, ignore bad data in
pref

Switch incorrect == to != when checking skipped fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

  Attachment #51960|0   |1
is obsolete||

--- Comment #43 from Nick Clemens  ---
Created attachment 52584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52584=edit
Bug 3534 - Patron quick add form

This patch adds a new system preference:
PatronQuickAddFields

When either this pref or BorrowerMandatoryField is populated this will add a
new dropdown to the bew patron toolbar.
When a category is chosen from this dropdown the fields in PatronQuickAddFields
and BorrowerMandatoryField will be displayed.
There will be a button allowing a user to switch from the quickadd to the full
form and fields will be copied between the forms when toggling.

The Quick add will only be displayed on add of a new patron, future edits
should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields
 and note the new button for adding a patron
 5 - Click the Quick add and choose a type
 6 - Only required or quick add fields should be displayed
 7 - Verify toggling forms copies information
 8 - Ensure you cannot save patron without filling required fields
 (quick add fields should be optional)
 9 - Ensure you can save patron with fields filled out
10 - Ensure that a duplicate patron brings up the duplicate/add new
buttons with full form displayed
11 - Verify that subsequent edits use only full form
12 - Verify that data on form submitted is the data saved to patron
13 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries)

Followed test plan, works as expected.
Re-tested together with followup, works as expected (2016-06-02)
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #42 from Katrin Fischer  ---
The mandatory fields show up nicely, but I have problems using the new
PatronQuickAddFields for adding additional fields. The fields are not showing
up. I have tried:
email
email|sex
email|B_address

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #41 from Nick Clemens  ---
Fixed indents, made guarantor form mandatory (and skip those fields if added)
and made sure bad data isn't processed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #40 from Nick Clemens  ---
Created attachment 52192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52192=edit
Bug 3534 (QA Followup) Fix indentation, show guarantor form, ignore bad data in
pref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #39 from Jonathan Druart  
---
QA comments:
1/ If you put a nonexisting field in the pref (test with surname|sex|xxx), you
will see "Expiry date (leave blank for auto calc):". Any ideas why?
2/ Please fix indentations in JS code
3/ It does not seem possible to display the guarantor form, is it expected?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Marc Véron  changed:

   What|Removed |Added

  Attachment #51446|0   |1
is obsolete||

--- Comment #38 from Marc Véron  ---
Created attachment 51961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51961=edit
Bug 3534 - QA Followup - use floating save

I am not sure if this is desired, it makes sense for consistency but
floats in a wierd place for a short form.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Marc Véron  changed:

   What|Removed |Added

  Attachment #51445|0   |1
is obsolete||

--- Comment #37 from Marc Véron  ---
Created attachment 51960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51960=edit
Bug 3534 - Patron quick add form

This patch adds a new system preference:
PatronQuickAddFields

When either this pref or BorrowerMandatoryField is populated this will add a
new dropdown to the bew patron toolbar.
When a category is chosen from this dropdown the fields in PatronQuickAddFields
and BorrowerMandatoryField will be displayed.
There will be a button allowing a user to switch from the quickadd to the full
form and fields will be copied between the forms when toggling.

The Quick add will only be displayed on add of a new patron, future edits
should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields
 and note the new button for adding a patron
 5 - Click the Quick add and choose a type
 6 - Only required or quick add fields should be displayed
 7 - Verify toggling forms copies information
 8 - Ensure you cannot save patron without filling required fields
 (quick add fields should be optional)
 9 - Ensure you can save patron with fields filled out
10 - Ensure that a duplicate patron brings up the duplicate/add new
buttons with full form displayed
11 - Verify that subsequent edits use only full form
12 - Verify that data on form submitted is the data saved to patron
13 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries)

Followed test plan, works as expected.
Re-tested together with followup, works as expected (2016-06-02)
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-05-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #36 from Nick Clemens  ---
(In reply to Marc Véron from comment #33)
> I re-tested, it seems that the "Save" button in the quick add form no longer
> works.
Yeah, the quick add save 'clicks' the full form save button, fixed the selector
and should work again

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-05-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

  Attachment #51389|0   |1
is obsolete||

--- Comment #34 from Nick Clemens  ---
Created attachment 51445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51445=edit
Bug 3534 - Patron quick add form

This patch adds a new system preference:
PatronQuickAddFields

When either this pref or BorrowerMandatoryField is populated this will add a
new dropdown to the bew patron toolbar.
When a category is chosen from this dropdown the fields in PatronQuickAddFields
and BorrowerMandatoryField will be displayed.
There will be a button allowing a user to switch from the quickadd to the full
form and fields will be copied between the forms when toggling.

The Quick add will only be displayed on add of a new patron, future edits
should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields
 and note the new button for adding a patron
 5 - Click the Quick add and choose a type
 6 - Only required or quick add fields should be displayed
 7 - Verify toggling forms copies information
 8 - Ensure you cannot save patron without filling required fields
 (quick add fields should be optional)
 9 - Ensure you can save patron with fields filled out
10 - Ensure that a duplicate patron brings up the duplicate/add new
buttons with full form displayed
11 - Verify that subsequent edits use only full form
12 - Verify that data on form submitted is the data saved to patron
13 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries)

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-05-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #35 from Nick Clemens  ---
Created attachment 51446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51446=edit
Bug 3534 - QA Followup - use floating save

I am not sure if this is desired, it makes sense for consistency but
floats in a wierd place for a short form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #33 from Marc Véron  ---
I re-tested, it seems that the "Save" button in the quick add form no longer
works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

  Attachment #51382|0   |1
is obsolete||

--- Comment #32 from Nick Clemens  ---
Created attachment 51389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51389=edit
Bug 3534 - Patron quick add form

This patch adds a new system preference:
PatronQuickAddFields

When either this pref or BorrowerMandatoryField is populated this will add a
new dropdown to the bew patron toolbar.
When a category is chosen from this dropdown the fields in PatronQuickAddFields
and BorrowerMandatoryField will be displayed.
There will be a button allowing a user to switch from the quickadd to the full
form and fields will be copied between the forms when toggling.

The Quick add will only be displayed on add of a new patron, future edits
should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields
 and note the new button for adding a patron
 5 - Click the Quick add and choose a type
 6 - Only required or quick add fields should be displayed
 7 - Verify toggling forms copies information
 8 - Ensure you cannot save patron without filling required fields
 (quick add fields should be optional)
 9 - Ensure you can save patron with fields filled out
10 - Ensure that a duplicate patron brings up the duplicate/add new
buttons with full form displayed
11 - Verify that subsequent edits use only full form
12 - Verify that data on form submitted is the data saved to patron
13 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries)

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

  Attachment #50665|0   |1
is obsolete||
  Attachment #50666|0   |1
is obsolete||
  Attachment #50729|0   |1
is obsolete||

--- Comment #31 from Nick Clemens  ---
Created attachment 51382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51382=edit
Bug 3534 - Patron quick add form

This patch adds a new system preference:
PatronQuickAddFields

When either this pref or BorrowerMandatoryField is populated this will add a
new dropdown to the bew patron toolbar.
When a category is chosen from this dropdown the fields in PatronQuickAddFields
and BorrowerMandatoryField will be displayed.
There will be a button allowing a user to switch from the quickadd to the full
form and fields will be copied between the forms when toggling.

The Quick add will only be displayed on add of a new patron, future edits
should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields
 and note the new button for adding a patron
 5 - Click the Quick add and choose a type
 6 - Only required or quick add fields should be displayed
 7 - Verify toggling forms copies information
 8 - Ensure you cannot save patron without filling required fields
 (quick add fields should be optional)
 9 - Ensure you can save patron with fields filled out
10 - Ensure that a duplicate patron brings up the duplicate/add new
buttons with full form displayed
11 - Verify that subsequent edits use only full form
12 - Verify that data on form submitted is the data saved to patron
13 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries)

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-05-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Patch doesn't apply

--- Comment #30 from Owen Leonard  ---
Nick, could I get you to rebase your patches? After that I'll see about fixing
up mine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #29 from Owen Leonard  ---
Nick, something I noticed while re-working my patch: If you start an add using
the quick add form but there is a problem (for instance, a duplicate card
number) the form is redisplayed in its full form. Shouldn't it show the brief
form instead?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #28 from Owen Leonard  ---
(In reply to Nick Clemens from comment #27)
> Are you thinking the user should
> be able to toggle even when not coming from the 'Quick add new patron'
> button?

No, just sloppiness on my part.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #27 from Nick Clemens  ---
(In reply to Owen Leonard from comment #26)
> Created attachment 50729 [details] [review]
> Bug 3534 [Follow-up] Patron quick add form

+[% IF quickadd && opadd %]
+
Show full form
+ Show brief form
+[% ELSE %]
+ Show full form
+ Show brief form
+[% END %]

This makes the toggle button show up on edits and form checks, but the
quick-add isn't built in those scenarios. Are you thinking the user should be
able to toggle even when not coming from the 'Quick add new patron' button?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #26 from Owen Leonard  ---
Created attachment 50729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50729=edit
Bug 3534 [Follow-up] Patron quick add form

This follow-up move the full/quick add toggle control to the top of the
patron entry form, reformating it as a link with a Font Awesome icon

The previous patch defined a new $(document).ready() block. This patch
moves that code into the existing $(document).ready() to keep things
organized.

This patch also makes some minor corrections to the markup, converting
some single quotes in HTML to double, and correcting capitalization.

To test, apply the patch and follow the original test plan. Confirm that
the toggle between full and brief form works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #25 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #24)
> (In reply to Jonathan Druart from comment #18)
> > Maybe it would be better not to have it but always add the switch button
> > ("Quick-add/Full form") on the add patron form (and move it to the top).
> 
> Nick, what do you think about this suggestion?

I like moving it to the top, but I am unsure about always defaulting to full
form.  I would want to check with the sponsors, let me see if I can get an
answer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #24 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #18)
> Maybe it would be better not to have it but always add the switch button
> ("Quick-add/Full form") on the add patron form (and move it to the top).

Nick, what do you think about this suggestion?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #23 from Nick Clemens  ---
Moved button and fixed case
Restricted whitespace to affected lines (and set my git user.name and
user.email)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

  Attachment #50414|0   |1
is obsolete||

--- Comment #22 from Nick Clemens  ---
Created attachment 50666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50666=edit
Bug 3534 - (QA followup) whitespace fixes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

  Attachment #50413|0   |1
is obsolete||

--- Comment #21 from Nick Clemens  ---
Created attachment 50665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50665=edit
Bug 3534 - Patron quick add form

This patch adds a new system preference:
PatronQuickAddFields

When either this pref or BorrowerMandatoryField is populated this will add a
new dropdown to the bew patron toolbar.
When a category is chosen from this dropdown the fields in PatronQuickAddFields
and BorrowerMandatoryField will be displayed.
There will be a button allowing a user to switch from the quickadd to the full
form and fields will be copied between the forms when toggling.

The Quick add will only be displayed on add of a new patron, future edits
should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields
 and note the new button for adding a patron
 5 - Click the Quick add and choose a type
 6 - Only required or quick add fields should be displayed
 7 - Verify toggling forms copies information
 8 - Ensure you cannot save patron without filling required fields
 (quick add fields should be optional)
 9 - Ensure you can save patron with fields filled out
10 - Ensure that a duplicate patron brings up the duplicate/add new
buttons with full form displayed
11 - Verify that subsequent edits use only full form
12 - Verify that data on form submitted is the data saved to patron
13 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries)

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #20 from Owen Leonard  ---
I suggested on IRC the separate button menu for "Quick add" because the version
of the patch I tested made the quick add action default if PatronQuickAddFields
were defined. I thought it was important that staff be able to choose to do a
full add if they chose to.

The two buttons do look awkward, though. Maybe that wasn't a good idea. I'm not
sure what the solution is. I'm going to 

The quick add button should at least be next to the "New patron" button. And
the mixed case on the button label should be corrected.

As for the second patch, it makes changes to far more than the 4 line required
by the QA tools. We should correct whitespace on changed lines, not all lines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #19 from Jonathan Druart  
---
Also patch's author of the second patch is "Your Full Name "
A lot of patches in the queue (FQA or NSO) are modifying this file, not sure
the second patch is necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #17 from Jonathan Druart  
---
pplying: Bug 3534 - Fix tabs to spaces
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #18 from Jonathan Druart  
---
I personally don't think that the new "Quick add New Patron" is well placed.
Maybe it would be better not to have it but always add the switch button
("Quick-add/Full form") on the add patron form (and move it to the top).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #16 from Jonathan Druart  
---
(In reply to Marc Véron from comment #3)
> There was a blog entry related to this bug using jQuery for a Patron quick
> add form. As far I remember it was declared as proof of concept.
> The link was: http://www.myacpl.org/koha/category/koha/customizations/
> (Link not valid as of today)

https://www.myacpl.org/koha/quick-patron-add/

Owen, could we get your opinion on this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Marc Véron  changed:

   What|Removed |Added

  Attachment #50410|0   |1
is obsolete||

--- Comment #15 from Marc Véron  ---
Created attachment 50414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50414=edit
Bug 3534 - Fix tabs to spaces

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Marc Véron  changed:

   What|Removed |Added

  Attachment #50362|0   |1
is obsolete||

--- Comment #14 from Marc Véron  ---
Created attachment 50413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50413=edit
Bug 3534 - Patron quick add form

This patch adds a new system preference:
PatronQuickAddFields

When either this pref or BorrowerMandatoryField is populated this will add a
new dropdown to the bew patron toolbar.
When a category is chosen from this dropdown the fields in PatronQuickAddFields
and BorrowerMandatoryField will be displayed.
There will be a button allowing a user to switch from the quickadd to the full
form and fields will be copied between the forms when toggling.

The Quick add will only be displayed on add of a new patron, future edits
should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields
 and note the new button for adding a patron
 5 - Click the Quick add and choose a type
 6 - Only required or quick add fields should be displayed
 7 - Verify toggling forms copies information
 8 - Ensure you cannot save patron without filling required fields
 (quick add fields should be optional)
 9 - Ensure you can save patron with fields filled out
10 - Ensure that a duplicate patron brings up the duplicate/add new
buttons with full form displayed
11 - Verify that subsequent edits use only full form
12 - Verify that data on form submitted is the data saved to patron
13 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries)

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #13 from Nick Clemens  ---
Created attachment 50410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50410=edit
Bug 3534 - Fix tabs to spaces

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #12 from Marc Véron  ---
Works great now,
However QA tools complain:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
   FAIL   forbidden patterns
forbidden pattern: tab char (line 277)
forbidden pattern: tab char (line 840)
forbidden pattern: tab char (line 272)
forbidden pattern: tab char (line 831)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #11 from Nick Clemens  ---
(In reply to Marc Véron from comment #9)
> Great feature! 
> But I have a problem when toggling between Quick add and Full form:

Fields should now populate when toggling between forms, quick add is now a
choice from patron toolbar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

  Attachment #50093|0   |1
is obsolete||

--- Comment #10 from Nick Clemens  ---
Created attachment 50362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50362=edit
Bug 3534 - Patron quick add form

This patch adds a new system preference:
PatronQuickAddFields

When either this pref or BorrowerMandatoryField is populated this will add a
new dropdown to the bew patron toolbar.
When a category is chosen from this dropdown the fields in PatronQuickAddFields
and BorrowerMandatoryField will be displayed.
There will be a button allowing a user to switch from the quickadd to the full
form and fields will be copied between the forms when toggling.

The Quick add will only be displayed on add of a new patron, future edits
should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields
 and note the new button for adding a patron
 5 - Click the Quick add and choose a type
 6 - Only required or quick add fields should be displayed
 7 - Verify toggling forms copies information
 8 - Ensure you cannot save patron without filling required fields
 (quick add fields should be optional)
 9 - Ensure you can save patron with fields filled out
10 - Ensure that a duplicate patron brings up the duplicate/add new
buttons with full form displayed
11 - Verify that subsequent edits use only full form
12 - Verify that data on form submitted is the data saved to patron
13 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #9 from Marc Véron  ---
Great feature! 
But I have a problem when toggling between Quick add and Full form:

To reproduce:

Madatory fields:
surname|firstname|cardnumber

PatronQuickAdd: Use
PatronQuickAddFields (none)

autoMemberNum: Do  default the card number field on the patron addition screen
to the next available card number 

Go to /cgi-bin/koha/members/members-home.pl
Hit "New Patron" and choose 

Quick add form displays as expected

Enter Surname AAA, First name BBB, Change card number from automatically
generated value to other value, Change patron category e.g. from Child to Adult

Toggle to Full form (Button "Quick-add/Full form)

Result: 
Fields Surname and First name are empty, card number is set back to
automatically generated value, patron category is reset to Child.


Toggle back to quick form
Result:
Values entered in quick add form re-appear.

Possible solution:
- Replace toggling function "Quick-add/Full form" by: "Save and edit in full
form"
- In /cgi-bin/koha/members/members-home.pl, provide a choice to use "Quick add"
or "Full form"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Owen Leonard  changed:

   What|Removed |Added

   Assignee|jwea...@bywatersolutions.co |n...@bywatersolutions.com
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

  Attachment #50092|0   |1
is obsolete||

--- Comment #8 from Nick Clemens  ---
Created attachment 50093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50093=edit
Bug 3534 - Patron quick add form

This patch adds two new system preferences:
PatronQuickAdd
PatronQuickAddFields

When enabled the pref will add a new form to memberentrygen composed of
the fields in PatronQuickAddFields and BorrowerMandatoryField. There
will be a button allowing a user to switch from the quickadd to the full
form.

The Quick add will only be displayed on add of a new patron,
future edits should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Enable quick add (do not add any fields)
 5 - Only required fields should be displayed
 6 - Ensure you can save patron
 7 - Verify that subsequent edits use only full form
 8 - Verify that data on form submitted is the data saved to patron
 9 - Add fields to PatronQuickAddFields
10 - check that fields are present in quick add form
11 - Ensure that you can save patron
12 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

  Attachment #50091|0   |1
is obsolete||

--- Comment #7 from Nick Clemens  ---
Created attachment 50092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50092=edit
Bug 3534 - Patron quick add form

This patch adds two new system preferences:
PatronQuickAdd
PatronQuickAddFields

When enabled the pref will add a new form to memberentrygen composed of
the fields in PatronQuickAddFields and BorrowerMandatoryField. There
will be a button allowing a user to switch from the quickadd to the full
form.

The Quick add will only be displayed on add of a new patron,
future edits should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Enable quick add (do not add any fields)
 5 - Only required fields should be displayed
 6 - Ensure you can save patron
 7 - Verify that subsequent edits use only full form
 8 - Verify that data on form submitted is the data saved to patron
 9 - Add fields to PatronQuickAddFields
10 - check that fields are present in quick add form
11 - Ensure that you can save patron
12 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Nick Clemens  changed:

   What|Removed |Added

  Attachment #50090|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 50091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50091=edit
Bug 3534 - Patron quick add form

This patch adds two new system preferences:
PatronQuickAdd
PatronQuickAddFields

When enabled the pref will add a new form to memberentrygen composed of
the fields in PatronQuickAddFields and BorrowerMandatoryField. There
will be a button allowing a user to switch from the quickadd to the full
form.

The Quick add will only be displayed on add of a new patron,
future edits should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Enable quick add (do not add any fields)
 5 - Only required fields should be displayed
 6 - Ensure you can save patron
 7 - Verify that subsequent edits use only full form
 8 - Verify that data on form submitted is the data saved to patron
 9 - Add fields to PatronQuickAddFields
10 - check that fields are present in quick add form
11 - Ensure that you can save patron
12 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2016-04-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

--- Comment #5 from Nick Clemens  ---
Created attachment 50090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50090=edit
Bug 3534 - Patron quick add form

This patch adds two new system preferences:
PatronQuickAdd
PatronQuickAddFields

When enabled the pref will add a new form to memberentrygen composed of
the fields in PatronQuickAddFields and BorrowerMandatoryField. There
will be a button allowing a user to switch from the quickadd to the full
form.

The Quick add will only be displayed on add of a new patron,
future edits should display the full form.

Test plan:
 1 - Apply patch
 2 - run updatedatabase.pl
 3 - Add a new patron and ensure nothing has changed
 4 - Enable quick add (do not add any fields)
 5 - Only required fields should be displayed
 6 - Ensure that values are populated when swtiching forms
 7 - Ensure you can save patron
 8 - Verify that subsequent edits use only full form
 9 - Add fields to PatronQuickAddFields
10 - check that fields are present in quick add form
11 - Ensure that you can save patron
12 - Test with various values in both MandatoryBorrowerFields and
PatronQuickAddFields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2015-11-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Jesse Weaver  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 CC||jwea...@bywatersolutions.co
   ||m,
   ||nic...@bywatersolutions.com
 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |jwea...@bywatersolutions.co
   ||m

--- Comment #4 from Jesse Weaver  ---
We have received sponsorship for the following approach:

a) Add a new system preference "PatronQuickAddFields"
b) In this new preference we would list the fields to be in the quick add form
( similar to the list of required fields system preference )
c) When displaying the "new patron" form in quick add mode, all fields that are
not mandatory or not listed in PatronQuickAddFields will be hidden

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2014-09-11 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #3 from Marc Véron ve...@veron.ch ---
There was a blog entry related to this bug using jQuery for a Patron quick add
form. As far I remember it was declared as proof of concept.
The link was: http://www.myacpl.org/koha/category/koha/customizations/
(Link not valid as of today)

I tested the jQuery code in early 2012 and re-tested it today with current
master by putting it into intranetuserjs system preference. It is not really a
solution for this enhancement request, but it still works nice. That's why I
put it here.

$(document).ready(function(){
var list = fieldset class=\rows\legendQuick Addol;
$(label.required).each(function(){
item = $(this).parent().html()
item = li+item+/li;
list += item;
});
list += /ol/fieldsetfieldset class=\action\input type=\submit\
value=\Save\ onclick=\return check_form_borrowers();\ name=\save\/a
href=\/cgi-bin/koha/members/member.pl\
class=\cancel\Cancel/a/fieldset;
$(#entryform).prepend(list);
});

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2014-08-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

jdem...@roseville.ca.us jdem...@roseville.ca.us changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3534] Patron quick add form

2013-04-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Version|rel_3_2 |master
  Change sponsored?|Sponsored   |---
Summary|Rearrange   |Patron quick add form
   |memberentrygen.tmpl for |
   |quick add   |

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Rephrasing bug description and changing version.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

96 matches

Mail list logo