[Koha-bugs] [Bug 35414] Silence warn related to number_of_copies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35414 Lucas Gass changed: What|Removed |Added Version(s)|24.05.00,23.11.01 |24.05.00,23.11.01,23.05.07 released in|| CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable --- Comment #7 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35414] Silence warn related to number_of_copies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35414 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|24.05.00|24.05.00,23.11.01 released in|| CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35414] Silence warn related to number_of_copies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35414 --- Comment #5 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35414] Silence warn related to number_of_copies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35414 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35414] Silence warn related to number_of_copies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35414 Marcel de Rooy changed: What|Removed |Added Attachment #159365|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 159425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159425=edit Bug 35414: Silence warn related to number_of_copies To test in ktd: - Tail the logs with "sudo tail -f /var/log/koha/kohadev/plack*.log" - Find a record in the staff client - Add an item to the record - Observe "[WARN] Argument "" isn't numeric in subroutine entry ..." in /var/log/koha/kohadev/plack-intranet-error.log - Apply this patch - restart_all - Tail the logs again - Add another item - Observe the absence of the earlier warning Thanks to Jonathan Druart for suggesting this particular solution! Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35414] Silence warn related to number_of_copies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35414 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35414] Silence warn related to number_of_copies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35414 Owen Leonard changed: What|Removed |Added Attachment #159338|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 159365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159365=edit Bug 35414: Silence warn related to number_of_copies To test in ktd: - Tail the logs with "sudo tail -f /var/log/koha/kohadev/plack*.log" - Find a record in the staff client - Add an item to the record - Observe "[WARN] Argument "" isn't numeric in subroutine entry ..." in /var/log/koha/kohadev/plack-intranet-error.log - Apply this patch - restart_all - Tail the logs again - Add another item - Observe the absence of the earlier warning Thanks to Jonathan Druart for suggesting this particular solution! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35414] Silence warn related to number_of_copies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35414 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35414] Silence warn related to number_of_copies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35414 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mag...@libriotech.no |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35414] Silence warn related to number_of_copies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35414 --- Comment #2 from Magnus Enger --- Created attachment 159338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159338=edit Bug 35414: Silence warn related to number_of_copies To test in ktd: - Tail the logs with "sudo tail -f /var/log/koha/kohadev/plack*.log" - Find a record in the staff client - Add an item to the record - Observe "[WARN] Argument "" isn't numeric in subroutine entry ..." in /var/log/koha/kohadev/plack-intranet-error.log - Apply this patch - restart_all - Tail the logs again - Add another item - Observe the absence of the earlier warning Thanks to Jonathan Druart for suggesting this particular solution! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35414] Silence warn related to number_of_copies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35414 Magnus Enger changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35414] Silence warn related to number_of_copies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35414
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail.
||com
--- Comment #1 from Jonathan Druart ---
I would do this:
-my $number_of_copies = min( scalar
$input->param('number_of_copies'), 1000 ); # TODO refine hardcoded maximum?
+my $number_of_copies = min( $input->param('number_of_copies') ||
0, 1000 ); # TODO refine hardcoded maximum?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
