[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 Baptiste changed: What|Removed |Added Attachment #165013|0 |1 is obsolete|| --- Comment #13 from Baptiste --- Created attachment 166641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166641=edit Bug 35508: Move logic to Koha::Patron::Attribute::store() Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 Baptiste changed: What|Removed |Added Attachment #165012|0 |1 is obsolete|| --- Comment #12 from Baptiste --- Created attachment 166640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166640=edit Bug 35508: Update borrowers.updated_on when modifying a patron's attribute Currently, if you have patron attributes and modify the values in a patron's account, the patron's updated_on date is not updated. This patch makes the "Updated on" change when a patron attribute is updated. To test: 1. Create a patron attribute type 1.1. Go to Administration > Patron attribute types 1.2. Click New patron attribute 1.3. Fill out the code and description 1.4. Click Save 2. Edit a patron (normal) 2.1. Go to Patrons and find a patron account 2.2. Click Edit 2.3. Change a regular field (e.g. Middle name) 2.4. Click Save --> Notice the "Updated on" date in the left column has been updated to now 3. Edit a patron attribute 3.1. In another patron account*, click Edit 3.2. Change the value of an attribute 3.3. Click Save --> Notice the "Updated on" date did not change 4. Apply the patch 4.1 Repeat step 3.1, 3.2, 3.3 --> Notice the "Updated on" date has now changed Signed-off-by: Esther Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 Katrin Fischer changed: What|Removed |Added Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 Katrin Fischer changed: What|Removed |Added Keywords||rel_24_05_candidate Status|Passed QA |Failed QA --- Comment #11 from Katrin Fischer --- (In reply to Kyle M Hall from comment #8) > The general consensus at the developers meeting was to move ahead with this! Great example for how we can use the meetings/Mattermost to resolve questions like this. :) I agree that we should log changes to patron attributes as changes to the patron, but I believe this patches currently have an unintended side-effect: Pre-patch: * Edit a patron record, save without changes: updated_on is unchanged. With these patches: * Edit a patron record, save without any changed: updated_on is changed. I know we just had some similar issues on bug 26744. Maybe some of that could be useful here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 --- Comment #10 from Kyle M Hall --- Created attachment 165013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165013=edit Bug 35508: Move logic to Koha::Patron::Attribute::store() Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 Kyle M Hall changed: What|Removed |Added Attachment #159895|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 165012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165012=edit Bug 35508: Update borrowers.updated_on when modifying a patron's attribute Currently, if you have patron attributes and modify the values in a patron's account, the patron's updated_on date is not updated. This patch makes the "Updated on" change when a patron attribute is updated. To test: 1. Create a patron attribute type 1.1. Go to Administration > Patron attribute types 1.2. Click New patron attribute 1.3. Fill out the code and description 1.4. Click Save 2. Edit a patron (normal) 2.1. Go to Patrons and find a patron account 2.2. Click Edit 2.3. Change a regular field (e.g. Middle name) 2.4. Click Save --> Notice the "Updated on" date in the left column has been updated to now 3. Edit a patron attribute 3.1. In another patron account*, click Edit 3.2. Change the value of an attribute 3.3. Click Save --> Notice the "Updated on" date did not change 4. Apply the patch 4.1 Repeat step 3.1, 3.2, 3.3 --> Notice the "Updated on" date has now changed Signed-off-by: Esther Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 --- Comment #8 from Kyle M Hall --- The general consensus at the developers meeting was to move ahead with this! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33997 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 --- Comment #7 from Caroline Cyr La Rose --- Also I think that end users don't see a difference between normal patron fields and patron attributes. We show the updated_on date in the left-hand column, so I think it would be logical (again, from end user pov) that this date be updated when we update a patron attribute. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 --- Comment #6 from Caroline Cyr La Rose --- Just pasting here what I said in the chat, to provide context The need behind this is that we have a client who is linking their patron account to an external system. We added a lot of patron attributes for them because it's a special library and they need specific information. They need their other system to be "triggered" when a patron is modified in Koha, either normal patron fields or patron attributes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #5 from Tomás Cohen Arazi --- I understand the proposal and the motivation. I've added this topic to next dev meeting's agenda [1] for broader discussion. [1] https://wiki.koha-community.org/wiki/Development_IRC_meeting_17_April_2024 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 --- Comment #4 from Blou --- Interesting. But after thinking about it, I do not see it really as a problem. updated_on is meant to tell when a patron was modified, imo, not tell us that a physical alignment on the hard drive was modified. Attributes are just extensions of the borrower table. Adding a field would make some reports really convoluted, and unsortable. It IS a solution, but doesn't seem optimal to me. Adding unnecessary complexity (imo). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #3 from Kyle M Hall --- I'm not sure about this. That columns is really meant to indicate the last time this particular row of this particular table was altered. What do you think of adding an "attributes_updated_on" column to the borrowers table for this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 Esther Melander changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||esther.melander@bywatersolu ||tions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 ByWater Sandboxes changed: What|Removed |Added Attachment #159838|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 159895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159895=edit Bug 35508: Update borrowers.updated_on when modifying a patron's attribute Currently, if you have patron attributes and modify the values in a patron's account, the patron's updated_on date is not updated. This patch makes the "Updated on" change when a patron attribute is updated. To test: 1. Create a patron attribute type 1.1. Go to Administration > Patron attribute types 1.2. Click New patron attribute 1.3. Fill out the code and description 1.4. Click Save 2. Edit a patron (normal) 2.1. Go to Patrons and find a patron account 2.2. Click Edit 2.3. Change a regular field (e.g. Middle name) 2.4. Click Save --> Notice the "Updated on" date in the left column has been updated to now 3. Edit a patron attribute 3.1. In another patron account*, click Edit 3.2. Change the value of an attribute 3.3. Click Save --> Notice the "Updated on" date did not change 4. Apply the patch 4.1 Repeat step 3.1, 3.2, 3.3 --> Notice the "Updated on" date has now changed Signed-off-by: Esther -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 Hammat wele changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 --- Comment #1 from Hammat wele --- Created attachment 159838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159838=edit Bug 35508: Update borrowers.updated_on when modifying a patron's attribute Currently, if you have patron attributes and modify the values in a patron's account, the patron's updated_on date is not updated. This patch makes the "Updated on" change when a patron attribute is updated. To test: 1. Create a patron attribute type 1.1. Go to Administration > Patron attribute types 1.2. Click New patron attribute 1.3. Fill out the code and description 1.4. Click Save 2. Edit a patron (normal) 2.1. Go to Patrons and find a patron account 2.2. Click Edit 2.3. Change a regular field (e.g. Middle name) 2.4. Click Save --> Notice the "Updated on" date in the left column has been updated to now 3. Edit a patron attribute 3.1. In another patron account*, click Edit 3.2. Change the value of an attribute 3.3. Click Save --> Notice the "Updated on" date did not change 4. Apply the patch 4.1 Repeat step 3.1, 3.2, 3.3 --> Notice the "Updated on" date has now changed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 Hammat wele changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 Hammat wele changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |hammat.w...@inlibro.com |ity.org | CC||hammat.w...@inlibro.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
