[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to main |Needs documenting --- Comment #68 from Fridolin Somers --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Katrin Fischer changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Tomás Cohen Arazi changed: What|Removed |Added Blocks||36419 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36419 [Bug 36419] Ambiguous return value in GetPlugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #67 from Katrin Fischer --- Second follow-up is on my branch, will push with the next batch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #66 from Marcel de Rooy --- Created attachment 163797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163797=edit Bug 35536: (follow-up) Fix Plugins.t for D10 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Katrin Fischer changed: What|Removed |Added Keywords|additional_work_needed, | |roadmap_24_05 | --- Comment #65 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #64) > Thx Tomas. > Does this need an additional keyword to attract RM attention? > Trying: additional_work_needed :) No need, it was already pushed last week. The automatic script doesn't update the bugs with the wrong status - I forgot to do it manually. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Keywords||additional_work_needed --- Comment #64 from Marcel de Rooy --- Thx Tomas. Does this need an additional keyword to attract RM attention? Trying: additional_work_needed :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #63 from Tomás Cohen Arazi --- Created attachment 163701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163701=edit Bug 35536: (follow-up) Add missing koha_object(s)_class definitions Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #62 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #61 from Marcel de Rooy --- Back to PQA. Test seems to fail with Elastic without this patch set too. Submitted a fix on 36397 btw. Could go along with pushing this set.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36397 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #60 from Katrin Fischer --- I applied the patches minus the last one and ran QA tools, unit tests are not passing: * Proving /kohadevbox/koha/t/db_dependent/Koha/Plugins/authority_hooks.t KO! # Failed test 'AddAuthority calls the hook with action=create, id passed' # at /kohadevbox/koha/t/db_dependent/Koha/Plugins/authority_hooks.t line 57. # found warning: Cannot determine authority type for record: 1740 at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch.pm line 573. # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'after_authority_action called with action: create, id: 1740' # expected to find warning: (?^u:after_authority_action called with action: create, id: \d+) # Failed test 'ModAuthority calls the hook with action=modify, id passed' # at /kohadevbox/koha/t/db_dependent/Koha/Plugins/authority_hooks.t line 61. # found warning: Cannot determine authority type for record: 1740 at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch.pm line 573. # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'after_authority_action called with action: modify, id: 1740' # expected to find warning: (?^u:after_authority_action called with action: modify, id: 1740) # Looks like you failed 2 tests of 3. # Failed test 'after_authority_action hook' # at /kohadevbox/koha/t/db_dependent/Koha/Plugins/authority_hooks.t line 70. # Looks like you failed 1 test of 4. /kohadevbox/koha/t/db_dependent/Koha/Plugins/authority_hooks.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/4 subtests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #59 from Tomás Cohen Arazi --- I love this. Thank Marcel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #58 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #56) > Signed-off-by: Kyle M Hall Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #57 from Kyle M Hall --- Only "issue" is the use of Data/Datas instead of Datum/Data or something less confusing than Datum/Data. I don't consider this a blocker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #56 from Kyle M Hall --- Created attachment 160889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160889=edit Bug 35536: DO NOT PUSH !!! - Example plugin After applying patch, run: perl -MKoha::Plugins -e"Koha::Plugin->new->InstallPlugins" This installs the TestMR plugin. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #55 from Kyle M Hall --- Created attachment 160888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160888=edit Bug 35536: Remove last two references to resultset PluginData Test plan: Run t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #54 from Kyle M Hall --- Created attachment 160887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160887=edit Bug 35536: Silence tests when run from koha-qa.pl Extending the regex in Plugins::_verbose. Test plan: Run qa tools on patch set. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #53 from Kyle M Hall --- Created attachment 160886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160886=edit Bug 35536: Refine verbose handling in some Koha::Plugins calls Three routines in Plugins got the verbose parameter on 35507. We can refine this a bit further. The idea here is report when you are installing plugins but not report when just calling plugins (flooding logs). [1] GetPlugins: Most callers do not expect (or check) results for failing plugins. This patch makes GetPlugins only return errors when passing the *errors* flag (in 2 cases). [a] The misc/devel script prints warnings now using verbose, so does not need the errors flag anymore. [b] plugins/plugins-home is the only case left. Tiny adjustment to keep current behavior. Fixed colspan in template. Does not need verbose in favor of 'errors' (passed to template). [c] For most calls we do not want verbose. New default is 0. [2] InstallPlugins [a] Disabled verbose in plugin-upload. Not really needed. Added a FIXME; we need to improve individual install. [b] misc/devel: No warnings anymore when calling InstallPlugins after GetPlugins. [3] get_enabled_plugins [a] Plugins->call does not need verbose. [b] Plugins->feature_enabled does not need it too. Test plan: [1] See previous plan. With TestMR data but without patch, run misc script and go to plugins-home. Do you see load errors on commandline or form? [2] Run plugins/plugins-upload (uploading just some file is good enough); verify that you do not see TestMR lines in logfile. [3] Run t/db_dependent/Koha/Plugins/Plugins.t for the additional test on verbose and errors flag. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #52 from Kyle M Hall --- Created attachment 160885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160885=edit Bug 35536: Reorder rollbacks Time to move all RemovePlugins calls BEFORE rollbacks. Broken.t did not even include a transaction! Some modules are removed there as well. Test plan: Search for wrong order with: grep -Pzo "txn_rollback;\n.*RemovePlugins" $(git grep -l RemovePlugins) No occurrences left? Think of another grep :) Check number of records in plugin_data/methods. Repeat: prove $(git grep -l Koha::Plugin | grep -P "^t\/db") And check number of records again. Same? Bonus: Apply TestMR plugin patch (marked DO NOT PUSH). Run perl -MKoha::Plugins -e"Koha::Plugins->new->InstallPlugins". Check plugin records in database. Keep those records but remove last patch from git. Run previous prove and verify no data changes since last check. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536
--- Comment #51 from Kyle M Hall ---
Created attachment 160884
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160884=edit
Bug 35536: Add RemovePlugins calls in plugin unit tests
[1] Replace Methods->delete by RemovePlugins.
git grep -l "Plugins::Methods->delete" | xargs sed -i
-e's/Plugins::Methods->delete/Plugins->RemovePlugins/g'
[2] Replace $schema->resultset('PluginData')->delete by destructive parameter.
[3] Add RemovePlugins too in Handler->delete too. Note that this call
might be better off with disable? Added a comment.
Test plan:
prove $(git grep -l Koha::Plugin | grep -P "^t\/db")
Signed-off-by: Marcel de Rooy
Signed-off-by: Martin Renvoize
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #50 from Kyle M Hall --- Created attachment 160883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160883=edit Bug 35536: Add Koha::Plugins->RemovePlugins class method Test plan: Run t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #49 from Kyle M Hall --- Created attachment 160882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160882=edit Bug 35536: Add Koha object classes for plugin_data Test plan: Read the patch. The objects will be used in subsequent patches, and tested there. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Kyle M Hall changed: What|Removed |Added Attachment #160817|0 |1 is obsolete|| Attachment #160818|0 |1 is obsolete|| Attachment #160819|0 |1 is obsolete|| Attachment #160820|0 |1 is obsolete|| Attachment #160821|0 |1 is obsolete|| Attachment #160822|0 |1 is obsolete|| Attachment #160823|0 |1 is obsolete|| Attachment #160824|0 |1 is obsolete|| Attachment #160825|0 |1 is obsolete|| --- Comment #48 from Kyle M Hall --- Created attachment 160881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160881=edit Bug 35536: Reorganize Plugins.t Move stuff in the middle into new subtest. Add transaction around second set of subtests. Test plan: t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #47 from Martin Renvoize --- This is great, and all works nice and consistently so I'm signing off. With my QA hat on.. I slightly wonder about the new Koha:: class names.. 'Data' and 'Datas' should strictly (according to british english at least) be 'Datum' and 'Data'... but I'm not sure if that's more or less confusing at the end of the day (I couldn't come up with a synonym that had a nicer plural either :( ) This is a real step forward though in my book. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Martin Renvoize changed: What|Removed |Added Attachment #160809|0 |1 is obsolete|| --- Comment #46 from Martin Renvoize --- Created attachment 160825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160825=edit Bug 35536: DO NOT PUSH !!! - Example plugin After applying patch, run: perl -MKoha::Plugins -e"Koha::Plugin->new->InstallPlugins" This installs the TestMR plugin. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Martin Renvoize changed: What|Removed |Added Attachment #160808|0 |1 is obsolete|| --- Comment #45 from Martin Renvoize --- Created attachment 160824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160824=edit Bug 35536: Remove last two references to resultset PluginData Test plan: Run t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Martin Renvoize changed: What|Removed |Added Attachment #160807|0 |1 is obsolete|| --- Comment #44 from Martin Renvoize --- Created attachment 160823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160823=edit Bug 35536: Silence tests when run from koha-qa.pl Extending the regex in Plugins::_verbose. Test plan: Run qa tools on patch set. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Martin Renvoize changed: What|Removed |Added Attachment #160806|0 |1 is obsolete|| --- Comment #43 from Martin Renvoize --- Created attachment 160822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160822=edit Bug 35536: Refine verbose handling in some Koha::Plugins calls Three routines in Plugins got the verbose parameter on 35507. We can refine this a bit further. The idea here is report when you are installing plugins but not report when just calling plugins (flooding logs). [1] GetPlugins: Most callers do not expect (or check) results for failing plugins. This patch makes GetPlugins only return errors when passing the *errors* flag (in 2 cases). [a] The misc/devel script prints warnings now using verbose, so does not need the errors flag anymore. [b] plugins/plugins-home is the only case left. Tiny adjustment to keep current behavior. Fixed colspan in template. Does not need verbose in favor of 'errors' (passed to template). [c] For most calls we do not want verbose. New default is 0. [2] InstallPlugins [a] Disabled verbose in plugin-upload. Not really needed. Added a FIXME; we need to improve individual install. [b] misc/devel: No warnings anymore when calling InstallPlugins after GetPlugins. [3] get_enabled_plugins [a] Plugins->call does not need verbose. [b] Plugins->feature_enabled does not need it too. Test plan: [1] See previous plan. With TestMR data but without patch, run misc script and go to plugins-home. Do you see load errors on commandline or form? [2] Run plugins/plugins-upload (uploading just some file is good enough); verify that you do not see TestMR lines in logfile. [3] Run t/db_dependent/Koha/Plugins/Plugins.t for the additional test on verbose and errors flag. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Martin Renvoize changed: What|Removed |Added Attachment #160805|0 |1 is obsolete|| --- Comment #42 from Martin Renvoize --- Created attachment 160821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160821=edit Bug 35536: Reorder rollbacks Time to move all RemovePlugins calls BEFORE rollbacks. Broken.t did not even include a transaction! Some modules are removed there as well. Test plan: Search for wrong order with: grep -Pzo "txn_rollback;\n.*RemovePlugins" $(git grep -l RemovePlugins) No occurrences left? Think of another grep :) Check number of records in plugin_data/methods. Repeat: prove $(git grep -l Koha::Plugin | grep -P "^t\/db") And check number of records again. Same? Bonus: Apply TestMR plugin patch (marked DO NOT PUSH). Run perl -MKoha::Plugins -e"Koha::Plugins->new->InstallPlugins". Check plugin records in database. Keep those records but remove last patch from git. Run previous prove and verify no data changes since last check. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536
Martin Renvoize changed:
What|Removed |Added
Attachment #160804|0 |1
is obsolete||
--- Comment #41 from Martin Renvoize ---
Created attachment 160820
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160820=edit
Bug 35536: Add RemovePlugins calls in plugin unit tests
[1] Replace Methods->delete by RemovePlugins.
git grep -l "Plugins::Methods->delete" | xargs sed -i
-e's/Plugins::Methods->delete/Plugins->RemovePlugins/g'
[2] Replace $schema->resultset('PluginData')->delete by destructive parameter.
[3] Add RemovePlugins too in Handler->delete too. Note that this call
might be better off with disable? Added a comment.
Test plan:
prove $(git grep -l Koha::Plugin | grep -P "^t\/db")
Signed-off-by: Marcel de Rooy
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Martin Renvoize changed: What|Removed |Added Attachment #160803|0 |1 is obsolete|| --- Comment #40 from Martin Renvoize --- Created attachment 160819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160819=edit Bug 35536: Add Koha::Plugins->RemovePlugins class method Test plan: Run t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Martin Renvoize changed: What|Removed |Added Attachment #160802|0 |1 is obsolete|| --- Comment #39 from Martin Renvoize --- Created attachment 160818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160818=edit Bug 35536: Add Koha object classes for plugin_data Test plan: Read the patch. The objects will be used in subsequent patches, and tested there. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Martin Renvoize changed: What|Removed |Added Attachment #160801|0 |1 is obsolete|| --- Comment #38 from Martin Renvoize --- Created attachment 160817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160817=edit Bug 35536: Reorganize Plugins.t Move stuff in the middle into new subtest. Add transaction around second set of subtests. Test plan: t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #37 from Marcel de Rooy --- Rebased. Please test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Attachment #160032|0 |1 is obsolete|| --- Comment #36 from Marcel de Rooy --- Created attachment 160809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160809=edit Bug 35536: DO NOT PUSH !!! - Example plugin After applying patch, run: perl -MKoha::Plugins -e"Koha::Plugin->new->InstallPlugins" This installs the TestMR plugin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Attachment #160031|0 |1 is obsolete|| --- Comment #35 from Marcel de Rooy --- Created attachment 160808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160808=edit Bug 35536: Remove last two references to resultset PluginData Test plan: Run t/db_dependent/Koha/Plugins/Plugins.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Attachment #160030|0 |1 is obsolete|| --- Comment #34 from Marcel de Rooy --- Created attachment 160807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160807=edit Bug 35536: Silence tests when run from koha-qa.pl Extending the regex in Plugins::_verbose. Test plan: Run qa tools on patch set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Attachment #160029|0 |1 is obsolete|| --- Comment #33 from Marcel de Rooy --- Created attachment 160806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160806=edit Bug 35536: Refine verbose handling in some Koha::Plugins calls Three routines in Plugins got the verbose parameter on 35507. We can refine this a bit further. The idea here is report when you are installing plugins but not report when just calling plugins (flooding logs). [1] GetPlugins: Most callers do not expect (or check) results for failing plugins. This patch makes GetPlugins only return errors when passing the *errors* flag (in 2 cases). [a] The misc/devel script prints warnings now using verbose, so does not need the errors flag anymore. [b] plugins/plugins-home is the only case left. Tiny adjustment to keep current behavior. Fixed colspan in template. Does not need verbose in favor of 'errors' (passed to template). [c] For most calls we do not want verbose. New default is 0. [2] InstallPlugins [a] Disabled verbose in plugin-upload. Not really needed. Added a FIXME; we need to improve individual install. [b] misc/devel: No warnings anymore when calling InstallPlugins after GetPlugins. [3] get_enabled_plugins [a] Plugins->call does not need verbose. [b] Plugins->feature_enabled does not need it too. Test plan: [1] See previous plan. With TestMR data but without patch, run misc script and go to plugins-home. Do you see load errors on commandline or form? [2] Run plugins/plugins-upload (uploading just some file is good enough); verify that you do not see TestMR lines in logfile. [3] Run t/db_dependent/Koha/Plugins/Plugins.t for the additional test on verbose and errors flag. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Attachment #160028|0 |1 is obsolete|| --- Comment #32 from Marcel de Rooy --- Created attachment 160805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160805=edit Bug 35536: Reorder rollbacks Time to move all RemovePlugins calls BEFORE rollbacks. Broken.t did not even include a transaction! Some modules are removed there as well. Test plan: Search for wrong order with: grep -Pzo "txn_rollback;\n.*RemovePlugins" $(git grep -l RemovePlugins) No occurrences left? Think of another grep :) Check number of records in plugin_data/methods. Repeat: prove $(git grep -l Koha::Plugin | grep -P "^t\/db") And check number of records again. Same? Bonus: Apply TestMR plugin patch (marked DO NOT PUSH). Run perl -MKoha::Plugins -e"Koha::Plugins->new->InstallPlugins". Check plugin records in database. Keep those records but remove last patch from git. Run previous prove and verify no data changes since last check. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536
Marcel de Rooy changed:
What|Removed |Added
Attachment #160027|0 |1
is obsolete||
--- Comment #31 from Marcel de Rooy ---
Created attachment 160804
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160804=edit
Bug 35536: Add RemovePlugins calls in plugin unit tests
[1] Replace Methods->delete by RemovePlugins.
git grep -l "Plugins::Methods->delete" | xargs sed -i
-e's/Plugins::Methods->delete/Plugins->RemovePlugins/g'
[2] Replace $schema->resultset('PluginData')->delete by destructive parameter.
[3] Add RemovePlugins too in Handler->delete too. Note that this call
might be better off with disable? Added a comment.
Test plan:
prove $(git grep -l Koha::Plugin | grep -P "^t\/db")
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Attachment #160026|0 |1 is obsolete|| --- Comment #30 from Marcel de Rooy --- Created attachment 160803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160803=edit Bug 35536: Add Koha::Plugins->RemovePlugins class method Test plan: Run t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Attachment #160025|0 |1 is obsolete|| --- Comment #29 from Marcel de Rooy --- Created attachment 160802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160802=edit Bug 35536: Add Koha object classes for plugin_data Test plan: Read the patch. The objects will be used in subsequent patches, and tested there. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Attachment #160024|0 |1 is obsolete|| --- Comment #28 from Marcel de Rooy --- Created attachment 160801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160801=edit Bug 35536: Reorganize Plugins.t Move stuff in the middle into new subtest. Add transaction around second set of subtests. Test plan: t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Keywords||roadmap_24_05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #27 from Marcel de Rooy --- Created attachment 160032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160032=edit Bug 35536: DO NOT PUSH !!! - Example plugin After applying patch, run: perl -MKoha::Plugins -e"Koha::Plugin->new->InstallPlugins" This installs the TestMR plugin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #26 from Marcel de Rooy --- Created attachment 160031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160031=edit Bug 35536: Remove last two references to resultset PluginData Test plan: Run t/db_dependent/Koha/Plugins/Plugins.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #25 from Marcel de Rooy --- Created attachment 160030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160030=edit Bug 35536: Silence tests when run from koha-qa.pl Extending the regex in Plugins::_verbose. Test plan: Run qa tools on patch set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #24 from Marcel de Rooy --- Created attachment 160029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160029=edit Bug 35536: Refine verbose handling in some Koha::Plugins calls Three routines in Plugins got the verbose parameter on 35507. We can refine this a bit further. The idea here is report when you are installing plugins but not report when just calling plugins (flooding logs). [1] GetPlugins: Most callers do not expect (or check) results for failing plugins. This patch makes GetPlugins only return errors when passing the *errors* flag (in 2 cases). [a] The misc/devel script prints warnings now using verbose, so does not need the errors flag anymore. [b] plugins/plugins-home is the only case left. Tiny adjustment to keep current behavior. Fixed colspan in template. Does not need verbose in favor of 'errors' (passed to template). [c] For most calls we do not want verbose. New default is 0. [2] InstallPlugins [a] Disabled verbose in plugin-upload. Not really needed. Added a FIXME; we need to improve individual install. [b] misc/devel: No warnings anymore when calling InstallPlugins after GetPlugins. [3] get_enabled_plugins [a] Plugins->call does not need verbose. [b] Plugins->feature_enabled does not need it too. Test plan: [1] See previous plan. With TestMR data but without patch, run misc script and go to plugins-home. Do you see load errors on commandline or form? [2] Run plugins/plugins-upload (uploading just some file is good enough); verify that you do not see TestMR lines in logfile. [3] Run t/db_dependent/Koha/Plugins/Plugins.t for the additional test on verbose and errors flag. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #23 from Marcel de Rooy --- Created attachment 160028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160028=edit Bug 35536: Reorder rollbacks Time to move all RemovePlugins calls BEFORE rollbacks. Broken.t did not even include a transaction! Some modules are removed there as well. Test plan: Search for wrong order with: grep -Pzo "txn_rollback;\n.*RemovePlugins" $(git grep -l RemovePlugins) No occurrences left? Think of another grep :) Check number of records in plugin_data/methods. Repeat: prove $(git grep -l Koha::Plugin | grep -P "^t\/db") And check number of records again. Same? Bonus: Apply TestMR plugin patch (marked DO NOT PUSH). Run perl -MKoha::Plugins -e"Koha::Plugins->new->InstallPlugins". Check plugin records in database. Keep those records but remove last patch from git. Run previous prove and verify no data changes since last check. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536
--- Comment #22 from Marcel de Rooy ---
Created attachment 160027
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160027=edit
Bug 35536: Add RemovePlugins calls in plugin unit tests
[1] Replace Methods->delete by RemovePlugins.
git grep -l "Plugins::Methods->delete" | xargs sed -i
-e's/Plugins::Methods->delete/Plugins->RemovePlugins/g'
[2] Replace $schema->resultset('PluginData')->delete by destructive parameter.
[3] Add RemovePlugins too in Handler->delete too. Note that this call
might be better off with disable? Added a comment.
Test plan:
prove $(git grep -l Koha::Plugin | grep -P "^t\/db")
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #21 from Marcel de Rooy --- Created attachment 160026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160026=edit Bug 35536: Add Koha::Plugins->RemovePlugins class method Test plan: Run t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #20 from Marcel de Rooy --- Created attachment 160025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160025=edit Bug 35536: Add Koha object classes for plugin_data Test plan: Read the patch. The objects will be used in subsequent patches, and tested there. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Attachment #159830|0 |1 is obsolete|| Attachment #159839|0 |1 is obsolete|| Attachment #159840|0 |1 is obsolete|| Attachment #159841|0 |1 is obsolete|| Attachment #159842|0 |1 is obsolete|| Attachment #159843|0 |1 is obsolete|| Attachment #159844|0 |1 is obsolete|| --- Comment #19 from Marcel de Rooy --- Created attachment 160024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160024=edit Bug 35536: Reorganize Plugins.t Move stuff in the middle into new subtest. Add transaction around second set of subtests. Test plan: t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #18 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #17) > Needs rebase for changes on 35507 Still working here. Add some parameters to RemovePlugins. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #17 from Marcel de Rooy --- Needs rebase for changes on 35507 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #16 from Marcel de Rooy --- Created attachment 159844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159844=edit Bug 35536: DONT PUSH !!! - Example plugin After applying patch, run: perl -MKoha::Plugins -e"Koha::Plugin->new->InstallPlugins" This installs the TestMR plugin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Attachment #159824|0 |1 is obsolete|| --- Comment #15 from Marcel de Rooy --- Created attachment 159843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159843=edit Bug 35536: Remove Method->delete and reorder rollbacks We removed the need for Method->delete, so we can remove that. Also we should now move all RemovePlugins calls BEFORE the last rollback. Nice and clean :) Test plan: Search for wrong order with: grep -Pzo "txn_rollback;\n.*RemovePlugins" $(git grep -l RemovePlugins) No occurrences left? Think of another grep :) Check number of records in plugin_data/methods. Repeat: prove $(git grep -l Koha::Plugin | grep -P "^t\/db") And check number of records again. Same? Bonus: Install a plugin before following test plan. You could use the attached 'DONT PUSH' example patch. Having 3 recs in data and 45 in methods with that plugin only (before/after tests). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536
Marcel de Rooy changed:
What|Removed |Added
Attachment #159823|0 |1
is obsolete||
--- Comment #14 from Marcel de Rooy ---
Created attachment 159842
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159842=edit
Bug 35536: Add RemovePlugins calls in plugin unit tests
[1] Replace Methods->delete by RemovePlugins:
git grep -l "Plugins::Methods->delete" | xargs sed -i
-e's/Plugins::Methods->delete/Plugins->RemovePlugins/g'
[2] Remove superfluous $schema->resultset('PluginData')->delete.
[3] Remove superfluous use Koha::Plugins::Methods.
[4] Add the line $plugins = Koha::Plugins->new in PluginRoutes.t.
As originally done in a separate patch. This makes both parts
of subtest 'needs_install use case tests' more consistent.
[5] Add RemovePlugins now in Handler->delete too.
Test plan:
prove $(git grep -l Koha::Plugin | grep -P "^t\/db")
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Attachment #159822|0 |1 is obsolete|| --- Comment #13 from Marcel de Rooy --- Created attachment 159841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159841=edit Bug 35536: Add Koha::Plugins->RemovePlugins class method Note: In a subsequent patch we will remove the cleanup action from Koha::Plugins::Method. Test plan: Run t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Attachment #159821|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 159840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159840=edit Bug 35536: Add Koha object classes for plugin_data Test plan: Read the patch. The objects will be used in subsequent patches, and tested there. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Attachment #159820|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 159839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159839=edit Bug 35536: Reorganize Plugins.t Move stuff in the middle into new subtest. Add transaction around second set of subtests. Test plan: t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Blocks||35548 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35548 [Bug 35548] Move KitchenSink test on its own and control table creation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Attachment #159825|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 159830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159830=edit Bug 35536: DO NOT PUSH !!! - Example plugin After applying patch, run: perl -MKoha::Plugins -e"Koha::Plugin->new->InstallPlugins" This installs the TestMR plugin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #9 from Marcel de Rooy --- prove $(git grep -l Koha::Plugin | grep -P "^t\/db") t/db_dependent/ImportBatch.t . ok t/db_dependent/Koha/Patron/Consents.t ok t/db_dependent/Koha/Patron_generate_userid.t . ok t/db_dependent/Koha/Plugins/Account_hooks.t .. ok t/db_dependent/Koha/Plugins/BackgroundJob.t .. ok t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t ok t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t .. ok t/db_dependent/Koha/Plugins/Broken.t . ok t/db_dependent/Koha/Plugins/Circulation_hooks.t .. ok t/db_dependent/Koha/Plugins/Holds_hooks.t ok t/db_dependent/Koha/Plugins/Patron.t . 1/5 Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'patron_barcode_transform called with parameter: test_cn_1' Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'patron_barcode_transform called with parameter: test_cn_1' Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'patron_barcode_transform called with parameter: test_cn_1' t/db_dependent/Koha/Plugins/Patron.t . ok t/db_dependent/Koha/Plugins/Plugins.t ok t/db_dependent/Koha/Plugins/Recall_hooks.t ... ok t/db_dependent/Koha/Plugins/authority_hooks.t ok t/db_dependent/Koha/REST/Plugin/PluginRoutes.t ... ok t/db_dependent/Koha/Template/Plugin/KohaPlugins.t ok All tests successful. Files=16, Tests=102, 130 wallclock secs ( 0.21 usr 0.05 sys + 121.79 cusr 5.89 csys = 127.94 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #8 from Marcel de Rooy --- NOTE FOR QA: FAIL Koha/Plugins/Data.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL Koha/Plugins/Method.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 Please ignore false failures for empty Koha object classes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #7 from Marcel de Rooy --- Created attachment 159825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159825=edit Bug 35536: DONT PUSH !!! - Example plugin After applying patch, run: perl -MKoha::Plugins -e"Koha::Plugin->new->InstallPlugins" This installs the TestMR plugin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #6 from Marcel de Rooy --- Created attachment 159824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159824=edit Bug 35536: Remove Method->delete and reorder rollbacks We removed the need for Method->delete, so we can remove that. Also we should now move all RemovePlugins calls BEFORE the last rollback. Nice and clean :) Test plan: Search for wrong order with: grep -Pzo "txn_rollback;\n.*RemovePlugins" $(git grep -l RemovePlugins) No occurrences left? Think of another grep :) Check number of records in plugin_data/methods. Repeat: prove $(git grep -l Koha::Plugin | grep -P "^t\/db") And check number of records again. Same? Bonus: Install a plugin before following test plan. You could use the attached 'DONT PUSH' example patch. Having 3 recs in data and 45 in methods with that plugin only (before/after tests). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536
--- Comment #5 from Marcel de Rooy ---
Created attachment 159823
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159823=edit
Bug 35536: Add RemovePlugins calls in plugin unit tests
[1] Replace Methods->delete by RemovePlugins
git grep -l "Plugins::Methods->delete" | xargs sed -i
-e's/Plugins::Methods->delete/Plugins->RemovePlugins/g'
[2] Remove superfluous $schema->resultset('PluginData')->delete;
[3] Remove superfluous use Koha::Plugins::Methods
[4] Add the line $plugins = Koha::Plugins->new in PluginRoutes.t.
As originally done in a separate patch. This makes both parts
of subtest 'needs_install use case tests' more consistent.
Test plan:
prove $(git grep -l Koha::Plugin | grep -P "^t\/db")
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #4 from Marcel de Rooy --- Created attachment 159822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159822=edit Bug 35536: Add Koha::Plugins->RemovePlugins class method Note: In a subsequent patch we will remove the cleanup action from Koha::Plugins::Method. Test plan: Run t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #3 from Marcel de Rooy --- Created attachment 159821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159821=edit Bug 35536: Add Koha object classes for plugin_data Test plan: Read the patch. The objects will be used in subsequent patches, and tested there. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Attachment #159804|0 |1 is obsolete|| --- Comment #2 from Marcel de Rooy --- Created attachment 159820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159820=edit Bug 35536: Reorganize Plugins.t Move stuff in the middle into new subtest. Add transaction around second set of subtests. Test plan: t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added CC||k...@bywatersolutions.com, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What|Removed |Added Summary|Improve removal of Koha |Improve removal of Koha |plugins |plugins in unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
