[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Lucas Gass changed: What|Removed |Added Blocks||16122 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 [Bug 16122] Item record needs to keep local use count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 --- Comment #14 from Fridolin Somers --- There are a lot of call on CanBookBeIssued() : ILS-DI, SIP, SCO ... Any need to also deal with AddReturn() ? Especially SCO may be used for local circulation no ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||fridolin.som...@biblibre.co ||m Version(s)|24.05.00|24.05.00,23.11.04 released in|| --- Comment #13 from Fridolin Somers --- Pushed to 23.11.x for 23.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 --- Comment #12 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 --- Comment #11 from Katrin Fischer --- Looking at this I was wondering, if moving from .pm to .pl is really the right move here concerning the API. Digging a little deeper, I think we are using AddIssue without CanBookBeIssued in the API, so this would not cause a change. I'll push, but leaving this note here in case I missed something in my line of thinking! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- Thanks Lucas, all looks good here, Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Martin Renvoize changed: What|Removed |Added Attachment #162687|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 162967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162967=edit Bug 35950: Adjust tests Signed-off-by: Andrew Fuerste Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Martin Renvoize changed: What|Removed |Added Attachment #162686|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 162966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162966=edit Bug 35950: Move AddReturn call into circulation.pl There should be no change in beahavior. Following the test plan from Bug 35840. To test: 1. APPLY PATCH, restart_all 2. Turn on RecordLocalUseOnReturn 3. Create a Statistical patron. 4. Check an item out to a regular patron. 5. Check the item out to a Statistical patron. 6. This should trigger a return and you will see 2 entries in the statistics table, one for localuse and one for a return. 7. Try checking out an item to the Stats patron that is NOT checked out. 8. You should only see 1 entry, localuse, in the statistics table. Signed-off-by: Andrew Fuerste Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #162618|0 |1 is obsolete|| --- Comment #7 from Andrew Fuerste-Henry --- Created attachment 162687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162687=edit Bug 35950: Adjust tests Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #162617|0 |1 is obsolete|| --- Comment #6 from Andrew Fuerste-Henry --- Created attachment 162686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162686=edit Bug 35950: Move AddReturn call into circulation.pl There should be no change in beahavior. Following the test plan from Bug 35840. To test: 1. APPLY PATCH, restart_all 2. Turn on RecordLocalUseOnReturn 3. Create a Statistical patron. 4. Check an item out to a regular patron. 5. Check the item out to a Statistical patron. 6. This should trigger a return and you will see 2 entries in the statistics table, one for localuse and one for a return. 7. Try checking out an item to the Stats patron that is NOT checked out. 8. You should only see 1 entry, localuse, in the statistics table. Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 --- Comment #5 from Lucas Gass --- Created attachment 162618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162618=edit Bug 35950: Adjust tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Lucas Gass changed: What|Removed |Added Attachment #162616|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 162617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162617=edit Bug 35950: Move AddReturn call into circulation.pl There should be no change in beahavior. Following the test plan from Bug 35840. To test: 1. APPLY PATCH, restart_all 2. Turn on RecordLocalUseOnReturn 3. Create a Statistical patron. 4. Check an item out to a regular patron. 5. Check the item out to a Statistical patron. 6. This should trigger a return and you will see 2 entries in the statistics table, one for localuse and one for a return. 7. Try checking out an item to the Stats patron that is NOT checked out. 8. You should only see 1 entry, localuse, in the statistics table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 --- Comment #3 from Lucas Gass --- Created attachment 162616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162616=edit Bug 35950: Move AddReturn call into circulation.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 --- Comment #2 from Lucas Gass --- (In reply to Martin Renvoize from comment #1) > I think the AddReturn should be moved into circ/circulation.pl after the > call to CanBookBeIssued when CanBookBeIssued returns a 'stat' response.. I > also think that perhaps the actual recording of the state should be dropped > from CanBookBeIssued and only take place within AddReturn. Thank you, I agree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Martin Renvoize changed: What|Removed |Added Depends on||35840 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Martin Renvoize changed: What|Removed |Added Depends on|35840 | --- Comment #1 from Martin Renvoize --- I think the AddReturn should be moved into circ/circulation.pl after the call to CanBookBeIssued when CanBookBeIssued returns a 'stat' response.. I also think that perhaps the actual recording of the state should be dropped from CanBookBeIssued and only take place within AddReturn. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Martin Renvoize changed: What|Removed |Added Depends on||35840 CC||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Lucas Gass changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
