[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Lucas Gass changed: What|Removed |Added Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in|| CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable --- Comment #29 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Fridolin Somers changed: What|Removed |Added Status|Pushed to main |Pushed to stable Version(s)|24.05.00|24.05.00,23.11.06 released in|| --- Comment #28 from Fridolin Somers --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 --- Comment #27 from Fridolin Somers --- Depends on Bug 36341 that added function Date_from_syspref() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Fridolin Somers changed: What|Removed |Added Depends on||36341 CC||fridolin.som...@biblibre.co ||m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36341 [Bug 36341] "Hold starts on date" should be limited to future dates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 --- Comment #26 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Katrin Fischer changed: What|Removed |Added Keywords|additional_work_needed, | |RM_priority | --- Comment #25 from Katrin Fischer --- Follow-up will be pushed to main. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #24 from Martin Renvoize --- Thanks to Nick for helping me wrap my head around this and Emily for the clean code in bug 35559 which lead to the fix. This should be ready to go again now Katrin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Martin Renvoize changed: What|Removed |Added Attachment #165725|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 --- Comment #23 from Martin Renvoize --- Created attachment 165910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165910=edit Bug 35977: (follow-up) Cleaner working approach This patch removes the Date_from_syspref recently added and replaces it with the correct parseDate call as per bug 35559. We also clean up the code around setting the input value in the first place and use iso which is what the rest of flatpickr expects and now is handled correctly in futuredate pickers. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35559 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 --- Comment #22 from Martin Renvoize --- I'm stuck.. I can't get the value to be properly picked up by flatpickr. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 --- Comment #21 from Martin Renvoize --- Created attachment 165725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165725=edit Bug 35977: (follow-up) Use KohaDate instead of raw This patch updates the value passed to the holdfrom input to use KohaDate formatting instead of Raw. The 'futureinclusive' logic now being triggered in the flatpickr instantiation expects the localised date format as apposed to the raw one. However, I can't get the flatpickr and input to pick up the passed date properly now :(. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36341 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Martin Renvoize changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 --- Comment #20 from Martin Renvoize --- I'm on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Katrin Fischer changed: What|Removed |Added Keywords||RM_priority --- Comment #19 from Katrin Fischer --- ... as I just accidentally pushed this - could we get a quick follow-up? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #18 from Katrin Fischer --- I am sorry, but this breaks the datepickers on the OPAC reserve page totally for me now :( The input shows: 2024-04-26T1 JS error: Uncaught ReferenceError: Date_from_syspref is not defined I was a little mean and set the DateFormat to the German DD.MM.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Katrin Fischer changed: What|Removed |Added Summary|Display current date in |Display current date in |Hold starts on date on |hold starts on when placing |opac-reserve|a hold in the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
