[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in|| Keywords|rel_23_05_candidate | --- Comment #27 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Koha collecto changed: What|Removed |Added CC||k...@collecto.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Fridolin Somers changed: What|Removed |Added Version(s)|24.05.00|24.05.00,23.11.06 released in|| CC||fridolin.som...@biblibre.co ||m Status|Pushed to main |Pushed to stable --- Comment #26 from Fridolin Somers --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #25 from David Cook --- Both those raised in bug 36820 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 David Cook changed: What|Removed |Added Blocks||36820 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36820 [Bug 36820] NEW_SUGGESTION is still sent for some modifications to the suggestion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #24 from David Cook --- (In reply to David Cook from comment #23) > That said... looking at this again and I'm not sure that this is 100% solved > yet. > > Technically, if you moved the status of a suggestion back to "Pending", it > would trigger another email. > > The solution for this probably would've been to use !$self->in_storage > before $self->SUPER::store() to set a flag for email sending. Another issue is if you have a suggestion as "Pending" and a staff user edits it without changing the status, emails will continue to be sent out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #23 from David Cook --- That said... looking at this again and I'm not sure that this is 100% solved yet. Technically, if you moved the status of a suggestion back to "Pending", it would trigger another email. The solution for this probably would've been to use !$self->in_storage before $self->SUPER::store() to set a flag for email sending. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #22 from David Cook --- Well done everyone. I have just gotten a report of this happening to someone, so it's great to see it fixed already upstream! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Keywords||rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #21 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #20 from Martin Renvoize --- Great improvement and bugfix, thanks! QA scripts are happy, the Unit tests cover the change well. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Martin Renvoize changed: What|Removed |Added Attachment #165579|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Martin Renvoize changed: What|Removed |Added Attachment #165578|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #19 from Martin Renvoize --- Created attachment 166053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166053=edit Bug 36122: Update unit test Signed-off-by: Roman Dolny Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #18 from Martin Renvoize --- Created attachment 166052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166052=edit Bug 36122: Add unit test Signed-off-by: Roman Dolny Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Martin Renvoize changed: What|Removed |Added Attachment #165577|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 166051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166051=edit Bug 36122: NEW_SUGGESTION is sent for every modification to the suggestion Signed-off-by: Roman Dolny Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Roman Dolny changed: What|Removed |Added Attachment #164481|0 |1 is obsolete|| --- Comment #16 from Roman Dolny --- Created attachment 165579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165579=edit Bug 36122: modif test Signed-off-by: Roman Dolny -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Roman Dolny changed: What|Removed |Added Attachment #162989|0 |1 is obsolete|| --- Comment #15 from Roman Dolny --- Created attachment 165578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165578=edit Bug 36122: add unit test Signed-off-by: Roman Dolny -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Roman Dolny changed: What|Removed |Added Attachment #162962|0 |1 is obsolete|| --- Comment #14 from Roman Dolny --- Created attachment 165577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165577=edit Bug 36122: NEW_SUGGESTION is sent for every modification to the suggestion Signed-off-by: Roman Dolny -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Roman Dolny changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Daphne Hoolahan changed: What|Removed |Added CC||d...@interleaf.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #13 from Matthias Le Gac --- I have modified how I change the value of the 'EmailPurchaseSuggestions' syspref during testing. Let me know if it works better now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #12 from Matthias Le Gac --- Created attachment 164481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164481=edit Bug 36122: modif test Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #11 from Matthias Le Gac --- (In reply to Lucas Gass from comment #10) > Mattais, > > Can you review these tests? Something seems not quite right: > > # Subtest: store > 1..8 > ok 1 - If suggesteddate not passed in, it will default to today > ok 2 - If suggesteddate passed in, it should be taken into account > ok 3 - If suggestion id modified, suggesteddate should not be modified > ok 4 - If EmailPurchaseSuggestions is not enabled, a message should not > be sent > not ok 5 - No message was sent > > # Failed test 'No message was sent' > # at /kohadevbox/koha/t/db_dependent/Koha/Suggestions.t line 89. > ok 6 - If the status of suggestion is not set to ASKED, a message should > not be sent > ok 7 - store raises an exception on invalid STATUS > ok 8 - UNKNOWN status stored > # Looks like you failed 1 test of 8. > not ok 1 - store > > > Thanks! I can't reproduce the problem, I've tried different situations but test 5 passes every time. Can you add these print "print STDERR "syspref: " . $syspref->variable . " value :" . $syspref->value . "\n";" to line 85 and 86 (before and after the syspref store line) and tell me what you get? To be sure that the changes made to the preferences have been good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #10 from Lucas Gass --- Mattais, Can you review these tests? Something seems not quite right: # Subtest: store 1..8 ok 1 - If suggesteddate not passed in, it will default to today ok 2 - If suggesteddate passed in, it should be taken into account ok 3 - If suggestion id modified, suggesteddate should not be modified ok 4 - If EmailPurchaseSuggestions is not enabled, a message should not be sent not ok 5 - No message was sent # Failed test 'No message was sent' # at /kohadevbox/koha/t/db_dependent/Koha/Suggestions.t line 89. ok 6 - If the status of suggestion is not set to ASKED, a message should not be sent ok 7 - store raises an exception on invalid STATUS ok 8 - UNKNOWN status stored # Looks like you failed 1 test of 8. not ok 1 - store Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #9 from Matthias Le Gac --- this is the first time I do test for Koha, so let me know if there's anything to improve. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #8 from Matthias Le Gac --- Created attachment 162989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162989=edit Bug 36122: add unit test Test plan : To recreate: 1. Enable EmailPurchaseSuggestions 2. Go to a patron's account and add an email address, a different one than the one used for EmailPurchaseSuggestions 3. Create a suggestion from the OPAC 3.1. Go to the OPAC and log in as a patron 3.2. Go to Your account > Purchase suggestions 3.3. Click New purchase suggestion 3.4. Enter a title 3.5. Click Submit your suggestion 4. Check the message_queue, there should be one NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should be 1 entry in message_queue) 5. Update the suggestion to accepted 5.1. In the staff interface, go to Acquisitions > Suggestions 5.2. In the suggestions list, check the box next to the suggestion 5.3. At the bottom of the screen, choose Mark selected as: Accepted 5.4. Click Submit 6. Check the message_queue again, there should be one ACCEPTED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 3 entries in message_queue) 7. Order the suggestion 7.1. Go to Acquisitions 7.2. Search for a vendor 7.3. Click New > Basket 7.4. Enter a basket name (Optional: for testing I like to change Create items when: cataloging the record) 7.5. Click Save 7.6. Click Add to basket 7.7. Click From a suggestion 7.8. Click Order next to the suggestion 7.9. Enter order details 7.10. Click Save 7.11. Click Close basket 7.12. Click Yes, close 8. Check the message_queue again, there should be one ORDERED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 5 entries in message_queue) 9. Apply the patch 10. now repeat steps 3 to 8 but : step 4 you have one NEW_SUGGESTION message in message_queue step 6 you have only one ACCEPTED message in message_queue step 8 you have only one ORDERED message in message_queue The NEW_SUGGESTION are now sent only on the submit of the suggestion and not on each steps. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Failed QA --- Comment #7 from Martin Renvoize --- Can we have a Unit test for this please. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #6 from Matthias Le Gac --- Created attachment 162962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162962=edit Bug 36122: NEW_SUGGESTION is sent for every modification to the suggestion Test plan : To recreate: 1. Enable EmailPurchaseSuggestions 2. Go to a patron's account and add an email address, a different one than the one used for EmailPurchaseSuggestions 3. Create a suggestion from the OPAC 3.1. Go to the OPAC and log in as a patron 3.2. Go to Your account > Purchase suggestions 3.3. Click New purchase suggestion 3.4. Enter a title 3.5. Click Submit your suggestion 4. Check the message_queue, there should be one NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should be 1 entry in message_queue) 5. Update the suggestion to accepted 5.1. In the staff interface, go to Acquisitions > Suggestions 5.2. In the suggestions list, check the box next to the suggestion 5.3. At the bottom of the screen, choose Mark selected as: Accepted 5.4. Click Submit 6. Check the message_queue again, there should be one ACCEPTED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 3 entries in message_queue) 7. Order the suggestion 7.1. Go to Acquisitions 7.2. Search for a vendor 7.3. Click New > Basket 7.4. Enter a basket name (Optional: for testing I like to change Create items when: cataloging the record) 7.5. Click Save 7.6. Click Add to basket 7.7. Click From a suggestion 7.8. Click Order next to the suggestion 7.9. Enter order details 7.10. Click Save 7.11. Click Close basket 7.12. Click Yes, close 8. Check the message_queue again, there should be one ORDERED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 5 entries in message_queue) 9. Apply the patch 10. now repeat steps 3 to 8 but : step 4 you have one NEW_SUGGESTION message in message_queue step 6 you have only one ACCEPTED message in message_queue step 8 you have only one ORDERED message in message_queue The NEW_SUGGESTION are now sent only on the submit of the suggestion and not on each steps. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Matthias Le Gac changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Matthias Le Gac changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Matthias Le Gac changed: What|Removed |Added CC||matthias.le-...@inlibro.com Assignee|koha-b...@lists.koha-commun |matthias.le-...@inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Marie-Luce Laflamme changed: What|Removed |Added CC||marie-luce.laflamme@inlibro ||.com --- Comment #5 from Marie-Luce Laflamme --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Caroline Cyr La Rose changed: What|Removed |Added CC||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Mirjam Vantieghem changed: What|Removed |Added CC||mirjam.vantieg...@etf.edu --- Comment #4 from Mirjam Vantieghem --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Caroline Cyr La Rose changed: What|Removed |Added Depends on||33236 --- Comment #3 from Caroline Cyr La Rose --- Possibly linked to bug 33236 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #2 from Caroline Cyr La Rose --- I forgot the patron's email address in the test plan. I don't think notices are generated if the patron doesn't have an email address. To recreate: 1. Enable EmailPurchaseSuggestions 2. Go to a patron's account and add an email address, a different one than the one used for EmailPurchaseSuggestions 3. Create a suggestion from the OPAC 3.1. Go to the OPAC and log in as a patron 3.2. Go to Your account > Purchase suggestions 3.3. Click New purchase suggestion 3.4. Enter a title 3.5. Click Submit your suggestion 4. Check the message_queue, there should be one NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should be 1 entry in message_queue) 5. Update the suggestion to accepted 5.1. In the staff interface, go to Acquisitions > Suggestions 5.2. In the suggestions list, check the box next to the suggestion 5.3. At the bottom of the screen, choose Mark selected as: Accepted 5.4. Click Submit 6. Check the message_queue again, there should be one ACCEPTED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 3 entries in message_queue) 7. Order the suggestion 7.1. Go to Acquisitions 7.2. Search for a vendor 7.3. Click New > Basket 7.4. Enter a basket name (Optional: for testing I like to change Create items when: cataloging the record) 7.5. Click Save 7.6. Click Add to basket 7.7. Click From a suggestion 7.8. Click Order next to the suggestion 7.9. Enter order details 7.10. Click Save 7.11. Click Close basket 7.12. Click Yes, close 8. Check the message_queue again, there should be one ORDERED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 5 entries in message_queue) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #1 from Caroline Cyr La Rose --- Might be the same as bug 35854, but I'm not 100% sure. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35854 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/