[Koha-bugs] [Bug 3624] Basket group delivery place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution||FIXED
--- Comment #23 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-10-28
16:30:30 UTC ---
Ok, I have looked into this:
NEW INSTALLATIONS
kohastructure.sql seems correct now. I also checked a new database, all fields
are there.
DROP TABLE IF EXISTS `aqbasketgroups`;
CREATE TABLE `aqbasketgroups` (
`id` int(11) NOT NULL auto_increment,
`name` varchar(50) default NULL,
`closed` tinyint(1) default NULL,
`booksellerid` int(11) NOT NULL,
`deliveryplace` varchar(10) default NULL,
`freedeliveryplace` text default NULL,
`deliverycomment` varchar(255) default NULL,
`billingplace` varchar(10) default NULL,
PRIMARY KEY (`id`),
KEY `booksellerid` (`booksellerid`),
CONSTRAINT `aqbasketgroups_ibfk_1` FOREIGN KEY (`booksellerid`) REFERENCES
`aqbooksellers` (`id`) ON UPDATE CASCADE ON DELETE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8;
UPDATED INSTALLATIONS
Installations updating from a version number below 3.01.00.94 should be ok. I
checked the sql statements are correct.
First update in updatedatabase.pl:
$DBversion = 3.01.00.094;
if (C4::Context-preference(Version) TransformToNum($DBversion)) {
$dbh-do(qq{ALTER TABLE aqbasketgroups ADD deliveryplace VARCHAR(10) default
NULL, ADD deliverycomment VARCHAR(255) default NULL;});
$DBversion = 3.01.00.097;
if (C4::Context-preference(Version) TransformToNum($DBversion)) {
$dbh-do(qq{ALTER TABLE aqbasketgroups ADD billingplace VARCHAR(10) NOT NULL
AFTER deliverycomment;});
NEW INSTALLATIONS CREATED WHILE FIELDS WHERE MISSING
I have removed the 3 columns from my database and added the code below as
3.06.00.001 to my updatedatabase. The updatedatabase reported no errors, but
the columns were NOT added to my databse.
$DBversion = '3.03.00.023';
I created a branch for an old version of Koha (3.02.04.000) and recreated my
database from scratch. The 3 columns are missing from aqbasketgroups. I checked
out back to master and ran the web installer. Got some complaints about privacy
and:
Upgrade to 3.03.00.023 done (Reconcile aqbasketgroups)
Confirmed that columns were correctly added to the datebase.
if (C4::Context-preference(Version) TransformToNum($DBversion)
$original_version TransformToNum(3.02.05.002)) {
my $sth = $dbh-prepare(SELECT * FROM INFORMATION_SCHEMA.COLUMNS WHERE
TABLE_NAME = 'aqbasketgroups' AND COLUMN_NAME = 'billingplace');
$sth-execute;
$dbh-do(ALTER TABLE aqbasketgroups ADD billingplace VARCHAR(10)) if !
$sth-fetchrow_hashref;
$sth = $dbh-prepare(SELECT * FROM INFORMATION_SCHEMA.COLUMNS WHERE
TABLE_NAME = 'aqbasketgroups' AND COLUMN_NAME = 'deliveryplace');
$sth-execute;
$dbh-do(ALTER TABLE aqbasketgroups ADD deliveryplace VARCHAR(10)) if !
$sth-fetchrow_hashref;
$sth = $dbh-prepare(SELECT * FROM INFORMATION_SCHEMA.COLUMNS WHERE
TABLE_NAME = 'aqbasketgroups' AND COLUMN_NAME = 'deliverycomment');
$sth-execute;
$dbh-do(ALTER TABLE aqbasketgroups ADD deliverycomment VARCHAR(255)) if
! $sth-fetchrow_hashref;
print Upgrade to $DBversion done (Reconcile aqbasketgroups)\n;
SetVersion ($DBversion);
}
XHTML VALIDITY
Checked on current master. Ok.
I am marking this closed, please reopen if I missed something.
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3624] Basket group delivery place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624 --- Comment #24 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-10-28 16:32:14 UTC --- Ok, some things got mixed up down here: NEW INSTALLATIONS CREATED WHILE FIELDS WHERE MISSING I have removed the 3 columns from my database and added the code below as 3.06.00.001 to my updatedatabase. The updatedatabase reported no errors, but the columns were NOT added to my database This didn't work, because the database update was also checking for the version number - so I went back and created a real old database to test it correctly. And this WORKED. :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3624] Basket group delivery place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Priority|PATCH-Sent |P5 Platform|PC |All -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3624] Basket group delivery place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624 --- Comment #21 from Paul Poulain paul.poul...@biblibre.com 2011-09-26 15:51:29 UTC --- Owen, it's unclear for me why you've removed the patch sent. Could you give more details pls ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3624] Basket group delivery place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624 --- Comment #22 from Ian Walls ian.wa...@bywatersolutions.com 2011-09-26 15:59:10 UTC --- Paul, There is no non-obsolete patch attached, so it was decided in IRC to remove the patch-sent status until we could get more information. Is there a pending patch that needs signoff or QA? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3624] Basket group delivery place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Patch Status|Needs Signoff |--- --- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-09-18 20:06:31 UTC --- The attached patch introduces translation problems (bug 6458). Problem was fixed by http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5131 Removing needs sign-off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3624] Basket group delivery place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #4581|0 |1 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3624] Basket group delivery place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added AssignedTo|paul.poul...@biblibre.com |ian.walls@bywatersolutions. ||com --- Comment #19 from Paul Poulain paul.poul...@biblibre.com 2011-08-02 14:04:30 UTC --- ian, once you have more details, give me the bug back, or close if no more relevant -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3624] Basket group delivery place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624 --- Comment #18 from Ian Walls ian.wa...@bywatersolutions.com 2011-07-25 15:33:46 UTC --- Paul, That seems likely; I'll try pulling an older-version update, and checking the update process. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3624] Basket group delivery place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624 --- Comment #17 from Paul Poulain paul.poul...@biblibre.com 2011-07-21 10:49:52 UTC --- an idea : The deliveryplace deliverycomment are added in 3.01.00.0094 and the 03.00.0023 does a test/check : my $sth = $dbh-prepare(SELECT * FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = 'aqbasketgroups' AND COLUMN_NAME = 'billingplace'); $sth-execute; $dbh-do(ALTER TABLE aqbasketgroups ADD billingplace VARCHAR(10)) if ! $sth-fetchrow_hashref; maybe there is something wrong with this check and the ALTER TABLE is not done. Do you have a backup with what you had before the update ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3624] Basket group delivery place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624 Ian Walls ian.wa...@bywatersolutions.com changed: What|Removed |Added CC||ian.walls@bywatersolutions. ||com --- Comment #16 from Ian Walls ian.wa...@bywatersolutions.com 2011-07-19 20:37:07 UTC --- On two recently updated installations, I've seen the deliveryplace, deliverycomment, and billingplace columns fail to be inserted into the table by updatedatabase.pl. Can anyone else confirm that upgrading from pre-3.03.00.023 to current HEAD fails to update the database appropriately, or is this a local problem for me? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3624] Basket group delivery place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|rel_3_2 |master Patch Status|Patch Pushed|Failed QA --- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-07-07 21:25:53 UTC --- Patch for xhtml validity needs to be redone for TT. Checked problem still exists in this template on master. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3624] Basket group delivery place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Patch Status|Failed QA |Does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3624] Basket group delivery place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #1469|0 |1 is obsolete|| Attachment #2798|0 |1 is obsolete|| Attachment #3229|0 |1 is obsolete|| --- Comment #14 from Chris Cormack ch...@bigballofwax.co.nz 2011-07-07 21:44:43 UTC --- Created attachment 4581 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4581 Bug 3624 : XHTML validation, rebased for Template Toolkit -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3624] Basket group delivery place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Patch Status|Does not apply |Needs Signoff Severity|blocker |trivial --- Comment #15 from Chris Cormack ch...@bigballofwax.co.nz 2011-07-07 21:46:17 UTC --- All that is remaining is the xhtml fix, patch attached -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3624] Basket group delivery place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624 Francois Charbonnier francois.charbonn...@biblibre.com changed: What|Removed |Added CC||francois.charbonnier@biblib ||re.com --- Comment #12 from Francois Charbonnier francois.charbonn...@biblibre.com 2011-04-06 12:49:33 UTC --- I tested this patch. It works but i noticed that the billing place isnt saved if you dont select a lirary in the drop-down list box. Is it a side effect? Do i open up a new bug? I also did selenium tests with the firefox addon. If anyone want these to replay the tests I did, let me know. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
