[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-05-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to main  |Needs documenting
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #18 from Fridolin Somers  ---
Not backported to 23.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Keywords|additional_work_needed, |
   |RM_priority |

--- Comment #17 from Martin Renvoize  ---
I have the test fix locally and will push shortly.. removing
additional_work_needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||additional_work_needed,
   ||RM_priority

--- Comment #16 from Katrin Fischer  ---
It looks like we are missing something here:

t/Makefile.t
not ok 1 - All directories should be mapped: .prettierrc.js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

--- Comment #15 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |jonathan.dru...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-04-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

--- Comment #14 from Jonathan Druart  ---
Created attachment 164249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164249=edit
Bug 36400 (follow-up): remove option editorconfig from .prettierrc.js

- The option doesn't seem do what it's intended for:
- The debug logs still show options from the .editorconfig (which is
actually what we want in this case).
- The option causes unwanted warnings when using the cli.
- In summary: we have to keep in mind that the rules are now hierarchical:
1. .editorconfig
2. .prettierrc.js

Signed-off-by: Brendan Lawlor 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-04-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #163799|0   |1
is obsolete||
 Attachment #163825|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  ---
Created attachment 164248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164248=edit
Bug 36400: Centralize {js,ts,vue} formatting config in .prettierrc.js

Let's centralize all formatting for js, ts and vue files in a .prettierrc.js.
The goal here is to preserve eslint's linting but ignore all of its
formatting options.

Seems to work for vue files in vscode, vscodium and neovim w/
vscode-eslint-language-server.

To test:
1) Pick any vue file for example.
2) Run format via your editor and either npx prettier -c .prettierrc.js
 [you can also use the -w flag to directly write].
3) Look for unexpected changes: vue files should be already formatted w/
these inline flags (see:
https://wiki.koha-community.org/wiki/Coding_Guidelines#JS14:_Prettier_JavaScript):
[--trailing-comma es5, --arrow-parens avoid].
4) Sign off if you're happy and comment or show what went wrong in a
comment.

Signed-off-by: Brendan Lawlor 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-04-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Brendan Lawlor  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

--- Comment #12 from Brendan Lawlor  ---
Before patch:
npx prettier -w ./koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue

git diff --compact-summary ./koha-tmpl/
intranet-tmpl/prog/js/vue/components/KohaTable.vue
 .../prog/js/vue/components/KohaTable.vue  | 110 +--
 1 file changed, 55 insertions(+), 55 deletions(-)

After patch:
npx prettier -c .prettierrc.js -w
./koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue
Checking formatting...
All matched files use Prettier code style!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Brendan Lawlor  changed:

   What|Removed |Added

 Attachment #163818|0   |1
is obsolete||

--- Comment #11 from Brendan Lawlor  ---
Created attachment 163825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163825=edit
Bug 36400 (follow-up): remove option editorconfig from .prettierrc.js

- The option doesn't seem do what it's intended for:
- The debug logs still show options from the .editorconfig (which is
actually what we want in this case).
- The option causes unwanted warnings when using the cli.
- In summary: we have to keep in mind that the rules are now hierarchical:
1. .editorconfig
2. .prettierrc.js

Signed-off-by: Brendan Lawlor 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

--- Comment #10 from Paul Derscheid  ---
Yes, it's exactly the same.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

--- Comment #9 from Brendan Lawlor  ---
Is the test plan for the follow up the same as it was for the first patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

--- Comment #8 from Paul Derscheid  ---
Created attachment 163818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163818=edit
Bug 36400 (follow-up): remove option editorconfig from .prettierrc.js

- The option doesn't seem do what it's intended for:
- The debug logs still show options from the .editorconfig (which is
actually what we want in this case).
- The option causes unwanted warnings when using the cli.
- In summary: we have to keep in mind that the rules are now hierarchical:
1. .editorconfig
2. .prettierrc.js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Paul Derscheid  changed:

   What|Removed |Added

   Patch complexity|Small patch |Trivial patch
 Status|Passed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #163710|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  ---
Created attachment 163799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163799=edit
Bug 36400: Centralize {js,ts,vue} formatting config in .prettierrc.js

Let's centralize all formatting for js, ts and vue files in a .prettierrc.js.
The goal here is to preserve eslint's linting but ignore all of its
formatting options.

Seems to work for vue files in vscode, vscodium and neovim w/
vscode-eslint-language-server.

To test:
1) Pick any vue file for example.
2) Run format via your editor and either npx prettier -c .prettierrc.js
 [you can also use the -w flag to directly write].
3) Look for unexpected changes: vue files should be already formatted w/
these inline flags (see:
https://wiki.koha-community.org/wiki/Coding_Guidelines#JS14:_Prettier_JavaScript):
[--trailing-comma es5, --arrow-parens avoid].
4) Sign off if you're happy and comment or show what went wrong in a
comment.

Signed-off-by: Brendan Lawlor 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #163695|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

--- Comment #6 from Paul Derscheid  ---
Yes, using eslint and prettier together can cause performance problems because
if not mitigated they both apply their formatting rules which can cause very
sluggish formatting and even timeouts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |paul.dersch...@lmscloud.de
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@gmail.com

--- Comment #5 from Jonathan Druart  ---
Can you explain why we need eslint deps whereas we already have prettier?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

--- Comment #4 from Brendan Lawlor  ---
Tested using vscode:

Before the patch:
npx prettier ./koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue

git diff --compact-summary ./koha-tmpl/
intranet-tmpl/prog/js/vue/components/KohaTable.vue
 .../prog/js/vue/components/KohaTable.vue  | 110 +--
 1 file changed, 55 insertions(+), 55 deletions(-)

After the patch:
npx prettier -c .prettierrc.js -w
./koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue

Checking formatting...
[warn] Ignored unknown option { editorconfig: "false" }.
[warn] Ignored unknown option { editorconfig: "false" }.
All matched files use Prettier code style!

No changes made to the vue file

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

--- Comment #3 from Brendan Lawlor  ---
Created attachment 163710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163710=edit
Bug 36400: Centralize {js,ts,vue} formatting config in .prettierrc.js

Let's centralize all formatting for js, ts and vue files in a .prettierrc.js.
The goal here is to preserve eslint's linting but ignore all of its
formatting options.

Seems to work for vue files in vscode, vscodium and neovim w/
vscode-eslint-language-server.

To test:
1) Pick any vue file for example.
2) Run format via your editor and either npx prettier -c .prettierrc.js
 [you can also use the -w flag to directly write].
3) Look for unexpected changes: vue files should be already formatted w/
these inline flags (see:
https://wiki.koha-community.org/wiki/Coding_Guidelines#JS14:_Prettier_JavaScript):
[--trailing-comma es5, --arrow-parens avoid].
4) Sign off if you're happy and comment or show what went wrong in a
comment.

Signed-off-by: Brendan Lawlor 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Brendan Lawlor  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

--- Comment #2 from Paul Derscheid  ---
Created attachment 163695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163695=edit
Attachment to Bug 36400 - Centralize {js,ts,vue} formatting config in
.prettierrc.js

Bug 36400: Centralize {js,ts,vue} formatting config in .prettierrc.js

Let's centralize all formatting for js, ts and vue files in a
.prettierrc.js.
The goal here is to preserve eslint's linting but ignore all of its
formatting options.

Seems to work for vue files in vscode, vscodium and neovim w/
vscode-eslint-language-server.

To test:
1) Pick any vue file for example.
2) Run format via your editor and either npx prettier -c .prettierrc.js
 [you can also use the -w flag to directly write].
3) Look for unexpected changes: vue files should be already formatted w/
these inline flags (see:
https://wiki.koha-community.org/wiki/Coding_Guidelines#JS14:_Prettier_JavaScript):
[--trailing-comma es5, --arrow-parens avoid].
4) Sign off if you're happy and comment or show what went wrong in a
comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

Paul Derscheid  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36400] Centralize {js, ts, vue} formatting config in .prettierrc.js

2024-03-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400

--- Comment #1 from Paul Derscheid  ---
Using the cli .editorconfig should be ignored by default, see
https://github.com/prettier/prettier/issues/15401

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/