[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #86 from Nick Clemens  ---
Awesome work all! Pushed to stable for 17.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #85 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #84 from Marcel de Rooy  ---
As referred to on IRC by Jonathan:
===
Looking at bug 4319: We also have C4::Reserves::IsItemOnHoldAndFound that does
exactly the same thing. So maybe "is_cancelable" is too specific?
What could we do to keep this code simple, understandable and consistent?
===
I would personally not block this patch for that reason. We use
IsItemOnHoldAndFound here to reduce yet more code to check the same; but this
report is not about that sub. I would prefer to move the sub to Koha::Holds
too, but that could well be done a its own report. If 4319 gets pushed and the
other one follows, a new report can merge them. Just my thoughts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Passed QA

--- Comment #83 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #82)
> WARNING: I have rebased bug 19301 on top of this one to avoid a rebase, but
> if this is not unblocked quickly I am going to rebase bug 19301 against
> master instead!

Here you are :)
You blocked it yourself and you didnt respond to my question in comment78.
Please do. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #82 from Jonathan Druart  
---
WARNING: I have rebased bug 19301 on top of this one to avoid a rebase, but if
this is not unblocked quickly I am going to rebase bug 19301 against master
instead!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Maksim  changed:

   What|Removed |Added

 CC||maksim@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |BLOCKED

--- Comment #81 from Jonathan Druart  
---
See bug 18856 comment 24.
I do not have the time right now to deep into it but I am collecting ideas to
keep the code smart.

Marked as blocked by 18856.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #80 from Alex Arnaud  ---
(In reply to Jonathan Druart from comment #77)
> 
> I am pretty sure something is wrong.

As already asked by Marcel, can you give me more explanation about what is
wrong?

Otherwise, i renamed hasItemswaitingOrInTransit to
has_items_waiting_or_intransit and and added pod description.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #79 from Alex Arnaud  ---
Created attachment 70457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70457=edit
Bug 4319 - [QA follow-up] Rename hasItemswaitingOrInTransit to
has_items_waiting_or_intransit and update pod

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #78 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #77)
> Also, when I see:
> @@ -1141,18 +1141,9 @@ sub IsAvailableForItemLevelRequest { 
> 
>  }
> 
>  return $any_available ? 0 : 1; 
> 
> +} else { # on_shelf_holds == 0 "If any unavailable" (the description is
> rather cryptic and could still be improved)
> +return $item->{onloan} || IsItemOnHoldAndFound( $item->{itemnumber}
> );  
> 
>  }
> -
> -if ($item->{onloan}) { 
> 
> -return 1;  
> 
> -}  
> 
> -
> -if ( Koha::Holds->search({itemnumber => $item->{itemnumber},   
> 
> -  found => ['W', 'T']})->count ) { 
> 
> -return 1;  
> 
> -}   
> 
> Then:
> +sub hasItemswaitingOrInTransit {
> +my ( $self ) = @_;
> +
> +if ( Koha::Holds->search({ biblionumber => $self->id,
> +   found => ['W', 'T'] })->count ) {
> +return 1;
> +}
> 
> I am pretty sure something is wrong.

It might be helpful to explain what you think is wrong. You are comparing
pieces of code here that have different goals.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #77 from Jonathan Druart  
---
Also, when I see:
@@ -1141,18 +1141,9 @@ sub IsAvailableForItemLevelRequest { 
 }

 return $any_available ? 0 : 1; 
+} else { # on_shelf_holds == 0 "If any unavailable" (the description is
rather cryptic and could still be improved)
+return $item->{onloan} || IsItemOnHoldAndFound( $item->{itemnumber} ); 
 }
-
-if ($item->{onloan}) { 
-return 1;  
-}  
-
-if ( Koha::Holds->search({itemnumber => $item->{itemnumber},   
-  found => ['W', 'T']})->count ) { 
-return 1;  
-}   

Then:
+sub hasItemswaitingOrInTransit {
+my ( $self ) = @_;
+
+if ( Koha::Holds->search({ biblionumber => $self->id,
+   found => ['W', 'T'] })->count ) {
+return 1;
+}

I am pretty sure something is wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #76 from Jonathan Druart  
---
Additionally, do you think adding camelCase method's name in a module
containing only snake_case is a good idea?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #75 from Jonathan Druart  
---
Comment on attachment 69815
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69815
Bug 4319: [OPAC] Allow holds on waiting/transit items

Review of attachment 69815:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=4319=69815)
-

::: Koha/Biblio.pm
@@ +319,5 @@
>  }
>  
> +=head3 hasItemswaitingOrInTransit
> +
> +=cut

Why are you cheating the QA script?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19301


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301
[Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #74 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #73)
> QA Comment:
> The POD statement is adjusted. Imo the POD should get some more attention.
> No blocker.

This is about the POD of IsAvailableForItemLevelRequest

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #72 from Marcel de Rooy  ---
Created attachment 69817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69817=edit
Bug 4319: (QA follow-up) Use ReservableItems in all scripts

[1] Call CountItemsIssued or hasItemswaitingOrInTransit when needed only.
[2] Add this logic to ISBD and MARC detail too, since they also use
this include.

Signed-off-by: Marcel de Rooy 
Confirming that Place hold now comes up if you have a waiting item and
circulation rule == If any unavailable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #71 from Marcel de Rooy  ---
Created attachment 69816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69816=edit
Bug 4319: (QA follow-up) Consistency in IsAvailableForItemLevelRequest

[1] For consistency going back to IsItemOnHoldAndFound in this sub.
This call is used in the on_shelf_holds == 2 case too.
The routine will be refactored quite soon.
Adding the else branch for on_shelf_holds == 0 for more clarity.
[2] Removing the test for found==F in reserves. In Koha F is only used
when the hold is filled and moved to oldreserves.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #73 from Marcel de Rooy  ---
QA Comment:
Thanks Alex for your perseverance. I am addressing your question from comment60
here too.
Putting this on top of sec report 19319 which does some changes to
Koha::Biblios->find in detail scripts.

IsItemOnHoldAndFound is only used in CanBookBeRenewed and
IsAvailableForItemLevelRequest; unfortunately it is not tested specifically.
I think it should be moved to Koha::Item. And it should not call DBIx directly
but use your search. The condition != undef is in practice the same as [W,T]
since F is only used when the reserve is filled (finished) and moved to
oldreserves.
For the same reason I remove this test (using F in the reserves table does not
reflect current use).
Koha::Holds->find($hold->{reserve_id})->found('F')->store;
$is = IsAvailableForItemLevelRequest( $item3, $borrower1);
is( $is, 0, "Item is neither waiting nor in transit." );
See the followup patches.

Rename hasItemswaitingOrInTransit => hasItemsWaitingOrInTransit ? No blocker.
The POD statement is adjusted. Imo the POD should get some more attention. No
blocker.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #69724|0   |1
is obsolete||
  Attachment #69728|0   |1
is obsolete||

--- Comment #70 from Marcel de Rooy  ---
Created attachment 69815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69815=edit
Bug 4319: [OPAC] Allow holds on waiting/transit items

Test plan:

 - Checkout an item
 - Place hold on this item,
 - Return the item
 - Make sure the hold is waiting (found W) and AllowOnShelfHolds is
   not to 'Allow'
 - Check that the button "Place hold" appears in opac detail page of
   the biblio

 - do the samewith items/reserves in transit

Changes on C4::Reserves::IsAvailableForItemLevelRequest

Make sure this tests pass:
  - t/db_dependent/Reserves.t
  - t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t

Rebased - 2017-12-12 - Alex Arnaud

Bug 4319 - [QA fix] Create Koha::Biblio->hasItemswaitingOrInTransit

Signed-off-by: Jon Knight 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||19319

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19301

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #69 from Marcel de Rooy  ---
QA: Looking here again

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #68 from Alex Arnaud  ---
@Marcel: did you read my question on Comment 60 ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #67 from Marcel de Rooy  ---
(In reply to Jon Knight from comment #66)
> Ah, sorry it was a sign off from applying the bugs using git bz as normal,
> so I'd not noticed it only included one.  Should be a complete sign off.

Thx.
@Alex: I plan to resume QA on this one soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #66 from Jon Knight  ---
Ah, sorry it was a sign off from applying the bugs using git bz as normal, so
I'd not noticed it only included one.  Should be a complete sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Jon Knight  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #65 from Jon Knight  ---
Ah, sorry it was a sign off from applying the bugs using git bz as normal, so
I'd not noticed it only included one.  Should be a complete sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #64 from Marcel de Rooy  ---
(In reply to Jon Knight from comment #63)
> Created attachment 69728 [details] [review]
> Bug 4319 - [QA fix] Create Koha::Biblio->hasItemswaitingOrInTransit
> 
> Signed-off-by: Jon Knight 

Jon,
For completeness: 
Did you intentionally sign off only the latest patch?
Or is it meant as a complete signoff and did you forget to change status?

Marcel

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Jon Knight  changed:

   What|Removed |Added

  Attachment #69725|0   |1
is obsolete||

--- Comment #63 from Jon Knight  ---
Created attachment 69728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69728=edit
Bug 4319 - [QA fix] Create Koha::Biblio->hasItemswaitingOrInTransit

Signed-off-by: Jon Knight 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #68786|0   |1
is obsolete||

--- Comment #61 from Alex Arnaud  ---
Created attachment 69724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69724=edit
Bug 4319 - [OPAC] allow to holds waiting items

Test plan:

 - Checkout an item
 - Place hold on this item,
 - Return the item
 - Make sure the hold is waiting (found W) and AllowOnShelfHolds is
   not to 'Allow'
 - Check that the button "Place hold" appears in opac detail page of
   the biblio

 - do the samewith items/reserves in transit

Changes on C4::Reserves::IsAvailableForItemLevelRequest

Make sure this tests pass:
  - t/db_dependent/Reserves.t
  - t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t

Rebased - 2017-12-12 - Alex Arnaud

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #62 from Alex Arnaud  ---
Created attachment 69725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69725=edit
Bug 4319 - [QA fix] Create Koha::Biblio->hasItemswaitingOrInTransit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #60 from Alex Arnaud  ---
(In reply to Marcel de Rooy from comment #56)
> It would be more consistent if we should use IsItemOnHoldAndFound in
> IsAvailableForItemLevelRequest instead of a Koha::Holds->search. We actually
> should adjust that routine. It does the same.

Are we sure IsItemOnHoldAndFound does the same than Koha::Holds->search on W
and T?
What about a F status? Is it already used?

Patch is coming for the others QA things

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Alex Arnaud  changed:

   What|Removed |Added

Summary|waiting items cannot be |waiting and in transit
   |reserved|items cannot be reserved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/