[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #41 from Mason James  ---
Pushed to 16.05.x, for 16.05.13 release

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #40 from Julian Maurice  ---
Pushed to 3.22.x for 3.22.21

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #39 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.08.

Always glad to see this 4 digit bug numbers resolved.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #38 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Mark!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Nick Clemens  changed:

   What|Removed |Added

  Attachment #62922|0   |1
is obsolete||

--- Comment #37 from Nick Clemens  ---
Created attachment 63328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63328=edit
Bug 4460: Amazon's AssociateID tag not used in links so referred revenue lost

Reworking based on output of:
git grep "gp\/reader"
Additionally, some changes might be in order though gp/reader works.
https://affiliate-program.amazon.com/help/topic/t64/a1
suggests using dp
A dp was discovered, so that part of the URL was left unchanged.
The "/ref..." part was changed to just an Amazon tag ("?tag={AAT}")
if defined.

TEST PLAN
-
 1) Added:
 "100 years of Canadian foreign policy /
  edited by Robert Bothwell and Jean Daudelin."
 2) Added a second book with the word foreign in the title.
 3) Waited for reindex
 4) Checked out the Canadian foreign policy book.
 5) Applied patch
 6) Made sure that:
- AmazonAssocTag was set to TEST (easy to notice)
- AmazonCoverImages was set to 'Show'
- OPACAmazonCoverImages was set to 'Show'
 7) Searched intranet for 'foreign' to find the detail page
-- hovering over picture shows URL with ?tag=TEST in it.
 8) Went to the OPAC Detail page
 9) Toggling OPACURLOpenInNewWindow, confirmed that URL for
the picture contained ?tag=TEST in it.
10) Logged into the OPAC
11) Confirmed the URL in the checked out list on your summary
page contained ?tag=TEST in it.
12) Confirmed the URL in the checked out list on your reading
history page contained ?tag=TEST in it.
13) Confirmed links worked (went to expected page)
14) run koha qa test tools

Followed test plan. Works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer  

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #36 from Katrin Fischer  ---
(In reply to Marc Véron from comment #33)
> Created attachment 60127 [details]
> Error message on Amazon
> 
> I tested some weeks ago and now again, the link to Amazon leads to an error
> message (see screenshot).
> Tested from Intranet detail page with "100 years of Canadian foreign policy
> / edited by Robert Bothwell and Jean Daudelin."
> Link to Amazon is:
> https://www.amazon.com/gp/reader/0773534342?tag=TEST#reader-link


Hm, I see the same problem without this patch as well - I think Amazon might
have changed something.

To me this appears to happen, when we have #reader-link attached and there is
no 'reader link' (preview feature) available for the article on Amazon.
Something else I noticed is that we open the Amazon page in the same tab, for
external sources, it's better to always open in a new tab. 

Should we take those 2 issues to a new bug? 

I've signed off on those patches for fixing the problem with the AssociateID.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #62921|0   |1
is obsolete||

--- Comment #35 from Katrin Fischer  ---
Created attachment 62922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62922=edit
[SIGNED OFF] Bug 4460: Amazon's AssociateID tag not used in links so referred
revenue lost

Reworking based on output of:
git grep "gp\/reader"
Additionally, some changes might be in order though gp/reader works.
https://affiliate-program.amazon.com/help/topic/t64/a1
suggests using dp
A dp was discovered, so that part of the URL was left unchanged.
The "/ref..." part was changed to just an Amazon tag ("?tag={AAT}")
if defined.

TEST PLAN
-
 1) Added:
 "100 years of Canadian foreign policy /
  edited by Robert Bothwell and Jean Daudelin."
 2) Added a second book with the word foreign in the title.
 3) Waited for reindex
 4) Checked out the Canadian foreign policy book.
 5) Applied patch
 6) Made sure that:
- AmazonAssocTag was set to TEST (easy to notice)
- AmazonCoverImages was set to 'Show'
- OPACAmazonCoverImages was set to 'Show'
 7) Searched intranet for 'foreign' to find the detail page
-- hovering over picture shows URL with ?tag=TEST in it.
 8) Went to the OPAC Detail page
 9) Toggling OPACURLOpenInNewWindow, confirmed that URL for
the picture contained ?tag=TEST in it.
10) Logged into the OPAC
11) Confirmed the URL in the checked out list on your summary
page contained ?tag=TEST in it.
12) Confirmed the URL in the checked out list on your reading
history page contained ?tag=TEST in it.
13) Confirmed links worked (went to expected page)
14) run koha qa test tools

Followed test plan. Works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #57688|0   |1
is obsolete||

--- Comment #34 from Katrin Fischer  ---
Created attachment 62921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62921=edit
[SIGNED OFF] Bug 4460: Amazon's AssociateID tag not used in links so referred
revenue lost

Reworking based on output of:
git grep "gp\/reader"
Additionally, some changes might be in order though gp/reader works.
https://affiliate-program.amazon.com/help/topic/t64/a1
suggests using dp
A dp was discovered, so that part of the URL was left unchanged.
The "/ref..." part was changed to just an Amazon tag ("?tag={AAT}")
if defined.

TEST PLAN
-
 1) Added:
 "100 years of Canadian foreign policy /
  edited by Robert Bothwell and Jean Daudelin."
 2) Added a second book with the word foreign in the title.
 3) Waited for reindex
 4) Checked out the Canadian foreign policy book.
 5) Applied patch
 6) Made sure that:
- AmazonAssocTag was set to TEST (easy to notice)
- AmazonCoverImages was set to 'Show'
- OPACAmazonCoverImages was set to 'Show'
 7) Searched intranet for 'foreign' to find the detail page
-- hovering over picture shows URL with ?tag=TEST in it.
 8) Went to the OPAC Detail page
 9) Toggling OPACURLOpenInNewWindow, confirmed that URL for
the picture contained ?tag=TEST in it.
10) Logged into the OPAC
11) Confirmed the URL in the checked out list on your summary
page contained ?tag=TEST in it.
12) Confirmed the URL in the checked out list on your reading
history page contained ?tag=TEST in it.
13) Confirmed links worked (went to expected page)
14) run koha qa test tools

Followed test plan. Works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #33 from Marc Véron  ---
Created attachment 60127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60127=edit
Error message on Amazon

I tested some weeks ago and now again, the link to Amazon leads to an error
message (see screenshot).
Tested from Intranet detail page with "100 years of Canadian foreign policy /
edited by Robert Bothwell and Jean Daudelin."
Link to Amazon is:
https://www.amazon.com/gp/reader/0773534342?tag=TEST#reader-link

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #32 from M. Tompsett  ---
I put this to "Needs Signoff" in case, Marc should retest it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

M. Tompsett  changed:

   What|Removed |Added

  Attachment #54746|0   |1
is obsolete||

--- Comment #31 from M. Tompsett  ---
Created attachment 57688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57688=edit
Bug 4460: Amazon's AssociateID tag not used in links so referred revenue lost

Reworking based on output of:
git grep "gp\/reader"
Additionally, some changes might be in order though gp/reader works.
https://affiliate-program.amazon.com/help/topic/t64/a1
suggests using dp
A dp was discovered, so that part of the URL was left unchanged.
The "/ref..." part was changed to just an Amazon tag ("?tag={AAT}")
if defined.

TEST PLAN
-
 1) Added:
 "100 years of Canadian foreign policy /
  edited by Robert Bothwell and Jean Daudelin."
 2) Added a second book with the word foreign in the title.
 3) Waited for reindex
 4) Checked out the Canadian foreign policy book.
 5) Applied patch
 6) Made sure that:
- AmazonAssocTag was set to TEST (easy to notice)
- AmazonCoverImages was set to 'Show'
- OPACAmazonCoverImages was set to 'Show'
 7) Searched intranet for 'foreign' to find the detail page
-- hovering over picture shows URL with ?tag=TEST in it.
 8) Went to the OPAC Detail page
 9) Toggling OPACURLOpenInNewWindow, confirmed that URL for
the picture contained ?tag=TEST in it.
10) Logged into the OPAC
11) Confirmed the URL in the checked out list on your summary
page contained ?tag=TEST in it.
12) Confirmed the URL in the checked out list on your reading
history page contained ?tag=TEST in it.
13) Confirmed links worked (went to expected page)
14) run koha qa test tools

Followed test plan. Works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

M. Tompsett  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #30 from Katrin Fischer  ---
My research suggests that the ref parameter is not needed - we could remove it
and that would also solve the dangling & problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #29 from M. Tompsett  ---
So, Katrin, how are we fixing this?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #28 from Katrin Fischer  ---
I am not persuaded that the ref is really an important part - and if you are
paid by it it would be interesting to know what our hardcoded value means.

No mention of the ref parameter:
https://affiliate-program.amazon.com/help/operating/linking
https://affiliate-program.amazon.com/help/topic/t64/a1

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #27 from M. Tompsett  ---
(In reply to Katrin Fischer from comment #26)
> I searched for documentation up and down last night - didn't come up with
> much. 
> 
> We don't have a 'please give feedback' status - so I am setting 'Failed QA',
> please take a look and consider/comment.

My guess, and I'm assuming Amazon would be able to tell us, is that ref=...
means that is the page it came from. In terms of generating revenue, I'm
guessing that not just the tag but the ref is also paid. Only Amazon would
know. And their documentation is not easily searched through.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #26 from Katrin Fischer  ---
I searched for documentation up and down last night - didn't come up with much. 

We don't have a 'please give feedback' status - so I am setting 'Failed QA',
please take a look and consider/comment.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #25 from Katrin Fischer  ---
I ended up way back... where no bug numbers and explanations exist.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #24 from Katrin Fischer  ---
It looks like Reed Wade removed the ref parameter in the first attempt to fix
this bug:
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10024

Wasn't able to find out when and why it was added.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #23 from Katrin Fischer  ---
I am not a real fan of the dangling '&' - instead of fixing it, does someone
know of the ref parameter is required? It appears to be hardcoded to
ref=sib_dp_pt/002-7879865-0184864, but links also appear to work without it?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Marc Véron  changed:

   What|Removed |Added

  Attachment #52670|0   |1
is obsolete||

--- Comment #22 from Marc Véron  ---
Created attachment 54746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54746=edit
Bug 4460: Amazon's AssociateID tag not used in links so referred revenue lost

Reworking based on output of:
git grep "gp\/reader"
Additionally, some changes might be in order though gp/reader works.
https://affiliate-program.amazon.com/help/topic/t64/a1
suggests using dp
A dp was discovered, so that part of the URL was left unchanged.
The "/ref..." part was changed to "?tag={AAT}"

TEST PLAN
-
 1) Added:
 "100 years of Canadian foreign policy /
  edited by Robert Bothwell and Jean Daudelin."
 2) Added a second book with the word foreign in the title.
 3) Waited for reindex
 4) Checked out the Canadian foreign policy book.
 5) Applied patch
 6) Made sure that:
- AmazonAssocTag was set to TEST (easy to notice)
- AmazonCoverImages was set to 'Show'
- OPACAmazonCoverImages was set to 'Show'
 7) Searched intranet for 'foreign' to find the detail page
-- hovering over picture shows URL with ?tag=TEST& in it.
 8) Went to the OPAC Detail page
 9) Toggling OPACURLOpenInNewWindow, confirmed that URL for
the picture contained ?tag=TEST& in it.
10) Logged into the OPAC
11) Confirmed the URL in the checked out list on your summary
page contained ?tag=TEST& in it.
12) Confirmed the URL in the checked out list on your reading
history page contained ?tag=TEST& in it.
13) Confirmed links worked (went to expected page)
14) run koha qa test tools

Followed test plan. Works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Marc Véron  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #21 from Marc Véron  ---
(In reply to Marc Véron from comment #20)
> (In reply to M. Tompsett from comment #19)
> > (In reply to Marc Véron from comment #17)
> > > I tested and got following results:
> > > OPAC:
> > > Detail page:
> > > http://www.amazon.com/dp/3907142330?tag=TEST;
> > 
> > Missing ref=sib_dp_pt/002-7879865-0184864 is not the issue. The issue is the
> > dangling ampersand. Though if you really think that adding the ref portion
> > is the correct course of action, I could do that. What say you, Marc?
> 
> I did some research, it seems that
> http://www.amazon.com/dp/3907142330?tag=TEST will be OK. Trailing & is
> superfluous. It seems to do no harm but can we remove it anyway?

Re-tested with full test plan. Dangling ampersand does no harm.
Will sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #20 from Marc Véron  ---
(In reply to M. Tompsett from comment #19)
> (In reply to Marc Véron from comment #17)
> > I tested and got following results:
> > OPAC:
> > Detail page:
> > http://www.amazon.com/dp/3907142330?tag=TEST;
> 
> Missing ref=sib_dp_pt/002-7879865-0184864 is not the issue. The issue is the
> dangling ampersand. Though if you really think that adding the ref portion
> is the correct course of action, I could do that. What say you, Marc?

I did some research, it seems that http://www.amazon.com/dp/3907142330?tag=TEST
will be OK. Trailing & is superfluous. It seems to do no harm but can we remove
it anyway?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #19 from M. Tompsett  ---
(In reply to Marc Véron from comment #17)
> I tested and got following results:
> OPAC:
> Detail page:
> http://www.amazon.com/dp/3907142330?tag=TEST;

Missing ref=sib_dp_pt/002-7879865-0184864 is not the issue. The issue is the
dangling ampersand. Though if you really think that adding the ref portion is
the correct course of action, I could do that. What say you, Marc?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||l...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

--- Comment #18 from M. Tompsett  ---
(In reply to Marc Véron from comment #17)
> Fazit: tag=TEST& added to all links, but on OPAC detail page the reminder of
> the link is missing.

Sucky. Will attempt to fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #17 from Marc Véron  ---
I tested and got follwoing results:

Staff client - detail page:

http://www.amazon.com/gp/reader/3257217358?tag=TEST=sib_dp_pt/002-7879865-0184864#reader-link

OPAC:

Detail page:
http://www.amazon.com/dp/3907142330?tag=TEST;

Checked out:
http://www.amazon.com/gp/reader/3907142330?tag=TEST=sib_dp_pt/002-7879865-0184864#reader-link

Reading history:
http://www.amazon.com/gp/reader/3907142330?tag=TEST=sib_dp_pt/002-7879865-0184864#reader-link

Fazit: tag=TEST& added to all links, but on OPAC detail page the reminder of
the link is missing.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

M. Tompsett  changed:

   What|Removed |Added

   Severity|enhancement |normal
   Assignee|k...@bywatersolutions.com   |mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/