[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #30 from Aleisha Amohia --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.03 released in|| --- Comment #29 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #28 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #27 from Jonathan Druart --- Created attachment 107224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107224=edit Bug 5087: Add server-side check If a user to access a CSV profile that is not available at the OPAC we should redirect to 404. It will also handle undefined csv_profiles For instance: kohadev.mydnsname.org:8080/cgi-bin/koha/opac-downloadshelf.pl?shelfnumber=1=3 kohadev.mydnsname.org:8080/cgi-bin/koha/opac-downloadcart.pl?bib_list=1/2/=3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #26 from Katrin Fischer --- Tomas is right, it makes more sense this way. We don't want 'opac only' we want 'staff only'. Usually you want the option with "less exposed" to be the default :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #25 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #24) > > Can you explain a bit more Tomas? > Should not we usually provide "OPAC only" by default, and explicitly pass > the "staff" flag? This is not 'opac only', this is like the 'public' flag on reports, i.e. 'staff only', and the author named it 'opac_display'. The original naming also required to pass it on the query in the OPAC controllers, I just thought it was better to name it different, and so the flipped value also. The default behavior is kept with my follow-up and DB default values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #24 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #20) > Created attachment 107167 [details] [review] > Bug 5087: (QA follow-up) Rename the attribute to fit later API usage > > This patch renames the introduced attribute for later usage on the API, > and changes the logic to use it the other way around. > > It also adds a KEY for the flag, as it will be used in WHERE statements. > > Signed-off-by: Tomas Cohen Arazi Can you explain a bit more Tomas? Should not we usually provide "OPAC only" by default, and explicitly pass the "staff" flag? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Tomás Cohen Arazi changed: What|Removed |Added Attachment #107112|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 107169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107169=edit Bug 5087: (QA follow-up) Fix leakage in opac-downloadshelf.pl Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #23 from Tomás Cohen Arazi --- Rebased the follow-up, boss. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 107166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107166=edit Bug 5087: Ability to define whether CSV profile shows in OPAC To test: 1) Update database 2) Update schema 3) In staff side, go to Tools -> CSV profiles 4) Make a CSV profile with profile type = MARC and usage = Export records 5) Leave 'Show option in OPAC' unchecked and save 6) Go to OPAC and add an item to your cart 7) Click Cart, click Download, confirm that your newly created CSV profile does not show as an option 8) Go back and edit CSV profile on staff side 9) Check the 'Show option in OPAC' checkbox and save 10) Go back to download cart in OPAC 11) Confirm the CSV profile now shows in the dropdown Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 107168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107168=edit Bug 5087: (QA follow-up) used_for deserves an index This patch introduces an index for the used_for column Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Tomás Cohen Arazi changed: What|Removed |Added Attachment #107111|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Tomás Cohen Arazi changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Tomás Cohen Arazi changed: What|Removed |Added Attachment #107113|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Tomás Cohen Arazi changed: What|Removed |Added Attachment #107114|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 107167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107167=edit Bug 5087: (QA follow-up) Rename the attribute to fit later API usage This patch renames the introduced attribute for later usage on the API, and changes the logic to use it the other way around. It also adds a KEY for the flag, as it will be used in WHERE statements. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Passed QA |Patch doesn't apply --- Comment #18 from Jonathan Druart --- Applying: Bug 5087: (QA follow-up) Rename the attribute to fit later API usage error: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Tomás Cohen Arazi changed: What|Removed |Added Text to go in the|This patch adds an option |This patch adds an option release notes|to show or not show a CSV |to show or not show a CSV |profile in the OPAC cart|profile in the OPAC cart |download formats list. |and lists download formats ||list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 107114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107114=edit Bug 5087: (QA follow-up) Fix leakage in opac-downloadshelf.pl Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 107113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107113=edit Bug 5087: (QA follow-up) used_for deserves an index This patch introduces an index for the used_for column Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 107112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107112=edit Bug 5087: (QA follow-up) Rename the attribute to fit later API usage This patch renames the introduced attribute for later usage on the API, and changes the logic to use it the other way around. It also adds a KEY for the flag, as it will be used in WHERE statements. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Tomás Cohen Arazi changed: What|Removed |Added Attachment #103955|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 107111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107111=edit Bug 5087: Ability to define whether CSV profile shows in OPAC To test: 1) Update database 2) Update schema 3) In staff side, go to Tools -> CSV profiles 4) Make a CSV profile with profile type = MARC and usage = Export records 5) Leave 'Show option in OPAC' unchecked and save 6) Go to OPAC and add an item to your cart 7) Click Cart, click Download, confirm that your newly created CSV profile does not show as an option 8) Go back and edit CSV profile on staff side 9) Check the 'Show option in OPAC' checkbox and save 10) Go back to download cart in OPAC 11) Confirm the CSV profile now shows in the dropdown Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Katrin Fischer changed: What|Removed |Added Blocks|25402 | Depends on||25402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25402 [Bug 25402] Put OPAC cart download options into dropdown menu -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer --- Hi Aleisha, thanks a lot for taking these on! 1) With this patch we will hide any CSV profiles now shown in the OPAC. I think we should add an update for the existing CSV profiles to check the checkbox, so that we have no change of behaviour on update. 2) Can you please make the same change for the lists download? That should then cover all bases! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Owen Leonard changed: What|Removed |Added Blocks||25402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25402 [Bug 25402] Put OPAC cart download options into dropdown menu -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Owen Leonard changed: What|Removed |Added Attachment #103506|0 |1 is obsolete|| --- Comment #12 from Owen Leonard --- Created attachment 103955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103955=edit Bug 5087: Ability to define whether CSV profile shows in OPAC To test: 1) Update database 2) Update schema 3) In staff side, go to Tools -> CSV profiles 4) Make a CSV profile with profile type = MARC and usage = Export records 5) Leave 'Show option in OPAC' unchecked and save 6) Go to OPAC and add an item to your cart 7) Click Cart, click Download, confirm that your newly created CSV profile does not show as an option 8) Go back and edit CSV profile on staff side 9) Check the 'Show option in OPAC' checkbox and save 10) Go back to download cart in OPAC 11) Confirm the CSV profile now shows in the dropdown Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #10 from David Nind --- Thanks Aleisha, the database update now works. Everything now works as per the test plan. However, when testing I tried to turn off the 'Show option in OPAC' setting and I get this error message: "An error occurred when updating this CSV profile. Perhaps it already exists." This appears in red at the top of the CSV profiles page after pressing the submit button. I can successfully make changes to any of the other form elements for the CSV profile. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Aleisha Amohia changed: What|Removed |Added Text to go in the||This patch adds an option release notes||to show or not show a CSV ||profile in the OPAC cart ||download formats list. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #11 from Aleisha Amohia --- Thanks for testing David, but unfortunately I'm not getting that error! Perhaps a data problem? Setting back to Needs signoff in case this is working as expected for someone else. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Aleisha Amohia changed: What|Removed |Added Attachment #103437|0 |1 is obsolete|| --- Comment #9 from Aleisha Amohia --- Created attachment 103506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103506=edit Bug 5087: Ability to define whether CSV profile shows in OPAC To test: 1) Update database 2) Update schema 3) In staff side, go to Tools -> CSV profiles 4) Make a CSV profile with profile type = MARC and usage = Export records 5) Leave 'Show option in OPAC' unchecked and save 6) Go to OPAC and add an item to your cart 7) Click Cart, click Download, confirm that your newly created CSV profile does not show as an option 8) Go back and edit CSV profile on staff side 9) Check the 'Show option in OPAC' checkbox and save 10) Go back to download cart in OPAC 11) Confirm the CSV profile now shows in the dropdown Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
Status|Needs Signoff |Failed QA
--- Comment #8 from David Nind ---
Hi Aleisha.
I get this error when trying to do the database update:
root@eb7cfcd62ddf:koha(bz5087)$ perl installer/data/mysql/updatedatabase.pl
{UNKNOWN}: Can't locate object method "add_columns" via package "PACKAGE__"
(perhaps you forgot to load "PACKAGE__"?) at
/kohadevbox/koha/Koha/Schema/Result/ExportFormat.pm line 159.
Compilation failed in require at /usr/share/perl5/Class/C3/Componentised.pm
line 150. at /usr/share/perl5/Class/C3/Componentised.pm line 155
Compilation failed in require at /kohadevbox/koha/Koha/Database.pm line 50.
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Aleisha Amohia changed: What|Removed |Added Attachment #98779|0 |1 is obsolete|| --- Comment #7 from Aleisha Amohia --- Created attachment 103437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103437=edit Bug 5087: Ability to define whether CSV profile shows in OPAC To test: 1) Update database 2) Update schema 3) In staff side, go to Tools -> CSV profiles 4) Make a CSV profile with profile type = MARC and usage = Export records 5) Leave 'Show option in OPAC' unchecked and save 6) Go to OPAC and add an item to your cart 7) Click Cart, click Download, confirm that your newly created CSV profile does not show as an option 8) Go back and edit CSV profile on staff side 9) Check the 'Show option in OPAC' checkbox and save 10) Go back to download cart in OPAC 11) Confirm the CSV profile now shows in the dropdown Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #6 from Aleisha Amohia --- (In reply to Owen Leonard from comment #5) > I get this warning from the QA tool: > > FAIL installer/data/mysql/kohastructure.sql >OK boolean_vs_tinyint >OK charset_collate >OK git manipulation >FAIL tinyint_has_boolean_flag > The new column export_format.opac_option is using TINYINT(1) > as type but is not defined as boolean in the schema file > (Koha/Schema/Result/ExportFormat.pm), see the SQL12 coding guideline Hi Owen, did you update the schema files? misc/devel/update_dbix_class_files.pl --db_name=koha_instance --db_user=koha_instance --db_passwd=thepassword -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- I get this warning from the QA tool: FAIL installer/data/mysql/kohastructure.sql OK boolean_vs_tinyint OK charset_collate OK git manipulation FAIL tinyint_has_boolean_flag The new column export_format.opac_option is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/ExportFormat.pm), see the SQL12 coding guideline -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Aleisha Amohia changed: What|Removed |Added Attachment #83664|0 |1 is obsolete|| --- Comment #4 from Aleisha Amohia --- Created attachment 98779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98779=edit Bug 5087: Ability to define whether CSV profile shows in OPAC To test: 1) Update database 2) Update schema 3) In staff side, go to Tools -> CSV profiles 4) Make a CSV profile with profile type = MARC and usage = Export records 5) Leave 'Show option in OPAC' unchecked and save 6) Go to OPAC and add an item to your cart 7) Click Cart, click Download, confirm that your newly created CSV profile does not show as an option 8) Go back and edit CSV profile on staff side 9) Check the 'Show option in OPAC' checkbox and save 10) Go back to download cart in OPAC 11) Confirm the CSV profile now shows in the dropdown Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- Hi Aleisha, please don't forget to change kohastructure.sql as well. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Maryse Simard changed: What|Removed |Added Attachment #83438|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 83664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83664=edit Bug 5087: Ability to define whether CSV profile shows in OPAC To test: 1) Update database 2) Update schema 3) In staff side, go to Tools -> CSV profiles 4) Make a CSV profile with profile type = MARC and usage = Export records 5) Leave 'Show option in OPAC' unchecked and save 6) Go to OPAC and add an item to your cart 7) Click Cart, click Download, confirm that your newly created CSV profile does not show as an option 8) Go back and edit CSV profile on staff side 9) Check the 'Show option in OPAC' checkbox and save 10) Go back to download cart in OPAC 11) Confirm the CSV profile now shows in the dropdown Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored CC||alei...@catalyst.net.nz Assignee|gmcha...@gmail.com |alei...@catalyst.net.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #1 from Aleisha Amohia --- Created attachment 83438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83438=edit Bug 5087: Ability to define whether CSV profile shows in OPAC To test: 1) Update database 2) Update schema 3) In staff side, go to Tools -> CSV profiles 4) Make a CSV profile with profile type = MARC and usage = Export records 5) Leave 'Show option in OPAC' unchecked and save 6) Go to OPAC and add an item to your cart 7) Click Cart, click Download, confirm that your newly created CSV profile does not show as an option 8) Go back and edit CSV profile on staff side 9) Check the 'Show option in OPAC' checkbox and save 10) Go back to download cart in OPAC 11) Confirm the CSV profile now shows in the dropdown Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Aleisha Amohia changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
