[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Lari Taskula  changed:

   What|Removed |Added

 Blocks|18494   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494
[Bug 18494] Fix Letters.t (follow-up of 5260)
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Lari Taskula  changed:

   What|Removed |Added

 Blocks||18494


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494
[Bug 18494] Fix Letters.t (follow-up of 5260)
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #78 from Mason James  ---
New feature, skipping for 16.05.x

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17659


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17659
[Bug 17659] sample_notices.sql is broken for fr-QA
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #77 from Katrin Fischer  ---
I think I need help to fix the tests. :(

My guess right now is that the "from" address, which for claims and orders is
the email of the librarian sending it, is somehow generated and not valid -
which could break the tests like that:

# found carped warning: Bad or missing From address: ''
found carped warning: Bad or missing From address: 'SSi32Vsm4u'

The tests did run nicely when I was developing this, I haven't been able to
locate when and why they broke :(

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #76 from Katrin Fischer  ---
Ok, I will try... :(

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #75 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #74)
> Which tests does it break? t/db_dependent/Letters.t?

Yes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #74 from Katrin Fischer  ---
Which tests does it break? t/db_dependent/Letters.t?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #73 from Jonathan Druart  
---
Katrin, could you have a look, it seems that the tests are failing now

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #72 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Katrin, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56706|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #71 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #60)
> Hi Jonathan, I have added a patch asking for confirmation, but honestly.. I
> am not persuaded by it.
> I think this will get annoying quite fast when you are working with the
> acquisition module on a daily basis. Also: we don't ask for confirmation for
> sending out a claim email neither in serials nor acquisitions.

Agreed, I obsoleted it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56707|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56709|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56708|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #70 from Jonathan Druart  
---
Created attachment 56795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56795=edit
Bug 5260: Use post params instead of get to avoid putting op=email in the
browser history

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56705|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #69 from Jonathan Druart  
---
Created attachment 56794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56794=edit
Bug 5260: simplify script and error handling

No need to redirect, just sent the params to the template directly

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #68 from Jonathan Druart  
---
Created attachment 56793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56793=edit
Bug 5260: Insert the new letter for existing installs

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #67 from Jonathan Druart  
---
Created attachment 56792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56792=edit
Bug 5260: make tests pass even without patron cat 'PT'

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56680|0   |1
is obsolete||

--- Comment #66 from Jonathan Druart  
---
Created attachment 56791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56791=edit
Bug 5260: QA follow-up - Add sample ACQORDER notice to sample notices

Adds the new notice ACQORDER to all web installers.

Verify by testing the SQL contains no errors and by running:
perl xt/sample_notices.t

NOTE:
- de-DE is already translated, others are in English.
- xt/sample_notices.t doesn't check fr-CA yet. I didn't fix this here
  as the file is missing other notices as well which should be fixed
  separately.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56679|0   |1
is obsolete||

--- Comment #65 from Jonathan Druart  
---
Created attachment 56790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56790=edit
Bug 5260: QA follow-up: Fix error when no notice template is defined

When no notice template ACQORDER was defined, you'r receive a false
positive "email sent" message. Now it will display a specific
error message instead.

Also includes 2 unit tests to test for the warn and new error code.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56562|0   |1
is obsolete||

--- Comment #63 from Jonathan Druart  
---
Created attachment 56788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56788=edit
Bug 5260 - Schema changes

Schema changes for new column in the aqcontacts table.

Signed-off-by: Martin Renvoize 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56568|0   |1
is obsolete||

--- Comment #64 from Jonathan Druart  
---
Created attachment 56789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56789=edit
Bug 5260: Follow-up - Reindenting POD of SendAlerts

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56560|0   |1
is obsolete||

--- Comment #61 from Jonathan Druart  
---
Created attachment 56786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56786=edit
Bug 5260 - Add option to send an order by e-mail to the acquisition module

With this patch it will be possible to send order information
to the vendor by e-mail. For now this feature can be triggered
manually with a button before closing the basket.
The order e-mail is based on the acquisition claim feature, but
uses a new notice template.

Test plan:

1) Vendors
A new checkbox "Contact when ordering?" was added to the vendor
page.
- Add a vendor and/or edit an existing vendor
- Verify the new option is saved correctly
- Verify the new option displays on the vendor summary page
  after saving

2) Notices
The feature works with a new notice template: ACQORDER
It works with the same formatting/fields etc. as the acq claim
notice.
- Add a new notice template ACQORDER in module
  'Claim/order aquisition'
- Make sure to use fields from the various offered tables
  in your notice
- Verify it is saved correctly

3) Basket
- Turn on LetterLog system preference
- Create multiple order lines
- Click the 'Send order' button in the toolbar
- Verify error or success message
- Verify you received the e-mail
- Verify there is a new entry with about the sent
  notice in your action_logs table

4) Regression testing...
- Verify order claims still work
- Verify serial claims still work
- Verify new serial issue notices still work
...
(I can provide additional test plans if needed)

Signed-off-by: Martin Renvoize 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56561|0   |1
is obsolete||

--- Comment #62 from Jonathan Druart  
---
Created attachment 56787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56787=edit
Bug 5260: Unit tests for new functionality in SendAlert

Signed-off-by: Martin Renvoize 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #56 from Katrin Fischer  ---
Created attachment 56706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56706=edit
[SIGNED OFF] Bug 5260: Insert the new letter for existing installs

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #60 from Katrin Fischer  ---
Hi Jonathan, I have added a patch asking for confirmation, but honestly.. I am
not persuaded by it.
I think this will get annoying quite fast when you are working with the
acquisition module on a daily basis. Also: we don't ask for confirmation for
sending out a claim email neither in serials nor acquisitions.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #59 from Katrin Fischer  ---
Created attachment 56709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56709=edit
Bug 5260: QA follow-up - Ask for confirmation before sending e-mail

With this patch there will be a confirmation alert when clicking
on 'E-mail order'.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #58 from Katrin Fischer  ---
Created attachment 56708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56708=edit
[SIGNED OFF] Bug 5260: Use post params instead of get to avoid putting op=email
in the browser history

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #56686|0   |1
is obsolete||
  Attachment #56687|0   |1
is obsolete||
  Attachment #56688|0   |1
is obsolete||
  Attachment #56689|0   |1
is obsolete||

--- Comment #55 from Katrin Fischer  ---
Created attachment 56705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56705=edit
[SIGNED OFF] Bug 5260: make tests pass even without patron cat 'PT'

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #57 from Katrin Fischer  ---
Created attachment 56707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56707=edit
[SIGNED OFF] Bug 5260: simplify script and error handling

No need to redirect, just sent the params to the template directly

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #54 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #53)
> Katrin,
> Could you have a look at the 4 patches please? They should not introduce any
> regression.
> I am wondering if we should not add a confirmation box as the button will
> sent an email.
> I also think that the button should not be displayed if the vendor does not
> have any email address defined, don't you think?

Hi Jonathan, thx for the follow-ups! I will test them later, but they all look
good to me and make sense.

I was modeling this from the way we send e-mails for claims. I am not against a
confirmation box, I can try to take a look at how this is done on other pages. 

Arguments for showing the button: The user gets an informative message, that
they need to edit a vendor contact in order to make it work. 

Also: I am not sure how to achieve hiding it correctly :( The logic here is not
as simple as checking for an email address in the vendor, as there can be
multiple contacts and the SendAlerts give priority to the one that is
acqprimary and has the right option checked (Take a look at the SQL in
SendAlerts).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #53 from Jonathan Druart  
---
Katrin,
Could you have a look at the 4 patches please? They should not introduce any
regression.
I am wondering if we should not add a confirmation box as the button will sent
an email.
I also think that the button should not be displayed if the vendor does not
have any email address defined, don't you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #52 from Jonathan Druart  
---
Created attachment 56689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56689=edit
Bug 5260: Use post params instead of get to avoid putting op=email in the
browser history

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #49 from Jonathan Druart  
---
Created attachment 56686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56686=edit
Bug 5260: make tests pass even without patron cat 'PT'

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #50 from Jonathan Druart  
---
Created attachment 56687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56687=edit
Bug 5260: Insert the new letter for existing installs

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #51 from Jonathan Druart  
---
Created attachment 56688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56688=edit
Bug 5260: simplify script and error handling

No need to redirect, just sent the params to the template directly

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||17469


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469
[Bug 17469] fr-CA web installer is missing some sample notices
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer  changed:

   What|Removed |Added

 Blocks|17469   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469
[Bug 17469] fr-CA web installer is missing some sample notices
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #48 from Katrin Fischer  ---
Created attachment 56680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56680=edit
Bug 5260: QA follow-up - Add sample ACQORDER notice to sample notices

Adds the new notice ACQORDER to all web installers.

Verify by testing the SQL contains no errors and by running:
perl xt/sample_notices.t

NOTE:
- de-DE is already translated, others are in English.
- xt/sample_notices.t doesn't check fr-CA yet. I didn't fix this here
  as the file is missing other notices as well which should be fixed
  separately.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #47 from Katrin Fischer  ---
Hi Jonathan,

thx for the review and catching this! I have (hopefully) fixed the problem. Can
you please take a look at the follow-up patch?

> Is there a good reason not to add the new ACQORDER notice?

No good reason really, more an oversight! I will work on another follow-up
covering it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #46 from Katrin Fischer  ---
Created attachment 56679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56679=edit
Bug 5260: QA follow-up: Fix error when no notice template is defined

When no notice template ACQORDER was defined, you'r receive a false
positive "email sent" message. Now it will display a specific
error message instead.

Also includes 2 unit tests to test for the warn and new error code.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #45 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #44)
> Is there a good reason not to add the new ACQORDER notice?

Without the letter created I get
"Order e-mail was sent to the vendor." on the interface, but

No orderacquisition ACQORDER letter transported by email at
/home/koha/src/C4/Letters.pm line 689.

in the logs.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #44 from Jonathan Druart  
---
Is there a good reason not to add the new ACQORDER notice?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #43 from Katrin Fischer  ---
Created attachment 56568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56568=edit
Bug 5260: Follow-up - Reindenting POD of SendAlerts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #42 from Katrin Fischer  ---
(In reply to Martin Renvoize from comment #40)
> Comment on attachment 56560 [details] [review]
> Bug 5260 - Add option to send an order by e-mail to the acquisition module
> 
> Review of attachment 56560 [details] [review]:
> -
> 
> Code looks generally good (given the area it's been added, it conforms to
> the script style), in testing I cannot find any fallout issues and the
> feature behaves as expected.
> 
> ::: C4/Letters.pm
> @@ +368,2 @@
> >  
> > +Parameters:
> 
> This block needs properly indenting please ;)

Adding a follow-up - was this what you were thinking about?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||17455


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17455
[Bug 17455] Add system preference to receive acq order e-mails as BCC
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|It will be possible to send |It will be possible to send
  release notes|order information to the|order information to the
   |vendor by e-mail. For now   |vendor by e-mail. For now
   |this feature can be |this feature can be
   |triggered manually with a   |triggered manually with a
   |button before closing the   |button before closing the
   |basket.
|basket.
   |The order e-mail is |The order e-mail is
   |based on the acquisition|based on the acquisition
   |claim feature, but uses a   |claim feature, but uses a
   |new notice template,|new notice template:
   |ACQORDER.   |ACQORDER.

--- Comment #41 from Katrin Fischer  ---
(In reply to Zeno Tajoli from comment #32)
> Hi Katrin,
> in my humble opinion the option to recieve a Bcc copy of e-mail is quite
> important.
> If we can develop it with this patch for me is better.

I agree that having the option to receive a BCC is good, but I think we
shouldn't mix it in with the claims. I filed bug 17455 for this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #40 from Martin Renvoize  ---
Comment on attachment 56560
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56560
Bug 5260 - Add option to send an order by e-mail to the acquisition module

Review of attachment 56560:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=5260=56560)
-

Code looks generally good (given the area it's been added, it conforms to the
script style), in testing I cannot find any fallout issues and the feature
behaves as expected.

::: C4/Letters.pm
@@ +368,2 @@
>  
> +Parameters:

This block needs properly indenting please ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #39 from Martin Renvoize  ---
Created attachment 56562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56562=edit
Bug 5260 - Schema changes

Schema changes for new column in the aqcontacts table.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #56549|0   |1
is obsolete||
  Attachment #56550|0   |1
is obsolete||
  Attachment #56551|0   |1
is obsolete||

--- Comment #37 from Martin Renvoize  ---
Created attachment 56560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56560=edit
Bug 5260 - Add option to send an order by e-mail to the acquisition module

With this patch it will be possible to send order information
to the vendor by e-mail. For now this feature can be triggered
manually with a button before closing the basket.
The order e-mail is based on the acquisition claim feature, but
uses a new notice template.

Test plan:

1) Vendors
A new checkbox "Contact when ordering?" was added to the vendor
page.
- Add a vendor and/or edit an existing vendor
- Verify the new option is saved correctly
- Verify the new option displays on the vendor summary page
  after saving

2) Notices
The feature works with a new notice template: ACQORDER
It works with the same formatting/fields etc. as the acq claim
notice.
- Add a new notice template ACQORDER in module
  'Claim/order aquisition'
- Make sure to use fields from the various offered tables
  in your notice
- Verify it is saved correctly

3) Basket
- Turn on LetterLog system preference
- Create multiple order lines
- Click the 'Send order' button in the toolbar
- Verify error or success message
- Verify you received the e-mail
- Verify there is a new entry with about the sent
  notice in your action_logs table

4) Regression testing...
- Verify order claims still work
- Verify serial claims still work
- Verify new serial issue notices still work
...
(I can provide additional test plans if needed)

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #38 from Martin Renvoize  ---
Created attachment 56561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56561=edit
Bug 5260: Unit tests for new functionality in SendAlert

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #36 from Katrin Fischer  ---
Ready for testing now!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #35 from Katrin Fischer  ---
Created attachment 56551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56551=edit
Bug 5260 - Schema changes

Schema changes for new column in the aqcontacts table.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #34 from Katrin Fischer  ---
Created attachment 56550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56550=edit
Bug 5260: Unit tests for new functionality in SendAlert

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #56483|0   |1
is obsolete||
  Attachment #56484|0   |1
is obsolete||

--- Comment #33 from Katrin Fischer  ---
Created attachment 56549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56549=edit
Bug 5260 - Add option to send an order by e-mail to the acquisition module

With this patch it will be possible to send order information
to the vendor by e-mail. For now this feature can be triggered
manually with a button before closing the basket.
The order e-mail is based on the acquisition claim feature, but
uses a new notice template.

Test plan:

1) Vendors
A new checkbox "Contact when ordering?" was added to the vendor
page.
- Add a vendor and/or edit an existing vendor
- Verify the new option is saved correctly
- Verify the new option displays on the vendor summary page
  after saving

2) Notices
The feature works with a new notice template: ACQORDER
It works with the same formatting/fields etc. as the acq claim
notice.
- Add a new notice template ACQORDER in module
  'Claim/order aquisition'
- Make sure to use fields from the various offered tables
  in your notice
- Verify it is saved correctly

3) Basket
- Turn on LetterLog system preference
- Create multiple order lines
- Click the 'Send order' button in the toolbar
- Verify error or success message
- Verify you received the e-mail
- Verify there is a new entry with about the sent
  notice in your action_logs table

4) Regression testing...
- Verify order claims still work
- Verify serial claims still work
- Verify new serial issue notices still work
...
(I can provide additional test plans if needed)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #32 from Zeno Tajoli  ---
Hi Katrin,
in my humble opinion the option to recieve a Bcc copy of e-mail is quite
important.
If we can develop it with this patch for me is better.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|It will be possible to send |It will be possible to send
  release notes|order information to the|order information to the
   |vendor by e-mail. For now   |vendor by e-mail. For now
   |this feature can be |this feature can be
   |triggered manually with a   |triggered manually with a
   |button before closing the   |button before closing the
   |basket.
|basket.
   |The order e-mail is |The order e-mail is
   |based on the acquisition|based on the acquisition
   |claim feature, but uses a   |claim feature, but uses a
   |new notice template,|new notice template,
   |ACQORDER. Activing the sys  |ACQORDER.
   |preference ClaimsBccCopy,   |
   |also this mail will arrive  |
   |to the logged user in  Bcc. |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|It will be possible to send |It will be possible to send
  release notes|order information to the|order information to the
   |vendor by e-mail. For now   |vendor by e-mail. For now
   |this feature can be |this feature can be
   |triggered manually with a   |triggered manually with a
   |button before closing the   |button before closing the
   |basket.
|basket.
   |The order e-mail is |The order e-mail is
   |based on the acquisition|based on the acquisition
   |claim feature, but uses a   |claim feature, but uses a
   |new notice template,|new notice template,
   |ACQORDER.   |ACQORDER. Activing the sys
   ||preference ClaimsBccCopy,
   ||also this mail will arrive
   ||to the logged user in  Bcc.
 Depends on|17446   |

--- Comment #31 from Katrin Fischer  ---
As the name of the system preference is specific to claiming I have decided to
not make it work for orders also. If there is a need for a feature like this,
we could add it later on.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17446
[Bug 17446] Remove some seleted typos
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #30 from Katrin Fischer  ---
Zeno, thx for the feedback. I am still working on the tests and have to rebase
now on Marcel's bug. New patches coming soon.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|It will be possible to send |It will be possible to send
  release notes|order information to the|order information to the
   |vendor by e-mail. For now   |vendor by e-mail. For now
   |this feature can be |this feature can be
   |triggered manually with a   |triggered manually with a
   |button before closing the   |button before closing the
   |basket.
|basket.
   |The order e-mail is |The order e-mail is
   |based on the acquisition|based on the acquisition
   |claim feature, but uses a   |claim feature, but uses a
   |new notice template,|new notice template,
   |ACQORDER. Activing the sys  |ACQORDER.
   |preference ClaimsBccCopy,   |
   |also this mail will arrive  |
   |to the logged user in  Bcc. |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||17446


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17446
[Bug 17446] Remove some seleted typos
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Silvia Simonetti  changed:

   What|Removed |Added

 CC|s.simone...@cineca.it   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Zeno Tajoli  changed:

   What|Removed |Added

  Text to go in the|It will be possible to send |It will be possible to send
  release notes|order information
  |order information to the
   |to the  |vendor by e-mail. For now
   |vendor by e-mail. For now   |this feature can be
   |this feature can be |triggered manually with a
   |triggered
  |button before closing the
   |manually with a |basket.
   |button before closing the   |The order e-mail is
   |basket.
|based on the acquisition
   |The order e-mail is |claim feature, but uses a
   |based on the acquisition|new notice template,
   |claim feature, but uses a   |ACQORDER. Activing the sys
   |new notice template,|preference ClaimsBccCopy,
   |ACQORDER.
  |also this mail will arrive
   |Activing the sys|to the logged user in  Bcc.
   |preference ClaimsBccCopy,   |
   |also this mail will arrive  |
   |to the logged user in  Bcc. |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Zeno Tajoli  changed:

   What|Removed |Added

  Text to go in the||It will be possible to send
  release notes||order information
   ||to the
   ||vendor by e-mail. For now
   ||this feature can be
   ||triggered
   ||manually with a
   ||button before closing the
   ||basket.
   ||The order e-mail is
   ||based on the acquisition
   ||claim feature, but uses a
   ||new notice template,
   ||ACQORDER.
   ||Activing the sys
   ||preference ClaimsBccCopy,
   ||also this mail will arrive
   ||to the logged user in  Bcc.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #29 from Zeno Tajoli  ---
I take a look of code and for me is good.
I undeline that we need to update the description of ClaimsBccCopy sys
preference.
With this patch it becames:
"[... ] blind copy (BCC) to logged in user when sending an acquisition order my
mail or a claim notices for serial or acquisitions.".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #28 from Katrin Fischer  ---
Aware of missing tests - working on it, but would love some first feedback if
someone would like to take a look.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #27 from Katrin Fischer  ---
Created attachment 56484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56484=edit
Bug 5260 - Add option to send an order by e-mail to the acquisition module

With this patch it will be possible to send order information
to the vendor by e-mail. For now this feature can be triggered
manually with a button before closing the basket.
The order e-mail is based on the acquisition claim feature, but
uses a new notice template.

Test plan:

1) Vendors
A new checkbox "Contact when ordering?" was added to the vendor
page.
- Add a vendor and/or edit an existing vendor
- Verify the new option is saved correctly
- Verify the new option displays on the vendor summary page
  after saving

2) Notices
The feature works with a new notice template: ACQORDER
It works with the same formatting/fields etc. as the acq claim
notice.
- Add a new notice template ACQORDER in module
  'Claim/order aquisition'
- Make sure to use fields from the various offered tables
  in your notice
- Verify it is saved correctly

3) Basket
- Turn on LetterLog system preference
- Create multiple order lines
- Click the 'Send order' button in the toolbar
- Verify error or success message
- Verify you received the e-mail
- Verify there is a new entry with about the sent
  notice in your action_logs table

4) Regression testing...
- Verify order claims still work
- Verify serial claims still work
- Verify new serial issue notices still work
...
(I can provide additional test plans if needed)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #56449|0   |1
is obsolete||
  Attachment #56450|0   |1
is obsolete||

--- Comment #26 from Katrin Fischer  ---
Created attachment 56483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56483=edit
Bug 5260 - Schema changes

Schema changes for new column in the aqcontacts table.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #25 from Katrin Fischer  ---
Created attachment 56450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56450=edit
Bug 5260 - Schema changes

Schema changes for new column in the aqcontacts table.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #24 from Katrin Fischer  ---
Created attachment 56449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56449=edit
Bug 5260 - Add option to send an order by e-mail to the acquisition module

With this patch it will be possible to send order information
to the vendor by e-mail. For now this feature can be triggered
manually with a button before closing the basket.
The order e-mail is based on the acquisition claim feature, but
uses a new notice template.

Test plan:

1) Vendors
A new checkbox "Contact when ordering?" was added to the vendor
page.
- Add a vendor and/or edit an existing vendor
- Verify the new option is saved correctly
- Verify the new option displays on the vendor summary page
  after saving

2) Notices
The feature works with a new notice template: ACQORDER
It works with the same formatting/fields etc. as the acq claim
notice.
- Add a new notice template ACQORDER in module
  'Claim/order aquisition'
- Make sure to use fields from the various offered tables
  in your notice
- Verify it is saved correctly

3) Basket
- Turn on LetterLog system preference
- Create multiple order lines
- Click the 'Send order' button in the toolbar
- Verify error or success message
- Verify you received the e-mail
- Verify there is a new entry with about the sent
  notice in your action_logs table

4) Regression testing...
- Verify order claims still work
- Verify serial claims still work
- Verify new serial issue notices still work
...
(I can provide additional test plans if needed)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||17441


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17441
[Bug 17441] t/db_dependent/Letters.t fails on Jenkins
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

Katrin Fischer  changed:

   What|Removed |Added

Summary|It would be nice if Koha's  |Add option to send an order
   |Acquisition module could|by e-mail to the
   |order by email  |acquisition module

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/