[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||11169 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||11170 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #132 from Galen Charlton gmcha...@gmail.com --- Pushed to master, along with some follow-ups. The most significant one I believe resolves the concern Katrin had about too many orders ending up in the partial status when 'ordered' or 'new' would have been better. I'd appreciate review of that in case that particular follow-up needs to be modified. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #133 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Argh. I see that when I updated my test plan I put in OK everywhere, but I missed updating the line. The second test I did with Jonathan's changed updatedatabase procuded perfect results for all test data I had created - so the partials were correctly set, before I set to passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #134 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Galen Charlton from comment #132) Pushed to master, along with some follow-ups. The most significant one I believe resolves the concern Katrin had about too many orders ending up in the partial status when 'ordered' or 'new' would have been better. I'd appreciate review of that in case that particular follow-up needs to be modified. I agree with your followups. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #131 from Pierre Angot tredok.pie...@gmail.com --- Can you push this patch ? We are waiting it to test 8230. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #129 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #128) Hi Jonathan, guess it's ok that I retested, but please let me know if I missed something :) Yep, thanks! It seems I missed to change the status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #130 from Pierre Angot tredok.pie...@gmail.com --- Yeah ! Now, we are waiting for pushing. I can start to test 8230 ^^ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #119 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, I wanted to come back to this but see you have set Failed QA still - is it because of the edge case? I think we could deal with that as a separate bug, as the behaviour is buggy on master as well. - If that is the only problem remaining. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10984 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #21689|0 |1 is obsolete|| Attachment #21690|0 |1 is obsolete|| Attachment #21691|0 |1 is obsolete|| Attachment #21692|0 |1 is obsolete|| Attachment #21693|0 |1 is obsolete|| Attachment #21694|0 |1 is obsolete|| Attachment #21707|0 |1 is obsolete|| Attachment #21709|0 |1 is obsolete|| --- Comment #120 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21751 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21751action=edit [PASSED QA] Bug 5336:Order search (search and UI enhancements) You can now search orders by - order status - fund New field aqorders.orderstatus, it can contains following values: 0 = New 1 = Ordered 2 = Partial 3 = Complete 4 = Deleted To test: Search and check if results are consistent in histsearch.pl Signed-off-by: Cedric Vita cedric.v...@dracenie.com Signed-off-by: Pierre Angot tredok.pie...@gmail.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Comments on last patch. Note: status are no longer numeric, but strings now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #121 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21752 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21752action=edit [PASSED QA] Bug 5336: Late orders search: don't display deleted order. Test plan: Check that deleted orders are not listed in the late orders search results. Signed-off-by: Cedric Vita cedric.v...@dracenie.com Signed-off-by: Pierre Angot tredok.pie...@gmail.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #122 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21753 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21753action=edit [PASSED QA] Bug 5336: Merge parent ordernumber and ordernumber columns Signed-off-by: Cedric Vita cedric.v...@dracenie.com Signed-off-by: Pierre Angot tredok.pie...@gmail.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #123 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21754 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21754action=edit [PASSED QA] Bug 5336: Add unit tests for 3 acq routines Unit tests In C4::Acquisition for: - CloseBasket - ReopenBasket - GetBiblioCountByBasketno Signed-off-by: Cedric Vita cedric.v...@dracenie.com Signed-off-by: Pierre Angot tredok.pie...@gmail.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #125 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21756 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21756action=edit [PASSED QA] Bug 5336: Change numbers with understandable codes for orderstatus This patch uses understandable codes instead of magical numbers for the aqorders.orderstatus field. + execute sql queries in unit tests into a transaction. Signed-off-by: Pierre Angot tredok.pie...@gmail.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #124 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21755 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21755action=edit [PASSED QA] Bug 5336: QA followup - fix capitalization - fix update database message Signed-off-by: Pierre Angot tredok.pie...@gmail.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #126 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21757 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21757action=edit [PASSED QA] Bug 5336: FIX: partial status was not correctly set An order (o1) is considered as partially received if (at least) another order (o2) has the o1.ordernumber == o2.parent_ordernumber and the quantity received is to the quantity (to receive) and o1.ordernumber != o1.parent_ordernumber. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #127 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21758 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21758action=edit [PASSED QA] Bug 5336: Multiple QA fixes - add a message if the search returns no result - keep selected values if the search returns no result (for fund and order status) - remove plurals in order status - move the order status column in the search results table Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script. New tests also pass: t/db_dependent/Acquisition/close_reopen_basket.t 1) Database update - I end up with too many partials. My test cases: - New orders, basket still open OK Expected: new, Result: partial - Ordered orders, basket and basketgroup closed OK Expected: ordered, Result: partial - Partially received orders OK Expected: partial/complete, Result: partial/complete - Received orders OK: Expected: complete, Result: complete - Cancelled orders * cancelled from open basket before order OK: Expected: cancelled, Result: cancelled * cancelled from closed basket before receive OK: Expected: cancelled, Result: cancelled All aqorders where updated with the correct status. I have saved my 'pre-updatedatabase' and can repeat the test anytime you have a follow up. 2) Testing search functionality a) Order search - result list Order search shows a new column, I think it would be a bit better if the status there was singular instead of plural - new order, partially received order etc. - maybe we could even leave out the 'order'? (minor) The column seems a bit lost in the middle, not sure where it would make more sense (just saying) b) Order search - advanced search form The advanced search form now shows a new filter: Order status All new status can be searched. - an empty search will find all but cancelled orders - searching for cancelled orders works correctly and shows results Search works correctly, no regressions found. If no result is found a message is shown. All search input is kept, so you can modify your search terms easily. 3) Testing setting of status after applying the patch a) Create a new order with 2 items - status is new. OK b) Close the basket - status is ordered. OK c) Receive both items - status is completed. OK d) Undo receipt - status is ordered. OK e) Receive only 1 item - order is split up into 2 orders: - status is partial OK - status is completed OK f) Undo receipt of received item - order is combined into 1 again - status is ordered OK! g) Receive only 1 item again - status ordered/partial. h) Delete order. - status is completed - status is cancelled OK! i) Undo receipt of 1 item again. Refresh page. This results in the following behaviour, that has been reported as bug 10984. After refreshing the page follow message is shown: Cannot cancel receipt. Possible reasons : - The order line you trying to cancel was created from a partial receipt of another order line which is already received. Try to cancel this one first and retry. - The order line you trying to cancel was created from a partial receipt of another order line which has been deleted. Cancellation is not possible. BUT: The receipt is undone, but you are left with a line with 2 items, a cancellation date and the status ordered. Because of the cancellation date the order is not visible in pending orders. The status is correct - so I feel this should not stop this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #128 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, guess it's ok that I retested, but please let me know if I missed something :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #115 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 21708 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21708action=edit Bug 5336: Multiple QA fixes - add a message if the search returns no result - keep selected values if the search returns no result (for fund and order status) - remove plurals in order status - move the order status column in the search results table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #21697|0 |1 is obsolete|| --- Comment #114 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 21707 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21707action=edit Bug 5336: FIX: partial status was not correctly set An order (o1) is considered as partially received if (at least) another order (o2) has the o1.ordernumber == o2.parent_ordernumber and the quantity received is to the quantity (to receive) and o1.ordernumber != o1.parent_ordernumber. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #116 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #113) Hi Jonathan, Hi Katrin, Thanks for this great feedback :) 1) Database update - I end up with too many partials. My test cases: Yep, The previous followup introduces some issues on updating status. I think this one is good. 2) Testing search functionality a) Order search - result list Order search shows a new column, I think it would be a bit better if the status there was singular instead of plural - new order, partially received order etc. - maybe we could even leave out the 'order'? (minor) Fixed. The column seems a bit lost in the middle, not sure where it would make more sense (just saying) Fixed, moved to the beginning of the table. When a search gives no results, there is no message. Also, all filters and fields are cleared so you can't modify or check you previous search (minor) Fixed. The issue only existed for fund and order status. i) Undo receipt of 1 item again. Refresh page. Error message is shown: Cannot cancel receipt. Possible reasons : The order line you trying to cancel was created from a partial receipt of another order line which is already received. Try to cancel this one first and retry. The order line you trying to cancel was created from a partial receipt of another order line which has been deleted. Cancellation is not possible. BUT: The receipt is undon, you are left with an order line with 2 items, a cancellation date and the status ordered. Because of the cancellation date the order is not visible in pending orders. I reproduce the issue with the master branch. It is not from these patches. Could you confirm that? I will try to have a look and propose a followup on another report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #117 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I can't test before tonight - so if you could confirm it's also on master I would be ok with that. Could you go ahead and file the new bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #21708|0 |1 is obsolete|| --- Comment #118 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 21709 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21709action=edit Bug 5336: Multiple QA fixes - add a message if the search returns no result - keep selected values if the search returns no result (for fund and order status) - remove plurals in order status - move the order status column in the search results table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #97 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Pierre, thanks :) What I am trying to do is check the update procedure - but I am still stuck with receiving orders. I will try again tonight to see what's going wrong in my installation. It puzzles me quite a bit! Have you tested with AcqCreateItems on order? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #98 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21695 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21695action=edit my orders... Maybe someone spots something I don't see? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #99 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21696 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21696action=edit ... and no pending orders -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #100 from Pierre Angot tredok.pie...@gmail.com --- On sandboxes, AcqCreateItems is placing an order. I haven't tested with others :/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #101 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Testing with that too - it's just I am missing all pending orders... until I get that working I can't really continue to test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #102 from Pierre Angot tredok.pie...@gmail.com --- I've made a test with AcqCreateItem on Receive an order. Everything is correct. All my pending orders are there. No one is missing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #103 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I will investigate the code and the database tonight - another idea I have is permissions - are you superlibrarian? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #104 from Pierre Angot tredok.pie...@gmail.com --- Yes, I'm SuperLibriarian ^^ You can check on sandbox n°3 : http://pro.test3.biblibre.com/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #105 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Thx - but I really need to figure out what's wrong with my installation :) I am never testing with superlibrarian, because our users don't get this permission and I want to make sure it works right for them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #106 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #105) Thx - but I really need to figure out what's wrong with my installation :) I am never testing with superlibrarian, because our users don't get this permission and I want to make sure it works right for them. Katrin, Sorry for the delay. I think there is a bug on updating the orderstatus field. I will try to submit a followup asap. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #107 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 21697 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21697action=edit Bug 5336: FIX: partial status was not correctly set An order (o1) is considered as partially received if (at least) another order (o2) has the o1.ordernumber == o2.parent_ordernumber and the quantity received is to the quantity (to receive). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #108 from Jonathan Druart jonathan.dru...@biblibre.com --- Katrin, I let you switch to needs signoff if you think it is needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #109 from Pierre Angot tredok.pie...@gmail.com --- Do you have check permission order_manage and order_receive ? Here, I give the 2 permissions. I think I've maybe missed something. Did this patch do a modification in receive shipment ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #110 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Pierre, I am sorry - I think I confused you. I can't receive anything in my normal installation without these patches. It's hard to test anything in acq when you have such a problem. I will figure it out, don't worry. This patch is not applied yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #111 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, thx for the follow-up - I remember from reading the code I had a feeling there might be a problem for the partial receives. Give me a chance to fix my installation and I will continue testing this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #112 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I used git bisect to locate the problem: 04b4afbd92ab952671e5ea6124e9e95da4a05874 is the first bad commit Bug 9130 follow up: add statesave cookie and all option for parcel drop-down menu After deleting all cookies, the pending orders show again. So maybe a broken cookie caused the problem? Can continue testing now :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #113 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, I am pretty impressed with this :) But there are some issues, that need fixing: 1) Database update - I end up with too many partials. My test cases: - New orders, basket still open NOT OK Expected: new, Result: partial - Ordered orders, basket and basketgroup closed NOT OK Expected: ordered, Result: partial - Partially received orders OK Expected: partial/complete, Result: partial/complete - Received orders OK: Expected: complete, Result: complete - Cancelled orders * cancelled from open basket before order OK: Expected: cancelled, Result: cancelled * cancelled from closed basket before receive OK: Expected: cancelled, Result: cancelled I have saved my 'pre-updatedatabase' and can repeat the test anytime you have a follow up. 2) Testing search functionality a) Order search - result list Order search shows a new column, I think it would be a bit better if the status there was singular instead of plural - new order, partially received order etc. - maybe we could even leave out the 'order'? (minor) The column seems a bit lost in the middle, not sure where it would make more sense (just saying) b) Order search - advanced search form The advanced search form now shows a new filter: Order status All new status can be searched. - an empty search will find all but cancelled orders - searching for cancelled orders works correctly and shows results Search works correctly, no regressions found. When a search gives no results, there is no message. Also, all filters and fields are cleared so you can't modify or check you previous search (minor) 3) Testing setting of status after applying the patch a) Create a new order with 2 items - status is new. OK b) Close the basket - status is ordered. OK c) Receive both items - status is completed. OK d) Undo receipt - status is ordered. OK e) Receive only 1 item - order is split up into 2 orders: - status is partial OK - status is completed OK f) Undo receipt of received item - order is combined into 1 again - status is ordered OK! g) Receive only 1 item again - status ordered/partial. h) Delete order. - status is completed - status is cancelled OK! i) Undo receipt of 1 item again. Refresh page. Error message is shown: Cannot cancel receipt. Possible reasons : The order line you trying to cancel was created from a partial receipt of another order line which is already received. Try to cancel this one first and retry. The order line you trying to cancel was created from a partial receipt of another order line which has been deleted. Cancellation is not possible. BUT: The receipt is undon, you are left with an order line with 2 items, a cancellation date and the status ordered. Because of the cancellation date the order is not visible in pending orders. Summary: The database update is not quite right yet and there is an edge case where you are left with the wrong status. Also singulars in the orders search result page would be nice. Hope you can take another look - I like this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #86 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I have finally started configuring a shiny new database with examples to test the update with. I am currently stuck on receiving records - there are no orders showing up for receiving in the table of pending orders. I have 2 closed baskets that are assigned to a closed basket group. It's too late to figure out what's going wrong here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #87 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Any hints appreciated... the logs are clean. I am not seeing what I am doing wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #88 from Pierre Angot tredok.pie...@gmail.com --- I can't test on sandbox, there is something wrong with them. I'm waiting for Jonathan ^^ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added CC||sandbo...@biblibre.com --- Comment #89 from sandbo...@biblibre.com sandbo...@biblibre.com --- Patch tested with a sandbox, by Pierre Angot tredok.pie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Attachment #20895|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Attachment #20894|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Attachment #20896|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #90 from sandbo...@biblibre.com sandbo...@biblibre.com --- Created attachment 21689 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21689action=edit Bug 5336:Order search (search and UI enhancements) You can now search orders by - order status - fund New field aqorders.orderstatus, it can contains following values: 0 = New 1 = Ordered 2 = Partial 3 = Complete 4 = Deleted To test: Search and check if results are consistent in histsearch.pl Signed-off-by: Cedric Vita cedric.v...@dracenie.com Signed-off-by: Pierre Angot tredok.pie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Attachment #20897|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Attachment #20899|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #91 from sandbo...@biblibre.com sandbo...@biblibre.com --- Created attachment 21690 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21690action=edit Bug 5336: Late orders search: don't display deleted order. Test plan: Check that deleted orders are not listed in the late orders search results. Signed-off-by: Cedric Vita cedric.v...@dracenie.com Signed-off-by: Pierre Angot tredok.pie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Attachment #20898|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #92 from sandbo...@biblibre.com sandbo...@biblibre.com --- Created attachment 21691 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21691action=edit Bug 5336: Merge parent ordernumber and ordernumber columns Signed-off-by: Cedric Vita cedric.v...@dracenie.com Signed-off-by: Pierre Angot tredok.pie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #94 from sandbo...@biblibre.com sandbo...@biblibre.com --- Created attachment 21693 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21693action=edit Bug 5336: QA followup - fix capitalization - fix update database message Signed-off-by: Pierre Angot tredok.pie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #95 from sandbo...@biblibre.com sandbo...@biblibre.com --- Created attachment 21694 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21694action=edit Bug 5336: Change numbers with understandable codes for orderstatus This patch uses understandable codes instead of magical numbers for the aqorders.orderstatus field. + execute sql queries in unit tests into a transaction. Signed-off-by: Pierre Angot tredok.pie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #93 from sandbo...@biblibre.com sandbo...@biblibre.com --- Created attachment 21692 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21692action=edit Bug 5336: Add unit tests for 3 acq routines Unit tests In C4::Acquisition for: - CloseBasket - ReopenBasket - GetBiblioCountByBasketno Signed-off-by: Cedric Vita cedric.v...@dracenie.com Signed-off-by: Pierre Angot tredok.pie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #96 from Pierre Angot tredok.pie...@gmail.com --- Well, it works on sandbox 3 ^^ Test plan : - Add 2 orders, first with 3 items, second with 2 - Receive 2 of the first order - cancel one order - search order Results : - isbn : ok (isbn 10 and 13) - author : ok - title : ok, even if it is partial - fund : ok - basket : ok - basketgroup : ok - Bookseller invoice : ok, but label is not correct, it works with invoice name, not number - order status : ok for all -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Pierre Angot tredok.pie...@gmail.com changed: What|Removed |Added CC||tredok.pie...@gmail.com --- Comment #77 from Pierre Angot tredok.pie...@gmail.com --- Hi ! We are interrested by this patch and by 8230 :) Did someone do the QA for this one ? Is it possible do have this patch for 3.10 and 3.12 ? Do we need to make other tests ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #78 from Katrin Fischer katrin.fisc...@bsz-bw.de --- This is a new feature waiting for QA - I have it on my list and hope to get some work done in it today. As it's a new feature it is very unlikely to get backported to older versions like 3.12 and 3.10. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #79 from mathieu saby mathieu.s...@univ-rennes2.fr --- I understand Katrin, but it's sad, because this feature has apparently been developped in 2011, and I first tested it one year ago... Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #80 from Katrin Fischer katrin.fisc...@bsz-bw.de --- It often makes me sad too to see things sit for a long time, but we can all only do as much as we can. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #81 from Pierre Angot tredok.pie...@gmail.com --- Thank's for your answers ^^ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #82 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Pierre, if you could confirm that partially received orders are correctly recognized by the database update that would be helpful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #83 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Well, Pierre or anyone else :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #84 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Still applies cleanly, all tests and QA script pass. Have to prepare a database to test the databaes update and setting of correct status next. If someone wants to help with additonal testing, noting the test plan and results - it would be very welcome :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #85 from Pierre Angot tredok.pie...@gmail.com --- Ok. I'll test this afternoon ^^ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #19317|0 |1 is obsolete|| --- Comment #70 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 20894 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20894action=edit Bug 5336:Order search (search and UI enhancements) You can now search orders by - order status - fund New field aqorders.orderstatus, it can contains following values: 0 = New 1 = Ordered 2 = Partial 3 = Complete 4 = Deleted To test: Search and check if results are consistent in histsearch.pl Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #19319|0 |1 is obsolete|| --- Comment #72 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 20896 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20896action=edit Bug 5336: Merge parent ordernumber and ordernumber columns Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #76 from Jonathan Druart jonathan.dru...@biblibre.com --- Rebased patches! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #19318|0 |1 is obsolete|| --- Comment #71 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 20895 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20895action=edit Bug 5336: Late orders search: don't display deleted order. Test plan: Check that deleted orders are not listed in the late orders search results. Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #19320|0 |1 is obsolete|| --- Comment #73 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 20897 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20897action=edit Bug 5336: Add unit tests for 3 acq routines Unit tests In C4::Acquisition for: - CloseBasket - ReopenBasket - GetBiblioCountByBasketno Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #19550|0 |1 is obsolete|| --- Comment #75 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 20899 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20899action=edit Bug 5336: Change numbers with understandable codes for orderstatus This patch uses understandable codes instead of magical numbers for the aqorders.orderstatus field. + execute sql queries in unit tests into a transaction. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #19321|0 |1 is obsolete|| --- Comment #74 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 20898 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20898action=edit Bug 5336: QA followup - fix capitalization - fix update database message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #69 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Jonathan, there are a couple of conflicts, could you please rebase? I will try to come back to this as quick as possible as soon as the patches apply again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #67 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19550 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19550action=edit Bug 5336: Change numbers with understandable codes for orderstatus This patch uses understandable codes instead of magical numbers for the aqorders.orderstatus field. + execute sql queries in unit tests into a transaction. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #68 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #66) Jonathan, could you take a look at the my comments before I proceed here? Done in the last patch. You have to remove the columns (ALTER TABLE aqorders DROP COLUMN orderstatus;) and execute the updatedatabase entry. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #65 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I'd like to suggest changing the 'magical numbers' into easier understandable codes. Also I would suggest renaming the status a bit: - New - On order - Partially received - Received - Cancelled - (Completed could later be used for closed and paid invoices maybe) Not sure about the codes to use best, so this is more for the descriptions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #66 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Jonathan, could you take a look at the my comments before I proceed here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #63 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Comment on attachment 19317 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19317 Bug 5336:Order search (search and UI enhancements) Review of attachment 19317: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=5336attachment=19317) - ::: C4/Acquisition.pm @@ +2134,2 @@ +$query .= AND (datecancellationprinted is NULL or datecancellationprinted='-00-00') if $orderstatus ne '4'; Checking for status 4 here... @@ +2697,5 @@ +my $query= +SELECT COUNT( DISTINCT( biblionumber ) ) +FROM aqorders +WHERE basketno = ? +AND (datecancellationprinted IS NULL OR datecancellationprinted='-00-00') ... but not checking for status 4 here? ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt @@ +57,5 @@ +option value=0New/option +option value=1Ordered/option +option value=2Partial/option +option value=3Complete/option +option value=4Deleted/option Maybe instead of Deleted we should be using Cancelled. For easier and better translation we could also go a bit further and say: New orders/? Open orders/Pending orders Partially received orders Received orders Cancelled orders Only an idea, native speakers should check before implementing any change :) New/ordered could lead to misunderstandings. I think new are not send to the vendor (basket still open) and ordered are supposed to have been sent out. But I am not sure how to reflect that better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #64 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I have gone through the code again and I am going to start testing in the interface soon, Especially partial orders. I wonder if the update condition in the updatedatabase can work, as we split the orders for partial receives. I also have been thinking about the status field, I see some advantages and disadvantages of doing it this way. The arguments I can think of right now are: contra: we have another field to maintan where we have to make sure the value is set correctly at all times depending on actions and changing values in other fields. It also adds a bit more complexity to migrations as the status have to be mapped correctly. pro: It will be easy to do SQL reports on aqorders based on the new status fields because you won't have to join tables and figure out the exact conditions. I am a bit torn here, so leaving this as notes while I continue testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Silvia Simonetti s.simone...@cineca.it changed: What|Removed |Added CC||s.simone...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #62 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Started QA on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18497|0 |1 is obsolete|| Attachment #18498|0 |1 is obsolete|| Attachment #18499|0 |1 is obsolete|| Attachment #18500|0 |1 is obsolete|| --- Comment #53 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19317 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19317action=edit Bug 5336:Order search (search and UI enhancements) You can now search orders by - order status - fund New field aqorders.orderstatus, it can contains following values: 0 = New 1 = Ordered 2 = Partial 3 = Complete 4 = Deleted To test: Search and check if results are consistent in histsearch.pl Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #54 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19318 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19318action=edit Bug 5336: Late orders search: don't display deleted order. Test plan: Check that deleted orders are not listed in the late orders search results. Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #57 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19321 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19321action=edit Bug 5336: QA followup - fix capitalization - fix update database message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #55 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19319 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19319action=edit Bug 5336: Merge parent ordernumber and ordernumber columns Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #56 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19320 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19320action=edit Bug 5336: Add unit tests for 3 acq routines Unit tests In C4::Acquisition for: - CloseBasket - ReopenBasket - GetBiblioCountByBasketno Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #59 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, I think we both got the wrong bug number for 2)? :) Julian removed the internalnotes column now, so I think removing it now and readding the correct code later would be good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #58 from Jonathan Druart jonathan.dru...@biblibre.com --- Thanks Katrin! 1/ Done in the followup. 2) I amended the first patch for that. I am afraid to change that in the followup (It it is pushed after bug 5394 we will loose the line). 3) Capitalization : done. 4) I never got this failure, really strange. 5) 3.09.00.043 and 3.11.00.116 did not use the after column_name in the alter table query. So it certainly comes from here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #61 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Right, was confusing it with the other acq related patch with cancellationreason. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added QA Contact|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | --- Comment #52 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, I really like the idea of this. Starting with a code review and running the automated tests on the codes I found a few things: 1) The updatedatabase states: +print Upgrade to $DBversion done (Add category ORDRSTATUS values in authorised_values table)\n; But it does not actually add an authorised value? And it looks like we don't need one and can have the values in the template, so it might just be enough to correct the line. Please also add the bug number :) 2) Hm not sure about this line, does it maybe belong to 5394? order.internalnotes ) %][% order.internalnotes %]br /[% END %][% order.isbn %]/td 3) Capitalization: legendSearch Orders/legend +label for=orderstatusOrder Status: /label 4) Patches fail the QA script: FAILt/db_dependent/Acquisition/close_reopen_basket.t OK pod OK forbidden patterns FAIL valid Use of qw(...) as parentheses is deprecated OK critic 5) Checking my database and comparing it to kohacstructure in your patch, the order of subscriptionid and parent_ordernumber are reversed. Not really sure how to explain that right now, so just noting. Will continue to test as nothing is severe so far, but can you please provide a follow-up? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #45 from Paul Poulain paul.poul...@biblibre.com --- Patch tested with a sandbox, by Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #46 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 18496 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18496action=edit Bug 5336: Add unit tests for 3 acq routines Unit tests In C4::Acquisition for: - CloseBasket - ReopenBasket - GetBiblioCountByBasketno Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18411|0 |1 is obsolete|| Attachment #18412|0 |1 is obsolete|| Attachment #18413|0 |1 is obsolete|| Attachment #18414|0 |1 is obsolete|| Attachment #18496|0 |1 is obsolete|| --- Comment #47 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18497 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18497action=edit Bug 5336:Order search (search and UI enhancements) You can now search orders by - order status - fund New field aqorders.orderstatus, it can contains following values: 0 = New 1 = Ordered 2 = Partial 3 = Complete 4 = Deleted To test: Search and check if results are consistent in histsearch.pl Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #48 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18498 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18498action=edit Bug 5336: Late orders search: don't display deleted order. Test plan: Check that deleted orders are not listed in the late orders search results. Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #50 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18500 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18500action=edit Bug 5336: Add unit tests for 3 acq routines Unit tests In C4::Acquisition for: - CloseBasket - ReopenBasket - GetBiblioCountByBasketno Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #49 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18499 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18499action=edit Bug 5336: Merge parent ordernumber and ordernumber columns Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
