[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Lari Taskula la...@student.uef.fi changed: What|Removed |Added Blocks||14620 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 [Bug 14620] Contact information validations -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Lari Taskula la...@student.uef.fi changed: What|Removed |Added Blocks||14590 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #32 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Nice improvement, Juhani! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com Attachment #38711|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #38708|0 |1 is obsolete|| Attachment #38709|0 |1 is obsolete|| Attachment #38710|0 |1 is obsolete|| Attachment #38715|0 |1 is obsolete|| --- Comment #28 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38744 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38744action=edit [PASSED QA] Bug 5685: Validation of email address field This patch adds server-side client-side validation for email form fields in the members/memberentry -view and in the opac/memberentry-view (bootstrap). I recently added simple validation for phone number and email address fields for our in-house koha and saw this old bug: I'm open to any ideas on how to do this better. Validation for phone numbers would be easy to add on top of this but I left it out since this bug is only about the email fields. To test: 1) Select a member and go to any of the edit forms with email fields (Primary info, Library use, Alternate address, Alternative contact). 2) Disable javascript in the browser in order to test server-side validation and try to input invalid emails in each of the email form fields. 3) Confirm that an invalid address is catched from any of the email fields, an alert shown for each invalid address and that the member's information was not updated with invalid data. 4) Enable javascript in the browser. 5) Confirm that the jquery validation plugin caches invalid addresses from any of the email fields and that you cannot send the form before correcting the problem. 6) Perform the same tests for the opac-memberentry-view. Note: as the jQuery validation plugin doesn't exist in the bootstrap folder, I just copied it over from the staff-client folder -how to deal with this? Signed-off-by: Owen Leonard oleon...@myacpl.org I have undone the changes to opac.css so that they can be submitted as a separate patch. I have some other follow-ups to make as well. Signed-off-by: Nicole Engard neng...@bywatersolutions.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #30 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38746 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38746action=edit [PASSED QA] Bug 5685 [OPAC follow-up] Validation of email address field This patch makes a few changes to the way errors are handled in the OPAC: - The validation plugin has been moved from the global include file to the template itself. Since we aren't doing form validation on any other page yet it doesn't make sense to include it globally at this time. - The error message which appears if you have JavaScript disabled and have submitted invalid emails was styled in a non-standard way. - I have added in-page links to the error message which appears if you have JavaScript disabled so that you can click to jump to the field which contains the error. - I have modified the error message language slightly to make it (I hope) read better. Signed-off-by: Nicole Engard neng...@bywatersolutions.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #31 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38747 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38747action=edit [PASSED QA] Bug 5685: Add missing about information In comment #20, Katrin requested the about page be updated to reflect the addition of a jquery plugin. TEST PLAN - 1) Apply all patches 2) Log in to Staff Client 3) Home - About Koha - Licenses -- jQuery Validation Plugin is now listed nicely. 4) Run koha qa test tools License appears as expected, qa OK Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #29 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38745 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38745action=edit [PASSED QA] Bug 5685 [Compiled CSS] Validation of email address field This patch contains the recompiled opac.css file based on changes made to opac.less in the previous patch. Signed-off-by: Nicole Engard neng...@bywatersolutions.com FIXED the compress. - mtompset Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #27 from Marc Véron ve...@veron.ch --- Created attachment 38715 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38715action=edit [Signed-off] Bug 5685: Add missing about information In comment #20, Katrin requested the about page be updated to reflect the addition of a jquery plugin. TEST PLAN - 1) Apply all patches 2) Log in to Staff Client 3) Home - About Koha - Licenses -- jQuery Validation Plugin is now listed nicely. 4) Run koha qa test tools License appears as expected, qa OK Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #22 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38707 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38707action=edit Bug 5685: Add missing about information In comment #20, Katrin requested the about page be updated to reflect the addition of a jquery plugin. TEST PLAN - 1) Apply all patches 2) Log in to Staff Client 3) Home - About Koha - Licenses -- jQuery Validation Plugin is now listed nicely. 4) Run koha qa test tools -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38063|0 |1 is obsolete|| --- Comment #23 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38708 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38708action=edit Bug 5685: Validation of email address field This patch adds server-side client-side validation for email form fields in the members/memberentry -view and in the opac/memberentry-view (bootstrap). I recently added simple validation for phone number and email address fields for our in-house koha and saw this old bug: I'm open to any ideas on how to do this better. Validation for phone numbers would be easy to add on top of this but I left it out since this bug is only about the email fields. To test: 1) Select a member and go to any of the edit forms with email fields (Primary info, Library use, Alternate address, Alternative contact). 2) Disable javascript in the browser in order to test server-side validation and try to input invalid emails in each of the email form fields. 3) Confirm that an invalid address is catched from any of the email fields, an alert shown for each invalid address and that the member's information was not updated with invalid data. 4) Enable javascript in the browser. 5) Confirm that the jquery validation plugin caches invalid addresses from any of the email fields and that you cannot send the form before correcting the problem. 6) Perform the same tests for the opac-memberentry-view. Note: as the jQuery validation plugin doesn't exist in the bootstrap folder, I just copied it over from the staff-client folder -how to deal with this? Signed-off-by: Owen Leonard oleon...@myacpl.org I have undone the changes to opac.css so that they can be submitted as a separate patch. I have some other follow-ups to make as well. Signed-off-by: Nicole Engard neng...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685
--- Comment #21 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 38063
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38063
Bug 5685: Validation of email address field
Review of attachment 38063:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=5685attachment=38063)
-
::: koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.validate.min.js
@@ +1,4 @@
+/*! jQuery Validation Plugin - v1.10.0 - 9/7/2012
+* https://github.com/jzaefferer/jquery-validation
+* Copyright (c) 2012 Jörn Zaefferer; Licensed MIT, GPL */
+(function(a){a.extend(a.fn,{validate:function(b){if(!this.length){bb.debugwindow.consoleconsole.warn(nothing
selected, can't validate, returning nothing);return}var
c=a.data(this[0],validator);return
c?c:(this.attr(novalidate,novalidate),c=new
a.validator(b,this[0]),a.data(this[0],validator,c),c.settings.onsubmit(this.validateDelegate(:submit,click,function(b){c.settings.submitHandler(c.submitButton=b.target),a(b.target).hasClass(cancel)(c.cancelSubmit=!0)}),this.submit(function(b){function
d(){var d;return c.settings.submitHandler?(c.submitButton(d=a(input
type='hidden'/).attr(name,c.submitButton.name).val(c.submitButton.value).appendTo(c.currentForm)),c.settings.submitHandler.call(c,c.currentForm,b),c.submitButtond.remove(),!1):!0}return
c.settings.debugb.preventDefault(),c.cancelSubmit?(c.cancelSubmit=!1,d()):c.form()?c.pendingRequest?(c.formSubmitted=!0,!1):d():(c.focusInvalid(),!1)})),c)},valid:function(){if(a(this[0]).is(form))return
this.validate().form();var b=!0,c=a(this[0].form).validate();return
this.each(function(){b=c.element(this)}),b},removeAttrs:function(b){var
c={},d=this;return
a.each(b.split(/\s/),function(a,b){c[b]=d.attr(b),d.removeAttr(b)}),c},rules:function(b,c){var
d=this[0];if(b){var
e=a.data(d.form,validator).settings,f=e.rules,g=a.validator.staticRules(d);switch(b){caseadd:a.extend(g,a.validator.normalizeRule(c)),f[d.name]=g,c.messages(e.messages[d.name]=a.extend(e.messages[d.name],c.messages));break;caseremove:if(!c)return
delete f[d.name],g;var h={};return
a.each(c.split(/\s/),function(a,b){h[b]=g[b],delete g[b]}),h}}var
i=a.validator.normalizeRules(a.extend({},a.validator.metadataRules(d),a.validator.classRules(d),a.validator.attributeRules(d),a.validator.staticRules(d)),d);if(i.required){var
j=i.required;delete i.required,i=a.extend({required:j},i)}return
i}}),a.extend(a.expr[:],{blank:function(b){return!a.trim(+b.value)},filled:function(b){return!!a.trim(+b.value)},unchecked:function(a){return!a.checked}}),a.validator=function(b,c){this.settings=a.extend(!0,{},a.validator.defaults,b),this.currentForm=c,this.init()},a.validator.format=function(b,c){return
arguments.length===1?function(){var c=a.makeArray(arguments);return
c.unshift(b),a.validator.format.apply(this,c)}:(arguments.length2c.constructor!==Array(c=a.makeArray(arguments).slice(1)),c.constructor!==Array(c=[c]),a.each(c,function(a,c){b=b.replace(new
RegExp(\\{+a+\\},g),c)}),b)},a.extend(a.validator,{defaults:{messages:{},groups:{},rules:{},errorClass:error,validClass:valid,errorElement:label,focusInvalid:!0,errorContainer:a([]),errorLabelContainer:a([]),onsubmit:!0,ignore::hidden,ignoreTitle:!1,onfocusin:function(a,b){this.lastActive=a,this.settings.focusCleanup!this.blockFocusCleanup(this.settings.unhighlightthis.settings.unhighlight.call(this,a,this.settings.errorClass,this.settings.validClass),this.addWrapper(this.errorsFor(a)).hide())},onfocusout:function(a,b){!this.checkable(a)(a.name
in
this.submitted||!this.optional(a))this.element(a)},onkeyup:function(a,b){if(b.which===9this.elementValue(a)===)return;(a.name
in
this.submitted||a===this.lastActive)this.element(a)},onclick:function(a,b){a.name
in this.submitted?this.element(a):a.parentNode.name in
this.submittedthis.element(a.parentNode)},highlight:function(b,c,d){b.type===radio?this.findByName(b.name).addClass(c).removeClass(d):a(b).addClass(c).removeClass(d)},unhighlight:function(b,c,d){b.type===radio?this.findByName(b.name).removeClass(c).addClass(d):a(b).removeClass(c).addClass(d)}},setDefaults:function(b){a.extend(a.validator.defaults,b)},messages:{required:This
field is required.,remote:Please fix this field.,email:Please enter a
valid email address.,url:Please enter a valid URL.,date:Please enter a
valid date.,dateISO:Please enter a valid date (ISO).,number:Please enter
a valid number.,digits:Please enter only digits.,creditcard:Please enter
a valid credit card number.,equalTo:Please enter the same value
again.,maxlength:a.validator.format(Please enter no more than {0}
characters.),minlength:a.validator.format(Please enter at least {0}
characters.),rangelength:a.validator.format(Please enter a value between
{0} and {1} characters long.),range:a.validator.format(Please enter a value
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38065|0 |1 is obsolete|| --- Comment #25 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38710 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38710action=edit Bug 5685 [OPAC follow-up] Validation of email address field This patch makes a few changes to the way errors are handled in the OPAC: - The validation plugin has been moved from the global include file to the template itself. Since we aren't doing form validation on any other page yet it doesn't make sense to include it globally at this time. - The error message which appears if you have JavaScript disabled and have submitted invalid emails was styled in a non-standard way. - I have added in-page links to the error message which appears if you have JavaScript disabled so that you can click to jump to the field which contains the error. - I have modified the error message language slightly to make it (I hope) read better. Signed-off-by: Nicole Engard neng...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38707|0 |1 is obsolete|| --- Comment #26 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38711 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38711action=edit Bug 5685: Add missing about information In comment #20, Katrin requested the about page be updated to reflect the addition of a jquery plugin. TEST PLAN - 1) Apply all patches 2) Log in to Staff Client 3) Home - About Koha - Licenses -- jQuery Validation Plugin is now listed nicely. 4) Run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38064|0 |1 is obsolete|| --- Comment #24 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38709 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38709action=edit Bug 5685 [Compiled CSS] Validation of email address field This patch contains the recompiled opac.css file based on changes made to opac.less in the previous patch. Signed-off-by: Nicole Engard neng...@bywatersolutions.com FIXED the compress. - mtompset -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de --- 2 Problems with this: 1) koha-tmpl/opac-tmpl/bootstrap/css/opac.css is not correctly 'compressed' - before it is all on one line, now it's mulitple with just the spaces removed. 2) The patch adds a new jQuery plugin that should also show up on the about page. Please fix! Tests looked good. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #37393|0 |1 is obsolete|| --- Comment #19 from Nicole C. Engard neng...@gmail.com --- Created attachment 38065 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38065action=edit Bug 5685 [OPAC follow-up] Validation of email address field This patch makes a few changes to the way errors are handled in the OPAC: - The validation plugin has been moved from the global include file to the template itself. Since we aren't doing form validation on any other page yet it doesn't make sense to include it globally at this time. - The error message which appears if you have JavaScript disabled and have submitted invalid emails was styled in a non-standard way. - I have added in-page links to the error message which appears if you have JavaScript disabled so that you can click to jump to the field which contains the error. - I have modified the error message language slightly to make it (I hope) read better. Signed-off-by: Nicole Engard neng...@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #37391|0 |1 is obsolete|| --- Comment #17 from Nicole C. Engard neng...@gmail.com --- Created attachment 38063 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38063action=edit Bug 5685: Validation of email address field This patch adds server-side client-side validation for email form fields in the members/memberentry -view and in the opac/memberentry-view (bootstrap). I recently added simple validation for phone number and email address fields for our in-house koha and saw this old bug: I'm open to any ideas on how to do this better. Validation for phone numbers would be easy to add on top of this but I left it out since this bug is only about the email fields. To test: 1) Select a member and go to any of the edit forms with email fields (Primary info, Library use, Alternate address, Alternative contact). 2) Disable javascript in the browser in order to test server-side validation and try to input invalid emails in each of the email form fields. 3) Confirm that an invalid address is catched from any of the email fields, an alert shown for each invalid address and that the member's information was not updated with invalid data. 4) Enable javascript in the browser. 5) Confirm that the jquery validation plugin caches invalid addresses from any of the email fields and that you cannot send the form before correcting the problem. 6) Perform the same tests for the opac-memberentry-view. Note: as the jQuery validation plugin doesn't exist in the bootstrap folder, I just copied it over from the staff-client folder -how to deal with this? Signed-off-by: Owen Leonard oleon...@myacpl.org I have undone the changes to opac.css so that they can be submitted as a separate patch. I have some other follow-ups to make as well. Signed-off-by: Nicole Engard neng...@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #37392|0 |1 is obsolete|| --- Comment #18 from Nicole C. Engard neng...@gmail.com --- Created attachment 38064 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38064action=edit Bug 5685 [Compiled CSS] Validation of email address field This patch contains the recompiled opac.css file based on changes made to opac.less in the previous patch. Signed-off-by: Nicole Engard neng...@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com Attachment #32622|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #16 from M. Tompsett mtomp...@hotmail.com --- This seemed to be languishing a little. I hopefully have rebased appropriately. jsep...@student.uef.fi, could you please confirm? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #32623|0 |1 is obsolete|| --- Comment #14 from M. Tompsett mtomp...@hotmail.com --- Created attachment 37392 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37392action=edit Bug 5685 [Compiled CSS] Validation of email address field This patch contains the recompiled opac.css file based on changes made to opac.less in the previous patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #32624|0 |1 is obsolete|| --- Comment #15 from M. Tompsett mtomp...@hotmail.com --- Created attachment 37393 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37393action=edit Bug 5685 [OPAC follow-up] Validation of email address field This patch makes a few changes to the way errors are handled in the OPAC: - The validation plugin has been moved from the global include file to the template itself. Since we aren't doing form validation on any other page yet it doesn't make sense to include it globally at this time. - The error message which appears if you have JavaScript disabled and have submitted invalid emails was styled in a non-standard way. - I have added in-page links to the error message which appears if you have JavaScript disabled so that you can click to jump to the field which contains the error. - I have modified the error message language slightly to make it (I hope) read better. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #13 from M. Tompsett mtomp...@hotmail.com --- Created attachment 37391 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37391action=edit Bug 5685: Validation of email address field This patch adds server-side client-side validation for email form fields in the members/memberentry -view and in the opac/memberentry-view (bootstrap). I recently added simple validation for phone number and email address fields for our in-house koha and saw this old bug: I'm open to any ideas on how to do this better. Validation for phone numbers would be easy to add on top of this but I left it out since this bug is only about the email fields. To test: 1) Select a member and go to any of the edit forms with email fields (Primary info, Library use, Alternate address, Alternative contact). 2) Disable javascript in the browser in order to test server-side validation and try to input invalid emails in each of the email form fields. 3) Confirm that an invalid address is catched from any of the email fields, an alert shown for each invalid address and that the member's information was not updated with invalid data. 4) Enable javascript in the browser. 5) Confirm that the jquery validation plugin caches invalid addresses from any of the email fields and that you cannot send the form before correcting the problem. 6) Perform the same tests for the opac-memberentry-view. Note: as the jQuery validation plugin doesn't exist in the bootstrap folder, I just copied it over from the staff-client folder -how to deal with this? Signed-off-by: Owen Leonard oleon...@myacpl.org I have undone the changes to opac.css so that they can be submitted as a separate patch. I have some other follow-ups to make as well. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch --- Comment #12 from Marc Véron ve...@veron.ch --- DOes not apply Applying: Bug 5685: Validation of email address field Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging opac/opac-memberentry.pl Auto-merging members/memberentry.pl CONFLICT (content): Merge conflict in members/memberentry.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/less/opac.less CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/less/opac.less Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Failed to merge in the changes. Patch failed at 0001 Bug 5685: Validation of email address field -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #8 from Chris Cormack ch...@bigballofwax.co.nz --- CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/opac.css -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #30829|0 |1 is obsolete|| --- Comment #9 from Owen Leonard oleon...@myacpl.org --- Created attachment 32622 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32622action=edit [SIGNED-OFF] Bug 5685: Validation of email address field This patch adds server-side client-side validation for email form fields in the members/memberentry -view and in the opac/memberentry-view (bootstrap). I recently added simple validation for phone number and email address fields for our in-house koha and saw this old bug: I'm open to any ideas on how to do this better. Validation for phone numbers would be easy to add on top of this but I left it out since this bug is only about the email fields. To test: 1) Select a member and go to any of the edit forms with email fields (Primary info, Library use, Alternate address, Alternative contact). 2) Disable javascript in the browser in order to test server-side validation and try to input invalid emails in each of the email form fields. 3) Confirm that an invalid address is catched from any of the email fields, an alert shown for each invalid address and that the member's information was not updated with invalid data. 4) Enable javascript in the browser. 5) Confirm that the jquery validation plugin caches invalid addresses from any of the email fields and that you cannot send the form before correcting the problem. 6) Perform the same tests for the opac-memberentry-view. Note: as the jQuery validation plugin doesn't exist in the bootstrap folder, I just copied it over from the staff-client folder -how to deal with this? Signed-off-by: Owen Leonard oleon...@myacpl.org I have undone the changes to opac.css so that they can be submitted as a separate patch. I have some other follow-ups to make as well. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #10 from Owen Leonard oleon...@myacpl.org --- Created attachment 32623 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32623action=edit Bug 5685 [Compiled CSS] Validation of email address field This patch contains the recompiled opac.css file based on changes made to opac.less in the previous patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #11 from Owen Leonard oleon...@myacpl.org --- Created attachment 32624 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32624action=edit Bug 5685 [OPAC follow-up] Validation of email address field This patch makes a few changes to the way errors are handled in the OPAC: - The validation plugin has been moved from the global include file to the template itself. Since we aren't doing form validation on any other page yet it doesn't make sense to include it globally at this time. - The error message which appears if you have JavaScript disabled and have submitted invalid emails was styled in a non-standard way. - I have added in-page links to the error message which appears if you have JavaScript disabled so that you can click to jump to the field which contains the error. - I have modified the error message language slightly to make it (I hope) read better. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #7 from Juhani Seppälä jsep...@student.uef.fi --- Created attachment 30829 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30829action=edit Bug 5685: Validation of email address field This patch adds server-side client-side validation for email form fields in the members/memberentry -view and in the opac/memberentry-view (bootstrap). I recently added simple validation for phone number and email address fields for our in-house koha and saw this old bug: I'm open to any ideas on how to do this better. Validation for phone numbers would be easy to add on top of this but I left it out since this bug is only about the email fields. To test: 1) Select a member and go to any of the edit forms with email fields (Primary info, Library use, Alternate address, Alternative contact). 2) Disable javascript in the browser in order to test server-side validation and try to input invalid emails in each of the email form fields. 3) Confirm that an invalid address is catched from any of the email fields, an alert shown for each invalid address and that the member's information was not updated with invalid data. 4) Enable javascript in the browser. 5) Confirm that the jquery validation plugin caches invalid addresses from any of the email fields and that you cannot send the form before correcting the problem. 6) Perform the same tests for the opac-memberentry-view. Note: as the jQuery validation plugin doesn't exist in the bootstrap folder, I just copied it over from the staff-client folder -how to deal with this? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Juhani Seppälä jsep...@student.uef.fi changed: What|Removed |Added Status|NEW |Needs Signoff CC||jsep...@student.uef.fi Assignee|koha-b...@lists.koha-commun |jsep...@student.uef.fi |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #3860|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #3814|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Failed QA |ASSIGNED Version|3.6 |master Assignee|mark.gavillet@ptfs-europe.c |koha-b...@lists.koha-commun |om |ity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com Patch Status|Needs Signoff |Failed QA --- Comment #4 from Nicole C. Engard neng...@gmail.com 2011-04-19 15:09:15 UTC --- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug: 5685 - Email address format validation for patron records fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/js/members.js). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug: 5685 - Email address format validation for patron records When you have resolved this problem run git am --resolved. If you would prefer to skip this patch, instead run git am --skip. To restore the original branch and stop patching run git am --abort. nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #5 from Nicole C. Engard neng...@gmail.com 2011-04-19 15:19:20 UTC --- Okay you need both patches for it to apply, but after applying both nothing is stopping me from entering plain text (not an email address) in the email field on the patron record. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Mark Gavillet mark.gavil...@ptfs-europe.com changed: What|Removed |Added Attachment #3814|0 |1 is obsolete|| --- Comment #3 from Mark Gavillet mark.gavil...@ptfs-europe.com 2011-04-11 10:21:50 UTC --- Created attachment 3860 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3860 Proposed patch Commented line removed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #1 from Mark Gavillet mark.gavil...@ptfs-europe.com 2011-04-07 15:23:09 UTC --- Created attachment 3814 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3814 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Mark Gavillet mark.gavil...@ptfs-europe.com changed: What|Removed |Added Priority|P5 |PATCH-Sent CC||mark.gavillet@ptfs-europe.c ||om Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Version|unspecified |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
