[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #32 from Jonathan Druart  
---
Fixed in 3.22 by bug 14544.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Jonathan Druart  changed:

   What|Removed |Added

Version|master  |3.20

--- Comment #31 from Jonathan Druart  
---
A fix could be submitted on top of 3.20, in hopes that big 14544 will be into
3.22.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14544

--- Comment #30 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Will be fixed by 14544.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #29 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Jonathan Druart from comment #28)
 (In reply to M. de Rooy from comment #26)
  At this point, I would go for refactoring instead of spending more time on
  the current code. So I obsolete both patches.
 
 It's a major bug and still exists on master.
 I would like to see this bug fixed quickly.
 And the quicker way is to push these patches, don't you think?

See comment 25 for a reason not to.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #28 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to M. de Rooy from comment #26)
 At this point, I would go for refactoring instead of spending more time on
 the current code. So I obsolete both patches.

It's a major bug and still exists on master.
I would like to see this bug fixed quickly.
And the quicker way is to push these patches, don't you think?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Assignee|m.de.r...@rijksmuseum.nl|gmcha...@gmail.com

--- Comment #26 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Owen Leonard from comment #25)
 Testing this step in the OPAC:
 
  - Viewing private [and private] lists, navigate to second page of lists
  - Click 'delete' link next to a list name for an list WITH CONTENTS.
 
 Clicking 'delete' give me a JavaScript prompt but doesn't redirect back to
 the list with a confirmation button to delete the contents of the list as it
 did before. This means that if JavaScript is turned off a list with contents
 can be deleted without any warning at all. This seems like a regression to
 me.

OK. I am not sure if running Koha without JavaScript these days will be very
progressive, but this sounds valid.
At this point, I would go for refactoring instead of spending more time on the
current code. So I obsolete both patches.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #31898|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #31899|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #27 from M. de Rooy m.de.r...@rijksmuseum.nl ---
I just disabled javascript in Firefox (far away in about:config btw).

If I want to go to my lists in the opac and click on the Lists menu, nothing
happens. Same for clicking on Cart. Add to cart does not work. Etc. etc.

If we still should develop with disabled javascript in mind, is not the object
of this report, but there may already be quite some functionality that does not
work without it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com ---
Marcel,
There are several occurrences of DEL- in the template.
Your patch only changes one.


Something else, I didn't try but, if you remove the 4 lines in the pm file, are
you sure we won't introduce a regression? I am under the impression that this
test was there to verify the user has the right (i.e he is the owner/creator of
the list) to delete the list?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #15 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Jonathan Druart from comment #14)
 Marcel,
 There are several occurrences of DEL- in the template.
 Your patch only changes one.
 
 
 Something else, I didn't try but, if you remove the 4 lines in the pm file,
 are you sure we won't introduce a regression? I am under the impression that
 this test was there to verify the user has the right (i.e he is the
 owner/creator of the list) to delete the list?

I am working on it. Please wait..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #17 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Jonathan Druart from comment #14)
 Something else, I didn't try but, if you remove the 4 lines in the pm file,
 are you sure we won't introduce a regression? I am under the impression that
 this test was there to verify the user has the right (i.e he is the
 owner/creator of the list) to delete the list?

No, the permission test is still in the code. Thanks.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #16 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 31892
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31892action=edit
Bug 6279: Follow-up for pagination and confirm

This follow-up patch restores the pagination and removes the Confirm
buttons. This is not really needed since you already confirmed a
javascript messagebox.
The code needs refactoring. This is a quick fix.

Test plan:
Delete lists from the second page (from list view and detail view) in both
OPAC and staff.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #18 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Owen Leonard from comment #12)
  - Viewing public lists, navigate to second page of lists.
  - Click an list WITH CONTENTS to view its contents.
  - Click the delete list button from the list contents view.
  - No error. Redirected to the first page of public lists with no 
link to the second page of lists. Navigating back to public lists
and then to the second page of lists shows that the list WAS NOT
deleted.
  
  Fail.
 
 This was the only failure among those tests, other than the continuing
 problem of the pagination links disappearing.
 
 I'm not sure whether to sign off on this because it is an improvement or ask
 that this one case be fixed as well.

Thanks for testing, Owen.

I recall that deleting a list on the second page (from the all shelves view)
brought me back to the first page without pagination. So the confirm button
never appeared and I could not delete the list. But deleting it from its own
shelf page (with the items) was successfull with the first patch.

The second patch should resolve some further issues with pagination. In order
to achieve the best result in not too much time, I sacrificed the confirmation
buttons. They were at least debatable since you already confirm a delete.
Hopefully this can be signed off now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #31883|0   |1
is obsolete||
  Attachment #31892|0   |1
is obsolete||

--- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 31893
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31893action=edit
Bug 6279: Cannot delete lists from second page of lists in the OPAC

The code in Page.pm still needs more attention, but this may serve as
a quick fix for the problem; it will at least improve the situation.

If you delete a list from its individual page (viewshelf), you already
see the items (if any). So we will assume that after you said Yes to the
message box, you want to delete it. There will not be a confirmation
button anymore.
Note that after you deleted the list, the intended message is not shown and
the pagination bar is gone. I leave those for the future refactoring.

Test plan:
Delete a list from its own viewshelf page in OPAC and staff.
Note that OPAC will delete it rightaway now.
Note that staff still has the confirmation button.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 31894
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31894action=edit
Bug 6279: Follow-up for pagination and confirm

This follow-up patch restores the pagination and removes the Confirm
buttons. This is not really needed since you already confirmed a
javascript messagebox.
The code needs refactoring. This is a quick fix.

Test plan:
Delete lists from the second page (from list view and detail view) in both
OPAC and staff.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com ---
All looks good to me, but I really would like another sign off on this one.
I am not confident at all in this code and cannot be sure this patch won't
introduce regressions :-/

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #31893|0   |1
is obsolete||

--- Comment #22 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 31898
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31898action=edit
Bug 6279: Cannot delete lists from second page of lists in the OPAC

The code in Page.pm still needs more attention, but this may serve as
a quick fix for the problem; it will at least improve the situation.

If you delete a list from its individual page (viewshelf), you already
see the items (if any). So we will assume that after you said Yes to the
message box, you want to delete it. There will not be a confirmation
button anymore.
Note that after you deleted the list, the intended message is not shown and
the pagination bar is gone. I leave those for the future refactoring.

Test plan:
Delete a list from its own viewshelf page in OPAC and staff.
Note that OPAC will delete it rightaway now.
Note that staff still has the confirmation button.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Signed-off-by: Fridolin Somers fridolin.som...@biblibre.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #31894|0   |1
is obsolete||

--- Comment #23 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 31899
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31899action=edit
Bug 6279: Follow-up for pagination and confirm

This follow-up patch restores the pagination and removes the Confirm
buttons. This is not really needed since you already confirmed a
javascript messagebox.
The code needs refactoring. This is a quick fix.

Test plan:
Delete lists from the second page (from list view and detail view) in both
OPAC and staff.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Signed-off-by: Fridolin Somers fridolin.som...@biblibre.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #24 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Nice job, works fine

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #25 from Owen Leonard oleon...@myacpl.org ---
Testing this step in the OPAC:

 - Viewing private [and private] lists, navigate to second page of lists
 - Click 'delete' link next to a list name for an list WITH CONTENTS.

Clicking 'delete' give me a JavaScript prompt but doesn't redirect back to the
list with a confirmation button to delete the contents of the list as it did
before. This means that if JavaScript is turned off a list with contents can be
deleted without any warning at all. This seems like a regression to me.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
Problem in master and 3.14.x (at least)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED
   Assignee|fridolyn.som...@biblibre.co |jonathan.dru...@biblibre.co
   |m   |m

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Assignee|jonathan.dru...@biblibre.co |m.de.r...@rijksmuseum.nl
   |m   |

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
Marcel,
Could you have a look at this bug please?
I am a little bit lost in the VirtualShelves code.
I don't understand why the DelShelf is done as far in the code.
We shouldn't need to call GetShelves to delete a shelf.

Please tell me if you don't have the time and I will try to provide a patch.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Jonathan Druart from comment #8)
 Marcel,
 Could you have a look at this bug please?
 I am a little bit lost in the VirtualShelves code.
 I don't understand why the DelShelf is done as far in the code.
 We shouldn't need to call GetShelves to delete a shelf.
 
 Please tell me if you don't have the time and I will try to provide a patch.

Will have a look

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl ---
The (horrible) code in VirtualShelves/Page.pm needs refactoring. I would like
to do that when converting it to DBIx in one pass.

I try to reproduce your problem on master: I create 22 private lists. List 21
has one item, list 22 has no items. I delete list 21, have to confirm and it is
gone. I delete list 22; no confirm button because it is empty. It is gone too.

OK. Reading back: If I click on list 21 and want to delete there. It says: list
number unrecognized. Cool ;) Looking further..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #11 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 31883
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31883action=edit
Bug 6279: Cannot delete lists from second page of lists in the OPAC

The code in Page.pm still needs more attention, but this may serve as
a quick fix for the problem; it will at least improve the situation.

If you delete a list from its individual page (viewshelf), you already
see the items (if any). So we will assume that after you said Yes to the
message box, you want to delete it. There will not be a confirmation
button anymore.
Note that after you deleted the list, the intended message is not shown and
the pagination bar is gone. I leave those for the future refactoring.

Test plan:
Delete a list from its own viewshelf page in OPAC and staff.
Note that OPAC will delete it rightaway now.
Note that staff still has the confirmation button.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #12 from Owen Leonard oleon...@myacpl.org ---
(In reply to Owen Leonard from comment #4)
 Testing after applying the patch:

I once again followed this test plan.

 - Viewing public lists, navigate to second page of lists.
 - Click an list WITH CONTENTS to view its contents.
 - Click the delete list button from the list contents view.
 - No error. Redirected to the first page of public lists with no 
   link to the second page of lists. Navigating back to public lists
   and then to the second page of lists shows that the list WAS NOT
   deleted.
 
 Fail.

This was the only failure among those tests, other than the continuing problem
of the pagination links disappearing.

I'm not sure whether to sign off on this because it is an improvement or ask
that this one case be fixed as well.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #13 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Owen Leonard from comment #12)
 (In reply to Owen Leonard from comment #4)
  Testing after applying the patch:
 
 I once again followed this test plan.
 
  - Viewing public lists, navigate to second page of lists.
  - Click an list WITH CONTENTS to view its contents.
  - Click the delete list button from the list contents view.
  - No error. Redirected to the first page of public lists with no 
link to the second page of lists. Navigating back to public lists
and then to the second page of lists shows that the list WAS NOT
deleted.
  
  Fail.
 
 This was the only failure among those tests, other than the continuing
 problem of the pagination links disappearing.
 
 I'm not sure whether to sign off on this because it is an improvement or ask
 that this one case be fixed as well.

Do you mean that the list was not deleted in this case?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #15627|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 CC||jonathan.dru...@biblibre.co
   ||m
 Resolution|--- |FIXED

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
Works for me on master.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #5 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Seems lists need some revamping.
It is just impossible to correct this bug with current code.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Owen Leonard oleon...@myacpl.org ---
Testing after applying the patch:

- Viewing private lists, navigate to second page of lists
- Click 'delete' link next to a list name for an EMPTY list.
- Deletion successful.

Success.

- Viewing private lists, navigate to second page of lists
- Click 'delete' link next to a list name for an list WITH CONTENTS.
- Deletion successful but WITHOUT WARNING (I guess it's this way in
  master too).

Success.

- Viewing private lists, navigate to second page of lists.
- Click an EMPTY list to view its contents.
- Click the delete list button from the list contents view.
- No error, list deleted.

Success.

- Viewing private lists, navigate to second page of lists.
- Click a list WITH CONTENTS to view its contents.
- Click the delete list button from the list contents view.
- No error. Redirected to the first page of private lists with 
  no link to the second page of lists. Navigating back to private
  lists and then to the second page of lists shows that the list 
  was not deleted.

Fail.

- Viewing public lists, navigate to second page of lists
- Click 'delete' link next to a list name for an EMPTY list.
- No error. Redirected to the first page of public lists with no 
  link to the second page of lists. Navigating back to public lists
  and then to the second page of lists shows that the list WAS
  deleted.

Success*

- Viewing public lists, navigate to second page of lists
- Click 'delete' link next to a list name for list WITH CONTENTS.
- No error. Redirected to the first page of public lists with no 
  link to the second page of lists. Navigating back to public lists
  and then to the second page of lists shows that the list WAS NOT
  deleted.

Fail.

- Viewing public lists, navigate to second page of lists.
- Click an EMPTY list to view its contents.
- Click the delete list button from the list contents view.
- No error. Redirected to the first page of public lists with no 
  link to the second page of lists. Navigating back to public lists
  and then to the second page of lists shows that the list WAS
  deleted.

Success*

- Viewing public lists, navigate to second page of lists.
- Click an list WITH CONTENTS to view its contents.
- Click the delete list button from the list contents view.
- No error. Redirected to the first page of public lists with no 
  link to the second page of lists. Navigating back to public lists
  and then to the second page of lists shows that the list WAS NOT
  deleted.

Fail.

* The problem of being redirected to the first page of lists with no pagination
link to more lists is one which I thought we had a separate bug report for, but
I can't find it. In terms of the list being deleted these tests are successful,
but in terms of offering the user a working process they are a failure.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

--- Comment #2 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
This is still existing in actual master : 3.11.00.018

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=5524

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff
   Assignee|gmcha...@gmail.com  |fridolyn.som...@biblibre.co
   ||m

--- Comment #3 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 15627
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15627action=edit
Proposed patch

See commit message

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE

--- Comment #1 from Nicole C. Engard neng...@gmail.com 2011-04-28 12:10:16 
UTC ---


*** This bug has been marked as a duplicate of bug 5524 ***

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/