[Koha-bugs] [Bug 6590] Removing hyphens from ISBN and ISSN when cataloging a biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

--- Comment #27 from Katrin Fischer  ---
Would this help here?

Bug 23919 - Make ISSN searchable with and without hyphen

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from ISBN and ISSN when cataloging a biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Johanna Räisä  changed:

   What|Removed |Added

 CC||johanna.ra...@koha-suomi.fi

--- Comment #26 from Johanna Räisä  ---
Removing hyphens from the marcxml record is against the standard. I liked the
idea in the bug 27774 and now we have elasticsearch, so could this be done with
a system preference? When using elasticsearch keep hyphens on the marcxml for
example.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from ISBN and ISSN when cataloging a biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Magnus Enger  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28584

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from ISBN and ISSN when cataloging a biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

--- Comment #25 from Katrin Fischer  ---
*** Bug 27774 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from ISBN and ISSN when cataloging a biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Katrin Fischer  changed:

   What|Removed |Added

Summary|Removing hyphens from isbn  |Removing hyphens from ISBN
   |and issn when cataloging a  |and ISSN when cataloging a
   |biblio  |biblio

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27774

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Owen Leonard  changed:

   What|Removed |Added

Version|3.6 |master
   Priority|PATCH-Sent (DO NOT USE) |P5 - low

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Manos PETRIDIS  changed:

   What|Removed |Added

 CC||egpetri...@yahoo.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #23 from David Cook dc...@prosentient.com.au ---
(In reply to Fridolin SOMERS from comment #21)
 In Biblibre Solr version of Koha, there are plugins that can be defined on
 (sub)fields to perform such operations before indexing. One exists for ISBN
 adding normalized and without hyphens forms.
 
 Note that when using ICU indexing, the hyphen is a special separator so
 search with or without hyphens matchs ISBN, even adding hyphens in random
 place.

I don't really understand ICU indexing, but it looks like there is a specific
transliteration rule in the master words-icu.xml for hyphens when they're
preceded by numbers:

http://userguide.icu-project.org/transforms/general#TOC-Context

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=etc/zebradb/etc/words-icu.xml;h=57498cbca4a3ea2c76399f424b792e3055dcea01;hb=HEAD

It looks to me that hyphens get removed...

But then as Colin Campbell points out, there is a problem searching using
hyphens when using ICU:

http://lists.indexdata.dk/pipermail/zebralist/2013-August/002576.html

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

--- Comment #24 from David Cook dc...@prosentient.com.au ---
I've also run into the same problem as Colin... although I've discovered that
it appears to be an issue with newer versions of Zebra such as 2.0.59.

Older versions such as 2.0.47 and 2.0.44 (this latter is the default in the
Debian and Ubuntu repositories) seem to be unaffected. So if you installed
Zebra via the Indexdata repositories or newer versions by source, you  might be
affected by this bug as well...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13528

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #22 from Kyle M Hall k...@bywatersolutions.com ---
 Or could we do some trickery before the indexing? Like add a Koha-specific,
 hidden subfield to 020 where we store a normalized ISBN when a record is
 saved/updated? Business::ISBN would be good for doing that, I think.

This. Business::ISBN does an excellent job of normalizing ISBNs.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

--- Comment #21 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
In Biblibre Solr version of Koha, there are plugins that can be defined on
(sub)fields to perform such operations before indexing. One exists for ISBN
adding normalized and without hyphens forms.

Note that when using ICU indexing, the hyphen is a special separator so search
with or without hyphens matchs ISBN, even adding hyphens in random place.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

--- Comment #20 from Magnus Enger mag...@enger.priv.no ---
(In reply to comment #12)
 Alternate implementation idea:  use Zebra indexing configs to index both the
 plaintext ISBN (as it's written in the MARC record) and the normalized ISBN.
 This way, we don't have to change any of the actual data in the records or
 how search works; we just add more access points to the data.  Less chance
 of regression this way.
 
 I think if we added isbn.chr file to etc/zebradb/etc, updated default.idx to
 include it, and modified record.abs to add ISBN and ISSN to those index
 types, we could pull this off.

This sounds promising, but we need to be careful how we do the normalization.
We could extract {0-9xX} from 020$a, but then this would result in an incorrect
ISBN being indexed:

020 $a0914378260 (pbk. : v. 1) :$c$5.00

(This example is taken from
http://lists.indexdata.dk/pipermail/zebralist/2009-March/002136.html)

So we need to do something like extract the first word from 020$a, and then
extract {0-9xX} from it. Can we do that with a .chr file? 

Maybe it is easier with DOM indexing, as hinted at here?
http://lists.indexdata.dk/pipermail/zebralist/2009-March/002137.html

Or could we do some trickery before the indexing? Like add a Koha-specific,
hidden subfield to 020 where we store a normalized ISBN when a record is
saved/updated? Business::ISBN would be good for doing that, I think.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Serhij Dubyk du...@library.lviv.ua changed:

   What|Removed |Added

 CC||du...@library.lviv.ua

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

--- Comment #14 from Paul Poulain paul.poul...@biblibre.com 2011-10-07 
08:22:01 UTC ---
Ian, Frydolin, anyone : do you see a case where it could be interesting to keep
- in isbn/issn ?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

--- Comment #15 from Frédéric Demians frede...@tamil.fr 2011-10-07 08:51:43 
UTC ---
 Ian, Frydolin, anyone : do you see a case where it could be
 interesting to keep - in isbn/issn ?

In UNIMARC, ISBN field is supposed to contain ISBN as written on the
book cover. ISBN without hyphens can be stored in EAN (073) field.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

--- Comment #16 from Fridolyn SOMERS fridolyn.som...@gmail.com 2011-10-07 
12:22:18 UTC ---
(In reply to comment #14)
 Ian, Frydolin, anyone : do you see a case where it could be interesting to 
 keep
 - in isbn/issn ?

There may be a problem :
Hyphens are removed only if ISBN or ISSN index is present in search query.
If no index is selected and ISBN value (with hyphens) entered in search field,
search will not find.

This may appear in a copy/paste from an external source.

In our development, we indexed both with and without hyphens by duplicating the
ISBN/ISSN sub-fields in rebuild_zebra.

Note : in this patch, ISBN/ISSN field/subfield are hardcoded, regardless to
koha to marc mapping.

(in this case, a more extendable search engine like solr would be welcome)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Ian Walls ian.wa...@bywatersolutions.com changed:

   What|Removed |Added

   Patch Status|Signed Off  |Failed QA

--- Comment #17 from Ian Walls ian.wa...@bywatersolutions.com 2011-10-07 
15:49:15 UTC ---
Since this patch changes the MARC data, and that's in violation of UNIMARC
rules, I'm marking this as Failed QA.

I think my solution of adding an additional index field to ISBN that normalizes
it would be the most robust; it would work with keyword index, and not alter
the data in any way.  It would just provide more access points.  The new .chr
file could be reused on any numeric field we need to normalize.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

--- Comment #18 from Paul Poulain paul.poul...@biblibre.com 2011-10-07 
16:05:28 UTC ---
Ian, agreed with your arguments  conclusion
( also agreeing that something easier to extend like Solr will be good, but
that's another topic ;-) )

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

--- Comment #19 from Magnus Enger mag...@enger.priv.no 2011-10-07 16:26:59 
UTC ---
I agree with Ian - Koha should not change stuff that cataloguers put into the
MARC records.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com

--- Comment #11 from Paul Poulain paul.poul...@biblibre.com 2011-10-06 
12:06:33 UTC ---
sorry for being late to QA this patch

* the syspref system has been updated recently, and everything is not in
installer/data/mysql/sysprefs.sql, no need to have a specific line for each
language, so this patch won't apply

* i'm not sure a syspref is needed : when should we keep isbns ? Shouldn't we
just remove them.

Otherwise, the patch is good, and if you provide a new patch or convince me
that the syspref is needed before 3.6 i'll mark passed QA quickly.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 AssignedTo|gmcha...@gmail.com  |juan.sie...@xercode.es

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

--- Comment #12 from Ian Walls ian.wa...@bywatersolutions.com 2011-10-06 
12:22:33 UTC ---
Alternate implementation idea:  use Zebra indexing configs to index both the
plaintext ISBN (as it's written in the MARC record) and the normalized ISBN. 
This way, we don't have to change any of the actual data in the records or how
search works; we just add more access points to the data.  Less chance of
regression this way.

I think if we added isbn.chr file to etc/zebradb/etc, updated default.idx to
include it, and modified record.abs to add ISBN and ISSN to those index types,
we could pull this off.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

--- Comment #13 from Juan Romay Sieira juan.sie...@xercode.es 2011-10-06 
14:38:19 UTC ---
The syspref it's only to give an option to end user. If a library wants to keep
hyphens indexed, they could.
If you consider to remove it, I can do it, and upload a new patch.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #10 from Julian Maurice julian.maur...@biblibre.com 2011-07-22 
08:47:10 UTC ---
Patch seems to work on my Unimarc install.
I tried to modify an existing record and add hyphens in isbn and issn, and then
search for these isbn and issn (with and without hyphens).
I tried rebuild_zebra too (with and without -x and -nosanitize options).

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Juan Romay Sieira juan.sie...@xercode.es changed:

   What|Removed |Added

   Attachment #4637|0   |1
is obsolete||
   Attachment #4655|0   |1
is obsolete||
   Attachment #4656|0   |1
is obsolete||

--- Comment #9 from Juan Romay Sieira juan.sie...@xercode.es 2011-07-19 
11:35:43 UTC ---
Created attachment 4667
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4667
Removing hyphens from isbn and issn

If syspref IsbnIssnRemoveHyphens is enabled, hyphens from isbn and issn are
removed when zebra operations are executed. With rebuild_zebra does the same
thing, and it could be executed with -x -nosanitize param or not.

To test it, apply this patch, insert the new syspref  enable it, replace
zebraqueue_daemon.pl (of xxx-dev folder) with the included in misc/bin/, and
restart koha-zebraqueue-ctl.sh. Catalog a biblio or rebuild zebra index.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

--- Comment #6 from Juan Romay Sieira juan.sie...@xercode.es 2011-07-18 
10:44:20 UTC ---
Created attachment 4655
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4655
Patch to apply after the first one

In the first patch, hyphens were removed in the field MARCXML. Because this
could be a problem during an export of records, I decided to remove hyphens
while zebra operations are executed.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

--- Comment #7 from Juan Romay Sieira juan.sie...@xercode.es 2011-07-18 
10:54:49 UTC ---
Created attachment 4656
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4656
Missed add this file misc/bin/zebraqueue_daemon.pl in the second patch

I missed add this file misc/bin/zebraqueue_daemon.pl.

To test it, after apply the patches, replace zebraqueue_daemon.pl (of xxx-dev
folder) with the included in misc/bin/ . zebra queue daemon must be stop/start
to take effect (And if changes in sysprefs was made, restart queue daemon too).

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #2 from Frédéric Demians frede...@tamil.fr 2011-07-15 17:43:42 
UTC ---
I don't agree with this patch.

1) It doesn't handle multiple ISBN. In UNIMARC biblio record, you can
   repeat 010 field. With this patch, the first ISBN is 'normalized'.
   The followings are kept as they are.

2) This line doesn't sound good:

   $operand =~ s/-//g if (C4::Context-preference(IsbnIssnRemoveHyphens));

   '-' doesn't have the same meaning depending of the context. It must
   be interpreted differently in a term and in a ISBN. In an ISBN, it
   must be suppressed to concatenate all ISBN parts. In a phrase, it is
   a breaking character like space, comma, etc. 

3) With this patch, ISBN stored in Koha DB don't follow anymore
   MARC21/UNIMARC format which specify that hyphens must be present.

In my opinion, correct ISBN indexing and search should be delegated to
Zebra and mustn't modify stored biblio records. We could create a new
index type (we already have word, phrase, numeric index types). For this
type, hyphens could be suppressed by Zebra. And Koha search query
parser could identify ISBN/ISSN by a regex and suppress hyphens only for
them before sending search query to Zebra.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

   Priority|P5  |PATCH-Sent
   Patch Status|--- |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

--- Comment #4 from Juan Romay Sieira juan.sie...@xercode.es 2011-07-15 
21:25:01 UTC ---
(In reply to comment #2)
 I don't agree with this patch.
 
 1) It doesn't handle multiple ISBN. In UNIMARC biblio record, you can
repeat 010 field. With this patch, the first ISBN is 'normalized'.
The followings are kept as they are.
 
 2) This line doesn't sound good:
 
$operand =~ s/-//g if (C4::Context-preference(IsbnIssnRemoveHyphens));
 
'-' doesn't have the same meaning depending of the context. It must
be interpreted differently in a term and in a ISBN. In an ISBN, it
must be suppressed to concatenate all ISBN parts. In a phrase, it is
a breaking character like space, comma, etc. 
 
 3) With this patch, ISBN stored in Koha DB don't follow anymore
MARC21/UNIMARC format which specify that hyphens must be present.
 
 In my opinion, correct ISBN indexing and search should be delegated to
 Zebra and mustn't modify stored biblio records. We could create a new
 index type (we already have word, phrase, numeric index types). For this
 type, hyphens could be suppressed by Zebra. And Koha search query
 parser could identify ISBN/ISSN by a regex and suppress hyphens only for
 them before sending search query to Zebra.

If UNIMARC handle multiple isbns, its no just a problem to loop over them, and
remove hyphens in every one. And, the original isbn is kept in isbn field in
biblioitems table.
When a search is performed, only during search specifically by isbn or issn,
hyphens are removed from query, but not during other search like kw, au ...
I'm agree with the modification in koha. Add another index type to handle this.
I saw somebody did it a few days ago, here:
http://lists.indexdata.dk/pipermail/zebralist/2010-May/002423.html , it maybe
work, its only a decision about handle it.

We need this change, by one way or another, because most of the people search
an isbn without hyphens, and as I saw, most of the Z we used, could handle
this, searching with or without hyphens.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/