[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2013-04-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

--- Comment #30 from Chris Cormack ch...@bigballofwax.co.nz ---
Was released in 3.10.0, patches attached don't apply to 3.8.x, closing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-12-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9277

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED

--- Comment #25 from Paul Poulain paul.poul...@biblibre.com ---
I think I've found a big problem with this patch.
Under certain circumstances (I think it's because zebra  mysql are unsynched,
this can happen when you just deleted an authority, and it hasn't been deleted
on zebra) I get:

Can't use an undefined value as a HASH reference at
/home/paul/koha.dev/koha-community/C4/AuthoritiesMarc.pm line 355.
 at /home/paul/koha.dev/koha-community/authorities/authorities-home.pl line 203

git blame tells me the culprit is here. Investigating a little bit, I see that:
+   GetAuthType($authtypecode)-{'summary'};
will fail if GetAuthType() returns nothing
Changing this line to 
 ( GetAuthType($authtypecode) ? $_-{'authtypetext'}:'');

seems to fix the problem. Jared, could you check, confirm  provide a patch,
i'll sign it immediately

Another problem, maybe not related = the authorities in the list are now
displayed  HASH(0xb67ed88)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

--- Comment #26 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 11296
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11296action=edit
Bug 6720 follow-up: fix error when auth has been deleted

Thanks to Paul Poulain for finding the problem and proposing a solution.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

--- Comment #27 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Your suggested fix worked perfectly, as far as I could tell.

(In reply to comment #25)
 Another problem, maybe not related = the authorities in the list are now
 displayed  HASH(0xb67ed88)

See bug 8520 for a patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #28 from Paul Poulain paul.poul...@biblibre.com ---
follow-up signed-off, passed QA  pushed in one go

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

--- Comment #29 from Chris Cormack ch...@bigballofwax.co.nz ---
The three patches here don't apply cleanly to 3.8.x

 HEAD
===
my $thisauthtype = GetAuthType(GetAuthTypeCode($authid));
$newline{authtype} = defined ($thisauthtype) ?
$thisauthtype-{'authtypetext'} :
(GetAuthType($authtypecode) ?
$_-{'authtypetext'} : '');
 983012d... Bug 6720 follow-up: fix error when auth has been deleted

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

--- Comment #24 from Chris Cormack ch...@bigballofwax.co.nz ---
Patches do not apply on 3.8.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-07-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_8

--- Comment #22 from Paul Poulain paul.poul...@biblibre.com ---
The 3 patches on branch new/bug_6720 can be cherry picked to 3.8.x.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-07-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

--- Comment #20 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #19)
 mmm... the code says:
 +$newline{authtype} = defined ($thisauthtype) ?
 +$thisauthtype-{'summary'} :
 +   
 GetAuthType($authtypecode)-{'summary'};
 
 summary is not the authtype description, but how the authority display is
 built. I tried the patch anyway, and got a -suspected- wrong result: 
 
 The type of heading column now show:
 [200a][, 200b][ 200d][ ; 200c][ (200f)]
 
 :\\\

This definitely does not sound right. Follow-up coming shortly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-07-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-07-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

--- Comment #21 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 10861
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10861action=edit
Bug 6720 follow-up: use authtypetext instead of summary

Although auth_types.summary contains a string describing the type of
authority in MARC21, it does not in UNIMARC. auth_types.authtypetext
contains the proper label in both marcflavours.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-07-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #19 from Paul Poulain paul.poul...@biblibre.com ---
mmm... the code says:
+$newline{authtype} = defined ($thisauthtype) ?
+$thisauthtype-{'summary'} :
+   
GetAuthType($authtypecode)-{'summary'};

summary is not the authtype description, but how the authority display is
built. I tried the patch anyway, and got a -suspected- wrong result: 

The type of heading column now show:
[200a][, 200b][ 200d][ ; 200c][ (200f)]

:\\\

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-07-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
 QA Contact|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-07-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA Comments:

my $thisauthtype = GetAuthType(GetAuthTypeCode($authid));
This line is very scabby. It does 2 selects on the auth_header table.
But I don't find an other way to do that in our API.

Considering the dirty code into the SearchAuthorities routine, I mark as passed
QA this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

--- Comment #16 from Mirko Tietgen 5...@gmx.de ---
Created attachment 10444
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10444action=edit
Bug 6720: Display the authority type in OPAC

Due to a peculiarity in the way SearchAuthorities worked, the authority
search results on the OPAC always listed the authority type that the
user searched for, rather than the authority type of the results.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Works nicely, result list for OPAC search now shows the authority type
for each record.

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com
Rebased 20 June 2012.

Signed-off-by: Mirko Tietgen 5...@gmx.de
Works as expected.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Mirko Tietgen 5...@gmx.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||5...@gmx.de

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #13 from Chris Cormack ch...@bigballofwax.co.nz ---
Jared, is 
http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=authorities/detail.pl;h=a7d7d8f21882b7bcace75c5eb862eaebad8dfdeb;hp=d4f2c6730c76f19fb0aeefebdfd7fe5558066eff;hb=f809e47fd1644314bbd63542f3021382eece642f;hpb=f2ca89b30e8d48b987782ff3f9f7c8e8240b87a4

Safe to cherry-pick now, or best to wait until the second patch is pushed to
master also?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

--- Comment #14 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #13)
 Jared, is 
 http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=authorities/
 detail.pl;h=a7d7d8f21882b7bcace75c5eb862eaebad8dfdeb;
 hp=d4f2c6730c76f19fb0aeefebdfd7fe5558066eff;
 hb=f809e47fd1644314bbd63542f3021382eece642f;
 hpb=f2ca89b30e8d48b987782ff3f9f7c8e8240b87a4
 
 Safe to cherry-pick now, or best to wait until the second patch is pushed to
 master also?

You can cherry-pick that patch, and cherry-pick the next once it's been pushed
to master.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

--- Comment #15 from Chris Cormack ch...@bigballofwax.co.nz ---
Done, thanks for the quick reply

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply
 CC||paul.poul...@biblibre.com

--- Comment #9 from Paul Poulain paul.poul...@biblibre.com ---
The 1st patch does not apply anymore, the 2nd one is OK, so will push the 2nd
one now, please rebase the 1st one

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

  Attachment #10297|0   |1
is obsolete||

--- Comment #10 from Paul Poulain paul.poul...@biblibre.com ---
Comment on attachment 10297
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10297
[SIGNED-OFF] Bug 6720: show authority type in auth details

This patch has been pushed

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #10294|0   |1
is obsolete||

--- Comment #11 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 10380
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10380action=edit
Bug 6720: Display the authority type in OPAC

Due to a peculiarity in the way SearchAuthorities worked, the authority
search results on the OPAC always listed the authority type that the
user searched for, rather than the authority type of the results.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Works nicely, result list for OPAC search now shows the authority type
for each record.

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com
Rebased 20 June 2012.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #12 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Another signoff for the first patch now that it's been rebased would be super
keen.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #10265|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 10294
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10294action=edit
[SIGNED-OFF] Bug 6720: Display the authority type in OPAC

Due to a peculiarity in the way SearchAuthorities worked, the authority
search results on the OPAC always listed the authority type that the
user searched for, rather than the authority type of the results.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Works nicely, result list for OPAC search now shows the authority type
for each record.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Small note: Bug should remain open after pushing this patch. The problem also
still exists on the authority detail page in staff.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

--- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 10295
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10295action=edit
Bug 6720: show authority type in auth details

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #10295|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 10297
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10297action=edit
[SIGNED-OFF] Bug 6720: show authority type in auth details

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Authority type on detail page in staff now shows correctly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

--- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Thx Jared for providing an additional patch for the staff side problem!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #8 from Ian Walls koha.sek...@gmail.com ---
Patch 1:  adds new template param to get the Auth Type properly, then displays
it in the template.  Passed QA.

Patch 2:  replaces an empty string with the actual Auth Type.  Marking Passed
QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

--- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 10265
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10265action=edit
Bug 6720: Display the authority type in OPAC

Due to a peculiarity in the way SearchAuthorities worked, the authority
search results on the OPAC always listed the authority type that the
user searched for, rather than the authority type of the results.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Blocks||8212

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2011-08-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 CC||ian.walls@bywatersolutions.
   ||com
  Component|Templates   |MARC Authority data support
 AssignedTo|oleon...@myacpl.org |gmcha...@gmail.com

--- Comment #1 from Owen Leonard oleon...@myacpl.org 2011-08-15 16:36:22 UTC 
---
If this is a template error then it's not one I can see either. I'm
reclassifying this as an Authorities bug.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/