[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED --- Comment #131 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Patch too complex and big to backport to 3.14.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #130 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Chris, Kyle, Fridolin, Katrin, and Jonathan! Note that I have elected to have the feature be OFF by default for upgrades. It will be on by default for new installations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Keywords||rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #120 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Back to this... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #121 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 26836 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26836action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set Block expired patrons to Block 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set Block expired patrons to Don't block 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set Block expired patrons to Follow system preference BlockExpiredPatronOpacActions 9) Set the system preference BlockExpiredPatronOpacActions to Block 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to Don't block 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Melia Meggs me...@bywatersolutions.com Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #122 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 26837 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26837action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup Signed-off-by: Melia Meggs me...@bywatersolutions.com Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #123 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 26838 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26838action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup 2 * Hide renewal column, buttons and links * Fixes minor bug where upper-right table links would show even if renewal impossible * Cleans up some of the template formatting ( whitespace changes only ) Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #126 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 26841 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26841action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup 5 - Fixes a typo in one of the OPAC messages: you account - Fixes the updatedatabase script to use 1 instead of yes for the system preference default matching the sysprefs.sql file. - Fixes capitalization Don't Block in system preference description. - Adding . to the end of the warning, when renewals are blocked. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #127 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 26842 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26842action=edit [PASSED QA] Bug 6739: FIX conflicts with some others bugs. see comments 86 and 88. This patch fixes a bad conflict resolution in a previous patch. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #124 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 26839 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26839action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Installer fixes : - in kohastructure.sql, category.BlockExpiredPatronOpacActions default value is -1, sets the same in updatedatabase.pl - in syspref comment, replaces opac actions such as placing a hold or reserve by opac actions such as placing holds or renrw books - A 'YesNo' does not have 'yes' as value in database, it is '1'. - corrects small typo categori and syspref name case Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #125 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 26840 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26840action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Some corrections : - opac-reserve.tt : opening p instead of closing - opac-user.tt : warnexpired was in database format, adds the use of KohaDates template plugin - opac-user.tt : duplicated TT test : [% IF ( BORROWER_INF.warnexpired ) %] and [% ELSIF ( BORROWER_INF.warnexpired ) %], maybe a merge error - opac-user.tt : string instead of strong, maybe for HTML 6 :-) - opac-user.pl : adding dateformat var to template is already done by Auth.pm Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script. Testing notes: - Database update * Changes to kohastructure match changes done by the updatedatabase statement. Feature is activated by default. Fixing 'yes' to be '1' in a follow up. * Ran database update succesfully. * Note: Patrons are now blocked by default in new installations AND in updated installations. - System preference * Verified system preference shows up correctly. - Category configuration * Add new patron category * Edit existing patron category * Delete patron category * Check patron category summary table. = Verified all actions work as expected. = Verified chosen value for BlockExpiredPatronOpacActions' is always displayed and saved correctly. * Note: The new value is missing from the summary table. * Note: The new value is also not shown when deleting a patron category. - Check functionality * Renew and place a hold for an NOT EXPIRED patron with a) category: use syspref (default) syspref: block (default) b) category: use syspref (default) syspref: don't block c) category: block syspref: don't block d) category: block syspref: block e) category: don't block sypref: block * Verified renewals and placing holds were never blocked. * Also verified that the warning from NotifyBorrowerDeparture still shows up correctly. * Renew and place a hold for an EXPIRED patron with a) category: use syspref (default) syspref: block (default) = OK, both actions are blocked. b) category: use syspref (default) syspref: don't block = OK, both actions possible. c) category: block syspref: don't block = OK, both actions are blocked. d) category: block syspref: block = OK, both actions are blocked. e) category: don't block sypref: block = OK, both actions possible. Signed-off-by: Katrin Fischer katrin.fischer...@web.de 2014-04-06 Update: Will repeat and amend above test plan on last patch in this series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #128 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 26843 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26843action=edit [PASSED QA] Bug 6739: Template changes for the bootstrap theme Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes QA script, t, xt and t/db_dependent/Members*. Testing notes: - Database update * Changes to kohastructure match changes done by the updatedatabase statement. Feature is activated by default! * Ran database update succesfully. * Note: Expired patrons are now blocked by default in new AND in updated installations. - System preference * Verified system preference shows up correctly. - Category configuration * Add new patron category * Edit existing patron category * Delete patron category * Check patron category summary table. = Verified all actions work as expected. = Verified chosen value for BlockExpiredPatronOpacActions is always displayed and saved correctly. * Note: The new value is missing from the summary table. * Note: The new value is also not shown when deleting a patron category. - Check functionality * Renew and place a hold for an NOT EXPIRED patron with a) category: use syspref (default) syspref: block (default) b) category: use syspref (default) syspref: don't block c) category: block syspref: don't block d) category: block syspref: block e) category: don't block sypref: block f) category: don't block syspref: don't block Holds and renewals were always possible. * Also verified that the warning from NotifyBorrowerDeparture still shows up correctly. * Verified holds and renewals are still blocked, when the user has a restriction with a date in the future. * Renew and place a hold for an EXPIRED patron with a) category: use syspref (default) syspref: block (default) Holds and renewals blocked. b) category: use syspref (default) syspref: don't block Holds an renewals possible. c) category: block syspref: don't block Holds and renewals blocked. d) category: block syspref: block Holds and renewals blocked. e) category: don't block sypref: block Holds and renewals possible. f) category: don't block syspref: don't block Holds and renewals possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #26546|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #26550|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #26552|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #26551|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #26548|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #26547|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #26549|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #26553|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #129 from Katrin Fischer katrin.fisc...@bsz-bw.de --- There are a few more things to note: - Changing the existing behaviour by activating the feature by default might be debatable. I am going to leave this as it is and it could be changed easily if we get some opionions on this before release. - The changes to GetMemberDetails are currently not covered by unit tests. All existing tests in for Members* pass, so I am going to pass this on the condition, that we get some more to cover the changes. Enhancements: - Show the new value on the patron category summary table - Show the new field when deleting a patron category -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added CC|jcam...@cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #118 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Applies now and passes QA script, more testing later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #119 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Testing this again, please have a little patience. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25158|0 |1 is obsolete|| Attachment #25159|0 |1 is obsolete|| Attachment #25160|0 |1 is obsolete|| Attachment #25161|0 |1 is obsolete|| Attachment #25162|0 |1 is obsolete|| Attachment #25231|0 |1 is obsolete|| Attachment #25232|0 |1 is obsolete|| Attachment #25233|0 |1 is obsolete|| --- Comment #109 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26546 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26546action=edit Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set Block expired patrons to Block 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set Block expired patrons to Don't block 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set Block expired patrons to Follow system preference BlockExpiredPatronOpacActions 9) Set the system preference BlockExpiredPatronOpacActions to Block 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to Don't block 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Melia Meggs me...@bywatersolutions.com Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #110 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26547 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26547action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup Signed-off-by: Melia Meggs me...@bywatersolutions.com Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #114 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26551 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26551action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 5 - Fixes a typo in one of the OPAC messages: you account - Fixes the updatedatabase script to use 1 instead of yes for the system preference default matching the sysprefs.sql file. - Fixes capitalization Don't Block in system preference description. - Adding . to the end of the warning, when renewals are blocked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #112 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26549 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26549action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Installer fixes : - in kohastructure.sql, category.BlockExpiredPatronOpacActions default value is -1, sets the same in updatedatabase.pl - in syspref comment, replaces opac actions such as placing a hold or reserve by opac actions such as placing holds or renrw books - A 'YesNo' does not have 'yes' as value in database, it is '1'. - corrects small typo categori and syspref name case Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #113 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26550 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26550action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Some corrections : - opac-reserve.tt : opening p instead of closing - opac-user.tt : warnexpired was in database format, adds the use of KohaDates template plugin - opac-user.tt : duplicated TT test : [% IF ( BORROWER_INF.warnexpired ) %] and [% ELSIF ( BORROWER_INF.warnexpired ) %], maybe a merge error - opac-user.tt : string instead of strong, maybe for HTML 6 :-) - opac-user.pl : adding dateformat var to template is already done by Auth.pm Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script. Testing notes: - Database update * Changes to kohastructure match changes done by the updatedatabase statement. Feature is activated by default. Fixing 'yes' to be '1' in a follow up. * Ran database update succesfully. * Note: Patrons are now blocked by default in new installations AND in updated installations. - System preference * Verified system preference shows up correctly. - Category configuration * Add new patron category * Edit existing patron category * Delete patron category * Check patron category summary table. = Verified all actions work as expected. = Verified chosen value for BlockExpiredPatronOpacActions' is always displayed and saved correctly. * Note: The new value is missing from the summary table. * Note: The new value is also not shown when deleting a patron category. - Check functionality * Renew and place a hold for an NOT EXPIRED patron with a) category: use syspref (default) syspref: block (default) b) category: use syspref (default) syspref: don't block c) category: block syspref: don't block d) category: block syspref: block e) category: don't block sypref: block * Verified renewals and placing holds were never blocked. * Also verified that the warning from NotifyBorrowerDeparture still shows up correctly. * Renew and place a hold for an EXPIRED patron with a) category: use syspref (default) syspref: block (default) = OK, both actions are blocked. b) category: use syspref (default) syspref: don't block = OK, both actions possible. c) category: block syspref: don't block = OK, both actions are blocked. d) category: block syspref: block = OK, both actions are blocked. e) category: don't block sypref: block = OK, both actions possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #111 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26548 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26548action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 2 * Hide renewal column, buttons and links * Fixes minor bug where upper-right table links would show even if renewal impossible * Cleans up some of the template formatting ( whitespace changes only ) Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #116 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26553 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26553action=edit Bug 6739: template changes for the bootstrap theme -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #115 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26552 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26552action=edit Bug 6739: FIX conflicts with some others bugs. see comments 86 and 88. This patch fixes a bad conflict resolution in a previous patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #117 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #108) I am sorry, there is a conflict I can't resolve in this patch series: Patches rebased against master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #108 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I am sorry, there is a conflict I can't resolve in this patch series: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 6739 - expired patrons not blocked from opac actions - Followup 2 fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 6739 - expired patrons not blocked from opac actions - Followup 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jacek Ablewicz a...@biblos.pk.edu.pl changed: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Rafal Kopaczka rkopac...@afm.edu.pl changed: What|Removed |Added CC||rkopac...@afm.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #25163|0 |1 is obsolete|| --- Comment #105 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 25231 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25231action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 5 - Fixes a typo in one of the OPAC messages: you account - Fixes the updatedatabase script to use 1 instead of yes for the system preference default matching the sysprefs.sql file. - Fixes capitalization Don't Block in system preference description. - Adding . to the end of the warning, when renewals are blocked. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #25164|0 |1 is obsolete|| --- Comment #106 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 25232 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25232action=edit Bug 6739: FIX conflicts with some others bugs. see comments 86 and 88. This patch fixes a bad conflict resolution in a previous patch. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #25165|0 |1 is obsolete|| --- Comment #107 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 25233 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25233action=edit Bug 6739: template changes for the bootstrap theme Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #24385|0 |1 is obsolete|| Attachment #24386|0 |1 is obsolete|| Attachment #24387|0 |1 is obsolete|| Attachment #24388|0 |1 is obsolete|| Attachment #24389|0 |1 is obsolete|| Attachment #24390|0 |1 is obsolete|| Attachment #24391|0 |1 is obsolete|| Attachment #24392|0 |1 is obsolete|| --- Comment #97 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25158 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25158action=edit Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set Block expired patrons to Block 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set Block expired patrons to Don't block 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set Block expired patrons to Follow system preference BlockExpiredPatronOpacActions 9) Set the system preference BlockExpiredPatronOpacActions to Block 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to Don't block 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Melia Meggs me...@bywatersolutions.com Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #99 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25160 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25160action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 2 * Hide renewal column, buttons and links * Fixes minor bug where upper-right table links would show even if renewal impossible * Cleans up some of the template formatting ( whitespace changes only ) Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #100 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25161 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25161action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Installer fixes : - in kohastructure.sql, category.BlockExpiredPatronOpacActions default value is -1, sets the same in updatedatabase.pl - in syspref comment, replaces opac actions such as placing a hold or reserve by opac actions such as placing holds or renrw books - A 'YesNo' does not have 'yes' as value in database, it is '1'. - corrects small typo categori and syspref name case Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #98 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25159 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25159action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup Signed-off-by: Melia Meggs me...@bywatersolutions.com Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #101 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25162 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25162action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Some corrections : - opac-reserve.tt : opening p instead of closing - opac-user.tt : warnexpired was in database format, adds the use of KohaDates template plugin - opac-user.tt : duplicated TT test : [% IF ( BORROWER_INF.warnexpired ) %] and [% ELSIF ( BORROWER_INF.warnexpired ) %], maybe a merge error - opac-user.tt : string instead of strong, maybe for HTML 6 :-) - opac-user.pl : adding dateformat var to template is already done by Auth.pm Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script. Testing notes: - Database update * Changes to kohastructure match changes done by the updatedatabase statement. Feature is activated by default. Fixing 'yes' to be '1' in a follow up. * Ran database update succesfully. * Note: Patrons are now blocked by default in new installations AND in updated installations. - System preference * Verified system preference shows up correctly. - Category configuration * Add new patron category * Edit existing patron category * Delete patron category * Check patron category summary table. = Verified all actions work as expected. = Verified chosen value for BlockExpiredPatronOpacActions' is always displayed and saved correctly. * Note: The new value is missing from the summary table. * Note: The new value is also not shown when deleting a patron category. - Check functionality * Renew and place a hold for an NOT EXPIRED patron with a) category: use syspref (default) syspref: block (default) b) category: use syspref (default) syspref: don't block c) category: block syspref: don't block d) category: block syspref: block e) category: don't block sypref: block * Verified renewals and placing holds were never blocked. * Also verified that the warning from NotifyBorrowerDeparture still shows up correctly. * Renew and place a hold for an EXPIRED patron with a) category: use syspref (default) syspref: block (default) = OK, both actions are blocked. b) category: use syspref (default) syspref: don't block = OK, both actions possible. c) category: block syspref: don't block = OK, both actions are blocked. d) category: block syspref: block = OK, both actions are blocked. e) category: don't block sypref: block = OK, both actions possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #102 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25163 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25163action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 5 - Fixes a typo in one of the OPAC messages: you account - Fixes the updatedatabase script to use 1 instead of yes for the system preference default matching the sysprefs.sql file. - Fixes capitalization Don't Block in system preference description. - Adding . to the end of the warning, when renewals are blocked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #103 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25164 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25164action=edit Bug 6739: FIX conflicts with some others bugs. see comments 86 and 88. This patch fixes a bad conflict resolution in a previous patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #104 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25165 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25165action=edit Bug 6739: template changes for the bootstrap theme -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739
--- Comment #88 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 21312
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21312
[PASSED QA] Bug 6739 - expired patrons not blocked from opac actions
Review of attachment 21312:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=6739attachment=21312)
-
::: opac/opac-user.pl
@@ +157,4 @@
if ($issues){
foreach my $issue ( sort { $b-{date_due}-datetime() cmp
$a-{date_due}-datetime() } @{$issues} ) {
# check for reserves
+my ( $restype, $res, undef ) = CheckReserves( $issue-{'itemnumber'}
);
This is a regression of bug 9367.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #21312|0 |1 is obsolete|| Attachment #21313|0 |1 is obsolete|| Attachment #21314|0 |1 is obsolete|| Attachment #21315|0 |1 is obsolete|| Attachment #21316|0 |1 is obsolete|| Attachment #21317|0 |1 is obsolete|| --- Comment #89 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24385 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24385action=edit Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set Block expired patrons to Block 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set Block expired patrons to Don't block 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set Block expired patrons to Follow system preference BlockExpiredPatronOpacActions 9) Set the system preference BlockExpiredPatronOpacActions to Block 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to Don't block 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Melia Meggs me...@bywatersolutions.com Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #90 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24386 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24386action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup Signed-off-by: Melia Meggs me...@bywatersolutions.com Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #92 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24388 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24388action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Installer fixes : - in kohastructure.sql, category.BlockExpiredPatronOpacActions default value is -1, sets the same in updatedatabase.pl - in syspref comment, replaces opac actions such as placing a hold or reserve by opac actions such as placing holds or renrw books - A 'YesNo' does not have 'yes' as value in database, it is '1'. - corrects small typo categori and syspref name case Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #91 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24387 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24387action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 2 * Hide renewal column, buttons and links * Fixes minor bug where upper-right table links would show even if renewal impossible * Cleans up some of the template formatting ( whitespace changes only ) Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #93 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24389 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24389action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Some corrections : - opac-reserve.tt : opening p instead of closing - opac-user.tt : warnexpired was in database format, adds the use of KohaDates template plugin - opac-user.tt : duplicated TT test : [% IF ( BORROWER_INF.warnexpired ) %] and [% ELSIF ( BORROWER_INF.warnexpired ) %], maybe a merge error - opac-user.tt : string instead of strong, maybe for HTML 6 :-) - opac-user.pl : adding dateformat var to template is already done by Auth.pm Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script. Testing notes: - Database update * Changes to kohastructure match changes done by the updatedatabase statement. Feature is activated by default. Fixing 'yes' to be '1' in a follow up. * Ran database update succesfully. * Note: Patrons are now blocked by default in new installations AND in updated installations. - System preference * Verified system preference shows up correctly. - Category configuration * Add new patron category * Edit existing patron category * Delete patron category * Check patron category summary table. = Verified all actions work as expected. = Verified chosen value for BlockExpiredPatronOpacActions' is always displayed and saved correctly. * Note: The new value is missing from the summary table. * Note: The new value is also not shown when deleting a patron category. - Check functionality * Renew and place a hold for an NOT EXPIRED patron with a) category: use syspref (default) syspref: block (default) b) category: use syspref (default) syspref: don't block c) category: block syspref: don't block d) category: block syspref: block e) category: don't block sypref: block * Verified renewals and placing holds were never blocked. * Also verified that the warning from NotifyBorrowerDeparture still shows up correctly. * Renew and place a hold for an EXPIRED patron with a) category: use syspref (default) syspref: block (default) = OK, both actions are blocked. b) category: use syspref (default) syspref: don't block = OK, both actions possible. c) category: block syspref: don't block = OK, both actions are blocked. d) category: block syspref: block = OK, both actions are blocked. e) category: don't block sypref: block = OK, both actions possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #95 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24391 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24391action=edit Bug 6739: FIX conflicts with some others bugs. see comments 86 and 88. This patch fixes a bad conflict resolution in a previous patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #96 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24392 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24392action=edit Bug 6739: template changes for the bootstrap theme -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #94 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24390 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24390action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 5 - Fixes a typo in one of the OPAC messages: you account - Fixes the updatedatabase script to use 1 instead of yes for the system preference default matching the sysprefs.sql file. - Fixes capitalization Don't Block in system preference description. - Adding . to the end of the warning, when renewals are blocked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739
--- Comment #86 from Galen Charlton gmcha...@gmail.com ---
Comment on attachment 21312
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21312
[PASSED QA] Bug 6739 - expired patrons not blocked from opac actions
Review of attachment 21312:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=6739attachment=21312)
-
::: opac/opac-user.pl
@@ +65,4 @@
}
);
+my $OPACDisplayRequestPriority =
(C4::Context-preference(OPACDisplayRequestPriority)) ? 1 : 0;
This is a regression on bug 7398; OPACDisplayRequestPriority no longer exists.
@@ -110,4 @@
$canrenew = 0;
$template-param(
renewal_blocked_fines = sprintf( '%.02f', $no_renewal_amt ),
-renewal_blocked_fines_amountoutstanding = sprintf( '%.02f',
$borr-{amountoutstanding} ),
Removing this would cause a regression of bug 8408.
@@ -170,5 @@
$charges += $ac-{'amountoutstanding'}
if $ac-{'accounttype'} eq 'F';
$charges += $ac-{'amountoutstanding'}
- if $ac-{'accounttype'} eq 'FU';
-$charges += $ac-{'amountoutstanding'}
Removing this would cause a regression on bug 8079.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #87 from Galen Charlton gmcha...@gmail.com --- Marked as failed QA on account of the three regressions that this patch series would cause. Overall, looks reasonable, and I expect it to pass into master once the regressions have been fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #85 from Jonathan Druart jonathan.dru...@biblibre.com --- Galen, Are you waiting for something to push these patches ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added QA Contact|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #76 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Working on this now... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #77 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Happy to say that it applied cleanly and passed the automatic tests :) Continueing testing... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20641|0 |1 is obsolete|| Attachment #20642|0 |1 is obsolete|| Attachment #20643|0 |1 is obsolete|| Attachment #20644|0 |1 is obsolete|| Attachment #20645|0 |1 is obsolete|| --- Comment #78 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21312 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21312action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set Block expired patrons to Block 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set Block expired patrons to Don't block 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set Block expired patrons to Follow system preference BlockExpiredPatronOpacActions 9) Set the system preference BlockExpiredPatronOpacActions to Block 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to Don't block 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Melia Meggs me...@bywatersolutions.com Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #79 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21313 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21313action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup Signed-off-by: Melia Meggs me...@bywatersolutions.com Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #82 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21316 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21316action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Some corrections : - opac-reserve.tt : opening p instead of closing - opac-user.tt : warnexpired was in database format, adds the use of KohaDates template plugin - opac-user.tt : duplicated TT test : [% IF ( BORROWER_INF.warnexpired ) %] and [% ELSIF ( BORROWER_INF.warnexpired ) %], maybe a merge error - opac-user.tt : string instead of strong, maybe for HTML 6 :-) - opac-user.pl : adding dateformat var to template is already done by Auth.pm Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script. Testing notes: - Database update * Changes to kohastructure match changes done by the updatedatabase statement. Feature is activated by default. Fixing 'yes' to be '1' in a follow up. * Ran database update succesfully. * Note: Patrons are now blocked by default in new installations AND in updated installations. - System preference * Verified system preference shows up correctly. - Category configuration * Add new patron category * Edit existing patron category * Delete patron category * Check patron category summary table. = Verified all actions work as expected. = Verified chosen value for BlockExpiredPatronOpacActions' is always displayed and saved correctly. * Note: The new value is missing from the summary table. * Note: The new value is also not shown when deleting a patron category. - Check functionality * Renew and place a hold for an NOT EXPIRED patron with a) category: use syspref (default) syspref: block (default) b) category: use syspref (default) syspref: don't block c) category: block syspref: don't block d) category: block syspref: block e) category: don't block sypref: block * Verified renewals and placing holds were never blocked. * Also verified that the warning from NotifyBorrowerDeparture still shows up correctly. * Renew and place a hold for an EXPIRED patron with a) category: use syspref (default) syspref: block (default) = OK, both actions are blocked. b) category: use syspref (default) syspref: don't block = OK, both actions possible. c) category: block syspref: don't block = OK, both actions are blocked. d) category: block syspref: block = OK, both actions are blocked. e) category: don't block sypref: block = OK, both actions possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #80 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21314 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21314action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup 2 * Hide renewal column, buttons and links * Fixes minor bug where upper-right table links would show even if renewal impossible * Cleans up some of the template formatting ( whitespace changes only ) Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #81 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21315 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21315action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Installer fixes : - in kohastructure.sql, category.BlockExpiredPatronOpacActions default value is -1, sets the same in updatedatabase.pl - in syspref comment, replaces opac actions such as placing a hold or reserve by opac actions such as placing holds or renrw books - A 'YesNo' does not have 'yes' as value in database, it is '1'. - corrects small typo categori and syspref name case Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #83 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21317 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21317action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 5 - Fixes a typo in one of the OPAC messages: you account - Fixes the updatedatabase script to use 1 instead of yes for the system preference default matching the sysprefs.sql file. - Fixes capitalization Don't Block in system preference description. - Adding . to the end of the warning, when renewals are blocked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Blocks||10932 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #84 from Katrin Fischer katrin.fisc...@bsz-bw.de --- This is something that is quite annoying for some libraries and I feel like I have tested thoroughly (which probably means I missed something). So some automated regression tests would be very much appreciated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #19994|0 |1 is obsolete|| --- Comment #72 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 20642 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20642action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 1 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #19993|0 |1 is obsolete|| --- Comment #71 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 20641 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20641action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions Rebased master. syspref.sql is now a single insert with alphabetical ordered sysprefs. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #19996|0 |1 is obsolete|| --- Comment #74 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 20644 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20644action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #19997|0 |1 is obsolete|| --- Comment #75 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 20645 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20645action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #70 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Patches no longer apply, I fixed the conflict in sysprefs.sql in the first patch, but got stuck on opac.tt in the third. Can you please rebase? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #19553|0 |1 is obsolete|| --- Comment #65 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19993 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19993action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #19555|0 |1 is obsolete|| --- Comment #67 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19995 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19995action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 2 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #19554|0 |1 is obsolete|| --- Comment #66 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19994 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19994action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 1 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #19678|0 |1 is obsolete|| --- Comment #68 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19996 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19996action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Rebased master. I recreated this patch manually. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #19679|0 |1 is obsolete|| --- Comment #69 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19997 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19997action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #64 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 6739 - expired patrons not blocked from opac actions - Followup 3 fatal: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #63 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I am sorry, I know this has gone rounds for a while, but I can't get follow up 3 to apply after fixing the merge conflict in the first patch. Can someone please provide rebased patches? Thx! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #19558|0 |1 is obsolete|| --- Comment #61 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19678 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19678action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Installer fixes : - in kohastructure.sql, category.BlockExpiredPatronOpacActions default value is -1, sets the same in updatedatabase.pl - in syspref comment, replaces opac actions such as placing a hold or reserve by opac actions such as placing holds or renrw books - A 'YesNo' does not have 'yes' as value in database, it is '1'. - corrects small typo categori and syspref name case Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #19560|0 |1 is obsolete|| --- Comment #62 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19679 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19679action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Some corrections : - opac-reserve.tt : opening p instead of closing - opac-user.tt : warnexpired was in database format, adds the use of KohaDates template plugin - opac-user.tt : duplicated TT test : [% IF ( BORROWER_INF.warnexpired ) %] and [% ELSIF ( BORROWER_INF.warnexpired ) %], maybe a merge error - opac-user.tt : string instead of strong, maybe for HTML 6 :-) - opac-user.pl : adding dateformat var to template is already done by Auth.pm Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #18042|0 |1 is obsolete|| --- Comment #55 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19554 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19554action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #18041|0 |1 is obsolete|| --- Comment #54 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19553 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19553action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #18043|0 |1 is obsolete|| --- Comment #56 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19555 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19555action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 2 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #57 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19558 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19558action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Follow-up to correct files in installer. See commit message. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #58 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Followup 3 needs signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
