subject:"\[Koha\-bugs\] \[Bug 7088\] cannot renew items on hold even with override"

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2022-11-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

 CC|bugzi...@warmlight.co.uk|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2020-07-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||25999


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25999
[Bug 25999] Renewal due date not being honoured for items with holds
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-10-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||23551


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551
[Bug 23551] Problem with renewal period when using the renewal tab
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-10-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23551

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-05-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
  Text to go in the||This enhancement enables
  release notes||items that are on hold to
   ||be renewed with a due date
   ||specified by the user. It
   ||is enabled by the new
   ||"AllowRenewalOnHoldOverride
   ||" system preference.
   ||
   ||It
   ||can appear in two
   ||locations:
   ||
   ||1. In the
   ||"Checkouts" table on the
   ||Patron Details screen. It
   ||is now possible to select
   ||on loan items that would
   ||otherwise fulfil a hold
   ||request to be renewed. When
   ||such an item is selected,
   ||an additional date
   ||selection box is displayed
   ||to allow the user to
   ||specify the due date for
   ||all on hold items that are
   ||to be renewed.
   ||
   ||2. In the
   ||Circulation > Renew alert
   ||screen. When a barcode of
   ||an on loan item that would
   ||ordinarily fulfil a hold
   ||request is entered, the
   ||usual alert is displayed
   ||indicating that the item is
   ||on hold, it is still
   ||possible to override this,
   ||and renew, however it is
   ||now also possible to
   ||specify a due date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-05-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||19.05.00
released in||
 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

--- Comment #86 from Martin Renvoize  ---
Enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-05-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #85 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89051|0   |1
is obsolete||

--- Comment #83 from Katrin Fischer  ---
Created attachment 89093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89093=edit
Bug 7088: (follow-up) AllowRenewalLimitOverride fix

This patch causes the click event listener on the #override_limit to be
created if EITHER the AllowRenewalOnHoldOverride OR
AllowRenewalLimitOverride sysprefs are enabled. Previously, it would
only be created if the AllowRenewalLimitOverride syspref was enabled,
which would cause the checkbox to be displayed but do nothing.

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89052|0   |1
is obsolete||

--- Comment #84 from Katrin Fischer  ---
Created attachment 89094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89094=edit
Bug 7088: (follow-up) Modify checkbox enabling

As described in comment #50, we need to only enable renewal on items
that are disabled in line with which sysprefs are enabled. So we now
only enable renewal of on hold items if the AllowRenewalOnHoldOverride
syspref is on and we only enable renewal of all other limited items
when the AllowRenewalLimitOverride syspref is on.

NOTE: The test plan below has changed substantially from previous
iterations

Test plan (you might want to make a coffee first...):

- Apply patch
- Rebuild CSS

- Go to the Patron Details page for a patron who has an item on loan that would
fulfil an outstanding loan request.
- The patron also needs to have an item on loan that cannot be renewed for some
other reason, say renewal limit has been reached
=> TEST: Observe that it is NOT possible to select either item for renewal

- Enable the "AllowRenewalLimitOverride" syspref
- Return to the Patron Details page
- Check the "Override renewal restrictions" checkbox
=> TEST: Observe that it IS possible to select the the item that has reached
the renewal limit, but not the item that is on hold

- Disable the "AllowRenewalLimitOverride" syspref
- Enable the "AllowRenewalOnHoldOverride" syspref
- Return to the Patron Details page
- Check the "Override renewal restrictions" checkbox
=> TEST: Observe that it is NOT possible to select the the item that has
reached the renewal limit, but it IS possible to select the item on hold

- Enable the "AllowRenewalLimitOverride" syspref
- Enable the "AllowRenewalOnHoldOverride" syspref
- Return to the Patron Details page
- Check the "Override renewal restrictions" checkbox
=> TEST: Observe that it IS possible to select the the item that has reached
the renewal limit, AND it IS possible to select the item on hold

- Select the item that is on hold
=> TEST: Observe that an additional "On hold due date" input box is displayed
- De-select the item
=> TEST: Observe that an additional "On hold due date" input box is hidden
- Select the item
- In the "On hold due date" input box, select a due date for the item
- Click "Renew or check in selected items"
=> TEST: Observe that the item is renewed as usual
- In the "Renewal due date" input box, select a due date
- Remove the contents of the "On hold due date" input box
- Click "Renew or check in selected items"
=> TEST: Observe that the item is renewed by falling back to the "Renewal due
date" value if a value is not specified in the "On hold due date" input box
- Remove the contents of the "Renewal due date" input box
- Click "Renew or check in selected items"
=> TEST: Observe that the standard loan period is used for the renewal period
if no due date is specified in either box
- In the "On hold due date" input box, select a due date for the item
- In the "Renewal due date" input box, select a different due date
- Click "Renew all"
=> TEST: Observe that all non on hold items are renewed using the value in
"Renewal due date" and on hold items are renewed using the value in "On hold
due date"
- From the main staff client from page, choose "Circulation", then choose
"Renew"
- Enter the barcode of an item that you know to be on hold and submit
=> TEST: In the alert box that appears, observe that a date picker is
displayed
- Choose a due date for this item, then click "Override and renew"
=> TEST: In the "Item renewed" box, observe that the item has been
renewed to the date specified

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89044|0   |1
is obsolete||

--- Comment #76 from Katrin Fischer  ---
Created attachment 89086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89086=edit
Bug 7088: Add AllowRenewalOnHoldOverride syspref

Enables the renewal of on hold items with specified due dates to be turned
on/off

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

Signed-off-by: Andrew Farthing 

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89046|0   |1
is obsolete||

--- Comment #78 from Katrin Fischer  ---
Created attachment 89088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89088=edit
Bug 7088: (follow-up) Fix renewal limit bug

There was a bug in that altering the state of the "Override renewal
limit" checkbox was altering the appearance of the per-item "On hold"
checkbox. This is incorrect, the "Override renewal limit" checkbox is
unconnected with this bug.

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

Signed-off-by: Andrew Farthing 

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89049|0   |1
is obsolete||

--- Comment #81 from Katrin Fischer  ---
Created attachment 89091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89091=edit
Bug 7088: (follow-up) Default hold checkbox display

As per item 4 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

Now, the checkbox for renewing on hold items behaves the same way as the
checkbox for renewing items that have reached their renew limit. It is
necessary to check the re-labelled "Override renewal restrictions"
checkbox before it is possible to select on-hold items for renewal.

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89047|0   |1
is obsolete||

--- Comment #79 from Katrin Fischer  ---
Created attachment 89089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89089=edit
Bug 7088: (follow-up) Remove script "type" attribute

As per item 1 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89048|0   |1
is obsolete||

--- Comment #80 from Katrin Fischer  ---
Created attachment 89090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89090=edit
Bug 7088: (follow-up) Set syspref default to off

As per item 2 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89050|0   |1
is obsolete||

--- Comment #82 from Katrin Fischer  ---
Created attachment 89092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89092=edit
Bug 7088: (follow-up) Add pref to checkbox

As per commit #29 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c29

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89045|0   |1
is obsolete||

--- Comment #77 from Katrin Fischer  ---
Created attachment 89087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89087=edit
Bug 7088: Allow renew on hold items with due date

This patch adds the ability for items that are on hold to be renewed with a due
date specfied by the user. It is enabled by the new
"AllowRenewalOnHoldOverride" syspref. It is manifested in two locations:

1. In the "Checkouts" table on the Patron Details screen. It is now possible to
select on loan items that would otherwise fulfil a hold request to be renewed.
When such an item is selected, an additional date selection box is displayed to
allow the user to specify the due date for all on hold items that are to be
renewed.

2. In the Circulation > Renew alert screen. When a barcode of an on loan item
that would ordinarily fulfil a hold request is entered, the usual alert is
displayed indicating that the item is on hold, it is still possible to override
this, and renew, however it is now also possible to specify a due date.

Test plan:

- Go to the Patron Details page for a patron who has an item on loan that would
fulfil an outstanding loan request.
- TEST: Observe that it is NOT possible to select this item
- Enable the "AllowRenewalOnHoldOverride" syspref
- Return to the Patron Details page for a patron who has an item on loan that
would fulfil an outstanding loan request.
- TEST: Observe that it IS possible to select this item
- Select the item
- TEST: Observe that an additional "On hold due date" input box is displayed
- De-select the item
- TEST: Observe that an additional "On hold due date" input box is hidden
- Select the item
- In the "On hold due date" input box, select a due date for the item
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed as usual
- In the "Renewal due date" input box, select a due date
- Remove the contents of the "On hold due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed by falling back to the "Renewal due
date" value if a value is not specified in the "On hold due date" input box
- Remove the contents of the "Renewal due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the standard loan period is used for the renewal period if
no due date is specified in either box
- In the "On hold due date" input box, select a due date for the item
- In the "Renewal due date" input box, select a different due date
- Click "Renew all"
- TEST: Observe that all non on hold items are renewed using the value in
"Renewal due date" and on hold items are renewed using the value in "On hold
due date"
- From the main staff client from page, choose "Circulation", then choose
"Renew"
- Enter the barcode of an item that you know to be on hold and submit
- TEST: In the alert box that appears, observe that a date picker is
displayed
- Choose a due date for this item, then click "Override and renew"
- TEST: In the "Item renewed" box, observe that the item has been
renewed to the date specified

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

Signed-off-by: Andrew Farthing 

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #75 from Katrin Fischer  ---
I guess I was too sleepy last night - the date field shows up once you actually
click on a hold to renew. I think it might be debatable to show it with
clicking the checkbox, but really no reason at all to fail this :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #74 from Katrin Fischer  ---
Hi Andrew, it might be my messed up rebase (changes from 21757 caused a
conflict), but now the hold due date never shows up.

Test case:
- Hold renewals allowed
- Renewal limit overrides are not

2 items on my account, both are 'on hold'

Check the checkbox - checkboxes unlock
But: the date doesn't show up

I am sorry, I'll give it another go tomorrow!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89034|0   |1
is obsolete||

--- Comment #73 from Katrin Fischer  ---
Created attachment 89052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89052=edit
Bug 7088: (follow-up) Modify checkbox enabling

As described in comment #50, we need to only enable renewal on items
that are disabled in line with which sysprefs are enabled. So we now
only enable renewal of on hold items if the AllowRenewalOnHoldOverride
syspref is on and we only enable renewal of all other limited items
when the AllowRenewalLimitOverride syspref is on.

NOTE: The test plan below has changed substantially from previous
iterations

Test plan (you might want to make a coffee first...):

- Apply patch
- Rebuild CSS

- Go to the Patron Details page for a patron who has an item on loan that would
fulfil an outstanding loan request.
- The patron also needs to have an item on loan that cannot be renewed for some
other reason, say renewal limit has been reached
=> TEST: Observe that it is NOT possible to select either item for renewal

- Enable the "AllowRenewalLimitOverride" syspref
- Return to the Patron Details page
- Check the "Override renewal restrictions" checkbox
=> TEST: Observe that it IS possible to select the the item that has reached
the renewal limit, but not the item that is on hold

- Disable the "AllowRenewalLimitOverride" syspref
- Enable the "AllowRenewalOnHoldOverride" syspref
- Return to the Patron Details page
- Check the "Override renewal restrictions" checkbox
=> TEST: Observe that it is NOT possible to select the the item that has
reached the renewal limit, but it IS possible to select the item on hold

- Enable the "AllowRenewalLimitOverride" syspref
- Enable the "AllowRenewalOnHoldOverride" syspref
- Return to the Patron Details page
- Check the "Override renewal restrictions" checkbox
=> TEST: Observe that it IS possible to select the the item that has reached
the renewal limit, AND it IS possible to select the item on hold

- Select the item that is on hold
=> TEST: Observe that an additional "On hold due date" input box is displayed
- De-select the item
=> TEST: Observe that an additional "On hold due date" input box is hidden
- Select the item
- In the "On hold due date" input box, select a due date for the item
- Click "Renew or check in selected items"
=> TEST: Observe that the item is renewed as usual
- In the "Renewal due date" input box, select a due date
- Remove the contents of the "On hold due date" input box
- Click "Renew or check in selected items"
=> TEST: Observe that the item is renewed by falling back to the "Renewal due
date" value if a value is not specified in the "On hold due date" input box
- Remove the contents of the "Renewal due date" input box
- Click "Renew or check in selected items"
=> TEST: Observe that the standard loan period is used for the renewal period
if no due date is specified in either box
- In the "On hold due date" input box, select a due date for the item
- In the "Renewal due date" input box, select a different due date
- Click "Renew all"
=> TEST: Observe that all non on hold items are renewed using the value in
"Renewal due date" and on hold items are renewed using the value in "On hold
due date"
- From the main staff client from page, choose "Circulation", then choose
"Renew"
- Enter the barcode of an item that you know to be on hold and submit
=> TEST: In the alert box that appears, observe that a date picker is
displayed
- Choose a due date for this item, then click "Override and renew"
=> TEST: In the "Item renewed" box, observe that the item has been
renewed to the date specified

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89033|0   |1
is obsolete||

--- Comment #72 from Katrin Fischer  ---
Created attachment 89051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89051=edit
Bug 7088: (follow-up) AllowRenewalLimitOverride fix

This patch causes the click event listener on the #override_limit to be
created if EITHER the AllowRenewalOnHoldOverride OR
AllowRenewalLimitOverride sysprefs are enabled. Previously, it would
only be created if the AllowRenewalLimitOverride syspref was enabled,
which would cause the checkbox to be displayed but do nothing.

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89032|0   |1
is obsolete||

--- Comment #71 from Katrin Fischer  ---
Created attachment 89050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89050=edit
Bug 7088: (follow-up) Add pref to checkbox

As per commit #29 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c29

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89029|0   |1
is obsolete||

--- Comment #68 from Katrin Fischer  ---
Created attachment 89047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89047=edit
Bug 7088: (follow-up) Remove script "type" attribute

As per item 1 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89027|0   |1
is obsolete||

--- Comment #66 from Katrin Fischer  ---
Created attachment 89045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89045=edit
Bug 7088: Allow renew on hold items with due date

This patch adds the ability for items that are on hold to be renewed with a due
date specfied by the user. It is enabled by the new
"AllowRenewalOnHoldOverride" syspref. It is manifested in two locations:

1. In the "Checkouts" table on the Patron Details screen. It is now possible to
select on loan items that would otherwise fulfil a hold request to be renewed.
When such an item is selected, an additional date selection box is displayed to
allow the user to specify the due date for all on hold items that are to be
renewed.

2. In the Circulation > Renew alert screen. When a barcode of an on loan item
that would ordinarily fulfil a hold request is entered, the usual alert is
displayed indicating that the item is on hold, it is still possible to override
this, and renew, however it is now also possible to specify a due date.

Test plan:

- Go to the Patron Details page for a patron who has an item on loan that would
fulfil an outstanding loan request.
- TEST: Observe that it is NOT possible to select this item
- Enable the "AllowRenewalOnHoldOverride" syspref
- Return to the Patron Details page for a patron who has an item on loan that
would fulfil an outstanding loan request.
- TEST: Observe that it IS possible to select this item
- Select the item
- TEST: Observe that an additional "On hold due date" input box is displayed
- De-select the item
- TEST: Observe that an additional "On hold due date" input box is hidden
- Select the item
- In the "On hold due date" input box, select a due date for the item
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed as usual
- In the "Renewal due date" input box, select a due date
- Remove the contents of the "On hold due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed by falling back to the "Renewal due
date" value if a value is not specified in the "On hold due date" input box
- Remove the contents of the "Renewal due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the standard loan period is used for the renewal period if
no due date is specified in either box
- In the "On hold due date" input box, select a due date for the item
- In the "Renewal due date" input box, select a different due date
- Click "Renew all"
- TEST: Observe that all non on hold items are renewed using the value in
"Renewal due date" and on hold items are renewed using the value in "On hold
due date"
- From the main staff client from page, choose "Circulation", then choose
"Renew"
- Enter the barcode of an item that you know to be on hold and submit
- TEST: In the alert box that appears, observe that a date picker is
displayed
- Choose a due date for this item, then click "Override and renew"
- TEST: In the "Item renewed" box, observe that the item has been
renewed to the date specified

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

Signed-off-by: Andrew Farthing 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89031|0   |1
is obsolete||

--- Comment #70 from Katrin Fischer  ---
Created attachment 89049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89049=edit
Bug 7088: (follow-up) Default hold checkbox display

As per item 4 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

Now, the checkbox for renewing on hold items behaves the same way as the
checkbox for renewing items that have reached their renew limit. It is
necessary to check the re-labelled "Override renewal restrictions"
checkbox before it is possible to select on-hold items for renewal.

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89030|0   |1
is obsolete||

--- Comment #69 from Katrin Fischer  ---
Created attachment 89048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89048=edit
Bug 7088: (follow-up) Set syspref default to off

As per item 2 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89028|0   |1
is obsolete||

--- Comment #67 from Katrin Fischer  ---
Created attachment 89046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89046=edit
Bug 7088: (follow-up) Fix renewal limit bug

There was a bug in that altering the state of the "Override renewal
limit" checkbox was altering the appearance of the per-item "On hold"
checkbox. This is incorrect, the "Override renewal limit" checkbox is
unconnected with this bug.

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

Signed-off-by: Andrew Farthing 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89026|0   |1
is obsolete||

--- Comment #65 from Katrin Fischer  ---
Created attachment 89044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89044=edit
Bug 7088: Add AllowRenewalOnHoldOverride syspref

Enables the renewal of on hold items with specified due dates to be turned
on/off

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

Signed-off-by: Andrew Farthing 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #64 from Liz Rea  ---
Created attachment 89034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89034=edit
Bug 7088: (follow-up) Modify checkbox enabling

As described in comment #50, we need to only enable renewal on items
that are disabled in line with which sysprefs are enabled. So we now
only enable renewal of on hold items if the AllowRenewalOnHoldOverride
syspref is on and we only enable renewal of all other limited items
when the AllowRenewalLimitOverride syspref is on.

NOTE: The test plan below has changed substantially from previous
iterations

Test plan (you might want to make a coffee first...):

- Apply patch
- Rebuild CSS

- Go to the Patron Details page for a patron who has an item on loan that would
fulfil an outstanding loan request.
- The patron also needs to have an item on loan that cannot be renewed for some
other reason, say renewal limit has been reached
=> TEST: Observe that it is NOT possible to select either item for renewal

- Enable the "AllowRenewalLimitOverride" syspref
- Return to the Patron Details page
- Check the "Override renewal restrictions" checkbox
=> TEST: Observe that it IS possible to select the the item that has reached
the renewal limit, but not the item that is on hold

- Disable the "AllowRenewalLimitOverride" syspref
- Enable the "AllowRenewalOnHoldOverride" syspref
- Return to the Patron Details page
- Check the "Override renewal restrictions" checkbox
=> TEST: Observe that it is NOT possible to select the the item that has
reached the renewal limit, but it IS possible to select the item on hold

- Enable the "AllowRenewalLimitOverride" syspref
- Enable the "AllowRenewalOnHoldOverride" syspref
- Return to the Patron Details page
- Check the "Override renewal restrictions" checkbox
=> TEST: Observe that it IS possible to select the the item that has reached
the renewal limit, AND it IS possible to select the item on hold

- Select the item that is on hold
=> TEST: Observe that an additional "On hold due date" input box is displayed
- De-select the item
=> TEST: Observe that an additional "On hold due date" input box is hidden
- Select the item
- In the "On hold due date" input box, select a due date for the item
- Click "Renew or check in selected items"
=> TEST: Observe that the item is renewed as usual
- In the "Renewal due date" input box, select a due date
- Remove the contents of the "On hold due date" input box
- Click "Renew or check in selected items"
=> TEST: Observe that the item is renewed by falling back to the "Renewal due
date" value if a value is not specified in the "On hold due date" input box
- Remove the contents of the "Renewal due date" input box
- Click "Renew or check in selected items"
=> TEST: Observe that the standard loan period is used for the renewal period
if no due date is specified in either box
- In the "On hold due date" input box, select a due date for the item
- In the "Renewal due date" input box, select a different due date
- Click "Renew all"
=> TEST: Observe that all non on hold items are renewed using the value in
"Renewal due date" and on hold items are renewed using the value in "On hold
due date"
- From the main staff client from page, choose "Circulation", then choose
"Renew"
- Enter the barcode of an item that you know to be on hold and submit
=> TEST: In the alert box that appears, observe that a date picker is
displayed
- Choose a due date for this item, then click "Override and renew"
=> TEST: In the "Item renewed" box, observe that the item has been
renewed to the date specified

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #63 from Liz Rea  ---
Created attachment 89033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89033=edit
Bug 7088: (follow-up) AllowRenewalLimitOverride fix

This patch causes the click event listener on the #override_limit to be
created if EITHER the AllowRenewalOnHoldOverride OR
AllowRenewalLimitOverride sysprefs are enabled. Previously, it would
only be created if the AllowRenewalLimitOverride syspref was enabled,
which would cause the checkbox to be displayed but do nothing.

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #60 from Liz Rea  ---
Created attachment 89030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89030=edit
Bug 7088: (follow-up) Set syspref default to off

As per item 2 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #59 from Liz Rea  ---
Created attachment 89029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89029=edit
Bug 7088: (follow-up) Remove script "type" attribute

As per item 1 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #62 from Liz Rea  ---
Created attachment 89032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89032=edit
Bug 7088: (follow-up) Add pref to checkbox

As per commit #29 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c29

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #61 from Liz Rea  ---
Created attachment 89031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89031=edit
Bug 7088: (follow-up) Default hold checkbox display

As per item 4 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

Now, the checkbox for renewing on hold items behaves the same way as the
checkbox for renewing items that have reached their renew limit. It is
necessary to check the re-labelled "Override renewal restrictions"
checkbox before it is possible to select on-hold items for renewal.

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Liz Rea  changed:

   What|Removed |Added

  Attachment #85434|0   |1
is obsolete||
  Attachment #85435|0   |1
is obsolete||
  Attachment #85436|0   |1
is obsolete||
  Attachment #85437|0   |1
is obsolete||
  Attachment #85438|0   |1
is obsolete||
  Attachment #85439|0   |1
is obsolete||
  Attachment #85440|0   |1
is obsolete||
  Attachment #88446|0   |1
is obsolete||
  Attachment #88868|0   |1
is obsolete||

--- Comment #56 from Liz Rea  ---
Created attachment 89026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89026=edit
Bug 7088: Add AllowRenewalOnHoldOverride syspref

Enables the renewal of on hold items with specified due dates to be turned
on/off

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

Signed-off-by: Andrew Farthing 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #58 from Liz Rea  ---
Created attachment 89028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89028=edit
Bug 7088: (follow-up) Fix renewal limit bug

There was a bug in that altering the state of the "Override renewal
limit" checkbox was altering the appearance of the per-item "On hold"
checkbox. This is incorrect, the "Override renewal limit" checkbox is
unconnected with this bug.

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

Signed-off-by: Andrew Farthing 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #57 from Liz Rea  ---
Created attachment 89027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89027=edit
Bug 7088: Allow renew on hold items with due date

This patch adds the ability for items that are on hold to be renewed with a due
date specfied by the user. It is enabled by the new
"AllowRenewalOnHoldOverride" syspref. It is manifested in two locations:

1. In the "Checkouts" table on the Patron Details screen. It is now possible to
select on loan items that would otherwise fulfil a hold request to be renewed.
When such an item is selected, an additional date selection box is displayed to
allow the user to specify the due date for all on hold items that are to be
renewed.

2. In the Circulation > Renew alert screen. When a barcode of an on loan item
that would ordinarily fulfil a hold request is entered, the usual alert is
displayed indicating that the item is on hold, it is still possible to override
this, and renew, however it is now also possible to specify a due date.

Test plan:

- Go to the Patron Details page for a patron who has an item on loan that would
fulfil an outstanding loan request.
- TEST: Observe that it is NOT possible to select this item
- Enable the "AllowRenewalOnHoldOverride" syspref
- Return to the Patron Details page for a patron who has an item on loan that
would fulfil an outstanding loan request.
- TEST: Observe that it IS possible to select this item
- Select the item
- TEST: Observe that an additional "On hold due date" input box is displayed
- De-select the item
- TEST: Observe that an additional "On hold due date" input box is hidden
- Select the item
- In the "On hold due date" input box, select a due date for the item
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed as usual
- In the "Renewal due date" input box, select a due date
- Remove the contents of the "On hold due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed by falling back to the "Renewal due
date" value if a value is not specified in the "On hold due date" input box
- Remove the contents of the "Renewal due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the standard loan period is used for the renewal period if
no due date is specified in either box
- In the "On hold due date" input box, select a due date for the item
- In the "Renewal due date" input box, select a different due date
- Click "Renew all"
- TEST: Observe that all non on hold items are renewed using the value in
"Renewal due date" and on hold items are renewed using the value in "On hold
due date"
- From the main staff client from page, choose "Circulation", then choose
"Renew"
- Enter the barcode of an item that you know to be on hold and submit
- TEST: In the alert box that appears, observe that a date picker is
displayed
- Choose a due date for this item, then click "Override and renew"
- TEST: In the "Item renewed" box, observe that the item has been
renewed to the date specified

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

Signed-off-by: Andrew Farthing 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Liz Rea  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #55 from Andrew Isherwood  ---
Hi Katrin - I've re-tested and all seems fine to me. I recorded a video just to
make sure you agree: https://nimb.ws/oMZJ7F

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #54 from Katrin Fischer  ---
(In reply to Andrew Isherwood from comment #53)
> Hi Katrin - It sounds like you didn't rebuild the CSS. Can you check you
> did, the hold date input box was behaving correctly for me after I performed
> the last modifications.

I thought I did, but can#t make sure before tonight. Can you please retest to
make sure?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #53 from Andrew Isherwood  ---
Hi Katrin - It sounds like you didn't rebuild the CSS. Can you check you did,
the hold date input box was behaving correctly for me after I performed the
last modifications.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #52 from Katrin Fischer  ---
I am very very sorry :(

The checkbox behaviour looks better now, but the 'hold date' input is now
always visible and not just appearing when needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #51 from Andrew Isherwood  ---
Created attachment 88868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88868=edit
Bug 7088: (follow-up) Modify checkbox enabling

As described in comment #50, we need to only enable renewal on items
that are disabled in line with which sysprefs are enabled. So we now
only enable renewal of on hold items if the AllowRenewalOnHoldOverride
syspref is on and we only enable renewal of all other limited items
when the AllowRenewalLimitOverride syspref is on.

NOTE: The test plan below has changed substantially from previous
iterations

Test plan (you might want to make a coffee first...):

- Apply patch
- Rebuild CSS

- Go to the Patron Details page for a patron who has an item on loan that would
fulfil an outstanding loan request.
- The patron also needs to have an item on loan that cannot be renewed for some
other reason, say renewal limit has been reached
=> TEST: Observe that it is NOT possible to select either item for renewal

- Enable the "AllowRenewalLimitOverride" syspref
- Return to the Patron Details page
- Check the "Override renewal restrictions" checkbox
=> TEST: Observe that it IS possible to select the the item that has reached
the renewal limit, but not the item that is on hold

- Disable the "AllowRenewalLimitOverride" syspref
- Enable the "AllowRenewalOnHoldOverride" syspref
- Return to the Patron Details page
- Check the "Override renewal restrictions" checkbox
=> TEST: Observe that it is NOT possible to select the the item that has
reached the renewal limit, but it IS possible to select the item on hold

- Enable the "AllowRenewalLimitOverride" syspref
- Enable the "AllowRenewalOnHoldOverride" syspref
- Return to the Patron Details page
- Check the "Override renewal restrictions" checkbox
=> TEST: Observe that it IS possible to select the the item that has reached
the renewal limit, AND it IS possible to select the item on hold

- Select the item that is on hold
=> TEST: Observe that an additional "On hold due date" input box is displayed
- De-select the item
=> TEST: Observe that an additional "On hold due date" input box is hidden
- Select the item
- In the "On hold due date" input box, select a due date for the item
- Click "Renew or check in selected items"
=> TEST: Observe that the item is renewed as usual
- In the "Renewal due date" input box, select a due date
- Remove the contents of the "On hold due date" input box
- Click "Renew or check in selected items"
=> TEST: Observe that the item is renewed by falling back to the "Renewal due
date" value if a value is not specified in the "On hold due date" input box
- Remove the contents of the "Renewal due date" input box
- Click "Renew or check in selected items"
=> TEST: Observe that the standard loan period is used for the renewal period
if no due date is specified in either box
- In the "On hold due date" input box, select a due date for the item
- In the "Renewal due date" input box, select a different due date
- Click "Renew all"
=> TEST: Observe that all non on hold items are renewed using the value in
"Renewal due date" and on hold items are renewed using the value in "On hold
due date"
- From the main staff client from page, choose "Circulation", then choose
"Renew"
- Enter the barcode of an item that you know to be on hold and submit
=> TEST: In the alert box that appears, observe that a date picker is
displayed
- Choose a due date for this item, then click "Override and renew"
=> TEST: In the "Item renewed" box, observe that the item has been
renewed to the date specified

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #50 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #49)
> Hi Andrew,
> 
> I am very sorry, not sure the last patch is quite right. I think what
> happens now is that either will make 'all' checkboxes appear, if the item is
> on hold or not. I think we need to control the checkboxes separately, if
> that makes sense?
> 
> Test case:
> Have at least 2 items checked out, 1 is on hold.
> 
> AllowRenewalOnHoldOverride Allow
> AllowRenewalLimitOverride Don't allow
>  
> - Restriction override checkbox below table appears - OK
> - Checking the box, enables the on hold item for renewal - OK
> - Checking the box also enabled all other items for renewal - not OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #49 from Katrin Fischer  ---
Hi Andrew,

I am very sorry, not sure the last patch is quite right. I think what happens
now is that either will make 'all' checkboxes appear, if the item is on hold or
not. I think we need to control the checkboxes separately, if that makes sense?

Test case:
Have at least 2 items checked out, 1 is on hold.

AllowRenewalOnHoldOverride
AllowRenewalLimitOverride

- Restriction override checkbox below table appears - OK
- Checking the box, enables the on hold item for renewal - OK
- Checking the box also enabled all other items for renewal - not OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #48 from Andrew Isherwood  ---
Hi Katrin

Now I've added that patch, the checkbox will be displayed and be functional if
the user has "circulate_override_renewals" and EITHER
"AllowRenewalLimitOverride" OR "AllowRenewalOnHoldOverride" are enabled.

Consequently, the test plan is now slightly incorrect, revised version below:

- Go to the Patron Details page for a patron who has an item on loan that would
fulfil an outstanding loan request.
- TEST: Observe that it is NOT possible to select this item
- ** Carry out all following steps, first with the "AllowRenewalLimitOverride"
syspref enabled, then with the "AllowRenewalOnHoldOverride" syspref enabled **

- Return to the Patron Details page for a patron who has an item on loan that
would fulfil an outstanding loan request.
- Check the "Override renewal restrictions" checkbox
- TEST: Observe that it IS possible to select this item
- Select the item
- TEST: Observe that an additional "On hold due date" input box is displayed
- De-select the item
- TEST: Observe that an additional "On hold due date" input box is hidden
- Select the item
- In the "On hold due date" input box, select a due date for the item
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed as usual
- In the "Renewal due date" input box, select a due date
- Remove the contents of the "On hold due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed by falling back to the "Renewal due
date" value if a value is not specified in the "On hold due date" input box
- Remove the contents of the "Renewal due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the standard loan period is used for the renewal period if
no due date is specified in either box
- In the "On hold due date" input box, select a due date for the item
- In the "Renewal due date" input box, select a different due date
- Click "Renew all"
- TEST: Observe that all non on hold items are renewed using the value in
"Renewal due date" and on hold items are renewed using the value in "On hold
due date"
- From the main staff client from page, choose "Circulation", then choose
"Renew"
- Enter the barcode of an item that you know to be on hold and submit
- TEST: In the alert box that appears, observe that a date picker is
displayed
- Choose a due date for this item, then click "Override and renew"
- TEST: In the "Item renewed" box, observe that the item has been
renewed to the date specified

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #47 from Andrew Isherwood  ---
Created attachment 88446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88446=edit
Bug 7088: (follow-up) AllowRenewalLimitOverride fix

This patch causes the click event listener on the #override_limit to be
created if EITHER the AllowRenewalOnHoldOverride OR
AllowRenewalLimitOverride sysprefs are enabled. Previously, it would
only be created if the AllowRenewalLimitOverride syspref was enabled,
which would cause the checkbox to be displayed but do nothing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #46 from Andrew Isherwood  ---
Sorry, my comment above is incorrect. The click event listener is currently
only created if the AllowRenewalLimitOverride syspref is turned on, I think it
needs adapting so it is created if the AllowRenewalLimitOverride OR
AllowRenewalOnHoldOverride sysprefs are turned on. The checkbox will then be
displayed if the user has circulate_override_renewals AND either of those
sysprefs are enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #45 from Andrew Isherwood  ---
(In reply to Katrin Fischer from comment #44)
> Hm, maybe the checkbox should now shop up in this case then? Right now the
> checkbox just appears to have no effect - and if I understand you correctly
> that's the expected behaviour as both need to be allowed to work?

Actually, looking again, I think this is a misunderstanding on my part. The
"Override renewal restrictions" checkbox is displayed if the user has
AllowRenewalLimitOverride OR AllowRenewalOnHoldOverride. But the click listener
is only created if the user has AllowRenewalLimitOverride, which I think is
incorrect. I think it needs adapting so it is created if the user has
AllowRenewalLimitOverride OR AllowRenewalOnHoldOverride.

I'll create a patch to do that now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #44 from Katrin Fischer  ---
(In reply to Andrew Isherwood from comment #43)
> (In reply to Katrin Fischer from comment #42)
> > Hi Andrew,
> > 
> > sorry, we are almost there. Most things worked really well (like checkbox
> > visibility), but found one case that didn't work as expected:
> > 
> > HoldOverride = Allow
> > LimitOverride = Not allowed
> > 
> > Item is on hold, 2 of 2 renewals remaining.
> > Staff user has override permission.
> > 
> > But: Checking the checkbox doesn't make the item renewable.
> 
> Hi Katrin,
> 
> The test plan specifies that LimitOverride needs to be enabled for the
> functionality to work. If it's disabled the click listener on the override
> checkbox isn't created, which explains why it doesn't do anything. This
> isn't something that has been modified in my patches, it's pre-existing Koha
> functionality. Are you expecting something different?

Hm, maybe the checkbox should now shop up in this case then? Right now the
checkbox just appears to have no effect - and if I understand you correctly
that's the expected behaviour as both need to be allowed to work?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #43 from Andrew Isherwood  ---
(In reply to Katrin Fischer from comment #42)
> Hi Andrew,
> 
> sorry, we are almost there. Most things worked really well (like checkbox
> visibility), but found one case that didn't work as expected:
> 
> HoldOverride = Allow
> LimitOverride = Not allowed
> 
> Item is on hold, 2 of 2 renewals remaining.
> Staff user has override permission.
> 
> But: Checking the checkbox doesn't make the item renewable.

Hi Katrin,

The test plan specifies that LimitOverride needs to be enabled for the
functionality to work. If it's disabled the click listener on the override
checkbox isn't created, which explains why it doesn't do anything. This isn't
something that has been modified in my patches, it's pre-existing Koha
functionality. Are you expecting something different?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #42 from Katrin Fischer  ---
Hi Andrew,

sorry, we are almost there. Most things worked really well (like checkbox
visibility), but found one case that didn't work as expected:

HoldOverride = Allow
LimitOverride = Not allowed

Item is on hold, 2 of 2 renewals remaining.
Staff user has override permission.

But: Checking the checkbox doesn't make the item renewable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-04-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-03-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-03-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #41 from Owen Leonard  ---
(In reply to Owen Leonard from comment #40)
> I do have one issue: The new date picker should be hidden initially,
> correct? For me it isn't.

Sorry, my mistake -- I didn't rebuild CSS. I think this can be put back to
"Signed off" unless someone wants to suggest a label change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-03-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #40 from Owen Leonard  ---
What about changing the label to "Due date for on hold items" ?

I think having the second date picker is something which looks to me like
clutter but I assume that those who want to use the feature will appreciate it.

I do have one issue: The new date picker should be hidden initially, correct?
For me it isn't.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Liz Rea  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #39 from Liz Rea  ---
I personally don't like the 2nd date picker and think it's confusing, at least
how it is labelled. There is something that I find ambiguous about "On hold due
date" but I'm having a hard time putting what it is into words.

Maybe a hover text on the label that explains more what the box is for?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-02-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #83094|0   |1
is obsolete||

--- Comment #34 from Andrew Isherwood  ---
Created attachment 85436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85436=edit
Bug 7088: (follow-up) Fix renewal limit bug

There was a bug in that altering the state of the "Override renewal
limit" checkbox was altering the appearance of the per-item "On hold"
checkbox. This is incorrect, the "Override renewal limit" checkbox is
unconnected with this bug.

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

Signed-off-by: Andrew Farthing 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #83093|0   |1
is obsolete||

--- Comment #33 from Andrew Isherwood  ---
Created attachment 85435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85435=edit
Bug 7088: Allow renew on hold items with due date

This patch adds the ability for items that are on hold to be renewed with a due
date specfied by the user. It is enabled by the new
"AllowRenewalOnHoldOverride" syspref. It is manifested in two locations:

1. In the "Checkouts" table on the Patron Details screen. It is now possible to
select on loan items that would otherwise fulfil a hold request to be renewed.
When such an item is selected, an additional date selection box is displayed to
allow the user to specify the due date for all on hold items that are to be
renewed.

2. In the Circulation > Renew alert screen. When a barcode of an on loan item
that would ordinarily fulfil a hold request is entered, the usual alert is
displayed indicating that the item is on hold, it is still possible to override
this, and renew, however it is now also possible to specify a due date.

Test plan:

- Go to the Patron Details page for a patron who has an item on loan that would
fulfil an outstanding loan request.
- TEST: Observe that it is NOT possible to select this item
- Enable the "AllowRenewalOnHoldOverride" syspref
- Return to the Patron Details page for a patron who has an item on loan that
would fulfil an outstanding loan request.
- TEST: Observe that it IS possible to select this item
- Select the item
- TEST: Observe that an additional "On hold due date" input box is displayed
- De-select the item
- TEST: Observe that an additional "On hold due date" input box is hidden
- Select the item
- In the "On hold due date" input box, select a due date for the item
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed as usual
- In the "Renewal due date" input box, select a due date
- Remove the contents of the "On hold due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed by falling back to the "Renewal due
date" value if a value is not specified in the "On hold due date" input box
- Remove the contents of the "Renewal due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the standard loan period is used for the renewal period if
no due date is specified in either box
- In the "On hold due date" input box, select a due date for the item
- In the "Renewal due date" input box, select a different due date
- Click "Renew all"
- TEST: Observe that all non on hold items are renewed using the value in
"Renewal due date" and on hold items are renewed using the value in "On hold
due date"
- From the main staff client from page, choose "Circulation", then choose
"Renew"
- Enter the barcode of an item that you know to be on hold and submit
- TEST: In the alert box that appears, observe that a date picker is
displayed
- Choose a due date for this item, then click "Override and renew"
- TEST: In the "Item renewed" box, observe that the item has been
renewed to the date specified

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

Signed-off-by: Andrew Farthing 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #38 from Andrew Isherwood  ---
Created attachment 85440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85440=edit
Bug 7088: (follow-up) Add pref to checkbox

As per commit #29 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c29

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #84510|0   |1
is obsolete||

--- Comment #36 from Andrew Isherwood  ---
Created attachment 85438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85438=edit
Bug 7088: (follow-up) Set syspref default to off

As per item 2 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #83092|0   |1
is obsolete||

--- Comment #32 from Andrew Isherwood  ---
Created attachment 85434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85434=edit
Bug 7088: Add AllowRenewalOnHoldOverride syspref

Enables the renewal of on hold items with specified due dates to be turned
on/off

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

Signed-off-by: Andrew Farthing 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #84509|0   |1
is obsolete||

--- Comment #35 from Andrew Isherwood  ---
Created attachment 85437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85437=edit
Bug 7088: (follow-up) Remove script "type" attribute

As per item 1 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #84850|0   |1
is obsolete||

--- Comment #37 from Andrew Isherwood  ---
Created attachment 85439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85439=edit
Bug 7088: (follow-up) Default hold checkbox display

As per item 4 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

Now, the checkbox for renewing on hold items behaves the same way as the
checkbox for renewing items that have reached their renew limit. It is
necessary to check the re-labelled "Override renewal restrictions"
checkbox before it is possible to select on-hold items for renewal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-02-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #31 from Liz Rea  ---
Just a note for testers, if you are testing as I was, with an item that has
multiple items that are not all checked out, you will need 
AllowRenewalIfOtherItemsAvailable turned on to see the checkbox.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-02-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #30 from Andrew Isherwood  ---
Thanks for the feedback regarding the pref Katrin, good spot, I'd completely
missed that, I'll create a patch to sort it out shortly.

As far as the second date selector for on hold due dates is concerned, it may
be useful to know that this development was specced and has been accepted by
three of our customers, all of whom comprise librarians, they are all happy
with a second date selector that only appears when an on hold item is selected
for renewal. I'll try and get them to comment on this bug if that would be
helpful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||oleon...@myacpl.org,
   ||wizzy...@gmail.com

--- Comment #29 from Katrin Fischer  ---
Hi Andrew,

I think we need to work on the visibility of the checkbox and maybe the logic
of triggering things with it now (sorry, I think that makes things a bit more
complicated:

 
 [% IF ( CAN_user_circulate_override_renewals ) %]
 [% IF CAN_user_circulate_override_renewals &&
Koha.Preference( 'AllowRenewalLimitOverride' ) %]
-Override renewal
limit:
+Override renewal
restrictions:

You will want to add your new pref there with an OR condition there I think
Another option might be to have && and a separate label if only hold override
is allowed?

I am still not sure about the second date box - I'd like to get some opinions
on it. Adding Owen and Liz for now, but looking for any librarians opinion
really.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #28 from Andrew Isherwood  ---
(In reply to Katrin Fischer from comment #24)

> 4) I'd also have expected the renewal to be locked initially and the
> checkbox to unlock it. Reasoning: Renewing an item with a hold should always
> be an exception. The way it's now a "renew all" checked on top will also
> check the "on hold" ones which might be easily missed. We could relabel the
> checkbox and use it for both: Allow override of renewal restrictions?

Hi Katrin

I've just attached a patch that addresses this. The on hold items now behave in
the same way as items that have reached their renewal limit, they are not
selectable until the checkbox is checked. Speaking of which, I've re-labelled
the checkbox from "Override renewal limit" to "Override renewal restrictions"
as per you suggestion. So now, "Select all" and "Renew all" will not act upon
the on hold items unless the override is checked.

I'm not familiar with the process when a UI label is changed, is there any
maintenance work that needs to happen so translations don't break?

>3) I don't understand the new entry form for the hold due date. My feeling is 
>that we should use the one existing already for entering the new due date for 
>any override. Having 2 forms seems confusing.

We discussed this internally at great length when speccing out the development.
It was felt by both our customers and us that having two date selection boxes
made most sense since it's conceivable that the user may wish to have different
due dates for on hold items and non-on hold items. The fact that the "On hold
due date" date input doesn't appear until an on hold item is checked for
renewal (if you're not seeing this behaviour, rebuild your CSS) reinforces it's
purpose.

I'm going to set this back to Signed off as I believe it's ready for another QA
run :) Thanks for your feedback!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #27 from Andrew Isherwood  ---
Created attachment 84850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84850=edit
Bug 7088: (follow-up) Default hold checkbox display

As per item 4 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

Now, the checkbox for renewing on hold items behaves the same way as the
checkbox for renewing items that have reached their renew limit. It is
necessary to check the re-labelled "Override renewal restrictions"
checkbox before it is possible to select on-hold items for renewal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-01-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #26 from Andrew Isherwood  ---
Created attachment 84510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84510=edit
Bug 7088: (follow-up) Set syspref default to off

As per item 2 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-01-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #25 from Andrew Isherwood  ---
Created attachment 84509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84509=edit
Bug 7088: (follow-up) Remove script "type" attribute

As per item 1 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #24 from Katrin Fischer  ---
Hi Andrew,

some first QA notes here:

1) The QA script fails, easy to fix:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt
   OK filters
   FAIL   forbidden patterns
forbidden pattern: Attribute type should not be used for script
tags (bug 20053) (line 206)

2) We don't want to change the current behaviour for updating installations, so
the feature should be set to of in the database update. I think since all the
other override features also default to "no", I'd also make it no for new
installations.

3) I don't understand the new entry form for the hold due date. My feeling is
that we should use the one existing already for entering the new due date for
any override. Having 2 forms seems confusing.

4) I'd also have expected the renewal to be locked initially and the checkbox
to unlock it. Reasoning: Renewing an item with a hold should always be an
exception. The way it's now a "renew all" checked on top will also check the
"on hold" ones which might be easily missed. We could relabel the checkbox and
use it for both: Allow override of renewal restrictions?

Last 2 are up for discussion of course. Feel free to seek an additional
opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|tomasco...@gmail.com|katrin.fisc...@bsz-bw.de
Summary|cannot renew items on hold  |Cannot renew items on hold
   |even with override  |even with override
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2019-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 QA Contact|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2018-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #23 from Andrew Isherwood  ---
Test plan:

- Apply bug
- Rebuild CSS
- Go to the Patron Details page for a patron who has an item on loan that would
fulfil an outstanding loan request.
- TEST: Observe that it is NOT possible to select this item
- Enable the "AllowRenewalOnHoldOverride" syspref
- Return to the Patron Details page for a patron who has an item on loan that
would fulfil an outstanding loan request.
- TEST: Observe that it IS possible to select this item
- Select the item
- TEST: Observe that an additional "On hold due date" input box is displayed
- De-select the item
- TEST: Observe that an additional "On hold due date" input box is hidden
- Select the item
- In the "On hold due date" input box, select a due date for the item
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed as usual
- In the "Renewal due date" input box, select a due date
- Remove the contents of the "On hold due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed by falling back to the "Renewal due
date" value if a value is not specified in the "On hold due date" input box
- Remove the contents of the "Renewal due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the standard loan period is used for the renewal period if
no due date is specified in either box
- In the "On hold due date" input box, select a due date for the item
- In the "Renewal due date" input box, select a different due date
- Click "Renew all"
- TEST: Observe that all non on hold items are renewed using the value in
"Renewal due date" and on hold items are renewed using the value in "On hold
due date"
- From the main staff client from page, choose "Circulation", then choose
"Renew"
- Enter the barcode of an item that you know to be on hold and submit
- TEST: In the alert box that appears, observe that a date picker is
displayed
- Choose a due date for this item, then click "Override and renew"
- TEST: In the "Item renewed" box, observe that the item has been
renewed to the date specified

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2018-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

PTFS Europe Sandboxes  changed:

   What|Removed |Added

  Attachment #83005|0   |1
is obsolete||

--- Comment #21 from PTFS Europe Sandboxes  ---
Created attachment 83093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83093=edit
Bug 7088: Allow renew on hold items with due date

This patch adds the ability for items that are on hold to be renewed with a due
date specfied by the user. It is enabled by the new
"AllowRenewalOnHoldOverride" syspref. It is manifested in two locations:

1. In the "Checkouts" table on the Patron Details screen. It is now possible to
select on loan items that would otherwise fulfil a hold request to be renewed.
When such an item is selected, an additional date selection box is displayed to
allow the user to specify the due date for all on hold items that are to be
renewed.

2. In the Circulation > Renew alert screen. When a barcode of an on loan item
that would ordinarily fulfil a hold request is entered, the usual alert is
displayed indicating that the item is on hold, it is still possible to override
this, and renew, however it is now also possible to specify a due date.

Test plan:

- Go to the Patron Details page for a patron who has an item on loan that would
fulfil an outstanding loan request.
- TEST: Observe that it is NOT possible to select this item
- Enable the "AllowRenewalOnHoldOverride" syspref
- Return to the Patron Details page for a patron who has an item on loan that
would fulfil an outstanding loan request.
- TEST: Observe that it IS possible to select this item
- Select the item
- TEST: Observe that an additional "On hold due date" input box is displayed
- De-select the item
- TEST: Observe that an additional "On hold due date" input box is hidden
- Select the item
- In the "On hold due date" input box, select a due date for the item
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed as usual
- In the "Renewal due date" input box, select a due date
- Remove the contents of the "On hold due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed by falling back to the "Renewal due
date" value if a value is not specified in the "On hold due date" input box
- Remove the contents of the "Renewal due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the standard loan period is used for the renewal period if
no due date is specified in either box
- In the "On hold due date" input box, select a due date for the item
- In the "Renewal due date" input box, select a different due date
- Click "Renew all"
- TEST: Observe that all non on hold items are renewed using the value in
"Renewal due date" and on hold items are renewed using the value in "On hold
due date"
- From the main staff client from page, choose "Circulation", then choose
"Renew"
- Enter the barcode of an item that you know to be on hold and submit
- TEST: In the alert box that appears, observe that a date picker is
displayed
- Choose a due date for this item, then click "Override and renew"
- TEST: In the "Item renewed" box, observe that the item has been
renewed to the date specified

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

Signed-off-by: Andrew Farthing 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2018-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

PTFS Europe Sandboxes  changed:

   What|Removed |Added

  Attachment #83004|0   |1
is obsolete||

--- Comment #20 from PTFS Europe Sandboxes  ---
Created attachment 83092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83092=edit
Bug 7088: Add AllowRenewalOnHoldOverride syspref

Enables the renewal of on hold items with specified due dates to be turned
on/off

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

Signed-off-by: Andrew Farthing 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2018-12-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

PTFS Europe Sandboxes  changed:

   What|Removed |Added

  Attachment #83006|0   |1
is obsolete||

--- Comment #22 from PTFS Europe Sandboxes  ---
Created attachment 83094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83094=edit
Bug 7088: (follow-up) Fix renewal limit bug

There was a bug in that altering the state of the "Override renewal
limit" checkbox was altering the appearance of the per-item "On hold"
checkbox. This is incorrect, the "Override renewal limit" checkbox is
unconnected with this bug.

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

Signed-off-by: Andrew Farthing 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2018-12-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #79691|0   |1
is obsolete||

--- Comment #19 from Andrew Isherwood  ---
Comment on attachment 79691
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79691
Bug 7088: DO NOT PUSH - Compiled CSS

Obsoleting this, I can't see any way in which it's helpful.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2018-12-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #82274|0   |1
is obsolete||

--- Comment #18 from Andrew Isherwood  ---
Created attachment 83006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83006=edit
Bug 7088: (follow-up) Fix renewal limit bug

There was a bug in that altering the state of the "Override renewal
limit" checkbox was altering the appearance of the per-item "On hold"
checkbox. This is incorrect, the "Override renewal limit" checkbox is
unconnected with this bug.

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2018-12-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #79690|0   |1
is obsolete||

--- Comment #17 from Andrew Isherwood  ---
Created attachment 83005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83005=edit
Bug 7088: Allow renew on hold items with due date

This patch adds the ability for items that are on hold to be renewed with a due
date specfied by the user. It is enabled by the new
"AllowRenewalOnHoldOverride" syspref. It is manifested in two locations:

1. In the "Checkouts" table on the Patron Details screen. It is now possible to
select on loan items that would otherwise fulfil a hold request to be renewed.
When such an item is selected, an additional date selection box is displayed to
allow the user to specify the due date for all on hold items that are to be
renewed.

2. In the Circulation > Renew alert screen. When a barcode of an on loan item
that would ordinarily fulfil a hold request is entered, the usual alert is
displayed indicating that the item is on hold, it is still possible to override
this, and renew, however it is now also possible to specify a due date.

Test plan:

- Go to the Patron Details page for a patron who has an item on loan that would
fulfil an outstanding loan request.
- TEST: Observe that it is NOT possible to select this item
- Enable the "AllowRenewalOnHoldOverride" syspref
- Return to the Patron Details page for a patron who has an item on loan that
would fulfil an outstanding loan request.
- TEST: Observe that it IS possible to select this item
- Select the item
- TEST: Observe that an additional "On hold due date" input box is displayed
- De-select the item
- TEST: Observe that an additional "On hold due date" input box is hidden
- Select the item
- In the "On hold due date" input box, select a due date for the item
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed as usual
- In the "Renewal due date" input box, select a due date
- Remove the contents of the "On hold due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed by falling back to the "Renewal due
date" value if a value is not specified in the "On hold due date" input box
- Remove the contents of the "Renewal due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the standard loan period is used for the renewal period if
no due date is specified in either box
- In the "On hold due date" input box, select a due date for the item
- In the "Renewal due date" input box, select a different due date
- Click "Renew all"
- TEST: Observe that all non on hold items are renewed using the value in
"Renewal due date" and on hold items are renewed using the value in "On hold
due date"
- From the main staff client from page, choose "Circulation", then choose
"Renew"
- Enter the barcode of an item that you know to be on hold and submit
- TEST: In the alert box that appears, observe that a date picker is
displayed
- Choose a due date for this item, then click "Override and renew"
- TEST: In the "Item renewed" box, observe that the item has been
renewed to the date specified

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2018-12-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #79689|0   |1
is obsolete||

--- Comment #16 from Andrew Isherwood  ---
Created attachment 83004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83004=edit
Bug 7088: Add AllowRenewalOnHoldOverride syspref

Enables the renewal of on hold items with specified due dates to be turned
on/off

Sponsored-by: Cheshire Libraries Shared Services
Sponsored-by: Halton Borough Council
Sponsored-by: Sefton Council

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2018-11-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #15 from Andrew Isherwood  ---
Created attachment 82274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82274=edit
Bug 7088: (follow-up) Fix renewal limit bug

There was a bug in that altering the state of the "Override renewal
limit" checkbox was altering the appearance of the per-item "On hold"
checkbox. This is incorrect, the "Override renewal limit" checkbox is
unconnected with this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2018-10-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #14 from Andrew Isherwood  ---
Test plan:

- Go to the Patron Details page for a patron who has an item on loan that would
fulfil an outstanding loan request.
- TEST: Observe that it is NOT possible to select this item
- Enable the "AllowRenewalLimitOverride" syspref
- Enable the "AllowRenewalOnHoldOverride" syspref
- Return to the Patron Details page for a patron who has an item on loan that
would fulfil an outstanding loan request.
- TEST: Observe that it IS possible to select this item
- Select the item
- TEST: Observe that an additional "On hold due date" input box is displayed
- De-select the item
- TEST: Observe that an additional "On hold due date" input box is hidden
- Select the item
- In the "On hold due date" input box, select a due date for the item
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed as usual
- In the "Renewal due date" input box, select a due date
- Remove the contents of the "On hold due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed by falling back to the "Renewal due
date" value if a value is not specified in the "On hold due date" input box
- Remove the contents of the "Renewal due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the standard loan period is used for the renewal period if
no due date is specified in either box
- In the "On hold due date" input box, select a due date for the item
- In the "Renewal due date" input box, select a different due date
- Click "Renew all"
- TEST: Observe that all non on hold items are renewed using the value in
"Renewal due date" and on hold items are renewed using the value in "On hold
due date"
- From the main staff client from page, choose "Circulation", then choose
"Renew"
- Enter the barcode of an item that you know to be on hold and submit
- TEST: In the alert box that appears, observe that a date picker is
displayed
- Choose a due date for this item, then click "Override and renew"
- TEST: In the "Item renewed" box, observe that the item has been
renewed to the date specified

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2018-10-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #79691|Bug 7088: Compiled CSS  |Bug 7088: DO NOT PUSH -
description||Compiled CSS

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2018-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Fiona Borthwick  changed:

   What|Removed |Added

 CC||fiona.borthwick@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2018-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood  changed:

   What|Removed |Added

 CC||andrew.isherwood@ptfs-europ
   ||e.com
   Assignee|kyle.m.h...@gmail.com   |andrew.isherwood@ptfs-europ
   ||e.com
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2018-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #11 from Andrew Isherwood  ---
Created attachment 79689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79689=edit
Bug 7088: Add AllowRenewalOnHoldOverride syspref

Enables the renewal of on hold items with specified due dates to be turned
on/off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2018-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #12 from Andrew Isherwood  ---
Created attachment 79690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79690=edit
Bug 7088: Allow renew on hold items with due date

This patch adds the ability for items that are on hold to be renewed with a due
date specfied by the user. It is enabled by the new
"AllowRenewalOnHoldOverride" syspref. It is manifested in two locations:

1. In the "Checkouts" table on the Patron Details screen. It is now possible to
select on loan items that would otherwise fulfil a hold request to be renewed.
When such an item is selected, an additional date selection box is displayed to
allow the user to specify the due date for all on hold items that are to be
renewed.

2. In the Circulation > Renew alert screen. When a barcode of an on loan item
that would ordinarily fulfil a hold request is entered, the usual alert is
displayed indicating that the item is on hold, it is still possible to override
this, and renew, however it is now also possible to specify a due date.

Test plan:

- Go to the Patron Details page for a patron who has an item on loan that would
fulfil an outstanding loan request.
- TEST: Observe that it is NOT possible to select this item
- Enable the "AllowRenewalOnHoldOverride" syspref
- Return to the Patron Details page for a patron who has an item on loan that
would fulfil an outstanding loan request.
- TEST: Observe that it IS possible to select this item
- Select the item
- TEST: Observe that an additional "On hold due date" input box is displayed
- De-select the item
- TEST: Observe that an additional "On hold due date" input box is hidden
- Select the item
- In the "On hold due date" input box, select a due date for the item
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed as usual
- In the "Renewal due date" input box, select a due date
- Remove the contents of the "On hold due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the item is renewed by falling back to the "Renewal due
date" value if a value is not specified in the "On hold due date" input box
- Remove the contents of the "Renewal due date" input box
- Click "Renew or check in selected items"
- TEST: Observe that the standard loan period is used for the renewal period if
no due date is specified in either box
- In the "On hold due date" input box, select a due date for the item
- In the "Renewal due date" input box, select a different due date
- Click "Renew all"
- TEST: Observe that all non on hold items are renewed using the value in
"Renewal due date" and on hold items are renewed using the value in "On hold
due date"
- From the main staff client from page, choose "Circulation", then choose
"Renew"
- Enter the barcode of an item that you know to be on hold and submit
- TEST: In the alert box that appears, observe that a date picker is
displayed
- Choose a due date for this item, then click "Override and renew"
- TEST: In the "Item renewed" box, observe that the item has been
renewed to the date specified

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2018-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

--- Comment #13 from Andrew Isherwood  ---
Created attachment 79691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79691=edit
Bug 7088: Compiled CSS

This is never going to merge, but I'm including it as I'm not sure
whether we should or not.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2016-08-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

--- Comment #10 from Sally Healey  
---
This would be a nice feature to add to Koha.

As it's an enhancement, I think it's worth asking:  could we also consider a
system preference to have a different circ period if the item is required by
another patron?

For instance, standard circ period is 21 days.  
Item is on hold - renewal only gives a new circ period of 7 days.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2014-05-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2013-02-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|REOPENED|NEW

--- Comment #9 from Nicole C. Engard neng...@gmail.com ---
I got asked about this again today, this is still a desired enhancement.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2012-10-17 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r

--- Comment #8 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Hi
We discovered this problem some days ago, but I have just find this bug in BZ.
As a librarian I completely agree with Nicole Engard : an override should be an
override...

M. Saby
Rennes 2 University

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2012-10-16 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
Version|rel_3_6 |master
 Resolution|INVALID |---
   Severity|major   |enhancement

--- Comment #7 from Nicole C. Engard neng...@gmail.com ---
Reopening as an enhancement. Most people seem to think that an override should
be an override and that means even items on hold.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 105 matches

Mail list logo