[Koha-bugs] [Bug 7324] Show alternate email as mailto link on patron summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 Chris Cormack changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7324] Show alternate email as mailto link on patron summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 Katrin Fischer changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7324] Show alternate email as mailto link on patron summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 --- Comment #7 from Paul Poulain 2011-12-16 10:48:50 UTC --- I think for core informations, it must be displayed even if it's empty (address, phone, email), but for other informations (alternate), it can be hidden. The patch about displaying values in forms or not is related to data entry only if i'm not mistaking. So those patches are related... by completing what the other do. Plus you may want to have alternate address entered when you need it, but, when it's not entered, you may want not to display entries. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7324] Show alternate email as mailto link on patron summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 --- Comment #6 from Katrin Fischer 2011-12-16 09:41:12 UTC --- I was thinking about it but was not sure everyone would like this change. Perhaps we can get some opinions? There is a patch waiting to be pushed that will make it possible to configure which fields are shown for patron entry. Changing the summary page to only show fields that are not empty would go well with this change. (bug 6190) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7324] Show alternate email as mailto link on patron summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 Paul Poulain changed: What|Removed |Added Version|master |rel_3_6 Patch Status|Signed Off |Patch Pushed --- Comment #5 from Paul Poulain 2011-12-16 09:36:15 UTC --- QA comment: this time everything is OK prove xt/author/translatable-templates.t xt/author/translatable-templates.t .. ok prove xt/author/valid-templates.t xt/author/valid-templates.t .. ok passed QA Note: that would be cool to hide all empty fields, like the ones in alternate addess and alternative contact. But this is a 1st step. patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7324] Show alternate email as mailto link on patron summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 Katrin Fischer changed: What|Removed |Added Patch Status|Failed QA |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7324] Show alternate email as mailto link on patron summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 Katrin Fischer changed: What|Removed |Added Attachment #6608|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer 2011-12-16 05:52:05 UTC --- Created attachment 6825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6825 Bug 7324: Show alternate email as mailto: / hide labels when field is empty UPDATE 2011-12-15 Fixed wrong div that broke the patron account display. Thank you Paul for catching this! Changes made to the patron detail tab: - alternate email shows as mailto: link - labels for following fields only show when field is filled - initials - date of birth - gender - country (alternate address) - email (alternate address) - state (alternative contact) - country (alternative contact) - phone (alternative contact) To test: 1) Add new patron with minimal data and check the labels don't show 2) Change patron to have data in changed fields and check labels show 3) Check all email addresses are shown as mailto: links now Signed-off-by: Liz Rea Verified tests 1-3, looks good to me. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7324] Show alternate email as mailto link on patron summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 Paul Poulain changed: What|Removed |Added Status|NEW |ASSIGNED CC||paul.poul...@biblibre.com Patch Status|Signed Off |Failed QA --- Comment #3 from Paul Poulain 2011-12-15 16:08:15 UTC --- QA comment: After applying the patch, the language tool bar start floating... investigating in the code I think there is a div closed by mistake: +[% IF ( altcontactcountry ) %]Country: [% altcontactcountry %][% END %] +[% IF ( altcontactphone ) %]Phone: [% altcontactphone %][% END %] marking failed QA. back to signed-off when you've submitted a new patch, it's a tiny one -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7324] Show alternate email as mailto link on patron summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7324] Show alternate email as mailto link on patron summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 Liz Rea changed: What|Removed |Added Attachment #6607|0 |1 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7324] Show alternate email as mailto link on patron summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 --- Comment #2 from Liz Rea 2011-12-06 17:58:47 UTC --- Created attachment 6608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6608 Bug 7324: Show alternate email as mailto: / hide labels when field is empty Changes made to the patron detail tab: - alternate email shows as mailto: link - labels for following fields only show when field is filled - initials - date of birth - gender - country (alternate address) - email (alternate address) - state (alternative contact) - country (alternative contact) - phone (alternative contact) To test: 1) Add new patron with minimal data and check the labels don't show 2) Change patron to have data in changed fields and check labels show 3) Check all email addresses are shown as mailto: links now Signed-off-by: Liz Rea Verified tests 1-3, looks good to me. Signed-off-by: Liz Rea -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7324] Show alternate email as mailto link on patron summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 Katrin Fischer changed: What|Removed |Added Priority|P5 - low|PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7324] Show alternate email as mailto link on patron summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7324 --- Comment #1 from Katrin Fischer 2011-12-06 17:54:38 UTC --- Created attachment 6607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6607 Bug 7324: Show alternate email as mailto: / hide labels when field is empty Changes made to the patron detail tab: - alternate email shows as mailto: link - labels for following fields only show when field is filled - initials - date of birth - gender - country (alternate address) - email (alternate address) - state (alternative contact) - country (alternative contact) - phone (alternative contact) To test: 1) Add new patron with minimal data and check the labels don't show 2) Change patron to have data in changed fields and check labels show 3) Check all email addresses are shown as mailto: links now -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
