[Koha-bugs] [Bug 7364] Fast-Add framework doesn't always get the branch for item creation

2012-10-14 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7364

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7364] Fast-Add framework doesn't always get the branch for item creation

2012-01-18 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7364

Katrin Fischer  changed:

   What|Removed |Added

   Priority|PATCH-Sent (DO NOT USE) |P3
 Status|Pushed to Master|Pushed to Stable
 CC||katrin.fisc...@bsz-bw.de

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7364] Fast-Add framework doesn't always get the branch for item creation

2012-01-17 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7364

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7364] Fast-Add framework doesn't always get the branch for item creation

2012-01-17 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7364

Paul Poulain  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7364] Fast-Add framework doesn't always get the branch for item creation

2012-01-16 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7364

Ian Walls  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7364] Fast-Add framework doesn't always get the branch for item creation

2012-01-16 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7364

Ian Walls  changed:

   What|Removed |Added

   Attachment #6847|0   |1
is obsolete||
 Status|ASSIGNED|Needs Signoff
 AssignedTo|r...@bywatersolutions.com   |ian.walls@bywatersolutions.
   ||com

--- Comment #8 from Ian Walls  2012-01-16 
18:07:36 UTC ---
Created attachment 7176
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7176
Syntax-corrected patch

Fixed use of {} in patch; should be ().  cataloging/additem.pl loads without
incident or error now

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7364] Fast-Add framework doesn't always get the branch for item creation

2012-01-16 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7364

Paul Poulain  changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED

--- Comment #7 from Paul Poulain  2012-01-16 
17:57:26 UTC ---
YIKES:

after applying this page, on my test server, I get a nasty:

syntax error at /home/paul/koha.dev/koha-community/cataloguing/additem.pl line
668, near "->param{"
Execution of /home/paul/koha.dev/koha-community/cataloguing/additem.pl aborted
due to compilation errors.

Reverting this patch solves the issue.

I'm logged in as a superlibrarian, (but not the mysql user), nothing more
specific that could explain the problem.

i'm reverting master until we understand where this comes from !

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7364] Fast-Add framework doesn't always get the branch for item creation

2012-01-16 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7364

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_6

--- Comment #6 from Paul Poulain  2012-01-16 
14:29:38 UTC ---
(In reply to comment #5)
> Is it really necessary to do a second QA on a 5 line patch that is clearly
> coded, and provides a more solid failover?
it was not really a QA. It's just that I test all the patches before pushing
them, and I couldn't understand how to test this one.

Thanks for the 
> 1. Set your library to one that's NOT the first alphabetically in the branch
list

that was what was missing !

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7364] Fast-Add framework doesn't always get the branch for item creation

2012-01-13 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7364

Ian Walls  changed:

   What|Removed |Added

Version|rel_3_4 |master
   Patch Status|Failed QA   |Passed QA

--- Comment #5 from Ian Walls  2012-01-13 
18:04:50 UTC ---
Paul,


Is it really necessary to do a second QA on a 5 line patch that is clearly
coded, and provides a more solid failover?  The code is currently assuming that
if the biblio's framework is FA, then a 'branch' param is passed in the URL. 
This isn't the case if you come from somewhere other than the Fast Add during
Checkout.


Test plan:

1. Set your library to one that's NOT the first alphabetically in the branch
list
2. From Circulation home page, click "Fast Cataloging"
3. Create a fast biblio, and save.
4. Now, on the items screen, you won't see your logged in branch, but rather
the first in the list.

Apply patch, and step 4 now shows the currently logged in branch as the
default.


Resetting to Passed QA.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7364] Fast-Add framework doesn't always get the branch for item creation

2012-01-13 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7364

Paul Poulain  changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
   Patch Status|Passed QA   |Failed QA

--- Comment #4 from Paul Poulain  2012-01-13 
10:34:59 UTC ---
I think I understand what this patch does, but there is no clear test case that
I can use to test myself, so please provide one (and switch back to passed QA)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7364] Fast-Add framework doesn't always get the branch for item creation

2012-01-09 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7364

Ian Walls  changed:

   What|Removed |Added

   Patch Status|Signed Off  |Passed QA

--- Comment #3 from Ian Walls  2012-01-09 
20:33:40 UTC ---
Much cleaner way of assigning the branchcode that works in all cases.  Marking
as Passed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7364] Fast-Add framework doesn't always get the branch for item creation

2011-12-17 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7364

Chris Cormack  changed:

   What|Removed |Added

   Priority|P5 - low|PATCH-Sent
 CC||ch...@bigballofwax.co.nz
   Patch Status|--- |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7364] Fast-Add framework doesn't always get the branch for item creation

2011-12-17 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7364

Chris Cormack  changed:

   What|Removed |Added

   Attachment #6835|0   |1
is obsolete||

--- Comment #2 from Chris Cormack  2011-12-18 
07:20:36 UTC ---
Created attachment 6847
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6847
Bug 7364: Possible to get to FA item add without current branch being defined.

Some paths to the FA item-add screen didn't have a branch defined--if the param
is set,
use it, otherwise, use the user's logged in branch.

Signed-off-by: Chris Cormack 

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7364] Fast-Add framework doesn't always get the branch for item creation

2011-12-16 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7364

D Ruth Bavousett  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|gmcha...@gmail.com  |r...@bywatersolutions.com

--- Comment #1 from D Ruth Bavousett  2011-12-16 
15:42:52 UTC ---
Created attachment 6835
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6835
Proposed patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/