[Koha-bugs] [Bug 7515] Authorized value code showing in OPAC for public note
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Katrin Fischer changed: What|Removed |Added Summary|authorized value code |Authorized value code |showing in opac for public |showing in OPAC for public |note|note -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Bug 7515 depends on bug 7525, which changed state. Bug 7525 Summary: Some database fields are displayed 'as is' when they are linked to authorised values https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7525 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 --- Comment #23 from Owen Leonard --- (In reply to Galen Charlton from comment #22) > > 2) Solve at the .tt level: i.e. use > > Koha::Template::Plugin::KohaAuthorisedValues and patch as we go along at the > > template level. > I prefer this option. This is very easily done, but we don't have a default authorized value category for public note and nonpublic note. Are these defaults we want to add? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #8214|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #7924|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|NEW QA Contact|koha.sek...@gmail.com |testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #22 from Galen Charlton gmcha...@gmail.com --- (In reply to Kyle M Hall from comment #21) 2) Solve at the .tt level: i.e. use Koha::Template::Plugin::KohaAuthorisedValues and patch as we go along at the template level. We can patch this sub to check for an authorised value mapping and return either the correct mapping or the original passed in data. The will greatly simplify the amount of code necessary to support the use of authorised values mapping. I prefer this option. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 --- Comment #21 from Kyle M Hall k...@bywatersolutions.com --- (In reply to comment #19) This patch looks to be a duplicate of bug 7379 if i'm not mistaking. I think we should find a generic solution and not add specific code. So switching to in discussion and also linking to bug 7525 Paul, can you give me some more input on this? I think there are a few solutions: 1) Solve at the .pl level: i.e. patch as we go along in the perl code ( i.e. this bug's patches ) 2) Solve at the .tt level: i.e. use Koha::Template::Plugin::KohaAuthorisedValues and patch as we go along at the template level. We can patch this sub to check for an authorised value mapping and return either the correct mapping or the original passed in data. The will greatly simplify the amount of code necessary to support the use of authorised values mapping. 3) Solve at the .pm level: i.e. all subs that send back data from biblio, biblioitems or items will first pass that data through a new sub ReplaceWithAuthorisedValues that will check each field to see if it is mapped to an authorised value list and replace the code with the data if necessary. I personally think choice 2 is will be the quickest, lightest weight solution. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #20 from Kyle M Hall k...@bywatersolutions.com --- (In reply to comment #19) This patch looks to be a duplicate of bug 7379 if i'm not mistaking. I think we should find a generic solution and not add specific code. So switching to in discussion and also linking to bug 7525 This is not a duplicate of bug 7379, but it is a similar situation. That one was pushed, so I don't see a reason why we shouldn't push this one too. Could we solve this at the template level using Koha::Template::Plugin::KohaAuthorisedValues? I think that would be an elegant solution, but we may need to add a more subroutine to it for various situations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |In Discussion Depends on||7379, 7525 --- Comment #19 from Paul Poulain paul.poul...@biblibre.com --- This patch looks to be a duplicate of bug 7379 if i'm not mistaking. I think we should find a generic solution and not add specific code. So switching to in discussion and also linking to bug 7525 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 delaye stephane.del...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||stephane.del...@biblibre.co ||m --- Comment #18 from delaye stephane.del...@biblibre.com --- i have crete une link between items.itemnotes(995$u : UNIMARc) and authorised_values I create an item In the opac the description of the authorised value display it's work! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Attachment #8182|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall kyle.m.h...@gmail.com --- Created attachment 8214 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8214action=edit Bug 7515 - Followup - Only set itemnotes to authorised value if said value exists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 --- Comment #15 from Kyle M Hall kyle.m.h...@gmail.com --- Created attachment 8182 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8182action=edit Bug 7515 - Followup - Only set itemnotes to authorised value if said value exists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #14 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA Comment: Filling itemnotes in Items.pm: Shouldn't you test if GetAuthValCode returned something? If it is not an authorized value, you are overwriting it, isn't it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Attachment #7893|0 |1 is obsolete|| --- Comment #12 from Kyle M Hall kyle.m.h...@gmail.com 2012-02-28 14:52:05 UTC --- Created attachment 7918 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7918 Bug 7515 - authorized value code showing in opac for public note This alters C4::Items::GetItemsInfo() to look up the authorised value for the itemnotes value if the field has been assigned an authorised value rather than being a free text field. A new boolean parameter $opac has been added to let GetItemsInfo know if the data is destined for the opac or intranet view. Defaults to intranet view. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #7918|0 |1 is obsolete|| --- Comment #13 from Nicole C. Engard neng...@gmail.com 2012-02-28 15:08:43 UTC --- Created attachment 7924 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7924 [SIGNED-OFF] Bug 7515 - authorized value code showing in opac for public note This alters C4::Items::GetItemsInfo() to look up the authorised value for the itemnotes value if the field has been assigned an authorised value rather than being a free text field. A new boolean parameter $opac has been added to let GetItemsInfo know if the data is destined for the opac or intranet view. Defaults to intranet view. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com Tested in staff client and the OPAC and the note shows the description that is appropriate for that page (OPAC or staff client). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC||paul.poul...@biblibre.com
--- Comment #11 from Paul Poulain paul.poul...@biblibre.com 2012-02-27
17:13:38 UTC ---
QA comment:
* my pre-apply hook complains:
my variable $authorised_valuecode masks earlier declaration in same scope at
/home/paul/koha.dev/koha-community//C4/Items.pm line 1264.
Looking at the code, you're adding
+my ($authorised_valuecode) =
C4::Koha::GetAuthValCode('items.itemnotes', $data-{frameworkcode});
and $authorised_valuecode is declared a few line before.
Removing the my is probably enough, please fix, test resubmit.
(the code is fine otherwise)
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #7833|0 |1 is obsolete|| --- Comment #10 from Nicole C. Engard neng...@gmail.com 2012-02-26 21:05:15 UTC --- Created attachment 7893 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7893 [SIGNED-OFF] Bug 7515 - authorized value code showing in opac for public note This alters C4::Items::GetItemsInfo() to look up the authorised value for the itemnotes value if the field has been assigned an authorised value rather than being a free text field. A new boolean parameter $opac has been added to let GetItemsInfo know if the data is destined for the opac or intranet view. Defaults to intranet view. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
CC||julian.maur...@biblibre.com
--- Comment #7 from Julian Maurice julian.maur...@biblibre.com 2012-02-23
10:03:19 UTC ---
QA comment:
In GetItemsInfo I think that all added code can be replaced by two already
existing subs:
my $sql_itemnotes =
SELECT authorised_value
FROM marc_subfield_structure
WHERE kohafield = 'items.itemnotes'
ANDframeworkcode = ?
;
my $sth_itemnotes = $dbh-prepare( $sql_itemnotes );
$sth_itemnotes-execute( $data-{'frameworkcode'} );
my ($authorised_valuecode) = $sth_itemnotes-fetchrow;
can be replaced by:
my ($authorised_valuecode) = C4::Koha::GetAuthValCode('items.itemnotes',
$data-{frameworkcode});
and
my $lib = $opac ? 'lib_opac' : 'lib';
if ($authorised_valuecode) {
$sth_itemnotes = $dbh-prepare(
SELECT $lib FROM authorised_values
WHERE category=?
AND authorised_value=?
);
$sth_itemnotes-execute( $authorised_valuecode, $data-{'itemnotes'} );
my ($lib) = $sth_itemnotes-fetchrow;
$data-{'itemnotes'} = $lib;
}
can be replaced by:
$data-{itemnotes} =
C4::Koha::GetKohaAuthorisedValueLib($authorised_valuecode, $data-{itemnotes},
$opac);
Does anybody agree?
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Attachment #7702|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall kyle.m.h...@gmail.com 2012-02-23 14:47:37 UTC --- Created attachment 7833 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7833 Bug 7515 - authorized value code showing in opac for public note This alters C4::Items::GetItemsInfo() to look up the authorised value for the itemnotes value if the field has been assigned an authorised value rather than being a free text field. A new boolean parameter $opac has been added to let GetItemsInfo know if the data is destined for the opac or intranet view. Defaults to intranet view. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 --- Comment #9 from Kyle M Hall kyle.m.h...@gmail.com 2012-02-23 14:48:45 UTC --- Updated patch to take into account the suggestions by Julian Maurice. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Ian Walls koha.sek...@gmail.com 2012-02-16 16:15:58 UTC --- This patch doesn't differentiate between the OPAC description (opaclib) and the staff client description (lib, which is used here). This means that the public will see the staffside description, which is counter to expectations. Marking as Failed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 --- Comment #5 from Kyle M Hall kyle.m.h...@gmail.com 2012-02-16 17:53:39 UTC --- Created attachment 7702 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7702 Bug 7515 - authorized value code showing in opac for public note This alters C4::Items::GetItemsInfo() to look up the authorised value for the itemnotes value if the field has been assigned an authorised value rather than being a free text field. A new boolean parameter $opac has been added to let GetItemsInfo know if the data is destined for the opac or intranet view. Defaults to intranet view. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Attachment #7644|0 |1 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #6 from Kyle M Hall kyle.m.h...@gmail.com 2012-02-16 17:54:59 UTC --- Updated the patch to take into account whether the data is to be used for the intranet or the opac. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 --- Comment #1 from Kyle M Hall kyle.m.h...@gmail.com 2012-02-14 18:12:09 UTC --- Created attachment 7641 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7641 Bug 7515 - authorized value code showing in opac for public note This alters C4::Items::GetItemsInfo() to look up the authorised value for the itemnotes value if the field has been assigned an authorised value rather than being a free text field. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff CC||kyle.m.h...@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #7641|0 |1 is obsolete|| --- Comment #2 from Nicole C. Engard neng...@gmail.com 2012-02-14 19:11:34 UTC --- Created attachment 7643 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7643 Bug 7515 - authorized value code showing in opac for public note This alters C4::Items::GetItemsInfo() to look up the authorised value for the itemnotes value if the field has been assigned an authorised value rather than being a free text field. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #7643|0 |1 is obsolete|| --- Comment #3 from Nicole C. Engard neng...@gmail.com 2012-02-14 19:12:00 UTC --- Created attachment 7644 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7644 [SIGNED-OFF] Bug 7515 - authorized value code showing in opac for public note This alters C4::Items::GetItemsInfo() to look up the authorised value for the itemnotes value if the field has been assigned an authorised value rather than being a free text field. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
