[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Owen Leonard changed: What|Removed |Added Blocks||25274 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25274 [Bug 25274] JavaScript error in OPAC cart when more details are shown -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 --- Comment #18 from Josef Moravec --- (In reply to Jonathan Druart from comment #17) > Since these patches the "Column visibility" button is displayed at the OPAC: > https://screenshots.firefox.com/OEOzq6a0aEozv8rU/catalogue.kohadev.org > > It should not. True, I filled a new Bug 21145 for this -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Josef Moravec changed: What|Removed |Added Blocks||21145 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 [Bug 21145] The "Column visibility" button should not be displayed at the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #17 from Jonathan Druart --- Since these patches the "Column visibility" button is displayed at the OPAC: https://screenshots.firefox.com/OEOzq6a0aEozv8rU/catalogue.kohadev.org It should not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Severity|minor |enhancement CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|RESOLVED --- Comment #16 from Martin Renvoize --- Enhancement, not porting to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #15 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 --- Comment #14 from Nick Clemens --- Created attachment 76625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76625=edit Bug 7547: (RM follow-up) Compiled css -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 --- Comment #13 from Nick Clemens --- Created attachment 76624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76624=edit Bug 7547: (QA follow-up) Make button background transparent for consistency Test plan: Add some records to cart in opac and show the cart, look at the print button/link --> without patch it has darker background than other buttons --> with this patch it has the same background Note: tested wir firefox 45, firefox 60 and chromium 66 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Nick Clemens changed: What|Removed |Added Attachment #76491|0 |1 is obsolete|| Attachment #76492|0 |1 is obsolete|| --- Comment #12 from Nick Clemens --- Created attachment 76623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76623=edit Bug 7547: printing a sorted cart This patch adds a DataTables-generated print button to the OPAC cart. To make that process easier, the DataTables plugin has been upgraded to the latest version (1.10.18) with the Buttons plugin included. Changes to the OPAC LESS file style the DataTables button to look like the static version. Other templates in the OPAC which use the DataTables plugin have been modified to use up-to-date option names. To test, apply the patch and add several titles to the cart. - Open the cart - Re-sort the cart using something other than the default sort - Click the 'Print' button. - A print view should open in a separate window, sorted correctly, and automatically show the print dialog. - Click the cart's 'More details' button and click the print button. - This should trigger the print dialog directly. - Test DataTables sorting on other modified pages: - Bibliographic detail page (holdings table) - Course reserves (table of courses) - Course details (table of titles) - Full subscription history - Detail page for a subscription -> More details -> Full history - Most popular - Purchase suggestions - Self checkouts - Tag cloud - Your fines - Your interlibrary loan requests - Your reading history - Your search history - Your search IDREF for ppn (I don't know how to test this) The DataTables plugin is removed from "Your routing lists" and Self check-in because it is unused. Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Josef Moravec changed: What|Removed |Added Attachment #76418|0 |1 is obsolete|| --- Comment #10 from Josef Moravec --- Created attachment 76491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76491=edit Bug 7547: printing a sorted cart This patch adds a DataTables-generated print button to the OPAC cart. To make that process easier, the DataTables plugin has been upgraded to the latest version (1.10.18) with the Buttons plugin included. Changes to the OPAC LESS file style the DataTables button to look like the static version. Other templates in the OPAC which use the DataTables plugin have been modified to use up-to-date option names. To test, apply the patch and add several titles to the cart. - Open the cart - Re-sort the cart using something other than the default sort - Click the 'Print' button. - A print view should open in a separate window, sorted correctly, and automatically show the print dialog. - Click the cart's 'More details' button and click the print button. - This should trigger the print dialog directly. - Test DataTables sorting on other modified pages: - Bibliographic detail page (holdings table) - Course reserves (table of courses) - Course details (table of titles) - Full subscription history - Detail page for a subscription -> More details -> Full history - Most popular - Purchase suggestions - Self checkouts - Tag cloud - Your fines - Your interlibrary loan requests - Your reading history - Your search history - Your search IDREF for ppn (I don't know how to test this) The DataTables plugin is removed from "Your routing lists" and Self check-in because it is unused. Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 --- Comment #11 from Josef Moravec --- Created attachment 76492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76492=edit Bug 7547: (QA follow-up) Make button background transparent for consistency Test plan: Add some records to cart in opac and show the cart, look at the print button/link --> without patch it has darker background than other buttons --> with this patch it has the same background Note: tested wir firefox 45, firefox 60 and chromium 66 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Josef Moravec changed: What|Removed |Added QA Contact||josef.mora...@gmail.com CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Katrin Fischer changed: What|Removed |Added Attachment #76246|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 76418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76418=edit Bug 7547: printing a sorted cart This patch adds a DataTables-generated print button to the OPAC cart. To make that process easier, the DataTables plugin has been upgraded to the latest version (1.10.18) with the Buttons plugin included. Changes to the OPAC LESS file style the DataTables button to look like the static version. Other templates in the OPAC which use the DataTables plugin have been modified to use up-to-date option names. To test, apply the patch and add several titles to the cart. - Open the cart - Re-sort the cart using something other than the default sort - Click the 'Print' button. - A print view should open in a separate window, sorted correctly, and automatically show the print dialog. - Click the cart's 'More details' button and click the print button. - This should trigger the print dialog directly. - Test DataTables sorting on other modified pages: - Bibliographic detail page (holdings table) - Course reserves (table of courses) - Course details (table of titles) - Full subscription history - Detail page for a subscription -> More details -> Full history - Most popular - Purchase suggestions - Self checkouts - Tag cloud - Your fines - Your interlibrary loan requests - Your reading history - Your search history - Your search IDREF for ppn (I don't know how to test this) The DataTables plugin is removed from "Your routing lists" and Self check-in because it is unused. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 --- Comment #8 from Katrin Fischer --- This seems to work well, but I want to check the other changed pages still. Something I notices on the printout is that the printing runs into the footers/headers in Firefox and there is only very little to no margin on the left and right. Not sure if we can do something about this, seems similar with the existing print feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Katrin Fischer changed: What|Removed |Added Summary|printing a sorted cart |Printing a sorted cart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 --- Comment #7 from Owen Leonard --- Created attachment 76246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76246=edit Bug 7547: printing a sorted cart This patch adds a DataTables-generated print button to the OPAC cart. To make that process easier, the DataTables plugin has been upgraded to the latest version (1.10.18) with the Buttons plugin included. Changes to the OPAC LESS file style the DataTables button to look like the static version. Other templates in the OPAC which use the DataTables plugin have been modified to use up-to-date option names. To test, apply the patch and add several titles to the cart. - Open the cart - Re-sort the cart using something other than the default sort - Click the 'Print' button. - A print view should open in a separate window, sorted correctly, and automatically show the print dialog. - Click the cart's 'More details' button and click the print button. - This should trigger the print dialog directly. - Test DataTables sorting on other modified pages: - Bibliographic detail page (holdings table) - Course reserves (table of courses) - Course details (table of titles) - Full subscription history - Detail page for a subscription -> More details -> Full history - Most popular - Purchase suggestions - Self checkouts - Tag cloud - Your fines - Your interlibrary loan requests - Your reading history - Your search history - Your search IDREF for ppn (I don't know how to test this) The DataTables plugin is removed from "Your routing lists" and Self check-in because it is unused. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Katrin Fischerchanged: What|Removed |Added Severity|enhancement |minor CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- Updating to be a bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 --- Comment #5 from Patrick Robitaille--- Hi, I wonder if someone is working on the problem. It still persists in version 17.05 of Koha. Thanks, Patrick. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Patrick Robitaillechanged: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Marjorie Barry-Vilachanged: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] printing a sorted cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Barton Chittenden bar...@bywatersolutions.com changed: What|Removed |Added CC||bar...@bywatersolutions.com --- Comment #1 from Barton Chittenden bar...@bywatersolutions.com --- I had one of our partners report this as an issue today. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] printing a sorted cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 --- Comment #2 from Barton Chittenden bar...@bywatersolutions.com --- Created attachment 31000 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31000action=edit Cart, sorted by Items then printed using the browser's Print option (Control-P) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] printing a sorted cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 --- Comment #4 from Barton Chittenden bar...@bywatersolutions.com --- Note that the issue occurs in both OPAC and Staff Client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/