[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

--- Comment #55 from Victor Grousset/tuxayo  ---
Conflict in koha-tmpl/intranet-tmpl/prog/js/staff-global.js
Can't resolve and can't backport to 19.11.x


<<< HEAD
if (typeof $.cookie("lastborrowernumber") === "undefined" ||
($("#hiddenborrowernumber").val() != $.cookie("lastborrowernumber") &&
$.cookie("currentborrowernumber") != $("#hiddenborrowernumber").val())) {
$.cookie("lastborrowernumber", $("#hiddenborrowernumber").val(), {
path: "/" });
$.cookie("lastborrowername", $("#hiddenborrowername").val(), { path:
"/" });
$.cookie("lastborrowercard", $("#hiddenborrowercard").val(), { path:
"/" });
}
$.cookie("currentborrowernumber", $("#hiddenborrowernumber").val(), { path:
"/" });
||| parent of b460a630ef (Bug 7607: Remove empty inputs when submitting
search form)

/* Search results browsing */
/* forms with action leading to search */
$("form[action*='search.pl']").submit(function(){
resetSearchContext();
});
/* any link to launch a search except navigation links */
   
$("[href*='search.pl?']").not(".nav").not('.searchwithcontext').click(function(){
resetSearchContext();
});
/* any link to a detail page from the results page. */
$("#bookbag_form a[href*='detail.pl?']").click(function(){
resetSearchContext();
});

===

/* Search results browsing */
/* forms with action leading to search */
$("form[action*='search.pl']").submit(function(){
var removedPrior = false;
$(".search_set").each(function(){
if( removedPrior ){
$(this).find('select[name="op"]').remove();
removedPrior = false;
}
if( $(this).find('input[name="q"]').val() == "" ){
$(this).remove();
removedPrior = true;
}
});
resetSearchContext();
});
/* any link to launch a search except navigation links */
   
$("[href*='search.pl?']").not(".nav").not('.searchwithcontext').click(function(){
resetSearchContext();
});
/* any link to a detail page from the results page. */
$("#bookbag_form a[href*='detail.pl?']").click(function(){
resetSearchContext();
});

>>> b460a630ef (Bug 7607: Remove empty inputs when submitting search form)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.07
released in||
 CC||and...@bywatersolutions.com

--- Comment #54 from Andrew Fuerste-Henry  ---
backported to 20.05.x for 20.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_20_11_target|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #53 from Jonathan Druart  
---
Pushed to master for 20.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||20.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Signed Off  |Passed QA

--- Comment #52 from Martin Renvoize  ---
This works really well, and I can't replicate any issues with using the back
button either.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #113781|0   |1
is obsolete||

--- Comment #51 from Martin Renvoize  ---
Created attachment 113874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113874=edit
Bug 7607: (follow-up) Address OPAC and limits

This patch adds the same function to the OPAC and adds support for limits

I adjust the class on staff side to match the one already existing on OPAC

On the OPAC when you click the back button the fields are not enabled - on the
staff side they are,
I leave this problem for someone else to solve

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #113692|0   |1
is obsolete||

--- Comment #50 from Martin Renvoize  ---
Created attachment 113873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113873=edit
Bug 7607: (follow-up) Disable rather than remove inputs

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Josef Moravec 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #113691|0   |1
is obsolete||

--- Comment #49 from Martin Renvoize  ---
Created attachment 113872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113872=edit
Bug 7607: Remove empty inputs when submitting search form

This patch surrounds the operator, index, and query fields on the advanced
search
page wtih a 'search_set' class.

This allows us to process them as a group and confirm the query is populated
before submitting
the other parts to the form

TO test:
1 - Go to advanced search
2 - Use search boxes to search like:
Title: (leave blank)
Author: clinton
keyword: shuffle
3 - Perform search
4 - Note no results as you searched for title:clinton etc.
5 - apply patch
6 - refresh and repeat
7 - search is now correct
8 - Try vaeious searches with 'more options' and selecting different operators

Signed-off-by: David Nind 
Signed-off-by: David Cook 
Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Josef Moravec 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|RM_priority |rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #48 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #45)
> Created attachment 113781 [details] [review] [review]
> On the OPAC when you click the back button the fields are not enabled - on
> the staff side they are,
> I leave this problem for someone else to solve

Looks ok for me on Firefox (68.12.0esr) and Chromium (Version 83.0.4103.116)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #47 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #45)
> Created attachment 113781 [details] [review]
> On the OPAC when you click the back button the fields are not enabled - on
> the staff side they are,
> I leave this problem for someone else to solve

Looks of for me on Firefox (68.12.0esr) and Chromium (Version 83.0.4103.116)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #46 from David Cook  ---
(In reply to Jonathan Druart from comment #44)

Thanks for clarifying, Jonathan! Makes sense.

(In reply to Nick Clemens from comment #45)
> On the OPAC when you click the back button the fields are not enabled - on
> the staff side they are,
> I leave this problem for someone else to solve

Hmm bizarre...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #45 from Nick Clemens  ---
Created attachment 113781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113781=edit
Bug 7607: (follow-up) Address OPAC and limits

This patch adds the same function to the OPAC and adds support for limits

I adjust the class on staff side to match the one already existing on OPAC

On the OPAC when you click the back button the fields are not enabled - on the
staff side they are,
I leave this problem for someone else to solve

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #44 from Jonathan Druart  
---
(In reply to David Cook from comment #43)
> (In reply to Jonathan Druart from comment #42)
> > 1. Those patches don't affect the OPAC
> 
> That's a good point but I don't know that it's worth failing it?

The first patch dealt with OPAC, and the code is similar. I don't see any good
reasons to not fix it as well.

> > 2. Same problem exists with the "limit" parameter.
> 
> Can you provide steps to reproduce that problem and more explanation? I have
> not experienced any problems with the "limit" parameter.

Nothing special...
Adv search:
/cgi-bin/koha/catalogue/search.pl?advsearch=1=kw=d=_by=relevance

(On top of bug 25548)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #43 from David Cook  ---
(In reply to Jonathan Druart from comment #42)
> 1. Those patches don't affect the OPAC

That's a good point but I don't know that it's worth failing it?

> 2. Same problem exists with the "limit" parameter.

Can you provide steps to reproduce that problem and more explanation? I have
not experienced any problems with the "limit" parameter.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #42 from Jonathan Druart  
---
1. Those patches don't affect the OPAC
2. Same problem exists with the "limit" parameter.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 QA Contact||josef.mora...@gmail.com
 Status|Signed Off  |Passed QA

--- Comment #41 from Josef Moravec  ---
I do really like to see this bug fixed.

- QA tools passed.
- Behaviour is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Josef Moravec  changed:

   What|Removed |Added

 Attachment #113683|0   |1
is obsolete||

--- Comment #40 from Josef Moravec  ---
Created attachment 113692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113692=edit
Bug 7607: (follow-up) Disable rather than remove inputs

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Josef Moravec  changed:

   What|Removed |Added

 Attachment #113682|0   |1
is obsolete||

--- Comment #39 from Josef Moravec  ---
Created attachment 113691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113691=edit
Bug 7607: Remove empty inputs when submitting search form

This patch surrounds the operator, index, and query fields on the advanced
search
page wtih a 'search_set' class.

This allows us to process them as a group and confirm the query is populated
before submitting
the other parts to the form

TO test:
1 - Go to advanced search
2 - Use search boxes to search like:
Title: (leave blank)
Author: clinton
keyword: shuffle
3 - Perform search
4 - Note no results as you searched for title:clinton etc.
5 - apply patch
6 - refresh and repeat
7 - search is now correct
8 - Try vaeious searches with 'more options' and selecting different operators

Signed-off-by: David Nind 

Signed-off-by: David Cook 

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #38 from Victor Grousset/tuxayo  ---
As a step to help QA, here is another signoff.

However I'm having a crash of the qa-test-tools. Maybe it's my setup, however
it works on other previous commits from master.


From a koha-testing-docker with up to date qa-test-tools:
kohadev-koha@kohadevbox:/kohadevbox/koha$ /kohadevbox/qa-test-tools/koha-qa.pl
-v 2 -c 2
testing 2 commit(s) (applied to 55835cc 'af Bug 27021: Make chaining ->empty
a')

Processing files before patches
sh: 1: Syntax error: "(" unexpected100.00%)

Processing files after patches
|>| 2 / 2 (100.00%)

 OK koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
   OK filters
   OK forbidden patterns
   OK git manipulation
   OK js_in_body
   OK spelling
   OK tt_valid
   OK valid_template

 OK koha-tmpl/intranet-tmpl/prog/js/staff-global.js
   OK ES template literals
   OK git manipulation


Processing additional checks OK!
sh: 1: Syntax error: "(" unexpected
kohadev-koha@kohadevbox:/kohadevbox/koha$

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #113134|0   |1
is obsolete||

--- Comment #37 from Victor Grousset/tuxayo  ---
Created attachment 113683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113683=edit
Bug 7607: (follow-up) Disable rather than remove inputs

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #113133|0   |1
is obsolete||

--- Comment #36 from Victor Grousset/tuxayo  ---
Created attachment 113682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113682=edit
Bug 7607: Remove empty inputs when submitting search form

This patch surrounds the operator, index, and query fields on the advanced
search
page wtih a 'search_set' class.

This allows us to process them as a group and confirm the query is populated
before submitting
the other parts to the form

TO test:
1 - Go to advanced search
2 - Use search boxes to search like:
Title: (leave blank)
Author: clinton
keyword: shuffle
3 - Perform search
4 - Note no results as you searched for title:clinton etc.
5 - apply patch
6 - refresh and repeat
7 - search is now correct
8 - Try vaeious searches with 'more options' and selecting different operators

Signed-off-by: David Nind 

Signed-off-by: David Cook 

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||RM_priority
 QA Contact|m.de.r...@rijksmuseum.nl|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #35 from David Cook  ---
(In reply to Nick Clemens from comment #34)
> In chrome and firefox the field is enabled again when hitting back. visually
> it is probably less jarring to see the field disabled versus removed so I
> think it can move forward like this

Sounds good!

I think the input reset type doesn't remove the disabled attribute but I don't
think that we ever use that in Koha, so no worries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #34 from Nick Clemens  ---
(In reply to David Cook from comment #33)
> (In reply to Nick Clemens from comment #31)
> > (In reply to Jonathan Druart from comment #28)
> > > To prevent the values to be sent maybe we could disable the elements 
> > > instead
> > > of removing them from the DOM. What do you think?
> > 
> > It seems to work either way - I am not sure if there is any advantage in one
> > method over the other, but I trust the RM
> 
> What's the effect when hitting the "Back" button in the browser? I have a
> feeling that removing the elements might work better than disabling them in
> that context, but I'm not 100% sure off the top of my head. (Just thinking
> of different scenarios.)

In chrome and firefox the field is enabled again when hitting back. visually it
is probably less jarring to see the field disabled versus removed so I think it
can move forward like this

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Nick Clemens  changed:

   What|Removed |Added

 Attachment #112964|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #33 from David Cook  ---
(In reply to Nick Clemens from comment #31)
> (In reply to Jonathan Druart from comment #28)
> > To prevent the values to be sent maybe we could disable the elements instead
> > of removing them from the DOM. What do you think?
> 
> It seems to work either way - I am not sure if there is any advantage in one
> method over the other, but I trust the RM

What's the effect when hitting the "Back" button in the browser? I have a
feeling that removing the elements might work better than disabling them in
that context, but I'm not 100% sure off the top of my head. (Just thinking of
different scenarios.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #32 from David Cook  ---
(In reply to Nick Clemens from comment #29)
> Signed-off-by: David Nind 
> 
> Signed-off-by: David Cook 
> 
> https://bugs.koha-community.org/show_bug.cgi?id=7606

Ooops I think I introduced an extra mistyped line to the bottom of the commit
message. Hope someone erases that later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #31 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #28)
> To prevent the values to be sent maybe we could disable the elements instead
> of removing them from the DOM. What do you think?

It seems to work either way - I am not sure if there is any advantage in one
method over the other, but I trust the RM

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #29 from Nick Clemens  ---
Created attachment 113133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113133=edit
Bug 7607: Remove empty inputs when submitting search form

This patch surrounds the operator, index, and query fields on the advanced
search
page wtih a 'search_set' class.

This allows us to process them as a group and confirm the query is populated
before submitting
the other parts to the form

TO test:
1 - Go to advanced search
2 - Use search boxes to search like:
Title: (leave blank)
Author: clinton
keyword: shuffle
3 - Perform search
4 - Note no results as you searched for title:clinton etc.
5 - apply patch
6 - refresh and repeat
7 - search is now correct
8 - Try vaeious searches with 'more options' and selecting different operators

Signed-off-by: David Nind 

Signed-off-by: David Cook 

https://bugs.koha-community.org/show_bug.cgi?id=7606

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #30 from Nick Clemens  ---
Created attachment 113134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113134=edit
Bug 7607: (follow-up) Disable rather than remove inputs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #28 from Jonathan Druart  
---
To prevent the values to be sent maybe we could disable the elements instead of
removing them from the DOM. What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|jonathan.dru...@bugs.koha-c |n...@bywatersolutions.com
   |ommunity.org|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

David Cook  changed:

   What|Removed |Added

 Blocks||25548


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
[Bug 25548] Package install Apache performs unnecessary redirects
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

David Cook  changed:

   What|Removed |Added

 Attachment #111064|0   |1
is obsolete||
 Attachment #111065|0   |1
is obsolete||
 Attachment #112963|0   |1
is obsolete||

--- Comment #27 from David Cook  ---
Created attachment 112964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112964=edit
Bug 7607: [Alternate] Remove empty inputs when submitting search form

This patch surrounds the operator, index, and query fields on the advanced
search
page wtih a 'search_set' class.

This allows us to process them as a group and confirm the query is populated
before submitting
the other parts to the form

TO test:
1 - Go to advanced search
2 - Use search boxes to search like:
Title: (leave blank)
Author: clinton
keyword: shuffle
3 - Perform search
4 - Note no results as you searched for title:clinton etc.
5 - apply patch
6 - refresh and repeat
7 - search is now correct
8 - Try vaeious searches with 'more options' and selecting different operators

Signed-off-by: David Nind 

Signed-off-by: David Cook 

https://bugs.koha-community.org/show_bug.cgi?id=7606

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #26 from David Cook  ---
Ok this issue is really annoying me, so let's get it sorted...

Test plan:
0. No patch
1. Go to
http://localhost:8081/cgi-bin/koha/catalogue/search.pl?expanded_options=1
2. Change 2nd "Keyword" and 3rd "Keyword" to "Author"
3. Change 2nd search box to "Martin" and 3rd search box to "Humble"
4. Change 2nd op box (between Martin and Humble) to "or"
5. Click "Search"
6. Note the following URL: 
http://localhost:8081/cgi-bin/koha/catalogue/search.pl?advsearch=1=kw=and=au=Martin=or=au=Humble_by=relevance
7. Note the HTML response:
No results match your search for 'kw,wrdl: Martin and au,wrdl: Humble'.

Test plan:
0. Apply Nick's patch and "koha-plack --restart kohadev"
1. Go to
http://localhost:8081/cgi-bin/koha/catalogue/search.pl?expanded_options=1
2. Change 2nd "Keyword" and 3rd "Keyword" to "Author"
3. Change 2nd search box to "Martin" and 3rd search box to "Humble"
4. Change 2nd op box (between Martin and Humble) to "or"
5. Click "Search"
5b. If you have a quick eye, you'll see the empty search box was removed by
Javascript. Yay!
6. Note the following URL:
http://localhost:8081/cgi-bin/koha/catalogue/search.pl?advsearch=1=au=Martin=or=au=Humble_by=relevance
7. Note the HTML response:
12 result(s) found for 'au,wrdl: Martin or au,wrdl: Humble'.

Great patch, Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #24 from David Cook  ---
Comment on attachment 112912
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112912
Bug 7607: [Alternate] Remove empty inputs when submitting search form

Review of attachment 112912:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=7607=112912)
-

::: koha-tmpl/intranet-tmpl/prog/js/staff-global.js
@@ +140,5 @@
> +if( $(this).find('input[name="q"]').val() == "" ){
> +$(this).remove();
> +removedPrior = true;
> +}
> +});

I haven't tested the code but what about the idx? Wouldn't this code exacerbate
the problem?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

David Nind  changed:

   What|Removed |Added

 Attachment #112912|0   |1
is obsolete||

--- Comment #25 from David Nind  ---
Created attachment 112963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112963=edit
Bug 7607: [Alternate] Remove empty inputs when submitting search form

This patch surrounds the operator, index, and query fields on the advanced
search
page wtih a 'search_set' class.

This allows us to process them as a group and confirm the query is populated
before submitting
the other parts to the form

TO test:
1 - Go to advanced search
2 - Use search boxes to search like:
Title: (leave blank)
Author: clinton
keyword: shuffle
3 - Perform search
4 - Note no results as you searched for title:clinton etc.
5 - apply patch
6 - refresh and repeat
7 - search is now correct
8 - Try vaeious searches with 'more options' and selecting different operators

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #23 from Katrin Fischer  ---
(In reply to Nick Clemens from comment #22)
> hopefully helping and not muddying, adding an alternate patch to remove the
> whole search (index, query, operator) if there is no value provided

Thx Nick, I was going to comment that we don't need to change the form itself!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #22 from Nick Clemens  ---
hopefully helping and not muddying, adding an alternate patch to remove the
whole search (index, query, operator) if there is no value provided

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #21 from Nick Clemens  ---
Created attachment 112912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112912=edit
Bug 7607: [Alternate] Remove empty inputs when submitting search form

This patch surrounds the operator, index, and query fields on the advanced
search
page wtih a 'search_set' class.

This allows us to process them as a group and confirm the query is populated
before submitting
the other parts to the form

TO test:
1 - Go to advanced search
2 - Use search boxes to search like:
Title: (leave blank)
Author: clinton
keyword: shuffle
3 - Perform search
4 - Note no results as you searched for title:clinton etc.
5 - apply patch
6 - refresh and repeat
7 - search is now correct
8 - Try vaeious searches with 'more options' and selecting different operators

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #20 from David Cook  ---
(In reply to David Cook from comment #17)
> Actually, we have a customization that does something like this patch, and
> it actually causes the problem to be worse.
> 
> If you set the idx element value to '', the idx select elements don't get
> sent, but the empty q input elements do. So you wind up with a mismatched
> number of parameters.

This isn't true *if* you provide an option in the select list with a value of
''. 

So adding that option element in the list would help, if we want to use the
Javascript in the patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #19 from David Cook  ---
(In reply to David Cook from comment #18)
> And if people are worried about ugly URLs, then I think they should open a
> new bug report to remove unused search boxes in advanced search from the DOM
> so they don't get submitted with the HTML form.

Alternatively, we could only show 1 search box on the advanced search page, and
make people add more search boxes as needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #18 from David Cook  ---
(In reply to Jonathan Druart from comment #16)
> If we have the change from bug 25548, this issue will get fixed.

I agree. Bug 25548 would resolve Bug 7607.

And if people are worried about ugly URLs, then I think they should open a new
bug report to remove unused search boxes in advanced search from the DOM so
they don't get submitted with the HTML form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au
 Status|BLOCKED |Failed QA

--- Comment #17 from David Cook  ---
Actually, we have a customization that does something like this patch, and it
actually causes the problem to be worse.

If you set the idx element value to '', the idx select elements don't get sent,
but the empty q input elements do. So you wind up with a mismatched number of
parameters.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #16 from Jonathan Druart  
---
If we have the change from bug 25548, this issue will get fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #15 from Katrin Fischer  ---
I believe major is justified as this is an issue we've run into multiple times
over the years and it affects the OPAC search and so is confusing to users.

I am not sure how it relates to bug 25548 ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |BLOCKED

--- Comment #14 from Jonathan Druart  
---
Blocked by bug 25548 for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #13 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #12)
> Should this really be marked as Major btw ?

I fixed it because it was marked as major :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #12 from Marcel de Rooy  ---
Should this really be marked as Major btw ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #11 from Marcel de Rooy  ---
QA Comment: Works, but kind of tweaky ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #10 from Marcel de Rooy  ---
Created attachment 111065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111065=edit
Bug 7607: (QA follow-up) Add comment line to new submit action

The solution here is a workaround, but we need to document why
we are doing this.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #110849|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 111064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111064=edit
Bug 7607: Fix adv search when leaving fields empty

We have a rewrite rule in our apache config that remove empty
parameters:
  RewriteCond %{QUERY_STRING} (.*?)(?:[A-Za-z0-9_-]+)=&(.*)

That causes the advanced search to search on the wrong index if an input
field is left empty.

Test plan (staff and OPAC):
- leave the first pulldown on keyword and the search term empty
- select author or title from the second pull down and enter a search term

Signed-off-by: David Nind 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|BLOCKED |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |BLOCKED

--- Comment #8 from Marcel de Rooy  ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25548

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

David Nind  changed:

   What|Removed |Added

 Attachment #110845|0   |1
is obsolete||

--- Comment #7 from David Nind  ---
Created attachment 110849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110849=edit
Bug 7607: Fix adv search when leaving fields empty

We have a rewrite rule in our apache config that remove empty
parameters:
  RewriteCond %{QUERY_STRING} (.*?)(?:[A-Za-z0-9_-]+)=&(.*)

That causes the advanced search to search on the wrong index if an input
field is left empty.

Test plan (staff and OPAC):
- leave the first pulldown on keyword and the search term empty
- select author or title from the second pull down and enter a search term

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #107963|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 110845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110845=edit
Bug 7607: Fix adv search when leaving fields empty

We have a rewrite rule in our apache config that remove empty
parameters:
  RewriteCond %{QUERY_STRING} (.*?)(?:[A-Za-z0-9_-]+)=&(.*)

That causes the advanced search to search on the wrong index if an input
field is left empty.

Test plan (staff and OPAC):
- leave the first pulldown on keyword and the search term empty
- select author or title from the second pull down and enter a search term

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||da...@davidnind.com

--- Comment #5 from David Nind  ---
Patch no longer applies 8-( :

root@kohadevbox:koha(bz7607)$ git bz apply 7607
Bug 7607 - Advanced search: Index and search term don't match when leaving
fields empty

107963 - Bug 7607: Fix adv search when leaving fields empty

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 7607: Fix adv search when leaving fields empty
Using index info to reconstruct a base tree...
M   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
M   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 7607: Fix adv search when leaving fields empty
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-7607-Fix-adv-search-when-leaving-fields-empty-P2nq_2.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #4 from Jonathan Druart  
---
Created attachment 107963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107963=edit
Bug 7607: Fix adv search when leaving fields empty

We have a rewrite rule in our apache config that remove empty
parameters:
  RewriteCond %{QUERY_STRING} (.*?)(?:[A-Za-z0-9_-]+)=&(.*)

That causes the advanced search to search on the wrong index if an input
field is left empty.

Test plan (staff and OPAC):
- leave the first pulldown on keyword and the search term empty
- select author or title from the second pull down and enter a search term

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m

--- Comment #3 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
This might be caused by URL-rewriting (in apache configuration).
Because when Keyword is selected, the value of select is empty and it generates
in URL idx= which is removed by URL-rewriting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr

--- Comment #1 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Same observation at Lyon3 : the problem comes from what Paul Poulain pointed
out in last comment of bug 3264. (But a recent test in Chrome got the same
wrong result as in Firefox).
As a work around I put the following function in opacuserjs syspref but I guess
it would be better to find a more orthodox way :

$(document).ready(function(){
$(input[name='do']).click(function(){
$(input[name='q']).each(function(i){
if (!$(this).val()){
$(select[name='idx']).eq(i).append('option value=
selected=selected/option'); 
}
}); 
});
});

and in intranetuserjs :

$(document).ready(function() {
$(#submit1,#submit2).click(function(){
$(input[name='q']).each(function(i){
if (!$(this).val()){
$(select[name='idx']).eq(i).append('option value=
selected=selected/option'); 
}
}); 
});
});

Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||jcam...@cpbibliography.com
 QA Contact|koha.sek...@gmail.com   |

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Adding Jared in CC as I think he mentioned his search rewrite work might have a
fix for this :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Blocks||9234

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/