[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #12022|0 |1 is obsolete|| --- Comment #39 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 12022 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12022 [SIGNED-OFF] Bug 7642 - fix the lost display of tag sizes this patch obsoleted by the rebased one -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #40 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master, on master branch directly The QA tools have detected a mistake in POD doc (that was here before this patch), I've fixed it too -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #41 from Chris Cormack ch...@bigballofwax.co.nz --- This wont apply to 3.8.x please rebase if it is needed there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #42 from Robin Sheat ro...@catalyst.net.nz --- Created attachment 12626 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12626action=edit Bug 7642 - [3.8.x] fix the lost display of tag sizes This fixes the display of different sized words for differently popular tags. It is a bit of a refactor of that part of the system, moving logic to more sensible places (and removing an unused method on the way.) Note that it isn't an attempt to reproduce what was there previously, just to do something similar, and in an easier to change fashion. Sponsored-By: New Zealand Educational Institute Signed-off-by: Marc Veron ve...@veron.ch Works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #43 from Robin Sheat ro...@catalyst.net.nz --- Rebased against 3.8.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #44 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.8.x, will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #35 from Paul Poulain paul.poul...@biblibre.com --- Some comments: * the patch does not apply anymore Applying: Bug 7642 - fix the lost display of tag sizes Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/css/opac.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/css/opac.css Auto-merging C4/Tags.pm CONFLICT (content): Merge conflict in C4/Tags.pm Failed to merge in the changes. Patch failed at 0001 Bug 7642 - fix the lost display of tag sizes When you have resolved this problem run git am --resolved. If you would prefer to skip this patch, instead run git am --skip. To restore the original branch and stop patching run git am --abort. Patch left in /tmp/SIGNED-OFF-Bug-7642---fix-the-lost-display-of-tag--OPHe1P.patch * you should add the css to ccsr theme * this patch is attached to 7642, but it's not really a follow-up of the previous part, shouldn't it be another bug number ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #36 from Robin Sheat ro...@catalyst.net.nz --- Created attachment 12604 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12604action=edit Bug 7642 - fix the lost display of tag sizes This fixes the display of different sized words for differently popular tags. It is a bit of a refactor of that part of the system, moving logic to more sensible places (and removing an unused method on the way.) Note that it isn't an attempt to reproduce what was there previously, just to do something similar, and in an easier to change fashion. Sponsored-By: New Zealand Educational Institute Signed-off-by: Marc Veron ve...@veron.ch Works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #37 from Robin Sheat ro...@catalyst.net.nz --- Rebased against master, added CSS to ccsr theme, fixed Jonathan's QA comments. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #38 from Robin Sheat ro...@catalyst.net.nz --- Oh, it probably could have got its own bug number, but I thought it was going to be a simple followup when I started it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #34 from Katrin Fischer katrin.fisc...@bsz-bw.de --- *** Bug 8814 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #33 from Jonathan Druart jonathan.dru...@biblibre.com --- QA Comments: - Remove an unused routine (rectify_weights) - Simplify tag weight management - add UT not blocker: - add a tabulation character in C4/Tags.pm (but a lot of already exist) - useless use Data::Dumper in Tags.t Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch --- Comment #29 from Marc Véron ve...@veron.ch --- I had the same error as well and do not know how to resolve it: Applying: Bug 7642 - fix the lost display of tag sizes fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/prog/en/modules/opac-tags.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #30 from Robin Sheat ro...@catalyst.net.nz --- Created attachment 12014 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12014action=edit Bug 7642 - fix the lost display of tag sizes This fixes the display of different sized words for differently popular tags. It is a bit of a refactor of that part of the system, moving logic to more sensible places (and removing an unused method on the way.) Note that it isn't an attempt to reproduce what was there previously, just to do something similar, and in an easier to change fashion. Sponsored-By: New Zealand Educational Institute -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #31 from Robin Sheat ro...@catalyst.net.nz --- I think the issue was that I'd based it off a branch that you didn't have, and so it couldn't do 3-way merge when it found a conflict. Try this, which is based off current master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Attachment #10988|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #12014|0 |1 is obsolete|| --- Comment #32 from Marc Véron ve...@veron.ch --- Created attachment 12022 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12022action=edit [SIGNED-OFF] Bug 7642 - fix the lost display of tag sizes This fixes the display of different sized words for differently popular tags. It is a bit of a refactor of that part of the system, moving logic to more sensible places (and removing an unused method on the way.) Note that it isn't an attempt to reproduce what was there previously, just to do something similar, and in an easier to change fashion. Sponsored-By: New Zealand Educational Institute Signed-off-by: Marc Veron ve...@veron.ch Works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #25 from Owen Leonard oleon...@myacpl.org --- The first patch no longer applies for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #26 from Owen Leonard oleon...@myacpl.org --- Oh never mind, the first one was already pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #10123|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added CC||neng...@gmail.com --- Comment #27 from Owen Leonard oleon...@myacpl.org --- *** Bug 8445 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #28 from Owen Leonard oleon...@myacpl.org --- Same problem with the follow-up patch. Does not apply. Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 7642 - fix the lost display of tag sizes fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/prog/en/modules/opac-tags.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7642 - fix the lost display of tag sizes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #19 from Robin Sheat ro...@catalyst.net.nz --- Created attachment 10986 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10986action=edit Bug 7642 - fix the lost display of tag sizes This fixes the display of different sized words for differently popular tags. It is a bit of a refactor of that part of the system, moving logic to more sensible places (and removing an unused method on the way.) Note that it isn't an attempt to reproduce what was there previously, just to do something similar, and in an easier to change fashion. Sponsored-By: New Zealand Educational Institute -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #20 from Robin Sheat ro...@catalyst.net.nz --- This should be applied on top of the previous patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #21 from Robin Sheat ro...@catalyst.net.nz --- Created attachment 10987 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10987action=edit Bug 7642 - fix the lost display of tag sizes This fixes the display of different sized words for differently popular tags. It is a bit of a refactor of that part of the system, moving logic to more sensible places (and removing an unused method on the way.) Note that it isn't an attempt to reproduce what was there previously, just to do something similar, and in an easier to change fashion. Sponsored-By: New Zealand Educational Institute -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Attachment #10986|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #22 from Robin Sheat ro...@catalyst.net.nz --- This one just removes some CSS stuff that wasn't supposed to be there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Attachment #10987|0 |1 is obsolete|| --- Comment #23 from Robin Sheat ro...@catalyst.net.nz --- Created attachment 10988 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10988action=edit Bug 7642 - fix the lost display of tag sizes This fixes the display of different sized words for differently popular tags. It is a bit of a refactor of that part of the system, moving logic to more sensible places (and removing an unused method on the way.) Note that it isn't an attempt to reproduce what was there previously, just to do something similar, and in an easier to change fashion. Sponsored-By: New Zealand Educational Institute -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #24 from Robin Sheat ro...@catalyst.net.nz --- For serious this time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Status|Pushed to Stable|ASSIGNED --- Comment #17 from Robin Sheat ro...@catalyst.net.nz --- I've found this causes a regression: the tags no longer display in their correct size, they all appear the same, as the value in the 'title' field was used by javascript to calculate the font-size attribute. I'm hoping to get this fixed in not too long. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #18 from Robin Sheat ro...@catalyst.net.nz --- Also, the size calculation logic should probably get moved to template toolkit rather than javascript. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #16 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.8.x, will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_8 Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #14 from Paul Poulain paul.poul...@biblibre.com --- QA comment: tiniest patch ever maybe, but I've a doubt. In opac-tags.pl, there is still some references to cloudweight field that you remove from the template (and is no more used in the template), for example: $_-{cloudweight} = $strata; I'm not sure I'm right, so I let someone else investigating and confirming or infirming. Not changing QA status for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #15 from Ian Walls koha.sek...@gmail.com --- cloudweight looks to be an attempt to cluster the various weightings of terms into strata groups, 1 through 5. This isn't even the tag's raw weight, just it's relative weight projected to a 5 point scale. I don't think this is worth keeping, as it does nothing to inform the patron about anything they can actually use. Marking this as Passed QA, as it's perfectly valid code, and that it removes is okay (by my opinion) to remove. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||paul.poul...@biblibre.com --- Comment #10 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #9) Leaving decision to QA team and RM. RM fully agreeing with owen katrin is happy to see he's not the only member of FAUSP (Fighters Against Useless System Preferences) let's go to disabling this option : if the number is confusing (and I agree it is), just remove it ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #11 from Robin Sheat ro...@catalyst.net.nz --- Alrighty then, I'll modify it to do so. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #12 from Robin Sheat ro...@catalyst.net.nz --- Created attachment 10111 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10111action=edit Bug 7642 - remove the cloud weight from the tags -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Attachment #10028|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Stacey Walker sta...@catalyst-eu.net changed: What|Removed |Added Attachment #10111|0 |1 is obsolete|| Status|Needs Signoff |Signed Off Assignee|ro...@catalyst.net.nz |sta...@catalyst-eu.net --- Comment #13 from Stacey Walker sta...@catalyst-eu.net --- Created attachment 10123 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10123action=edit signed off patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #9785|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 10028 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10028action=edit [SIGNED-OFF] Bug 7642 - OpacShowTagCloudWeight system preference This system preference allows the mouseover text on the tag cloud to be turned off. The text consists of the weight for the tag, but users are more likely to confuse it with the number of items that have this tag. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works as advertised, tiny change to the HTML output. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Leaving decision to QA team and RM. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #5 from Owen Leonard oleon...@myacpl.org --- Adding a preference for this seems like overkill to me. Why not either make the number represent the actual number of items tagged or remove the title attribute altogether? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I agree with Owen here - it seems like it's confusing how it is now and I would really like a way to show the number of titles associated with a tag. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #7 from Robin Sheat ro...@catalyst.net.nz --- Making it reflect the real number of items is hard, you have to do a whole nother set of queries to account for multiple people tagging the same thing the same. Removing it totally is obviously easy, but I didn't want to remove that option in case there were people that liked it. Basically, I didn't want to remove an existing feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #1 from Robin Sheat ro...@catalyst.net.nz --- *** Bug 8157 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|oleon...@myacpl.org |ro...@catalyst.net.nz --- Comment #2 from Robin Sheat ro...@catalyst.net.nz --- I plan to make a syspref that'll allow this to be turned off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #3 from Robin Sheat ro...@catalyst.net.nz --- Created attachment 9785 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9785action=edit Bug 7642 - OpacShowTagCloudWeight system preference This system preference allows the mouseover text on the tag cloud to be turned off. The text consists of the weight for the tag, but users are more likely to confuse it with the number of items that have this tag. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #4 from Robin Sheat ro...@catalyst.net.nz --- This will apply to the 3.6 (and I guess 3.8) branches happily enough, just with easy-to-fix conflicts due to changes in the prefs and database files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/