[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Blocks||14001 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Blocks||12025 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #105 from Galen Charlton --- Pushed to master, along with a follow-up to fixes UTF-8 encoding issues in the CSV export. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Kyle M Hall changed: What|Removed |Added Attachment #21971|0 |1 is obsolete|| --- Comment #103 from Kyle M Hall --- Created attachment 22209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22209&action=edit Bug 7684: QA Followup and bugfixes This followup fixes some QA issues: - replace the MySQLism SQL_CALC_FOUND_ROWS - use Koha::DateUtils instead of C4::Dates - replace "branch" and "location" with "library" - fixe wrong capitalisation on "Clear all" and "Select all" and fixes some behaviors: - the inventory tools can be used without barcode file (fixed for the csv export too). - mark as not scanned a non scanned item. - update the datelastseen 1 time per biblio (and fixes the displayed count) Signed-off-by: Mathieu Saby Signed-off-by: Koha Team Amu Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Kyle M Hall changed: What|Removed |Added Attachment #21972|0 |1 is obsolete|| --- Comment #104 from Kyle M Hall --- Created attachment 22210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22210&action=edit Bug 7684: Argument missing The cgi argument in missing for routine C4::Reports::Guided::_get_column_defs. It causes a crash on generating the CSV file. Signed-off-by: Koha Team Amu Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Kyle M Hall changed: What|Removed |Added Attachment #21970|0 |1 is obsolete|| --- Comment #102 from Kyle M Hall --- Created attachment 22208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22208&action=edit Bug 7684: multiple fixes for inventory * when a file was uploaded and the comparison with catalogue range requested, the comparison was wrong: the logic was wrong * items that were not supposed to be scanned (ie: supposed to be on another shelf) didn't had the author and title, it was hard to retrieve them on the shelved * some useful fields were missing, like homebranch, location, status * the CSV export contained all the item information. It should contain the same informations as the screen Behaviour now: * scan a list of barcode & select a range of location * if a barcode has been scanned and should not be (mis placed item), the information is displayed * if you choose "compare barcodes list to result option", the resulting list contains all items that have been scanned and those that were supposed to be. Any item not in both list appears with a specific message on the last column Signed-off-by: Leila Signed-off-by: Koha Team Amu Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Paul Poulain changed: What|Removed |Added Attachment #21440|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #101 from Koha Team AMU --- Just a problem fixed : the csv was ko. It's really better now! Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 sandbo...@biblibre.com changed: What|Removed |Added Attachment #21968|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #99 from sandbo...@biblibre.com --- Created attachment 21971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21971&action=edit Bug 7684: QA Followup and bugfixes This followup fixes some QA issues: - replace the MySQLism SQL_CALC_FOUND_ROWS - use Koha::DateUtils instead of C4::Dates - replace "branch" and "location" with "library" - fixe wrong capitalisation on "Clear all" and "Select all" and fixes some behaviors: - the inventory tools can be used without barcode file (fixed for the csv export too). - mark as not scanned a non scanned item. - update the datelastseen 1 time per biblio (and fixes the displayed count) Signed-off-by: Mathieu Saby Signed-off-by: Koha Team Amu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #100 from sandbo...@biblibre.com --- Created attachment 21972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21972&action=edit Bug 7684: Argument missing The cgi argument in missing for routine C4::Reports::Guided::_get_column_defs. It causes a crash on generating the CSV file. Signed-off-by: Koha Team Amu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #98 from sandbo...@biblibre.com --- Created attachment 21970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21970&action=edit Bug 7684: multiple fixes for inventory * when a file was uploaded and the comparison with catalogue range requested, the comparison was wrong: the logic was wrong * items that were not supposed to be scanned (ie: supposed to be on another shelf) didn't had the author and title, it was hard to retrieve them on the shelved * some useful fields were missing, like homebranch, location, status * the CSV export contained all the item information. It should contain the same informations as the screen Behaviour now: * scan a list of barcode & select a range of location * if a barcode has been scanned and should not be (mis placed item), the information is displayed * if you choose "compare barcodes list to result option", the resulting list contains all items that have been scanned and those that were supposed to be. Any item not in both list appears with a specific message on the last column Signed-off-by: Leila Signed-off-by: Koha Team Amu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 sandbo...@biblibre.com changed: What|Removed |Added Attachment #21441|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 sandbo...@biblibre.com changed: What|Removed |Added Attachment #21331|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 sandbo...@biblibre.com changed: What|Removed |Added CC||sandbo...@biblibre.com --- Comment #97 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Koha Team Amu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #96 from Jonathan Druart --- Created attachment 21968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21968&action=edit Bug 7684: Argument missing The cgi argument in missing for routine C4::Reports::Guided::_get_column_defs. It causes a crash on generating the CSV file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 mathieu saby changed: What|Removed |Added Attachment #21332|0 |1 is obsolete|| --- Comment #95 from mathieu saby --- Created attachment 21441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21441&action=edit [PATCH][SIGNED OFF] Bug 7684: QA Followup and bugfixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 mathieu saby changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #94 from mathieu saby --- Ok, I have also read the documentation on your wiki (http://wiki.koha-community.org/wiki/Inventory) Some details are only in comments on this bug, for example the way of doing an inventory split between 3 files on 3 different dates. I think I understand now the 2 fields for date and the checkbox "Compare barcodes list to results". When it is pushed the documentation for this feature will need some substantial updates. I sign off, but I make a cosmetic remark : in csv file, the message "wrong place" stands for the message "Item should not have been scanned" in staff interface. Maybe it should be the same message. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #93 from mathieu saby --- (In reply to Jonathan Druart from comment #92) > (In reply to mathieu saby from comment #91) > > But what kind of problem is "Change item status" if the item was scanned and > > if it not a surprise? Do I need to change the item status? in what way? > > Search "change item status" on this page. Koha Team AMU explains how she/he > tested the patch. > I did not read all the long discussion for this bug. I see there is a lot of informations about how to test it that were not included in the commit message, especially comment 19. That's why I lost some time. > I don't reproduce. When I click on a title, a new window is opened and point > to catalogue/MARCdetail.pl?biblionumber=XXX Ok, I tried to open in a new tab instead of just clicking... I am taking a last look at this, but it should be ok. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #92 from Jonathan Druart --- (In reply to mathieu saby from comment #91) > But what kind of problem is "Change item status" if the item was scanned and > if it not a surprise? Do I need to change the item status? in what way? Search "change item status" on this page. Koha Team AMU explains how she/he tested the patch. > [Little bug, but I think it was here before, so it could be fixed in an > other patch : when you click on a title, you don't see the record, but the > home page of inventory page.] I don't reproduce. When I click on a title, a new window is opened and point to catalogue/MARCdetail.pl?biblionumber=XXX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #91 from mathieu saby --- AHHH OK I begin to understand how it works! So the number of "entries" of the table is not the number of items. Now that I have understood that, I'm very close to sign off. But what kind of problem is "Change item status" if the item was scanned and if it not a surprise? Do I need to change the item status? in what way? [Little bug, but I think it was here before, so it could be fixed in an other patch : when you click on a title, you don't see the record, but the home page of inventory page.] Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #90 from Jonathan Druart --- (In reply to mathieu saby from comment #89) > Created attachment 21440 [details] > Double lines in table 1 line / problem. It is normal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #89 from mathieu saby --- Created attachment 21440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21440&action=edit Double lines in table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #88 from mathieu saby --- New test on Sandbox 3 with its data. There is an issue, but not the one I thought: Some lines are doubled in the table! Look at the screenshot. Operations I made : I took 33 barcodes from MAURES / Documentaires adultes, whose 8 are "Exclus du prêt" and 0 on loan. I put them in a file, inject the file in inventory tool, check the box "Exclu du prêt" List of barcodes in my file : Exclus du prêt 00519000155050 00519000177146 00519000190438 0051995587 00519000100510 00519000106178 00519000106848 00519000106855 other: 00519000153048 00519000162478 00519000163450 00519000164128 00519000164870 00519000175439 0051985356 0051998656 0051999480 0051999597 00519000108943 00519000111699 00519000120146 00519000120518 00519000120831 00519000121250 00519000121763 00519000122902 00519000140805 00519000141605 00519000142793 00519000150549 00519000151505 0051900140 0051900207 M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #87 from mathieu saby --- Maybe my data are corrupted? So I will test on a sandbox and give you all these informations. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #86 from delaye --- the test description is not quite accurate: we not know the detailed contents of the test file How many copies by status (notforlona)? How many copies borrowed? How many copies missing unread? otherwise we do not know if you checked the reference comparrer barcodes ... the patch work properly..I do not agree to change the messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 mathieu saby changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #85 from mathieu saby --- Oups, I forgot an other issue : "Item should not have been scanned" is not a good message. this items were NOT in my barcode file, were IN my database So the message should have been "Item have been scanned" Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #84 from mathieu saby --- The " was the cause of the problem... I tested without them, it is ok. Test 1 : - file with 68 barcodes from Library1 - Location 1 - compared with the collection of Library1 - Location 1 - message "68 items modified : datelastseen set to 24/09/2013" - in the table : 621 entries -- 68 items with "Change item status" in Problem column -- the other with "Item should not have been scanned" => OK Test 1 : - same file - compared with the collection of Library1 - Location 1 - checkbox checked "Exclu du prêt" (in the first column) - message "68 items modified : datelastseen set to 24/09/2013" - in the table : 129 entries -- 68 items with "Change item status" in Problem column -- the other with "Item should not have been scanned" => KO because I don't have 129 "Exclu du prêt" items in my database The query select itemnumber from items where homebranch="BU" and location ="MAG" and notforloan = 3 gives me 18 items with notforloan=3 "3" is the value of "Exclu du prêt" in authorized values lists mapped with notforloan. And indeed, in the list of 129 entries, some have "Empruntable" status... So I think something is wrong. An other point (a little detail) : maybe in english "Change item status" is not right. What about "Item status changed" or something more explicit like "Item marked seen" ? Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #83 from mathieu saby --- Note : my csv file has " " around barcode. I think the issue comes from there -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #82 from mathieu saby --- yes, barcode notfound. The query gives 1 answer Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #81 from Jonathan Druart --- (In reply to mathieu saby from comment #80) > For the table, yes > But all the barcodes of my file were in my catalog. So I should not have 68 > yellow boxes with "item not found". Did you mean "*barcode* not found"? What is the result for "SELECT * FROM items WHERE barcode = 'RETRO20-833238';"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #80 from mathieu saby --- For the table, yes But all the barcodes of my file were in my catalog. So I should not have 68 yellow boxes with "item not found". Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #79 from Jonathan Druart --- (In reply to mathieu saby from comment #77) > oups, indeed. > > "Item should have been scanned" So, it is the expected behavior. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #78 from mathieu saby --- So, I suppose ALL the items of my file were in the list of barcodes not found (in yellow boxes) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #77 from mathieu saby --- oups, indeed. "Item should have been scanned" Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #76 from Jonathan Druart --- (In reply to mathieu saby from comment #75) > Failed QA : > Some were recognized and put in the table With something in the problem column? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 mathieu saby changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #75 from mathieu saby --- Failed QA : I exported a list of barcode, put it in a file, try to use the file in inventory tool. Some barcodes were not recognized "1754773" : barcode not found "RETRO20-833237" : barcode not found "RETRO20-833257" : barcode not found "RETRO20-773337" : barcode not found "RETRO20-833238" : barcode not found "0287755958" : barcode not found Some were recognized and put in the table The issue does not seem to be the structure of barcodes (numeric or alphanumeric with "RETRO-" string before a number). Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #74 from mathieu saby --- I did not understand it was needed ;-) I will test it again today. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Attachment #21112|0 |1 is obsolete|| --- Comment #72 from Jonathan Druart --- Created attachment 21331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21331&action=edit Bug 7684: multiple fixes for inventory * when a file was uploaded and the comparison with catalogue range requested, the comparison was wrong: the logic was wrong * items that were not supposed to be scanned (ie: supposed to be on another shelf) didn't had the author and title, it was hard to retrieve them on the shelved * some useful fields were missing, like homebranch, location, status * the CSV export contained all the item information. It should contain the same informations as the screen Behaviour now: * scan a list of barcode & select a range of location * if a barcode has been scanned and should not be (mis placed item), the information is displayed * if you choose "compare barcodes list to result option", the resulting list contains all items that have been scanned and those that were supposed to be. Any item not in both list appears with a specific message on the last column Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Attachment #21206|0 |1 is obsolete|| --- Comment #73 from Jonathan Druart --- Created attachment 21332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21332&action=edit Bug 7684: QA Followup and bugfixes This followup fixes some QA issues: - replace the MySQLism SQL_CALC_FOUND_ROWS - use Koha::DateUtils instead of C4::Dates - replace "branch" and "location" with "library" - fixe wrong capitalisation on "Clear all" and "Select all" and fixes some behaviors: - the inventory tools can be used without barcode file (fixed for the csv export too). - mark as not scanned a non scanned item. - update the datelastseen 1 time per biblio (and fixes the displayed count) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Depends on|10625 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #71 from Jonathan Druart --- (In reply to Chris Cormack from comment #69) > > The patch can be tested even so. > > In that case, why don't we remove the dependency? If that is not needed for > this, then it isn't really dependent? > > If the dependency is removed, the bot can test the patches, otherwise It > can't because it can't apply the dependency. This goes for humans too, it is > confusing to be marked dependent if it isn't. The depend patch was necessary (if you want this patch applies cleanly) but since it is blocker in discussion, I will remove the dependency. (In reply to mathieu saby from comment #70) > Error while trying a read a file : > "Undefined subroutine &main::read_file called at > /home/msaby/kohamaster/src/tools/inventory.pl line 163." You didn't apply bug 10625. But I will resubmit patch without using this dependency! > Also : > - I never understood why there are 2 "inventory date" fields. Could you tell > me? > > - I never understood why there is the need to check a box for comparing the > result with a file, if we have uploaded a Barcode file. Is not it obvious? > Or I am missing something? What is supposed to happend if we upload a file > and don't check the box? Did you have a look at the wiki page? (see comment 53) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 mathieu saby changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #70 from mathieu saby --- Error while trying a read a file : "Undefined subroutine &main::read_file called at /home/msaby/kohamaster/src/tools/inventory.pl line 163." Also : - I never understood why there are 2 "inventory date" fields. Could you tell me? - I never understood why there is the need to check a box for comparing the result with a file, if we have uploaded a Barcode file. Is not it obvious? Or I am missing something? What is supposed to happend if we upload a file and don't check the box? Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Chris Cormack changed: What|Removed |Added Bot Control|--- |Ignore this bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #69 from Chris Cormack --- (In reply to Jonathan Druart from comment #68) > (In reply to I'm just a bot from comment #66) > > This bug depends on 10625 which is in status In Discussion > > The patch can be tested even so. In that case, why don't we remove the dependency? If that is not needed for this, then it isn't really dependent? If the dependency is removed, the bot can test the patches, otherwise It can't because it can't apply the dependency. This goes for humans too, it is confusing to be marked dependent if it isn't. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #68 from Jonathan Druart --- (In reply to I'm just a bot from comment #66) > This bug depends on 10625 which is in status In Discussion The patch can be tested even so. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #67 from mathieu saby --- Oups, I hope Mr. Bot is wrong? Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 I'm just a bot changed: What|Removed |Added CC||git...@bugs.koha-community. ||org --- Comment #66 from I'm just a bot --- This bug depends on 10625 which is in status In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #65 from mathieu saby --- Ok, so if I understand well, the "problem" column is always blank is we don't compare Koha's data with a barcode file. That's what I wanted to know. I'll make an other test with a file of barcode. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #64 from Jonathan Druart --- (In reply to mathieu saby from comment #62) > Same test, but only showing callnumber between 130593/5/1 and 166026/1962/2 > (my callnumber are numeric, sometimes with a slash after the main number) > 0 results > => KO for this kind of callnumbers It is not introduce by this patch, it was the previous behavior. Maybe a fix could be added later. Currently the selection is done with the sql query (itemcallnumber < ? and itemcallnumber > ?) > It looks better than before, but > - why not a column on "withdrawn" status, as it is one of the possible > filters? It could be added later too if needed. > - wot sure the callnumber filter is working well. Bug 9456 introduces a sort on callnumber values, but it is not pushed for now. > Could you remind me when the column "Problem" is supposed to show something? There are 4 possible problems: * wrong place: the item should not have been scanned * missing: if the "compare barcodes list to results" has been checked, the alert is raised if the item does not appear in the results list. * change status: if an item has been scanned with a non-matching notforloan value * not scanned: the opposite of "missing". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #63 from mathieu saby --- I know it was already tested by Marseille, but there is a looot of things to check, so I prefered make my "full" own tests. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #62 from mathieu saby --- My first test. For the moment I only try to display a list of items and mark them seen, without comparing with a barcode file Trying to see all the items of a branch and location Before patch : - need to select XX items - in the resulting table : 5 columns "Seen", "Barcode", "Title", "Unseen since", "Problems" - the problem column contains the string "None" - no way to sort the table After the patch - no more need to select XX items : all the items are listed in a dynamic table with a pager - I checked the number of results, it is correct - the pager works fine - in the resulting table : 4 more columns : "Library", "Status", "Lost", "Damaged" - no column for type of document (at item level or biblio level) - no column for withdrawn status - column library contains the name of the branch, followed by the location and the callnumber into [] : "BU En Magasin [130593/5/1]" - status contains the "translated" value of coded status : "Empruntable" for item for loan - columns are sortable. it works well - column "problem" is void. but the "none" message was useless 3 buttons on bottom of table : Mark seen and Quit, Mark seen and Continue, Continue without marking On 1st page of results, I check 2 items and click on "Mark seen and Continue". The pager shows me automaticaly the 2d page. I click on 2 more items I click on "Mark seen and Quit" I am redirected to the home page of inventory. No message confirming me that 4 items were marked seen I made a report to confirm that : the 4 items were marked seen Same test, but checking "export to csv" : data well exported (encoded in iso 8859 and not in unicode). I can see the same informations as in screen display (but 3 columns for library - location - callnumber) => OK Same test, but using the filters in inventory home page on "items.notforloan", " items.itemlost", "items.withdrawn", "items.damaged" Only the items matching my filter criteria are displayed on screen or exported to csv => OK Same test, but only showing callnumber between XA and Z (my callnumber are like A 000, A 002 B 001, B 002 ... Z 999) Only callnumbers begining with XA->XG are displayed => OK for this kind of callnumbers Same test, but only showing callnumber between 130593/5/1 and 166026/1962/2 (my callnumber are numeric, sometimes with a slash after the main number) 0 results => KO for this kind of callnumbers = It looks better than before, but - why not a column on "withdrawn" status, as it is one of the possible filters? - wot sure the callnumber filter is working well. Could you remind me when the column "Problem" is supposed to show something? I haven't try to compare the results with a file of barcode yet. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #61 from Jonathan Druart --- (In reply to mathieu saby from comment #59) > Sorry... > > > Software error: > > syntax error at /home/msaby/kohamaster/src/tools/inventory.pl line 206, near > "HEAD Oops, sorry. A conflict was not fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Attachment #21113|0 |1 is obsolete|| --- Comment #60 from Jonathan Druart --- Created attachment 21206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21206&action=edit Bug 7684: QA Followup and bugfixes This followup fixes some QA issues: - replace the MySQLism SQL_CALC_FOUND_ROWS - use Koha::DateUtils instead of C4::Dates - replace "branch" and "location" with "library" - fixe wrong capitalisation on "Clear all" and "Select all" and fixes some behaviors: - the inventory tools can be used without barcode file (fixed for the csv export too). - mark as not scanned a non scanned item. - update the datelastseen 1 time per biblio (and fixes the displayed count) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 mathieu saby changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #59 from mathieu saby --- Sorry... Software error: syntax error at /home/msaby/kohamaster/src/tools/inventory.pl line 206, near "HEAD # now build the result list: inventoried items if requested, and mis-placed items -always- my " Global symbol "$inventorylist" requires explicit package name at /home/msaby/kohamaster/src/tools/inventory.pl line 206. Global symbol "$inventorylist" requires explicit package name at /home/msaby/kohamaster/src/tools/inventory.pl line 211. Global symbol "$inventorylist" requires explicit package name at /home/msaby/kohamaster/src/tools/inventory.pl line 218. Global symbol "$inventorylist" requires explicit package name at /home/msaby/kohamaster/src/tools/inventory.pl line 259. Global symbol "$inventorylist" requires explicit package name at /home/msaby/kohamaster/src/tools/inventory.pl line 271. Global symbol "$inventorylist" requires explicit package name at /home/msaby/kohamaster/src/tools/inventory.pl line 292. BEGIN not safe after errors--compilation aborted at /home/msaby/kohamaster/src/tools/inventory.pl line 301. For help, please send mail to the webmaster (webmaster@msaby-VirtualBox), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #58 from Jonathan Druart --- Created attachment 21113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21113&action=edit Bug 7684: QA Followup and bugfixes This followup fixes some QA issues: - replace the MySQLism SQL_CALC_FOUND_ROWS - use Koha::DateUtils instead of C4::Dates - replace "branch" and "location" with "library" - fixe wrong capitalisation on "Clear all" and "Select all" and fixes some behaviors: - the inventory tools can be used without barcode file (fixed for the csv export too). - mark as not scanned a non scanned item. - update the datelastseen 1 time per biblio (and fixes the displayed count) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Attachment #20467|0 |1 is obsolete|| Attachment #20468|0 |1 is obsolete|| --- Comment #57 from Jonathan Druart --- Created attachment 21112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21112&action=edit Bug 7684: multiple fixes for inventory * when a file was uploaded and the comparison with catalogue range requested, the comparison was wrong: the logic was wrong * items that were not supposed to be scanned (ie: supposed to be on another shelf) didn't had the author and title, it was hard to retrieve them on the shelved * some useful fields were missing, like homebranch, location, status * the CSV export contained all the item information. It should contain the same informations as the screen Behaviour now: * scan a list of barcode & select a range of location * if a barcode has been scanned and should not be (mis placed item), the information is displayed * if you choose "compare barcodes list to result option", the resulting list contains all items that have been scanned and those that were supposed to be. Any item not in both list appears with a specific message on the last column Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 mathieu saby changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #56 from mathieu saby --- Sorry, main patch does not apply Applying: Bug 7684: multiple fixes for inventory fatal: sha1 information is lacking or useless (tools/inventory.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7684: multiple fixes for inventory Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Attachment #19215|0 |1 is obsolete|| --- Comment #55 from Jonathan Druart --- Created attachment 20468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20468&action=edit Bug 7684: QA Followup and bugfixes This followup fixes some QA issues: - replace the MySQLism SQL_CALC_FOUND_ROWS - use Koha::DateUtils instead of C4::Dates - replace "branch" and "location" with "library" - fixe wrong capitalisation on "Clear all" and "Select all" and fixes some behaviors: - the inventory tools can be used without barcode file (fixed for the csv export too). - mark as not scanned a non scanned item. - update the datelastseen 1 time per biblio (and fixes the displayed count) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Attachment #18705|0 |1 is obsolete|| --- Comment #54 from Jonathan Druart --- Created attachment 20467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20467&action=edit Bug 7684: multiple fixes for inventory * when a file was uploaded and the comparison with catalogue range requested, the comparison was wrong: the logic was wrong * items that were not supposed to be scanned (ie: supposed to be on another shelf) didn't had the author and title, it was hard to retrieve them on the shelved * some useful fields were missing, like homebranch, location, status * the CSV export contained all the item information. It should contain the same informations as the screen Behaviour now: * scan a list of barcode & select a range of location * if a barcode has been scanned and should not be (mis placed item), the information is displayed * if you choose "compare barcodes list to result option", the resulting list contains all items that have been scanned and those that were supposed to be. Any item not in both list appears with a specific message on the last column Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Depends on||10625 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Assignee|matthias.meusburger@biblibr |jonathan.dru...@biblibre.co |e.com |m --- Comment #53 from Jonathan Druart --- A wiki page has been created: http://wiki.koha-community.org/wiki/Inventory -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Attachment #18706|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Attachment #16484|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #52 from Jonathan Druart --- Created attachment 19215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19215&action=edit Bug 7684: QA Followup and bugfixes This followup fixes some QA issues: - replace the MySQLism SQL_CALC_FOUND_ROWS - use Koha::DateUtils instead of C4::Dates - replace "branch" and "location" with "library" - fixe wrong capitalisation on "Clear all" and "Select all" and fixes some behaviors: - the inventory tools can be used without barcode file (fixed for the csv export too). - mark as not scanned a non scanned item. - update the datelastseen 1 time per biblio (and fixes the displayed count) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Sonia Lemaire changed: What|Removed |Added CC||sonia.lema...@biblibre.com --- Comment #51 from Sonia Lemaire --- I tested the patch using the two ways of making an inventory. The first way, by comparing a barcode file with a list of results : - I upload a barcode file - I select the library and the shelving location of the items I want to check - I choose the statuses of the items - I check the box “skip copies on loan” - I check the box “export to CSV file” - I check the box “compare barcodes list to results” Ok for items on loan : they have been checked in. Ok for misplaced items : marked as “should not have been scanned” on the screen and “wrong place” in the CSV file. Ok for wrong status : a notforloan item which should not be on the shelf is marked as “change item status” in both the online report and the CSV file. Ok for unknown barcode (scan error or item not found in koha) : marked as “barcode not found” ok for setting datelastseen to the inventory date Ok for CSV export Not ok : missing item : if a barcode has not been scanned when it should have been, it is ignored by the tool and no problem is reported. The second way, by creating a list of items to be checked “manually” - I select the library and the shelving location of the items I want to check - I choose the statuses of the items - I check the box “export to CSV file” As Mathieu Saby notes, it doesn't work. No list is created, neither on the online report, nor in the CSV file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 mathieu saby changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #50 from mathieu saby --- Hello This patch is needed, but I fear it broke something : If I use inventory module to export all the items of my library (all locations), without comparing the result with a file of barcode : A. Without the patch : I get a list of 944 records B. With the patch : 0 records (whatever boxes I check in statuses list...) M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 mathieu saby changed: What|Removed |Added CC||mathieu.saby@univ-rennes2.f ||r -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #49 from Jonathan Druart --- Note: The following qa fail seems to be a false positive: FAILC4/Items.pm FAIL pod *** WARNING: No items in =over / =back list in file C4/Items.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #48 from Jonathan Druart --- First patch has been amended in order to fix some QA issues (whitespaces and tabulations) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Attachment #17844|0 |1 is obsolete|| --- Comment #46 from Jonathan Druart --- Created attachment 18705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18705&action=edit Bug 7684: multiple fixes for inventory * when a file was uploaded and the comparison with catalogue range requested, the comparison was wrong: the logic was wrong * items that were not supposed to be scanned (ie: supposed to be on another shelf) didn't had the author and title, it was hard to retrieve them on the shelved * some useful fields were missing, like homebranch, location, status * the CSV export contained all the item information. It should contain the same informations as the screen Behaviour now: * scan a list of barcode & select a range of location * if a barcode has been scanned and should not be (mis placed item), the information is displayed * if you choose "compare barcodes list to result option", the resulting list contains all items that have been scanned and those that were supposed to be. Any item not in both list appears with a specific message on the last column Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #47 from Jonathan Druart --- Created attachment 18706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18706&action=edit Bug 7684: QA Followup This followup: - replaces the MySQLism SQL_CALC_FOUND_ROWS - uses Koha::DateUtils instead of C4::Dates - replaces "branch" and "location" with "library" - fixes wrong capitalisation on "Clear all" and "Select all" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #45 from Katrin Fischer --- Hi Matthias, looking again at your answers ant the new patch I still spot some problems: 1) Yes, I think it's worth it. We should not introduce new MySQLisms. 4) C4:Dates is deprecated as we are trying to get rid of it in favour of the new modules. Also I was wondering about the display of dates in the templates, it looks to me like this line should be using the TT plugin? +[% IF (moddatecount) %][% moddatecount %] items modified : datelastseen set to [% date %][% END %] 5) Terms might be wrong already, but it would be good to always use 'library' instead of branch or location when it's actually referring to home branch, holding branch etc. in the database. 6) There are some terms where capitalization is wrong: Clear All etc. Sorry :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Matthias Meusburger changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #44 from Matthias Meusburger --- Katrin, here are my answers to your remarks: 1) I could rewrite this without the SELECT SQL_CALC_FOUND_ROWS part, but it would be an important loss of performance (because I would have to relaunch the main time-consuming request a second time)... So is it worth it? (and I say that even though I know we're trying to get rid of mysqlisms) 2) This feature is not longer necessary, as the use of datatable for the results allows the user to change pagination and offset once the results are here. 3) Indeed. Removed. 4) The calendars are using datepicker, the DHTMLCalendar line was a leftover, it has been removed. As for the dates, since the calendars are used to set items.datelastseen, which is a date, and not a datetime, does it make sense to use Koha::DateUtils instead of C4::Dates? 5) For the terms used, I kept the ones from HEAD when I rebased, so it might be ok now? Also, fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Matthias Meusburger changed: What|Removed |Added Attachment #17841|0 |1 is obsolete|| --- Comment #43 from Matthias Meusburger --- Created attachment 17844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17844&action=edit Bug 7684: multiple fixes for inventory * when a file was uploaded and the comparison with catalogue range requested, the comparison was wrong: the logic was wrong * items that were not supposed to be scanned (ie: supposed to be on another shelf) didn't had the author and title, it was hard to retrieve them on the shelved * some useful fields were missing, like homebranch, location, status * the CSV export contained all the item information. It should contain the same informations as the screen Behaviour now: * scan a list of barcode & select a range of location * if a barcode has been scanned and should not be (mis placed item), the information is displayed * if you choose "compare barcodes list to result option", the resulting list contains all items that have been scanned and those that were supposed to be. Any item not in both list appears with a specific message on the last column Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #42 from Matthias Meusburger --- previous patch is a rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Matthias Meusburger changed: What|Removed |Added Attachment #16598|0 |1 is obsolete|| --- Comment #41 from Matthias Meusburger --- Created attachment 17841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17841&action=edit Bug 7684: multiple fixes for inventory * when a file was uploaded and the comparison with catalogue range requested, the comparison was wrong: the logic was wrong * items that were not supposed to be scanned (ie: supposed to be on another shelf) didn't had the author and title, it was hard to retrieve them on the shelved * some useful fields were missing, like homebranch, location, status * the CSV export contained all the item information. It should contain the same informations as the screen Behaviour now: * scan a list of barcode & select a range of location * if a barcode has been scanned and should not be (mis placed item), the information is displayed * if you choose "compare barcodes list to result option", the resulting list contains all items that have been scanned and those that were supposed to be. Any item not in both list appears with a specific message on the last column Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #40 from Katrin Fischer --- Hi Matthias, I finally got to look at this, but I spotted some problems with the patch. I think they might stem from this development being based on an older version of Koha. The major things I found are: 1) You are using SELECT SQL_CALC_FOUND_ROWS which is a MySQLism. Please can you rewrite that part? 2) I think you remove an existing feature as I can't see where this is added back in: -Show: - items - Beginning at offset: - - 3) There are changes related to authentication that don't seem to belong into this patch? 4) The calendar related code seems to be based on older code, using C4:Dates and i spotted one DHTML... - could you take a look? 5) There are some problems with the templates, like capitalization, terms used and the id in the body going missing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #39 from Katrin Fischer --- Some small things found by the QA script: QA SCRIPT testing 1 commit(s) (applied to 9c79f18 'Merge branch 'bug_10088' into 3.14-ma') 5fa6a41 Bug 7684: multiple fixes for inventory - C4/Auth.pm - C4/Items.pm - C4/Templates.pm - koha-tmpl/intranet-tmpl/prog/en/columns.def - koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt - tools/ajax-inventory.pl - tools/inventory.pl * C4/Auth.pm OK pod OK forbidden patterns OK valid OK critic OK * C4/Items.pm FAIL pod FAIL *** WARNING: No items in =over / =back list in file C4/Items.pm forbidden patterns OK valid OK critic OK * C4/Templates.pm OK pod OK forbidden patterns OK valid OK critic OK * tools/ajax-inventory.pl OK pod OK forbidden patterns OK valid OK critic OK * tools/inventory.pl FAIL pod OK forbidden patterns FAIL The patch introduces a forbidden pattern: tabulation character (346) The patch introduces a forbidden pattern: tabulation character (345) The patch introduces a forbidden pattern: tabulation character (342) The patch introduces a forbidden pattern: tabulation character (347) The patch introduces a forbidden pattern: tabulation character (344) The patch introduces a forbidden pattern: tabulation character (348) The patch introduces a forbidden pattern: tabulation character (343) valid OK critic OK * koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: tabulation character (209) The patch introduces a forbidden pattern: tabulation character (21) The patch introduces a forbidden pattern: tabulation character (260) The patch introduces a forbidden pattern: tabulation character (19) tt_validOK valid_template OK Please fix and provide a QA follow up. I will continue testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #38 from Jonathan Druart --- (In reply to comment #37) > Hi Team AMU, > could you write up some more detailed test plan with steps for me? This bug > has quite a long history now and it would make testing easier for me as I > have not much experience in using the inventory tool. Katrin, A test plan had provided on comment 19, isn't enough? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Katrin Fischer changed: What|Removed |Added Assignee|gmcha...@gmail.com |matthias.meusburger@biblibr ||e.com --- Comment #37 from Katrin Fischer --- Hi Team AMU, could you write up some more detailed test plan with steps for me? This bug has quite a long history now and it would make testing easier for me as I have not much experience in using the inventory tool. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|3.8 |master Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #36 from Koha Team AMU --- It's all right. Thanks! OK Missing item, column A of the csv, no column M, mark seen and continue About the link from the title - if one clicks with the left button : pop up opens on the catalog page - if one clicks with the middle button : new page opens on the inventory tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #35 from Paul Poulain --- Created attachment 16598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16598&action=edit Bug 7684: multiple fixes for inventory * when a file was uploaded and the comparison with catalogue range requested, the comparison was wrong: the logic was wrong * items that were not supposed to be scanned (ie: supposed to be on another shelf) didn't had the author and title, it was hard to retrieve them on the shelved * some useful fields were missing, like homebranch, location, status * the CSV export contained all the item information. It should contain the same informations as the screen Behaviour now: * scan a list of barcode & select a range of location * if a barcode has been scanned and should not be (mis placed item), the information is displayed * if you choose "compare barcodes list to result option", the resulting list contains all items that have been scanned and those that were supposed to be. Any item not in both list appears with a specific message on the last column Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Paul Poulain changed: What|Removed |Added Attachment #16594|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Paul Poulain changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||paul.poul...@biblibre.com --- Comment #34 from Paul Poulain --- Patch tested with a sandbox, by Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Matthias Meusburger changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #33 from Matthias Meusburger --- All OK fixed. As for the question, it is indeed a link to the record, but in a new window, so the inventory page is not replaced. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Matthias Meusburger changed: What|Removed |Added Attachment #16541|0 |1 is obsolete|| --- Comment #32 from Matthias Meusburger --- Created attachment 16594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16594&action=edit Bug 7684: multiple fixes for inventory * when a file was uploaded and the comparison with catalogue range requested, the comparison was wrong: the logic was wrong * items that were not supposed to be scanned (ie: supposed to be on another shelf) didn't had the author and title, it was hard to retrieve them on the shelved * some useful fields were missing, like homebranch, location, status * the CSV export contained all the item information. It should contain the same informations as the screen Behaviour now: * scan a list of barcode & select a range of location * if a barcode has been scanned and should not be (mis placed item), the information is displayed * if you choose "compare barcodes list to result option", the resulting list contains all items that have been scanned and those that were supposed to be. Any item not in both list appears with a specific message on the last column -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #31 from Koha Team AMU --- A question : the link on the title (in the online report) shouldn't it lead to the catalog? http://pro.test3.biblibre.com/cgi-bin/koha/catalogue/detail.pl?biblionumber=1 (the real biblionumber) instead of http://pro.test3.biblibre.com/cgi-bin/koha/tools/inventory.pl# -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #30 from Koha Team AMU --- OK "item should not have been scanned" and "change item status" OK description of the notforloan OK barcode not found OK title and author for all items OK csv KO missing item : no missing item! (neither in csv, nor on line). So : "mark seen and continue" can not be tested. KO csv column A : no title And in the csv, an item with the wrong status and the wrong location is twice, but the second time with the 2 reasons. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #29 from Matthias Meusburger --- This new patch fixes "wrong place" and adds separate lines when an item is in "wrong place" *and* "change item status". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
