[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #48 from Fridolin Somers  ---
Does not apply on 20.11.x because patches apply on code of Bug 28273

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||28273
 CC||fridolin.som...@biblibre.co
   ||m


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273
[Bug 28273] Multi-holds allow invalid pickup locations
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall  changed:

   What|Removed |Added

 Version(s)|21.11.00|21.11.00,21.05.04
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #47 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #46 from Jonathan Druart  ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||21.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #123814|0   |1
is obsolete||

--- Comment #45 from Katrin Fischer  ---
Created attachment 124235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124235=edit
Bug 7703: (follow-up) Treat no items like none available

This patch modifies the holds template so that during the
multi-hold process, titles with no items attached are treated the same
way as titles with no items available (items exist but cannot be place
don hold):

 - The row showing such a record will say "No items are available to be
placed on hold."
 - The pickup location dropdown will be hidden.

To test, follow the previous test plan and confirm that these change are
reflected. Now that the pickup location field isn't present for titles
without items you should be able to complete the holds process.

Signed-off-by: Sally 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #123813|0   |1
is obsolete||

--- Comment #44 from Katrin Fischer  ---
Created attachment 124234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124234=edit
Bug 7703: (QA follow-up)

Revised test plan from Owen:

This patch modifies the hold process so that if one of the titles in a
multi-hold process has no items the process doesn't abort completely.

To test, apply the patch and perform a search in the catalog which will
return one or more records with no items attached.

 - Check checkboxes for multiple results, some of which have items and
   at least one of which has no items.
 - Click "Place hold."
 - You should be taken to the page for placing multiple holds, with a
   heading, "Cannot place hold on some items."
 - Note: You will not be able to complete the holds process without the
   next patch.

Signed-off-by: Owen Leonard 

Signed-off-by: Sally 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #123812|0   |1
is obsolete||

--- Comment #43 from Katrin Fischer  ---
Created attachment 124233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124233=edit
Bug 7703: Don't block bulk hold action on search results if some items can't be
placed on hold

If you select multiple titles on the search results page in order to
place a bulk hold and some of those titles have no items you get a
JavaScript alert warning you can some cannot be placed on hold. You are
blocked from completing the action until you deselect the invalid hold.

This is unnecessary because the bulk hold process will safely refuse to
place a hold on these titles later in the process.

This patch removes the check that prevents submitting a multi-hold if
one or more records in the multi-hold have no items.

Test plan:
1) Apply patch
2) On the staff interface, do a search
3) On the search results, select at least one record with items and one
   record with no items.
4) Click the 'Place hold' button.
5) You should be redirected to reserve/request.pl with the message
   "Cannot place hold: this record has no items attached."

Signed-off-by: Owen Leonard 

Signed-off-by: Sally 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #42 from Katrin Fischer  ---
Maybe something for another bug: we could stop the process, if there are no
options for placing holds - like all records selected have no items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Sally  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sally.healey@cheshireshared
   ||services.gov.uk

--- Comment #41 from Sally  ---
Works well, big improvement - thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #123577|0   |1
is obsolete||

--- Comment #40 from Kyle M Hall  ---
Created attachment 123814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123814=edit
Bug 7703: (follow-up) Treat no items like none available

This patch modifies the holds template so that during the
multi-hold process, titles with no items attached are treated the same
way as titles with no items available (items exist but cannot be place
don hold):

 - The row showing such a record will say "No items are available to be
placed on hold."
 - The pickup location dropdown will be hidden.

To test, follow the previous test plan and confirm that these change are
reflected. Now that the pickup location field isn't present for titles
without items you should be able to complete the holds process.

Signed-off-by: Sally 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #123576|0   |1
is obsolete||

--- Comment #39 from Kyle M Hall  ---
Created attachment 123813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123813=edit
Bug 7703: (QA follow-up)

Revised test plan from Owen:

This patch modifies the hold process so that if one of the titles in a
multi-hold process has no items the process doesn't abort completely.

To test, apply the patch and perform a search in the catalog which will
return one or more records with no items attached.

 - Check checkboxes for multiple results, some of which have items and
   at least one of which has no items.
 - Click "Place hold."
 - You should be taken to the page for placing multiple holds, with a
   heading, "Cannot place hold on some items."
 - Note: You will not be able to complete the holds process without the
   next patch.

Signed-off-by: Owen Leonard 

Signed-off-by: Sally 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #123575|0   |1
is obsolete||

--- Comment #38 from Kyle M Hall  ---
Created attachment 123812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123812=edit
Bug 7703: Don't block bulk hold action on search results if some items can't be
placed on hold

If you select multiple titles on the search results page in order to
place a bulk hold and some of those titles have no items you get a
JavaScript alert warning you can some cannot be placed on hold. You are
blocked from completing the action until you deselect the invalid hold.

This is unnecessary because the bulk hold process will safely refuse to
place a hold on these titles later in the process.

This patch removes the check that prevents submitting a multi-hold if
one or more records in the multi-hold have no items.

Test plan:
1) Apply patch
2) On the staff interface, do a search
3) On the search results, select at least one record with items and one
   record with no items.
4) Click the 'Place hold' button.
5) You should be redirected to reserve/request.pl with the message
   "Cannot place hold: this record has no items attached."

Signed-off-by: Owen Leonard 

Signed-off-by: Sally 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #37 from Owen Leonard  ---
Created attachment 123577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123577=edit
Bug 7703: (follow-up) Treat no items like none available

This patch modifies the holds template so that during the
multi-hold process, titles with no items attached are treated the same
way as titles with no items available (items exist but cannot be place
don hold):

 - The row showing such a record will say "No items are available to be
placed on hold."
 - The pickup location dropdown will be hidden.

To test, follow the previous test plan and confirm that these change are
reflected. Now that the pickup location field isn't present for titles
without items you should be able to complete the holds process.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #36 from Owen Leonard  ---
Created attachment 123576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123576=edit
Bug 7703: (QA follow-up)

Revised test plan from Owen:

This patch modifies the hold process so that if one of the titles in a
multi-hold process has no items the process doesn't abort completely.

To test, apply the patch and perform a search in the catalog which will
return one or more records with no items attached.

 - Check checkboxes for multiple results, some of which have items and
   at least one of which has no items.
 - Click "Place hold."
 - You should be taken to the page for placing multiple holds, with a
   heading, "Cannot place hold on some items."
 - Note: You will not be able to complete the holds process without the
   next patch.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Owen Leonard  changed:

   What|Removed |Added

  Attachment #52166|0   |1
is obsolete||
  Attachment #52295|0   |1
is obsolete||
  Attachment #52296|0   |1
is obsolete||

--- Comment #35 from Owen Leonard  ---
Created attachment 123575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123575=edit
Bug 7703: Don't block bulk hold action on search results if some items can't be
placed on hold

If you select multiple titles on the search results page in order to
place a bulk hold and some of those titles have no items you get a
JavaScript alert warning you can some cannot be placed on hold. You are
blocked from completing the action until you deselect the invalid hold.

This is unnecessary because the bulk hold process will safely refuse to
place a hold on these titles later in the process.

This patch removes the check that prevents submitting a multi-hold if
one or more records in the multi-hold have no items.

Test plan:
1) Apply patch
2) On the staff interface, do a search
3) On the search results, select at least one record with items and one
   record with no items.
4) Click the 'Place hold' button.
5) You should be redirected to reserve/request.pl with the message
   "Cannot place hold: this record has no items attached."

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #32 from Kyle M Hall  ---
Thanks Srdjan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #14435|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #52168|0   |1
is obsolete||

--- Comment #31 from Srdjan Jankovic  ---
Created attachment 52296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52296=edit
[SIGNED-OFF] Bug 7703 - QA Followup 2

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #52167|0   |1
is obsolete||

--- Comment #30 from Srdjan Jankovic  ---
Created attachment 52295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52295=edit
[SIGNED-OFF] Bug 7703 - QA Followup

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #29 from Jonathan Druart  
---
Only the first patch has been signed off and it was 3 years ago.
It sounds safe to request another signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #26 from Kyle M Hall  ---
Created attachment 52166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52166=edit
Bug 7703 - Don't block bulk hold action if some items can't be placed on hold

If you select multiple titles on the search results page in order to
place a bulk hold and some of those titles have no items you get a
JavaScript alert warning you can some cannot be placed on hold. You are
blocked from completing the action until you deselect the invalid hold.

This is unnecessary because the bulk hold process will safely refuse to
place a hold on these titles later in the process.

This patch removes the check that prevents submitting a multi-hold if
one or more records in the multi-hold have no items.

Test plan:
1) Apply patch
2) On the staff interface, do a search
3) On the search results, select at least one record with items and one
record with no items.
4) Click the 'Place hold' button.
5) You should be redirected to reserve/request.pl with the message
"Cannot place hold: this record has no items attached."

Signed-off-by: Owen Leonard 

Added a description of the problem and copied the test plan from the bug
report, fulfilling commit message guidelines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #28144|0   |1
is obsolete||

--- Comment #28 from Kyle M Hall  ---
Created attachment 52168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52168=edit
Bug 7703 - QA Followup 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #19115|0   |1
is obsolete||

--- Comment #27 from Kyle M Hall  ---
Created attachment 52167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52167=edit
Bug 7703 - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #25 from Owen Leonard  ---
This bug is still valid in master as of 21 Dec 2015.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #24 from Marc Véron  ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #23 from Owen Leonard oleon...@myacpl.org ---
Applying: Bug 7703 - Don't block bulk hold action if some items can't be placed
on hold
Applying: Bug 7703 - QA Followup
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging C4/Items.pm
CONFLICT (content): Merge conflict in C4/Items.pm
Auto-merging C4/Biblio.pm
CONFLICT (content): Merge conflict in C4/Biblio.pm
Failed to merge in the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #21 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28144
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28144action=edit
Bug 7703 - QA Followup 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #22 from Kyle M Hall k...@bywatersolutions.com ---
I'm getting very strange behavior from the holds system at the moment. Could
someone please test with this new followup?

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

--- Comment #20 from Owen Leonard oleon...@myacpl.org ---
(In reply to Jonathan Druart from comment #19)
 Moreover, the
 message Cannot place hold: this record has no items attached. appears on a
 blank page (without back button or something else).

This issue does make it Failed QA, because the point of the bug is to make it
possible to continue to place a hold on those titles which do have items
attached even if the user also selected some which have no items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #16 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19114
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19114action=edit
Bug 7703 - Don't block bulk hold action if some items can't be placed on hold

If you select multiple titles on the search results page in order to
place a bulk hold and some of those titles have no items you get a
JavaScript alert warning you can some cannot be placed on hold. You are
blocked from completing the action until you deselect the invalid hold.

This is unnecessary because the bulk hold process will safely refuse to
place a hold on these titles later in the process.

This patch removes the check that prevents submitting a multi-hold if
one or more records in the multi-hold have no items.

Test plan:
1) Apply patch
2) On the staff interface, do a search
3) On the search results, select at least one record with items and one
record with no items.
4) Click the 'Place hold' button.
5) You should be redirected to reserve/request.pl with the message
Cannot place hold: this record has no items attached.

Signed-off-by: Owen Leonard oleon...@myacpl.org

Added a description of the problem and copied the test plan from the bug
report, fulfilling commit message guidelines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19114|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #17 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19115
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19115action=edit
Bug 7703 - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #18 from Kyle M Hall k...@bywatersolutions.com ---
I was able to recreate your issue, and I've attached a followup I think will
resolve it!

(In reply to comment #15)
 Created attachment 15290 [details]
 Biblio without item
 
 Hi Kyle,
 This biblio contains no item.
 When I search 'vifs', this title appears on the first page of results.
 I click on the checkbox and on the place holds' button.
 I still got the same error.
 
 reserve/request.pl: I pass into the following if statement:
 if (!@itemnumbers) {
 $template-param('noitems' = 1);
 $biblioloopiter{noitems} = 1;
 }
 and just after the GetItemInfosOf routine is called with @itemnumbers which
 is empty.
 I think we want to skip the current biblionumber if it does not contain any
 item. But maybe we want to raise this problem for the user too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com ---
Kyle, thanks for the followup, it fixes the issue.

Owen, why the current behavior is an issue? Is not it better to raise a
javascript warning? The current behavior avoid a page to load. Moreover, the
message Cannot place hold: this record has no items attached. appears on a
blank page (without back button or something else). I think it is not
convincing.

Switch to in discussion (because it is not really a failed qa, but need more
explanation).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 15290
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15290action=edit
Biblio without item

Hi Kyle,
This biblio contains no item.
When I search 'vifs', this title appears on the first page of results.
I click on the checkbox and on the place holds' button.
I still got the same error.

reserve/request.pl: I pass into the following if statement:
if (!@itemnumbers) {
$template-param('noitems' = 1);
$biblioloopiter{noitems} = 1;
}
and just after the GetItemInfosOf routine is called with @itemnumbers which is
empty.
I think we want to skip the current biblionumber if it does not contain any
item. But maybe we want to raise this problem for the user too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #14 from Kyle M Hall k...@bywatersolutions.com ---
Jonathan, I cannot recreate your error. When I try placing a hold on a bib with
no items I get the correct behavior as described. Do you think you could
provide me with some more info and perhaps re-test it?


(In reply to comment #13)
 QA Comment:
 
 I got an error:
 
 DBD::mysql::st execute failed: You have an error in your SQL syntax; check
 the manual that corresponds to your MySQL server version for the right
 syntax to use near ')' at line 3 at /home/koha/src/C4/Koha.pm line 833.
 
 Debug: request.pl l.320, the @itemnumbers is empty
 
 The issue appears when I place on hold a biblio without item.
 
 Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@biblibre.co
   ||m
 QA Contact|koha.sek...@gmail.com   |jonathan.dru...@biblibre.co
   ||m

--- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA Comment:

I got an error:

DBD::mysql::st execute failed: You have an error in your SQL syntax; check the
manual that corresponds to your MySQL server version for the right syntax to
use near ')' at line 3 at /home/koha/src/C4/Koha.pm line 833.

Debug: request.pl l.320, the @itemnumbers is empty

The issue appears when I place on hold a biblio without item.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #14360|0   |1
is obsolete||

--- Comment #12 from Owen Leonard oleon...@myacpl.org ---
Created attachment 14435
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14435action=edit
[SIGNED-OFF] Bug 7703 - Don't block bulk hold action if some items can't be
placed on hold

If you select multiple titles on the search results page in order to
place a bulk hold and some of those titles have no items you get a
JavaScript alert warning you can some cannot be placed on hold. You are
blocked from completing the action until you deselect the invalid hold.

This is unnecessary because the bulk hold process will safely refuse to
place a hold on these titles later in the process.

This patch removes the check that prevents submitting a multi-hold if
one or more records in the multi-hold have no items.

Test plan:
1) Apply patch
2) On the staff interface, do a search
3) On the search results, select at least one record with items and one
record with no items.
4) Click the 'Place hold' button.
5) You should be redirected to reserve/request.pl with the message
Cannot place hold: this record has no items attached.

Signed-off-by: Owen Leonard oleon...@myacpl.org

Added a description of the problem and copied the test plan from the bug
report, fulfilling commit message guidelines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Blocks||9336

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Blocks||9350

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #7 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to comment #6)
 Kyle, should the patch on this bug be moved to a new bug and the status of
 this bug changed back to ASSIGNED?

I think we need to move this patch to a new bug.

Kyle

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Attachment #9613|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall k...@bywatersolutions.com ---
Comment on attachment 9613
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9613
Bug 7703 - Don't block bulk hold action on search results if some items can't
be placed on hold

Moved to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9336

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #9 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14360
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14360action=edit
Bug 7703 - Don't block bulk hold action on search results if some items can't
be placed on hold

Remove the check that prevents submitting a multi-hold if one or more
records in the multi-hold have no items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #10 from Kyle M Hall k...@bywatersolutions.com ---
With the patch, attempting to place a multi-hold where one of the records has
no items results in the following message on reserve/request.pl

Cannot place hold: this record has no items attached.

Is this the expected behavior?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #11 from Kyle M Hall k...@bywatersolutions.com ---
Test plan:
1) Apply patch
2) On the staff interface, do a search
3) On the search results, select at least one record with items and one record
with no items.
4) Click the 'Place hold' button.
5) You should be redirected to reserve/request.pl with the message Cannot
place hold: this record has no items attached.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #6 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Kyle, should the patch on this bug be moved to a new bug and the status of this
bug changed back to ASSIGNED?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #5 from Owen Leonard oleon...@myacpl.org ---
I'm not sure what problem this patch is trying to address, but it doesn't
address the problem I'm trying to describe in this bug. My problem is related
to the catalog search results screen. In the staff client, perform a search
which will return a result set which includes at least one record with no
items. Select all results and click place hold. The operation will be blocked
with the error One or more selected items cannot be placed on hold. Since
request.pl can already sensibly handle multiple holds in this situation it
doesn't make sense for the results screen to block the operation.

Marking Failed QA because the patch doesn't match the bug, but perhaps the
patch belongs on a new bug with a different description?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #2 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 9613
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9613action=edit
Bug 7703 - Don't block bulk hold action on search results if some items can't
be placed on hold

In the staff client if you check multiple lines in search results and click
the button to place hold you might be blocked from proceeding because
One or more selected items cannot be placed on hold. The next stage of the
holds process is perfectly capable of warning the user about such problems.
The user should not have to search back through the list of items they
checked to find which one to un-check.

Fixed by not disabling the submit button in the event that one
of the records has no holdable items. Updated text of submit
buttons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #3 from Kyle M Hall kyle.m.h...@gmail.com ---
On a tangentially connected note, disabled buttons in Koha appear no different
than enabled buttons. We should really have some CSS in Koha to make disabled
buttons distinguishable from enabled ones.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I think normally we don't show a button, if it is not available. We also hide
areas and pages, that are not available because of missing permissions. Links
in pull down menus can be greyed out sometimes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
*** Bug 8097 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/