[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-10-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-05-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

--- Comment #19 from Paul Poulain  ---
QA comment for the typo patch provided by Colin: 1 line patch, fixes an evident
mistake that could/should have been detected before !

passed QA & pushed on branch 7949

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

--- Comment #18 from Colin Campbell  ---
Created attachment 9284
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9284&action=edit
Fix typo in patch as applied

There is a typo in the patch that causes a number of runtime warnings in make
test and will have an effect as the returned value of type is always
overwritten

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Paul Poulain  changed:

   What|Removed |Added

Version|master  |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #17 from Paul Poulain  ---
OK, the patch applies ! I made some tests, and even if I couldn't check the
patch work well because my configuration has no hourly rules nor fines, I could
do check-ins without any problem.

I also checked the code, and it looks logical.

patch pushed, please double check, i'm a little bit uncomfortable with pushing
such a patch 3 days before a release...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Elliott Davis  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Elliott Davis  changed:

   What|Removed |Added

   Attachment #8907|0   |1
is obsolete||
   Attachment #9012|0   |1
is obsolete||

--- Comment #16 from Elliott Davis  ---
Created attachment 9231
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9231&action=edit
Adds instant fine calculation

This should (hopefully) resolve the spacing issue Paul was seeing.  Also
rebased to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

--- Comment #15 from Paul Poulain  ---
mmm... something goes wrong:

When I apply those patches:
* the 1st does not apply, there's a tiny conflict in use, that I think I can
fix easily
* the 2nd one apply smoothly, BUT,

circ/circulation-home.pl gives me a bad:

syntax error at /home/paul/koha.dev/koha-community/C4/Circulation.pm line 1620,
near ") ) "
Global symbol "$amount" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1624.
Global symbol "$type" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1624.
Global symbol "$borrowernumber" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1628.
Global symbol "$item" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1628.
Global symbol "$circControlBranch" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1628.
Global symbol "$borrower" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1628.
Global symbol "$messages" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1629.
syntax error at /home/paul/koha.dev/koha-community/C4/Circulation.pm line 1630,
near "}"
Global symbol "$issue" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1632.
Global symbol "$item" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1632.
Global symbol "$item" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1637.
Global symbol "$branch" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1637.
Global symbol "$branch" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1638.
Global symbol "$item" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1638.
Global symbol "$item" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1639.
Global symbol "$branch" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1639.
syntax error at /home/paul/koha.dev/koha-community/C4/Circulation.pm line 1640,
near "}"
/home/paul/koha.dev/koha-community/C4/Circulation.pm has too many errors.
Compilation failed in require at
/home/paul/koha.dev/koha-community/C4/Overdues.pm line 26.
BEGIN failed--compilation aborted at
/home/paul/koha.dev/koha-community/C4/Overdues.pm line 26.
Compilation failed in require at
/home/paul/koha.dev/koha-community/C4/Members.pm line 30.
BEGIN failed--compilation aborted at
/home/paul/koha.dev/koha-community/C4/Members.pm line 30.

Looking at the patch, I don't understand what's happening :'(

You've submitted the patch with tabs, and i've set a git rule to transform them
to spaces. My supposition is that something went wrong with this.
Could you resubmit your patch with spaces instead of tab please ?
(switch back to passed QA once you've submitted)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Elliott Davis  changed:

   What|Removed |Added

   Attachment #8879|0   |1
is obsolete||

--- Comment #14 from Elliott Davis  ---
Created attachment 9012
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9012&action=edit
Patch to add instant fine calculation

This patch has the updated commit message.  Sorry for the confusion, I had a
slight git snafu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

--- Comment #13 from Paul Poulain  ---
mmm... I think there is a small mistake in this patch, so, to avoid addin one
by pushing something wrong, I prefer to ask:
The attachment http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8879
says
From: Elliott Davis 
Date: Thu, 29 Mar 2012 20:05:10 +
Subject: [PATCH 2/2] updateing whitespace changes

But I don't see the [PATCH 1/2]

Looking at (obsoleted) attachment 8781, the commit message is:
From: Elliott Davis 
Date: Thu, 29 Mar 2012 20:05:10 +
Subject: [PATCH] [Signed-Off] Adds instant fine calculation at checkin

http://bugs.koha-community.org/show_bug.cgi?id=7849
Signed-off-by: Kyle M Hall 

I feel it's just the commit message that is wrong, and the patch could be
pushed with an updated message.

Elliott, could you confirm ? (and, eventually, re-upload a patch with the
proper commit message)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

--- Comment #12 from Ian Walls  ---
Paul, the first patch is Passed QA now, but the followup is Needs Signoff. 
It's a one line change, just adding a conditional check to finesMode before
calling UpdateFine, but it needs to be tested.

Leaving this as Passed QA status until the first patch is addressed, then we
can reset to Needs Signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

--- Comment #11 from Ian Walls  ---
Created attachment 8907
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8907&action=edit
Bug 7849 Followup:  only charge fines on return if finesMode set to production

If the finesMode system preference is anything but 'production', patrons
shouldn't actually be charged any fines, even if the rules say they should
accrue them.  This followup adds that conditional check, in order to prevent
surprise fines at libraries with such a configuration.

To test:

1.  identify 2 overdue materials with associated fines rules
2.  set fines mode to 'production'
3.  return the first item: patron should be charged
4.  set fines mode to 'test' or 'none'
5.  return the second item:  the patron should not be charged

Followup idea:  if either 'test' or 'production', return the fine amt that
was/would have been charged, so it can be displayed on screen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

--- Comment #10 from Ian Walls  ---
Hmmm, in hindsight, one concern:

If the library has finesMode set to anything other than 'production', the
patron should not be charged.  Ideally, if the setting is 'test', the fines
value should appear on the template, with a confirmation box or some kind of
dialogue indicating what they WOULD be charged.  I'd settle for just respecting
'production' or !'production' at this point, though.

Needs followup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Ian Walls  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

--- Comment #9 from Ian Walls  ---
DateTime objects checkout.  Print to STDERR is removed.  $today variable is
altered by 1 day if dropbox mode, but it's not used in it's original context
again, so that's just fine.  UpdateFine call is consistent with the way it's
called in misc/cronjob/fines.pl

Checked that double-fines do not occur; running this at checkin just updates
the existing fine, not charging it again.

Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Liz Rea  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff
 CC||wizzy...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Elliott Davis  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Elliott Davis  changed:

   What|Removed |Added

   Attachment #8781|0   |1
is obsolete||

--- Comment #8 from Elliott Davis  ---
Created attachment 8879
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8879&action=edit
Add instant checkin to Circulation

To Test:

1) Check out an Item, hourly items are best but any will do.  
2) Make sure the item is overdue
3) Check the item in 
4) You should see a fine reflected that is correct for the amount of time it is
overdue according to your smart rules.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Paul Poulain  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Paul Poulain  changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com

--- Comment #7 from Paul Poulain  ---
QA comment: eliott, there are many tabs in your patch. You must use 4 spaces.
I have a git that update tabs to replace them by 4 spaces, but it seems that
your tab is set to 8 spaces, to the code look really ugly.

Failed QA, please resubmit with spaces.

2nd comment: a clear test plan would be usefull, I'm not sure I will be able to
easily test the patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Kyle M Hall  changed:

   What|Removed |Added

   Attachment #8703|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 8781
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8781&action=edit
[Signed-Off] Adds instant fine calculation at checkin

http://bugs.koha-community.org/show_bug.cgi?id=7849
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Elliott Davis  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 Depends on||7852

--- Comment #5 from Elliott Davis  ---
Kyle I'm sorry but I forgot to mark bug 7852 as a blocker for this patch. No
fine calculation will be working 100% until that gets pushed.

I'm going to flip this back to needs sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Kyle M Hall  ---
Unfortunately, I'm having some problems with testing this code. Using
$duration->days() only returns the number of days, not the length of time in
days. So an item that is overdue 2 months will show a days of 0. I had thought
in_units might work, but it does not appear to work either.

>From CPAN:
Returns the length of the duration in the units (any of those that can be
passed to new) given as arguments. All lengths are integral, but may be
negative. Smaller units are computed from what remains after taking away the
larger units given, so for example:

  $dur->in_units( 'years' );# 2
  $dur->in_units( 'months' );   # 27
  $dur->in_units( 'years', 'months' );  # (2, 3)
  $dur->in_units( 'weeks', 'days' );# (0, 0) !

The last example demonstrates that there *will not be any conversion between
units which don't have a fixed conversion rate*.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

--- Comment #3 from Kyle M Hall  ---
This code is far more terse then my own ( which I had written as a perl module
to be an alternative to the traditional fines cron ), and thus more efficient.
I won't bother submitting my own code, as Eliot Davis deserves a ++ for this.

(In reply to comment #2)
> Created attachment 8703 [details]
> Adds Instant fine calculation at checkin
> 
> To Test:
> 
> Check out an Item, hourly items are best but any will do.  Make sure the
> item is overdue, and when you check the item in you should see a fine
> reflected that is correct for the amount of time it is overdue according to
> your smart rules.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-04-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Elliott Davis  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

--- Comment #2 from Elliott Davis  ---
Created attachment 8703
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8703&action=edit
Adds Instant fine calculation at checkin

To Test:

Check out an Item, hourly items are best but any will do.  Make sure the item
is overdue, and when you check the item in you should see a fine reflected that
is correct for the amount of time it is overdue according to your smart rules.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

--- Comment #1 from Kyle M Hall  ---
fyi, I have written a module to do fines on checkin for the Crawford County
Federated Library System. I will find the code and post it up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/